- 03 Jan, 2022 1 commit
-
-
Christian Kuhn authored
It seems that symfony >= 5.4.0 has a bug in symfony finder that .gitignore files are no longer always found when the ->in() directive is a non-absolute path with '/../'. This triggers issues with our cgl fixer script in nightly mode. We work around that by using an absolute path instead in the configuration and will report the issue to symfony. Resolves: #96450 Related: #96171 Releases: master, 11.5 Change-Id: Ice865b92c118e26d519fbca7ae49e41fbe4d5110 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72842 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
- 08 Nov, 2021 1 commit
-
-
Use ignoreVCSIgnored for the Symfony finder initialization in php-cs-fixer.php to automatically ignore all files from .gitignore. Resolves: #95894 Releases: master Change-Id: If8e3d61af016ed56e8aea4c5b2b8290cca8b6329 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72072 Tested-by:
core-ci <typo3@b13.com>
Tested-by: 
Sybille Peters <sypets@gmx.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de> Tested-by:
Sybille Peters <sypets@gmx.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
- 02 Oct, 2021 1 commit
-
-
Static closures can not be used in ServerResponseCheck, since they break the call to the closure in FileDeclaration. Resolves: #95448 Releases: master Change-Id: Ie4e4b5564ed7ba8a45f42acf224e27aef8be428c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71417 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Helmut Hummel <typo3@helhum.io> Tested-by:
Simon Gilli <typo3@gilbertsoft.org>
Tested-by: Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Simon Gilli <typo3@gilbertsoft.org>
Reviewed-by:
-
- 24 Sep, 2021 2 commits
-
-
In some cases it can improve performance too. Resolves: #95210 Releases: master Change-Id: I4915bb1391ec99ff891248545080640965c8f62a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70204 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org> Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
Benni Mack authored
The rule trailing_comma_in_multiline is added to the PHP CS fixer configuration. This reduces possible merge conflicts in the future. The commands to apply the rules over the code base was ./bin/php-cs-fixer fix \ --path-mode intersection \ --config=Build/php-cs-fixer.php \ typo3/sysext And then: ./bin/php-cs-fixer fix --config=Build/php-cs-fixer.php Resolves: #94553 Releases: master Change-Id: I0ebbfa9edbbcde19aaeb44219a71f2f093ab705e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69825 Tested-by:core-ci <typo3@b13.com>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
-
- 04 May, 2021 1 commit
-
-
Benni Mack authored
This change raises the dev dependency PHP-CS-Fixer to 2.19 (forward-compatible to 3.0) and 3.0, allowing to run PHP-CS-Fixer with PHP8. This change adapts the config file to use the latest syntax. Using PSR-12 will be handled in a separate followup. Used composer commands: - composer req friendsofphp/php-cs-fixer:"^2.19 || ^3.0" --dev - composer req friendsofphp/php-cs-fixer:"^2.19 || ^3.0" -d typo3/sysext/core --dev --no-update Resolves: #94053 Releases: master, 10.4 Change-Id: I47d4ca1b09728599782883fb4958908446fd7cfe Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68989 Tested-by:
core-ci <typo3@b13.com>
Tested-by: 
Oliver Bartsch <bo@cedev.de>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by:
-
- 15 Apr, 2020 1 commit
-
-
TYPO3's PHP-CS-Fixer configuration is adapted to move towards the PSR-12 standard by unifying the new statement and adding proper braces argument methods and arguments. Resolves: #91026 Releases: master Change-Id: If5eb945e18fb4a2330e3c9eeaf90134126638079 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64163 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
- 14 Apr, 2020 1 commit
-
-
This change adds two changes 'blank_line_after_opening_tag' => true, 'single_trait_insert_per_statement' => true, to our PHP-CS Fixer configuration, adopting more rules related to PSR-12. Resolves: #91020 Releases: master Change-Id: I180b2cbceb077911bddeb42d9f131e5b32244ed2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64158 Tested-by:Josef Glatz <josefglatz@gmail.com> Tested-by:
Oliver Bartsch <bo@cedev.de>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by:
-
- 13 Apr, 2020 1 commit
-
-
As a preparation to be compatible with PSR-12, all spaces in strict type declerations are removed. Releases: master Resolves: #91009 Change-Id: I2b7c2fda42b44168b5c4c6b21711eede2eadaf2e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62104 Tested-by:
Oliver Bartsch <bo@cedev.de>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by:
-
- 25 Oct, 2019 1 commit
-
-
PHPUnit assertion method calls like ::assertSame(true, $foo) should be written with dedicated method like ::assertTrue($foo). Releases: master Resolves: #89501 Change-Id: I3d66794ea333ea114c64712c86a769e853a85dea Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62097 Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
-
- 24 Oct, 2019 2 commits
-
-
Usage of PHPUnit’s mock e.g. ->will($this->returnValue(..)) must be replaced by its shorter equivalent such as ->willReturn(...). Releases: master Resolves: #89503 Change-Id: I325e82f546154d1c94464bff03060b4353df6e9e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62100 Tested-by:
-
Class \PHPUnit\Framework\TestCase provides many assertion methods that can be called statically and dynamically in the context of tests. Sebastian Bergmann states that neither using $this nor self/static is right or wrong. There are two reasons to use self/static however. First of all IDE's like PhpStorm support code inspections that tell you to not call static methods dynamically and therefore make your code look like a christmas tree. Secondly, there is a rule for php-cs-fixer that can take care of the initial change and which helps sticking to one specific format, unifying the code style overall. Releases: master Resolves: #89499 Change-Id: Ib4a43a94a0df220b052b88b3c3e37e716560e996 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62095 Reviewed-by:
Manuel Selbach <manuel_selbach@yahoo.de> Reviewed-by:
-
- 04 Aug, 2019 1 commit
-
-
Resolves: #88911 Releases: master Change-Id: I310f0fb85cfa40b70ce65274e6e04fc21586ce0b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61434 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Susanne Moog <look@susi.dev> Reviewed-by:
-
- 19 Jul, 2019 1 commit
-
-
The php-cs-fixer rules have been adjusted by the following settings: - no_empty_phpdoc: Remove empty phpdoc blocks without any information - no_null_property_initialization: Remove initial null value from class properties - modernize_types_casting: Replace old-school `*val()` function calls with proper type casts Resolves: #88802 Releases: master Change-Id: Id2cfa849553d918e0461bafd09b3960bdf5ff700 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61324 Tested-by:
Frank Naegler <frank.naegler@typo3.org> Reviewed-by:
-
- 24 Oct, 2018 1 commit
-
-
Resolves: #86730 Releases: master, 8.7 Change-Id: I9e707e6d9c1305baa92b7f2c4c0f83bbeea52daa Reviewed-on: https://review.typo3.org/58683 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
-
- 30 Sep, 2018 1 commit
-
-
Add the phpdoc_no_access rule to the php-cs-fixer configuration to prevent the @access annotation from entering the core again. Resolves: #86475 Related: #86446 Releases: master Change-Id: I9db729ae1375434bea49f92468f7d490a554b4fb Reviewed-on: https://review.typo3.org/58497 Reviewed-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de> Tested-by:
-
- 16 Apr, 2018 1 commit
-
-
In order to improve code quality, the following code sniffers are added: - cast_spaces - declare_equal_normalize - dir_constant Resolves: #84590 Releases: master, 8.7 Change-Id: Ib8a353b9ec47bff146b5decc3d5f97d242672efa Reviewed-on: https://review.typo3.org/56533 Tested-by:
Mathias Schreiber <mathias.schreiber@typo3.com> Tested-by:
Sybille Peters <sypets@gmx.de>
Tested-by: Sybille Peters <sypets@gmx.de>
Reviewed-by:
-
- 22 Mar, 2018 1 commit
-
-
Unify the space before the colon of return type. Resolves: #84515 Releases: master, 8.7 Change-Id: Ie107e574965f834c8fcaa8c2aa4f44f7cc41d7c5 Reviewed-on: https://review.typo3.org/56414 Tested-by:
-
- 16 Dec, 2017 1 commit
-
-
The "self_accessor" fixer is more strict with younger php-cs-fixer releases and changes method argument type hints to self if a class object of the same class is expected. It also changes return type hints to self in this case. This fixer now may collide with the "xclass" system of the core and is thus deactivated. We shoud decide manually if self or class name is used. Change-Id: I3a8c20bea1d79ac2c7bc1e9ecbc2d435c4047843 Resolves: #83360 Related: #83331 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/55121 Reviewed-by:
Nicole Cordes <typo3@cordes.co> Tested-by:
Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by:
-
- 27 Nov, 2017 3 commits
-
-
As doctrine annotations have been introduced in the core the ruleset for proper formatting should be enabled. Releases: master Resolves: #83110 Change-Id: I3269fb04f4c28c066615060f98cd54290e3b5b46 Reviewed-on: https://review.typo3.org/54780 Reviewed-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Tested-by:
-
This patch applies the phpdoc_types_order rule of the php-cs-fixer. See http://cs.sensiolabs.org/ -> phpdoc_types_order Releases: master, 8.7 Resolves: #83109 Change-Id: I57291fb0b113ad01e2a171c1cfd6a9943d6302ad Reviewed-on: https://review.typo3.org/54779 Reviewed-by:
Alexander Opitz <opitz.alexander@googlemail.com> Tested-by:
-
This patch applies the phpdoc_types rule of the php-cs-fixer. See http://cs.sensiolabs.org/ -> phpdoc_types Releases: master, 8.7 Resolves: #83106 Change-Id: I958b75d85a08169a987afe9eed0baa4d86139770 Reviewed-on: https://review.typo3.org/54770 Reviewed-by:
-
- 23 Aug, 2017 1 commit
-
-
Add 2 new rules * no_superfluous_elseif * no_useless_else Both rules only apply if the if-statement contains a return. If this is the case the obsolete else/elseif part is dropped. Resolves: #82183 Releases: master,8.7 Change-Id: I94dfa6b5b96cbc3e350bd778f1796dda1a4d955a Reviewed-on: https://review.typo3.org/53791 Tested-by:
-
- 31 Jul, 2017 1 commit
-
-
With the new composer installers versions, the core package itself (in fact any composer package) can add scripts to be run on composer build time. Use this API to add scripts to TYPO3, that will create the entry scripts for frontend, backend and install tool We do this in a way, that also works if these system extensions are installed individually. This also has the benefit, that we can adapt the core with doing more things during composer build time (e.g. maybe publishing assets) in the future, or change the entry scripts to different locations, without touching the plugin any more. Resolves: #81981 Releases: master Change-Id: I3982bd5e73a14cdd54e83d0a7b3a1c93f2191efd Reviewed-on: https://review.typo3.org/53602 Reviewed-by:
-
- 28 Mar, 2017 1 commit
-
-
The TYPO3 Core currently has no guidline how to handle phpdoc comments regarding @return annoations related to "void" and "null". In practice, these annotations have no additional value if no additional documentation is given. With this change, the php-cs-fixer will remove any unnecessary linebreaks within the comments above the @return annotation, as well as remove completely empty phpdoc comments because the @return annotation is removed. Please be aware, that once PSR-5 is accepted, this coding standard within the TYPO3 Core will change again, where there are currently some further proposal details like inheritance information. Resolves: #80454 Releases: master Change-Id: Ie969d720684c0a75919fe5addd1c36ef5b12eb04 Reviewed-on: https://review.typo3.org/51686 Reviewed-by:
-
- 10 Feb, 2017 1 commit
-
-
php-cs-fixer added "no_alias_functions" to its ruleset of risky fixers. This patch allows risky fixers to be run. Change-Id: I50d01864733c3e0ab5d46cb09a5bb76a0a814561 Resolves: #79716 Releases: master Reviewed-on: https://review.typo3.org/51615 Reviewed-by:
-
- 25 Jan, 2017 1 commit
-
-
Change-Id: Ia32a61238bdf46c01a3856376c0a94d9d09339ee Resolves: #79361 Releases: master Reviewed-on: https://review.typo3.org/51423 Tested-by:
Jan Helke <typo3@helke.de> Tested-by:
-
- 01 Sep, 2016 1 commit
-
-
Extension adodb has been moved to TER and can be loaded with an upgrade wizard provided by the ext:dbal removal patch. Change-Id: I4b6cef864ef368059b49097abefd21e2175b99c2 Resolves: #77761 Releases: master Reviewed-on: https://review.typo3.org/49730 Tested-by:
Bamboo TYPO3com <info@typo3.com> Reviewed-by:
Morton Jonuschat <m.jonuschat@mojocode.de> Tested-by:
-
- 31 Aug, 2016 1 commit
-
-
The folder php-openid does not exists anymore in the TYPO3 core. Resolves: #77721 Releases: master Change-Id: I1c02b554a240ea2b2c24250a911f112d80fad99e Reviewed-on: https://review.typo3.org/49689 Reviewed-by:
-
- 30 Aug, 2016 2 commits
-
-
Resolves: #77701 Releases: master Change-Id: Id5f32eb76ac3adddd834160bc79828fefd0ce63c Reviewed-on: https://review.typo3.org/49665 Tested-by:
-
As decided during T3ACME we will use the short array syntax in master. The 7.6 branch will also be done to make backporting easier. Resolves: #77692 Releases: master,7.6 Change-Id: I37e9484b1012fc9161148257a842054c24d162ba Reviewed-on: https://review.typo3.org/49651 Reviewed-by:
-
- 11 Aug, 2016 1 commit
-
-
Replace the vendor name of the package as the old one is abandoned. Resolves: #77485 Releases: master Change-Id: I1149c7fc4379caad6176245ba08ac98d6220571c Reviewed-on: https://review.typo3.org/49453 Tested-by:
-
- 06 Jul, 2016 1 commit
-
-
A script is added to CGL check latest core commit with php-cs-fixer. This can be used by commiters before pushing patches to gerrit to verify CGL compatibility. The bamboo build chain will later use the same script on each pre-merge run. Change-Id: I40a7f4809c97f5865ccb8dc05dd9cc466be0638a Resolves: #76965 Releases: master Reviewed-on: https://review.typo3.org/48833 Reviewed-by:
-
- 21 Nov, 2015 1 commit
-
-
Resolves: #71748 Releases: master Change-Id: I3682856415b29d5bf2f885db038cb6666b47db3a Reviewed-on: https://review.typo3.org/44850 Reviewed-by:
-
- 20 Nov, 2015 6 commits
-
-
Scalar types should always be written in the same form. "int", not "integer"; "bool", not "boolean"; "float", not "real" or "double". Resolves: #71746 Releases: master Change-Id: I47d43e5b68187cd07301d277875ba333325e29c7 Reviewed-on: https://review.typo3.org/44844 Reviewed-by:
-
@package and @subpackage annotations should be omitted from phpdocs. Resolves: #71740 Releases: master Change-Id: I2a82bca6d4144726ead1b9d97aa580c15a4075b0 Reviewed-on: https://review.typo3.org/44836 Reviewed-by:
Martin Kutschker <martin.kutschker@ymail.com> Tested-by:
-
Resolves: #71738 Releases: master Change-Id: I71edcdb8ed1804bf94479237bd7f6c120420f779 Reviewed-on: https://review.typo3.org/44834 Reviewed-by:
-
Resolves: #71737 Releases: master Change-Id: Id8b107e7fe3486f6d829c8737d5450f9f6e6531b Reviewed-on: https://review.typo3.org/44833 Reviewed-by:
Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: -
Resolves: #71735 Releases: master Change-Id: Iabf78aeab4262909980351a1570d9b561e94ff7f Reviewed-on: https://review.typo3.org/44830 Reviewed-by:
Michael Oehlhof <typo3@oehlhof.de> Reviewed-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
Resolves: #71726 Releases: master Change-Id: I4a356c8da668acee555149eee9cf56ccdb4dc0ee Reviewed-on: https://review.typo3.org/44822 Reviewed-by:
-
