Commits · 14451baa8a71af481d23c04667ebb6e8c3a7c15f · typo3 / typo3

03 Jan, 2022 4 commits

[BUGFIX] Use realpath() for vcsIgnore in CGL fixer · 14451baa

Christian Kuhn authored Jan 03, 2022

It seems that symfony >= 5.4.0 has a bug in symfony
finder that .gitignore files are no longer always
found when the ->in() directive is a non-absolute
path with '/../'.
This triggers issues with our cgl fixer script in
nightly mode.
We work around that by using an absolute path
instead in the configuration and will report the
issue to symfony.

Resolves: #96450
Related: #96171
Releases: master, 11.5
Change-Id: Ice865b92c118e26d519fbca7ae49e41fbe4d5110
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72842


Tested-by: core-ci <typo3@b13.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>

14451baa

[BUGFIX] Allow rendering of subpages for spacers · 07638213

Benni Mack authored Dec 28, 2021 and

Oliver Bartsch committed Jan 03, 2022

If rendering of spacer pages in an HMENU is explicitly
given via SPC = 1, then subpages of pages are now rendered
as well.

This way, there is no difference between spacers and other
page types for submenu rendering anymore.

Resolves: #64428
Releases: main, 11.5
Change-Id: Ic4bc2661399498de61af486712ade85815ffa529
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72840


Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>

07638213

[BUGFIX] Avoid array offset on null warning when generating preview URL params · 0ce25043

Chris Müller authored Dec 30, 2021 and

Benni Mack committed Jan 03, 2022

Resolves: #96443
Releases: main, 11.5
Change-Id: I9f1c951628cf8872473ff20bbd59ffb769ffe279
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72839


Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Benni Mack <benni@typo3.org>

0ce25043

[BUGFIX] Avoid type errors in TimeTracker · 52d4e537

Susanne Moog authored Jan 02, 2022 and

Benni Mack committed Jan 03, 2022

Make sure to pass strings to html formatting methods.
Initialize hierarchy array correctly.

Resolves: #96448
Releases: main, 11.5
Change-Id: I2b9c28303c1c96d0a2ea1bc3ca971da3b4b3fe7d
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72838


Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>

52d4e537

30 Dec, 2021 4 commits

[BUGFIX] Avoid undefined array key in LegacyLinkNotationConverter · cd6df0df

Chris Müller authored Dec 29, 2021 and

Andreas Fernandez committed Dec 30, 2021

This error occurs when running linkvalidator in scheduler:
Undefined array key 1.

Resolves: #96439
Releases: main, 11.5
Change-Id: Idbe4b5bf52722a800026fc7af566daba925eaad2
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72837


Tested-by: core-ci <typo3@b13.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>

cd6df0df

[BUGFIX] Avoid duplicate pages in pagetree when rootPid is mounted · 62ada6fa

Benjamin Franzke authored Dec 28, 2021 and

Andreas Fernandez committed Dec 30, 2021

With the changes in #95854, implicit rootPid dbmounts caused
duplicated pages in pagetree, because explicit page mounts have
been considered multiple times for the pid=0 tree:

 * First time because of their relationship to pid = 0
 * Second time because of their explicit mount
   (which was sorted into the pid = 0 tree)

This happened because #95854 optimized to only use one call
to the PageTree repository, which then had the side effect
of merging "multiple" pages into one tree, instead
of showing "two" separate trees.

The patch ensures that multiple page trees are used when
the rootPid (0) is included as a webmount.

Releases: main, 11.5, 10.4
Resolves: #96367
Related: #95854
Change-Id: I7f421995f2d4aa88bb266fec684565102a4dc080
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72835


Tested-by: core-ci <typo3@b13.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>

62ada6fa

[BUGFIX] Fix TCA of sys_workspace custom_stages · 75c21c6b

Nikita Hovratov authored Dec 28, 2021 and

Benni Mack committed Dec 30, 2021

The TCA option "appearance" is an array, with
pre-defined configuration keys. The column
"custom_stages" of the table "sys_workspace" set a
csv value for this option. This does not work.

The configuration is now transformed into the
correct array format.

Resolves: #96437
Releases: main, 11.5, 10.4
Change-Id: I25112d7ea1ce605376d70fa2dabceddd3c121faa
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72833


Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>

75c21c6b

[BUGFIX] Avoid undefined array key in garbage collection task · a6561904

Chris Müller authored Dec 29, 2021 and

Benni Mack committed Dec 30, 2021

Resolves: #96438
Releases: main, 11.5
Change-Id: Idcb8ca5f889aef8d77c1e3950f5794fe54ed76e3
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72832


Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>

a6561904

29 Dec, 2021 1 commit

[TASK] Fix typo in InputDateTimeElement · f931a62a

Nikita Hovratov authored Dec 29, 2021 and

Benni Mack committed Dec 29, 2021

Resolves: #96441
Releases: main, 11.5
Change-Id: Id3ae6ee43d1db5ef2ee46fedb336561bc8049a72
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72791


Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>

f931a62a

28 Dec, 2021 1 commit

[BUGFIX] Remove useless felogin view configuration · 36454147

Markus Klein authored Dec 17, 2021 and

Benni Mack committed Dec 28, 2021

The setup should not contain the same settings twice.
Moreover, the default paths are always available,
no need to configure them.
Additionally, remove default paths from constants,
we don't need that either.

Resolves: #96384
Releases: main, 11.5
Change-Id: I204cc38a952dd7acd097d188d1637ad1b25324fc
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72719


Tested-by: core-ci <typo3@b13.com>
Tested-by: Simon Schaufelberger <simonschaufi+typo3@gmail.com>
Tested-by: Daniel Haupt <mail@danielhaupt.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Simon Schaufelberger <simonschaufi+typo3@gmail.com>
Reviewed-by: Daniel Haupt <mail@danielhaupt.de>
Reviewed-by: Benni Mack <benni@typo3.org>

36454147

23 Dec, 2021 10 commits

[TASK] Add tests for list menu with folder as root storage · 4d980f4e

Benni Mack authored Dec 22, 2021 and

Oliver Bartsch committed Dec 23, 2021

This change adds test to document the behavior that excludeDoktypes
needs to be set to render folders in a menus as well.

Resolves: #93924
Releases: main, 11.5
Change-Id: I870e2ef5cd07d5365d93ad04752b74a4edaebd64
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72790


Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>

4d980f4e

[BUGFIX] Do not link to untranslated records · dc749a15

Mathias Brodala authored Dec 21, 2018 and

Benni Mack committed Dec 23, 2021

This only fixes the issue for dedicated record links. Page links with
added query arguments can still lead to broken links.

Resolves: #87260
Releases: main, 11.5
Change-Id: Ib13aa1925de6463688e2b50612ce7b2820733ce7
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72788


Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>

dc749a15

[BUGFIX] Be consistent in HMENU.special = language · 1d5d5743

Benni Mack authored Dec 23, 2021

Previously, HMENU.addQueryString, which is only
available for special=language, was applied
not within the typolink() functionality but before.

By sorting out the properties, HMENU with
special=language now properly uses typolinks
addQueryString.

Using the magic property _ADD_GETVARS to activate
this option addQueryString but also using
the "_PAGES_OVERLAY_REQUESTEDLANGUAGE" allows
to fix special=language issues.

Resolves: #94713
Releases: main, 11.5
Change-Id: Ic26e702fb97bb878308de5e1710d2a3c4f28552d
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72789


Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>

1d5d5743

[BUGFIX] Avoid PHP 8 warnings in LocalCropScaleMaskHelper · c634d404

Benni Mack authored Dec 22, 2021

Resolves: #96344
Releases: main, 11.5
Change-Id: I986945e16e0a2adef827fc0532a431be7ab25e03
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72787


Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>

c634d404

[BUGFIX] Fix PHP 8 notices in workspaces preview · f99cd918

Benni Mack authored Dec 23, 2021

Resolves: #96430
Releases: main, 11.5
Change-Id: I8569537d90ee5dc74157db4f3e583366b82a2e27
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72786


Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>

f99cd918

[BUGFIX] Resolve shortcuts in HMENU to access restricted pages · 18b65882

Benni Mack authored Dec 22, 2021

There is a difference between

> typolink.linkAccessRestrictedPages = 1 (only a toggle)
and
> HMENU.showAccessRestrictedPages = [pageId]|NONE

HMENU.showAccessRestrictedPages behaves like
the global option "config.typolinkLinkAccessRestrictedPages"

Basically, if a page is access restricted, link
to a different {pageId}.

This change explains the behavior:
-- https://review.typo3.org/c/Packages/TYPO3.CMS/+/35908/

"typolink.linkAccessRestrictedPages" in contrast
still links to the actual disallowed page, which
is also nice in case you have a 403 error page in place.

This change fixes the behaviour of HMENU to behave
EXACTLY like the global config.typolinkLinkAccessRestrictedPages,
previously HMENU did some magic PLUS it set
"typolink.linkAccessRestrictedPages"

With this change, shortcuts to access restricted pages
now get properly transformed and linked for menus.

Resolves: #60258
Resolves: #65118
Related: #63804
Releases: main, 11.5
Change-Id: Ifd975243fe4b024b3fcbd4e356430d809cc0f429
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72785


Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>

18b65882

[BUGFIX] Avoid undefined array key in ContentObjectRenderer->getTypoLink() · 90817ca9

Chris Müller authored Dec 22, 2021 and

Benni Mack committed Dec 23, 2021

Resolves: #96418
Releases: main, 11.5
Change-Id: I00b77f478c667f59b751c6f13c975d03799086d7
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72783


Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>

90817ca9

[BUGFIX] Avoid undefined array key in TextMenuContentObject->writeMenu() · f6d94968

Chris Müller authored Dec 22, 2021 and

Benni Mack committed Dec 23, 2021

Resolves: #96377
Releases: main, 11.5
Change-Id: I98dfe39cf04468d54ee979afa34e7dd3bd40acf6
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72784


Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>

f6d94968

[BUGFIX] Respect query settings for version overlay enable fields · 061c799d

Sebastian Michaelsen authored Dec 08, 2020 and

Benni Mack committed Dec 23, 2021

Resolves: #93027
Releases: main, 11.5
Change-Id: I65b4b84a12cf4985d14a62217b075e5c421e0ee6
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72780


Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>

061c799d

[BUGFIX] Properly support translations only page module · e1c5366c

Oliver Bartsch authored Dec 10, 2021 and

Benni Mack committed Dec 23, 2021

This fixes several issues for the case that an editor only
has access to translated pages and not to the default
language (L=0).

Resolves: #95795
Releases: main, 11.5, 10.4
Change-Id: Ied31c7aa5229d3b8686741dd97005f9b5f16ef16
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72620


Tested-by: core-ci <typo3@b13.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>

e1c5366c

21 Dec, 2021 12 commits

[BUGFIX] Initialise parameter in AbstractElementBrowser correctly · 3a895968

Chris Müller authored Dec 21, 2021 and

Benni Mack committed Dec 21, 2021

This avoids the deprecation notice in PHP 8.1:
Passing null to parameter #2 ($string) of type string is deprecated in /var/www/html/public/typo3/sysext/recordlist/Classes/Browser/DatabaseBrowser.php line 179

Resolves: #96422
Releases: main, 11.5
Change-Id: I9c811bc0d2d4523a78fc6c72ee02be96efbe1bc3
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72779


Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>

3a895968

[BUGFIX] Ignore unmapped tables on non-default connections · f425ae37

Stephan Großberndt authored Nov 30, 2020 and

Christian Kuhn committed Dec 21, 2021

This patch changes the behaviour when building the SchemaDiff on a
non-default connection to only fetch tables which are mapped to that
connection instead of fetching table details of all tables and
discarding the information for unmapped tables later on.

This improves the performance and avoids errors for data types
unknown to doctrine/dbal in details of unmapped tables.

Resolves: #92959
Releases: main, 11.5
Change-Id: Ia4a62d861ea0748995eb0dec4f01e9e65eb3ed46
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72765


Tested-by: core-ci <typo3@b13.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>

f425ae37

[BUGFIX] Avoid undefined array key warnings in DatabaseRecordLinkBuilder · 61af3e74

Chris Müller authored Dec 21, 2021 and

Benni Mack committed Dec 21, 2021

Resolves: #96420
Releases: main, 11.5
Change-Id: Ida1b27956bfe759062904ee9d0c8246ea73f0667
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72763
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72778


Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>

61af3e74

[BUGFIX] Avoid PHP8 warning for "Insert records" with hidden records · 308e07f1

Chris Müller authored Dec 21, 2021 and

Benni Mack committed Dec 21, 2021

When one or more hidden records are referenced in an "Insert records"
content element, an "undefined array key" warning was thrown.

Resolves: #96419
Releases: main, 11.5
Change-Id: I4f90dc78540bf8c56163cfb8247a13c86869fbe1
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72777


Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>

308e07f1

[BUGFIX] Use generated TSFE in PageLinkBuilder · ed0912e0

Andreas Fernandez authored Nov 27, 2021

If the PageLinkBuilder is invoked with a non-available TSFE as e.g. in
the "Redirects" module, generating the URLs to pages with a fragment,
e.g. to a referenced content element, works now as we're using the
TSFE generated within PageLinkBuilder itself.

Resolves: #96101
Releases: main, 11.5
Change-Id: I481b7d8573424dab59df22b0d81a734e03b70575
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72776


Tested-by: core-ci <typo3@b13.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>

ed0912e0

[TASK] Allow EXT: syntax in f:uri.resource VH · a8b9eefb

Christian Kuhn authored Dec 16, 2021

f:uri.resource is frequently used to load CSS and
JavaScript resources. It is the only ViewHelper that
does not understand the general "EXT:" syntax that
is usually available when extension resource files
are referenced.

This is now added to improve consistency and
documented as best practice in VH documentation.

Change-Id: I504c79eef349b1ea6cc70cc0d7753319e1f356d9
Resolves: #96414
Releases: main, 11.5
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72760


Tested-by: core-ci <typo3@b13.com>
Tested-by: Stefan Bürk <stefan@buerk.tech>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>

a8b9eefb

[BUGFIX] Allow CSV in startingPoints config as advertised · f1b4f90e

Andreas Fernandez authored Dec 20, 2021

The category starting points introduced with #95037 were designed to
allow comma-separated values in its configuration. Due to improper
tests, this specific notation was not discovered as being broken right
now.

If the incoming configuration is a string, GeneralUtility::intExplode()
is applied to remove any non-integer value. Afterwards, a new CSV
string is generated.

Resolves: #96397
Related: #95037
Releases: main, 11.5
Change-Id: I0759d8093bb4665b7709f4e20539307467f246df
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72775


Tested-by: core-ci <typo3@b13.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>

f1b4f90e

[TASK] Remove stray javascript build outputs · 92072aa1

Benjamin Franzke authored Dec 21, 2021

RecordExportButton.js  has been introduced in #94622 by accident
(probably a left-over from a previous patchset re-added due to grunt watch).

The TypeScript source for Enum/Viewport/TopbarIdentifiers.js has been
removed with #78760, it is unused since then and therefore removed.

Releases: main, 11.5
Resolves: #96411
Resolves: #96412
Related: #94545
Related: #78760
Related: #96323
Change-Id: I226d51fc87ab8012e917e7d219688fca21eda364
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72773


Tested-by: core-ci <typo3@b13.com>
Tested-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>

92072aa1

[BUGFIX] Fix doctype annotations · 3344f500

Simon Schaufelberger authored Dec 20, 2021 and

Christian Kuhn committed Dec 21, 2021

According to https://docs.phpdoc.org/latest/guide/guides/types.html#union-types
it is only allowed to use "string|null" and not "?string"

Resolves: #96407
Releases: main, 11.5
Change-Id: I4e9ec53d05feb5cfffc4eebc29de447d6225ab66
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72774


Tested-by: core-ci <typo3@b13.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>

3344f500

[BUGFIX] Resolve shortcuts in typolink directly · ad385665

Benni Mack authored Oct 01, 2021

Currently, HMENU generates the direct destination for
a shortcut URL, but typolink does not. This is an
inconsistency, and since HMENU is actually using typolink
now as well (in 4.x this was different), the resolving
of shortcuts can now be moved into the typolink/link building
functionality.

Page Shortcuts are now resolved (recursively!) at a single point for
all links, except for RANDOM_SUBPAGE variants, as this is sorted
out during runtime when hitting the RANDOM_SUBPAGE shortcut page.

Resolves: #80113
Resolves: #95947
Releases: main, 11.5
Change-Id: Ib6204ff1b0ecb699ec87f5154dc18c974676e65c
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72772


Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>

ad385665

[TASK] Switch to new REST API end point · e9b43754

Simon Gilli authored Aug 16, 2020 and

Christian Kuhn committed Dec 21, 2021

The core version service now uses the new entry point of the REST API
available via https://get.typo3.org/api.

The old entry point is still available but should not be longer used.

For more information see `https://get.typo3.org/api/doc <https://get.typo3.org/api/doc>`_
and `https://github.com/TYPO3/get.typo3.org/pull/272 <https://github.com/TYPO3/get.typo3.org/pull/272>`_.

Resolves: #92020
Releases: main, 11.5, 10.4
Change-Id: I2c92554e9ba212827b6412d4a88ac5c92e26aa17
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72756


Tested-by: core-ci <typo3@b13.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>

e9b43754

[TASK] Raise friendsofphp/php-cs-fixer:^3.4 · 79a5e13b

Benni Mack authored Dec 20, 2021

The dev dependency friendsofphp/php-cs-fixer now
has a minimum requirement to 3.4, which comes
with PHP8.1 support.

This allows TYPO3 to run PHP-CS Fixer with
PHP 8.1 in the CI pipeline.

Testing configuration is not adjusted with this
patch, but allows using corresponding runTests.sh
testsuites cgl and cglGit:

Build/Scripts/runTests.sh -p 8.1 -s cglGit -n
Build/Scripts/runTests.sh -p 8.1 -s cgl -n

Used command:

composer req friendsofphp/php-cs-fixer:^3.4 --dev

Resolves: #96398
Releases: main, 11.5
Change-Id: I6a4eaec0294829afcdf84b7b32303eaafbaa72bb
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72718


Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>

79a5e13b

20 Dec, 2021 5 commits

[BUGFIX] Remove useless string cast of idn_to_ascii() · 9faf357a

Andreas Fernandez authored Dec 20, 2021 and

Oliver Bartsch committed Dec 21, 2021

The function `idn_to_ascii()` will return either `false` or a string,
the former one is returned on errors. In #93900, the result was cast to
string, making the check for `false` useless.

As `idn_to_ascii()` can return both, the string cast is removed to make
the check for `false` functional again.

Resolves: #96399
Related: #93900
Releases: main, 11.5
Change-Id: Ib5327766fc545a75feb7389d18358aa85b76e5db
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72720


Tested-by: Simon Schaufelberger <simonschaufi+typo3@gmail.com>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Simon Schaufelberger <simonschaufi+typo3@gmail.com>
Reviewed-by: Oliver Bartsch <bo@cedev.de>

9faf357a

[BUGFIX] Forward-compatible prepared statement support · ed725d12

Stefan Bürk authored Dec 09, 2021 and

Benni Mack committed Dec 20, 2021

doctrine/dbal:^3.2 changed return type of result for QueryBuilder
execute methods, no longer have used prepared statement accessible
for further query execution with other placeholder values.

To raise doctrine/dbal:^3.2 two places have been changed to reuse
the QueryBuilder instance itself instead of prepared statement with
the corresponding patch #96287, thus given up the performance gain
through reusable query execution plan in corresponding dbms systems.

This patch adds support for prepared statements to TYPO3's
QueryBuilder facade as this was not publicly available yet
for TYPO3 users to be forward-compatible with Doctrine DBAL 3.

Resolves: #96393
Related: #96287
Releases: main
Change-Id: I814670ebf9920ed3162a31f98ad9efd4031f47c9
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72716


Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>

ed725d12

[BUGFIX] Fix scoping issue in FormEngineValidation · 21798082

Benjamin Franzke authored Dec 14, 2021 and

Andreas Fernandez committed Dec 20, 2021

theChar is not initialized and therefore pollutes global scope.
(It is assigned to window.theChar in the FormEngine iframe).

Currently not an error (we are not using strict mode in RequireJS),
just bad style, but once we switch to strict mode (type="module"),
this will fail without proper declaration.

Releases: main, 11.5
Resolves: #96395
Related: #96323
Change-Id: Ie82da6a1b664e4010179cccaabb07e7d87b19038
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72717


Tested-by: core-ci <typo3@b13.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>

21798082

[TASK] Avoid deprecated doctrine/dbal method 'executeUpdate()' · b20ef47f

Stefan Bürk authored Dec 19, 2021 and

Benni Mack committed Dec 20, 2021

doctrine/dbal deprecated quite some methods to cleanup
their codebase and provided replacements with more
speaking method names.

Most deprecated method usages have been replaced in
the core, but we missed some.

The patch replaces the deprecated method 'executeUpdate()'
with the corresponding 'executeStatement()' method in
several places to clean this up.

This can be done also in 11.5 too, the required minimum
version of doctrine/dbal provides these new methods as
upwards compatible layer.

Resolves: #96389
Releases: main, 11.5
Change-Id: Ibf8f49a27a1c8c4b34bda88a20f4fba6afe45cb8
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72715


Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>

b20ef47f

[BUGFIX] Fix extension path in ComposerDeficitDetector · fd8d65c5

Helmut Hummel authored Dec 16, 2021

Instead of relying on a hard coded extension install path,
now the real extension path is used provided by the package manager

Releases: main, 11.5
Resolves: #96375
Change-Id: Ic2e4d71413416a5271420e939e5f74fa28cbaca6
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72691


Tested-by: core-ci <typo3@b13.com>
Tested-by: Helmut Hummel <typo3@helhum.io>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Helmut Hummel <typo3@helhum.io>

fd8d65c5

19 Dec, 2021 1 commit

[BUGFIX] Avoid exception in ContentObjectRenderer with PHP8 · 783abed0

Torben Hansen authored Dec 18, 2021 and

Benni Mack committed Dec 19, 2021

This patch ensures that the getQuery() function only uses the
minus operator to negate the $storagePid variable, if the variable
can be interpreted as an integer.

Resolves: #96321
Releases: main, 11.5
Change-Id: Idacd43fd6639218fc1126bffcd43e78338f18e0e
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72714


Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>

783abed0

18 Dec, 2021 1 commit

[BUGFIX] Fix PHP 8 strict warning in Package MetaData · 9f4edc9f

Helmut Hummel authored Dec 16, 2021

A "type" does not need to be set in a composer.json,
so the checks for package type must account for the type
being null, to not trigger a warning in PHP 8

Releases: 11.5, main
Resolves: #96372
Change-Id: Ic607c3dbb16dfcf4a28b0417b8340be36bcafa87
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72712


Tested-by: core-ci <typo3@b13.com>
Tested-by: Helmut Hummel <typo3@helhum.io>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Helmut Hummel <typo3@helhum.io>

9f4edc9f

17 Dec, 2021 1 commit

[BUGFIX] Make RichTextElement PHP 8 compatible · 99d92d22

Markus Klein authored Dec 17, 2021 and

Oliver Bartsch committed Dec 17, 2021

RTE yaml configuration can be incomplete/wrong or empty.
Do not access configuration settings without a safeguard.

Resolves: #96383
Releases: main, 11.5
Change-Id: Ie0888402e64a669816edd200d2d54e401e0c399f
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72713


Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>

99d92d22