Skip to content
GitLab
  1. 08 Jun, 2022 1 commit
  3. 07 Jun, 2022 1 commit
  5. 05 Apr, 2022 1 commit
  7. 14 Mar, 2022 1 commit
  9. 05 Mar, 2022 1 commit
  11. 02 Mar, 2022 1 commit
  13. 15 Feb, 2022 1 commit
  15. 14 Feb, 2022 1 commit
  17. 05 Feb, 2022 1 commit
  19. 18 Jan, 2022 1 commit
    • Stefan Bürk's avatar
      [TASK] Use proper QueryBuilder execute() replacement methods · 597a92fd
      Stefan Bürk authored and Benni Mack's avatar Benni Mack committed 
      doctrine/dbal implemented single purpose method to replace the
compound 'execute()' in QueryBuilder to avoid the incompatible
return typehint tuple of 'Doctrine\DBAL\Result|int' in favour
of 'executeQuery()' and 'executeStatement()' which was added
forward-compatible with #96247 marking the old one internal
but not deprecated for now to keep a eventually longer grace
period to mitigate for extensions developers.

This patch however goes through the core and replace these
methods to be clean as possible and is a first preparation
to remove the 'checkThisOnly' option from phpstan which are
swallowed by this option.

* replace 'execute' with 'executeQuery()' for select and
  count queries generating results ('Doctrine\DBAL\Result').
* use 'executeStatement()' for insert, update and delete
  queries return affected rows as return value (int)
* adjust return typehints to match the single return type
  signature on really minor places to match the return type
  of the wrapped replaced execute method.
* replace one really old 'exec()' from connection with
  corresponding replacement method along the way.
* add several todos on two places which are weird and do
  not make any sense for further investigation and fixing,
  as declared as out-of-the-scope for this wide-area patch.

Resolves: #96551
Related: #96247
Related: #96521
Releases: main, 11.5
Change-Id: Ie8d40f3882f1694ab7f7e5053729fa1c798a9c5f
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73032


Tested-by: Christian Kuhn's avatarChristian Kuhn <lolli@schwarzbu.ch>
Tested-by: core-ci's avatarcore-ci <typo3@b13.com>
Tested-by: Benni Mack's avatarBenni Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn's avatarChristian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack's avatarBenni Mack <benni@typo3.org>
      597a92fd
  21. 10 Jan, 2022 1 commit
  23. 05 Jan, 2022 1 commit
  25. 21 Dec, 2021 1 commit
  27. 16 Dec, 2021 1 commit
  29. 07 Dec, 2021 1 commit
  31. 28 Nov, 2021 1 commit
  33. 10 Nov, 2021 1 commit
  35. 13 Oct, 2021 1 commit
  37. 24 Sep, 2021 2 commits
  39. 02 Sep, 2021 1 commit
  41. 23 Aug, 2021 1 commit
  43. 29 Jul, 2021 1 commit
  45. 23 Jul, 2021 1 commit
  47. 22 Jul, 2021 1 commit
  49. 16 Jul, 2021 1 commit
  51. 16 Jun, 2021 1 commit
  53. 14 Jun, 2021 1 commit
  55. 06 Mar, 2021 1 commit
  57. 20 Jan, 2021 1 commit
  59. 20 Nov, 2020 1 commit
  61. 17 Nov, 2020 1 commit
  63. 12 Nov, 2020 1 commit
    • Benni Mack's avatar
      [!!!][TASK] Do not create new version placeholders in workspaces anymore · 74899ecf
      Benni Mack authored 
      Creating a new record in a workspace adds two database rows.

One that is the "placeholder", which - since v10.4 - contains
the same metadata as the other record:

* t3ver_wsid = workspaceID
* t3ver_oid = 0 (simulating behavior of an "online pendant record")
* t3ver_state = 1

And the "versionized" record, identified by:

* t3ver_wsid = workspaceID
* t3ver_oid = uid of the new placeholder record
* t3ver_state = -1

As of TYPO3 v10, the first record is not needed anymore,
the versioned record can be queried directly, however, since
the relations (except MM) point to the placeholder record,
this one is kept.

As result, only one record is created from now on:

* t3ver_wsid = workspaceID
* t3ver_oid = 0 (no online counterpart)
* t3ver_state = 1

On reading, the record is queried directly (no overlay needed anymore!)
with the existing Database Doctrine Restrictions. On publishing, the
record just gets the state/stage/wsid set and is "live".

This brings fundamental benefits:

* No overlays needed when querying
* Fewer database records (placeholders are not helpful)
* Conceptual problems with placeholder and shadowed fields are removed

Resolves: #92791
Releases: master
Change-Id: I0288cc63fe72d8442d586f309bd4054ac44e829b
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65587


Tested-by: default avatarTYPO3com <noreply@typo3.com>
Tested-by: Christian Kuhn's avatarChristian Kuhn <lolli@schwarzbu.ch>
Tested-by: Oliver Bartsch's avatarOliver Bartsch <bo@cedev.de>
Tested-by: Benni Mack's avatarBenni Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn's avatarChristian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Oliver Bartsch's avatarOliver Bartsch <bo@cedev.de>
Reviewed-by: Benni Mack's avatarBenni Mack <benni@typo3.org>
      74899ecf
  65. 28 Oct, 2020 1 commit
  67. 19 Oct, 2020 2 commits
  69. 18 Oct, 2020 1 commit
  71. 15 Oct, 2020 1 commit
  73. 13 Oct, 2020 1 commit
  75. 12 Oct, 2020 1 commit
    • Benni Mack's avatar
      [!!!][TASK] Remove move placeholders · 27c7de8a
      Benni Mack authored and Christian Kuhn's avatar Christian Kuhn committed 
      Workspaces ("Element-based versioning") previously had - due to
the "pid=-1" logic until TYPO3 v10 - a so-called "MOVE PLACEHOLDER".

This was indicated by t3ver_state = 3, all relevant fields:
* t3ver_state = 3 (move placeholder)
* t3ver_oid = 0 no connected live record, it allowed fetching these records
  with one query together with live records as db restrictions t3ver_oid > 0
* t3ver_wsid = workspace UID
* t3ver_move_id = UID of the live record
* pid = new PID the version was moved to
* sorting - when a record was moved within page with activated sorting

Other record fields were not important. However, when moving a record, the
value from TCA ctrl section "shadowColumnsForMovePlaceholders" was used to
fill in gaps from the live record.

The ACTUAL versioned record was indicated by t3ver_state = 4, the so-called
"MOVE POINTER". In previous version until TYPO3 v10, it's PID field was set
to -1, but since TYPO3 v10, it has the same PID as the "MOVE PLACEHOLDER".

Characteristics of the move pointer as of TYPO3 v10:
* t3ver_state = 4 (move pointer)
* t3ver_oid = UID of the live record
* t3ver_wsid = workspace UID
* t3ver_move_id = 0
* pid = PID the version was moved to
* sorting - same value as the live record (not evaluated until now)
* All other fields with optionally modified content

Both move placeholder and move pointer did not know each other directly.
Fetching the move pointer for a move placeheldor (or the other way around)
involved the live record, leading to many queries.

The patch obsoletes the move placeholder records, moving necessary
information to the move pointer: It now contains the updated sorting
and is considered in the Database Restrictions to be fetched.

In general, when publishing, the moved record now
behaves identical to the other versioned types.

This makes the internal code much easier, creates less DB queries
on read + write and leads to less DB records in the database.

The change removes creation of move placeholders, and considers the
move pointers when evaluating sorting and PID in DataHandler.

Read functionality from BackendUtility and PageRepository don't need an
additional step to fetch the live version of a move placeholder anymore.

An upgrade wizard takes existing move placeholders (state=3), updates
pid+sorting (PID generally not needed, just to be sure) of the move
pointer (state=4) and then deletes the move placeholder.

TCA definition $TCA[my-table][ctrl][shadowColumnsForMovePlaceholders]
is not needed anymore and removed by an auto TCA migration.

Finally, workspace enabled tables do not need the t3ver_move_id field
anymore: The live record UID is already in t3ver_oid field for state=4
records, just like with all other versioned records. The field will
be fully removed with a separate patch in order to keep the actual CSV
tests readable for this patch.

Resolves: #92497
Releases: master
Change-Id: I206336aec8be8a324fefdfd69f648f5a298c6ad1
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65797


Tested-by: default avatarTYPO3com <noreply@typo3.com>
Tested-by: Oliver Bartsch's avatarOliver Bartsch <bo@cedev.de>
Tested-by: Christian Kuhn's avatarChristian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Oliver Bartsch's avatarOliver Bartsch <bo@cedev.de>
Reviewed-by: Christian Kuhn's avatarChristian Kuhn <lolli@schwarzbu.ch>
      27c7de8a