Commits · 1072b2a39eae92bf1485c2d829670ab6dda7bb6a · typo3 / typo3

05 Jan, 2022 11 commits

[TASK] Ensure that hidden pages are not rendered as subpages in HMENU · 1072b2a3

Benni Mack authored Jan 05, 2022 and

Oliver Bartsch committed Jan 06, 2022

This change adds tests to a very old issue to ensure
that a page with only hidden subpages is not marked
as IFSUB etc.

MenuProcessor is extended to set a "hasSubpages" flag
when IFSUB, CURIFSUB or ACTIFSUB is set.

Resolves: #22190
Releases: main, 11.5
Change-Id: Ia9b73e8ae1028eafa94ba4fa5ca0dacf2562c074
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72888

Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>

1072b2a3

[BUGFIX] Use "pages.target" properly for Pages with External URL · 15c5d339

Benni Mack authored Jan 05, 2022

The database field "pages.target" allows to define
a custom target attribute for links in menus of external
URLs.

Before this was (wrongly) built in HMENU but applied
after Typolink worked. This option belongs to the
actual link building when building links to external URLs
where $conf[extTarget] is evaluated.

In addition, HMENU tests now also evaluate "target"
for regular pages as well.

Resolves: #96470
Releases: main, 11.5
Change-Id: I3919b6b13666565687e8ff56dcfc867c871837e2
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72887

Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>

15c5d339

[BUGFIX] Change misleading label for workspace mass action · 69f540a8

Oliver Bartsch authored Jan 05, 2022

With the introduction of the multi record selection, the workspace
actions, shown above and below the records, got prepended with
labels.

While the mass action targets the entire workspace, the label just
read "all", which is misleading because one could think the action
only targets all records of the current view and then accidentally
publish or even worse, discard the entire workspace.

This is fixed by changing the label.

Resolves: #96468
Releases: main, 11.5
Change-Id: Id2205e843656af7576f7038dddc81ae53308a185
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72886

Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>

69f540a8

[BUGFIX] Provide quoted array to string-list implode support · dc2c9dbd

Stefan Bürk authored Dec 27, 2021 and

Christian Kuhn committed Jan 05, 2022

With #96393 forward-compatible prepared statement
suport has been added, which lacks support for the
broadly known doctrine/dbal 'PARAM_STR_ARRAY' and
'PARAM_INT_ARRAY' types.

Internal methods as alternatives were introduced
as core internal methods with #92493 in the internal
'QueryHelper' class.

This patch now moves these internal implementations
to the 'QueryBuilder' to provide an forward-compatible
public alternative, which is needed to prepare statements
with 'in()' or 'notIn()' expression with array values,
which can only be used as non-placeholder, which is not
supported by PHP PDO implementation.

Further usage of internal implementation which was
introduced with #92493 are replaced with new public
methods and internal methods in QueryHelper removed.

Resolves: #96434
Related: #96393
Related: #92493
Releases: main, 11.5
Change-Id: I1f7f532eb82a248a28d8d7ec707d678d59a73ec0
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72885

Tested-by: core-ci <typo3@b13.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>

dc2c9dbd

[TASK] Better performance for LiveSearch · b2b124cb

Stefan Froemken authored Dec 15, 2021 and

Christian Kuhn committed Jan 05, 2022

We removed the SQL query on pages (column: pid) for TYPO3
administrators, because this group of people has access to
all pages anyway. Especially in large TYPO3 instances
the collection of all pages UIDs took a lot of time.

Resolves: #96356
Releases: main, 11.5
Change-Id: I436e15e79ce590c4228b9a9034f83497fa1db92e
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72884

Tested-by: core-ci <typo3@b13.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>

b2b124cb

[TASK] Make status of simulate time clearer · 468b1f6a

Susanne Moog authored Jan 02, 2022 and

Christian Kuhn committed Jan 05, 2022

Once a user simulated a time with the admin panel,
it has not been easy to see the status of the field
or to understand how to disable it. To make it easier
for the user to handle a separate checkbox has been added
that allows enabling or disabling the simulate time feature.

Resolves: #94596
Releases: main, 11.5
Change-Id: I309475f19f64dd8324f2466082d979d0afdbd501
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72883

Tested-by: core-ci <typo3@b13.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>

468b1f6a

[TASK] Adjust QueryBuilder PHPDoc comments · cdb016b3

Ingo Fabbri authored Jan 05, 2022 and

Christian Kuhn committed Jan 05, 2022

Some methods have the wrong type declaration.
E.g. string instead of mixed.
Add type-hints for completeness.

Resolves: #96463
Releases: main, 11.5
Change-Id: I415e8fa572ecbe278aa8323fd206494d314c559f
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72882

Tested-by: core-ci <typo3@b13.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>

cdb016b3

[BUGFIX] Mark shortcut pages as active in HMENU · a6593bd9

Benni Mack authored Jan 04, 2022

This change moves the method resolveShortcutPage()
into PageRepository as it is now also used in determining
if a page is marked as active / current.

The method `resolveShortcutPage()` is much more convenient
when working with $page records instead of the properties,
instead of `getPageShortcut()`.

This also allows MenuProcessor to have a proper "active"
and "current" values set properly without any workarounds.

Resolves: #85138
Resolves: #80841
Resolves: #87923
Releases: main, 11.5
Change-Id: Ic401fb42696757199c5974120f24250c467d9b75
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72881

Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>

a6593bd9

[BUGFIX] Resolving page slug ending with index and type suffix '.php' · 8b3e6321

Stefan Bürk authored Aug 16, 2021 and

Benni Mack committed Jan 05, 2022

If a page slug ends with 'index' and site has a routing
configuration with a PageTypeSuffix with index and suffix
'.php' as default suffix, route resolving cuts 'index.php'
from the uri, ending with a slug without index in it and
thus not resolving the page and displaying 404 page.

The reason for this is the code fragment which strips the
document root from the uri as a cleanup for some systems,
and fixes an issue for calling id/type parameters with
index.php (main entry point), which has been added as a
bugfix in v9 with #88028.

There was a first attempt to fix this page resolving issue
with #94537, which has been a regression and reverted with
issue #94968.

To ensure everything works and regression is covered before
a new patch, there has been two patches with #95096 and #95362.

After the regression there has been a really deep analysis,
to get all puzzle pieces together over the time, which ended
in the pre-patches and finally in this patch.

The stripping of the document root has been implemented to
late in the resolving chain to solve #88028, thus the followup
fixes interferred with the resolving concept. This patch moves
this stripping from the page-resolving point some steps early
to the site-resolving step, and doing the stripping only on
the left site of the uri and avoiding a generall str_replace(),
thus fixing past issues and the current issue in the correct
place.

Furthermore tests for this issue are (re)added with this patch,
as they were removed with the revert.

Resolves: #94905
Related: #95096
Related: #95362
Related: #94537
Related: #94968
Related: #88028
Releases: main, 11.5
Change-Id: I2e10689893047e2d8f19057dfac2fb3b5f0bdcde
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72880

Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>

8b3e6321

[BUGFIX] Add TCA migration for select authMode keywords · dd291132

Nikita Hovratov authored Dec 31, 2021 and

Oliver Bartsch committed Jan 05, 2022

With the introduction of itemGroups, the index 3 of
the select items array has been shifted one position
to the right. Before that, the index 3 was used for
descriptions and index 4 for an optional keyword
EXPL_ALLOW or EXPL_DENY. These are used together
with authMode=individual to explicitly allow or deny
single items.

Since descriptions now occupy the index 4, the
former usage of this index needs to be shifted as
well to index 5.

For backwards compatibility reasons, a TCA migration
is added, which will check for these special
keywords and move them one index up.

Resolves: #96444
Related: #91008
Releases: main, 11.5, 10.4
Change-Id: I32a96f5c6377871551ab4ee60a402a585da7eaa0
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72877

Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Oliver Bartsch <bo@cedev.de>

dd291132

[BUGFIX] Add CompositeExpression argument docblock type-hint · 10fff855

Ingo Fabbri authored Jan 04, 2022 and

Benni Mack committed Jan 05, 2022

This patch adds missing 'CompositeExpression' as union
type for QueryBuilder methods 'where()', 'andWhere()'
and 'orWhere()' to match the ability of the underlaying
doctrine/dbal QueryBuilder methods.

Resolves: #96457
Releases: main, 11.5, 10.4
Change-Id: Ib9330ffabcdc7680bfd5bb8a991cec60889c9773
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72878

Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>

10fff855

04 Jan, 2022 8 commits

[BUGFIX] Rename variable for storing the translated options · 0800ba7c

Jan Helke authored Jan 04, 2022 and

Christian Kuhn committed Jan 04, 2022

Ensure that in a foreign language context the selected option will
be translated in the finishers. Regression fix introduced with #93979.

Resolves: #96455
Related: #93979
Releases: main, 11.5
Change-Id: Ie6b33f70d6d9a19232821bda77e37b6f290ea061
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72859

Tested-by: core-ci <typo3@b13.com>
Tested-by: Jan Helke <jh@f7.de>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Jan Helke <jh@f7.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>

0800ba7c

[TASK] Extract symmetric mn scenario from ext:irre_tutorial · 7b8fa897

Anja Leichsenring authored Jan 01, 2022 and

Christian Kuhn committed Jan 04, 2022

The scenario provided by tables tx_irretutorial_mn_sym_* gets
its own test extension and gets loaded where needed.

Resolves: #96445
Releases: main, 11.5
Change-Id: I55a9c3ba1a5e1d238279a641f4e5380d936c23c9
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72876

Tested-by: core-ci <typo3@b13.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>

7b8fa897

[BUGFIX] Fix ordering of db mounts in page tree · a7332682

Benjamin Franzke authored Dec 28, 2021

With the changes in #95854, database mounts
are no longer sorted by the order they are defined in
the group/user settings, but undefined by the
order the database returns.

DB mounts aren't sorted against each other,
that means sorting values are not meaningful anyway,
and results in uncontrolable orderings.

Explicitly preserve the order using usort().
Also revert groupAndSortPages() to the state prior
to #95854, as the forcePid parameter would now be unused.

Releases: main, 11.5, 10.4
Resolves: #96359
Related: #95854
Change-Id: I64b8d90c68246cc0ac01abcbf3678aa1055189e3
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72875

Tested-by: core-ci <typo3@b13.com>
Tested-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>

a7332682

[BUGFIX] Do not overwrite previously set preview mode · 44a34cd8

Susanne Moog authored Jan 02, 2022 and

Christian Kuhn committed Jan 04, 2022

The frontend preview aspect may be set from the admin panel
or the frontend extension or even from a third-party extension
in a middleware. The previous implementation overwrote the preview
settings on every initialisation, resulting in lost preview
information. Instead of overwriting the setting, this change takes
the current preview value into account - if the preview was enabled
by a previous instance this is kept.

Additionally, the logic to set the preview flag in both frontend
and admin panel has been streamlined.

Resolves: #91225
Releases: main, 11.5
Change-Id: I9f642bca1928638cac5eb5c1468710f5fad28137
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72872

Tested-by: core-ci <typo3@b13.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>

44a34cd8

[BUGFIX] Avoid invalid mktemp argument busybox in cglGit · c7c55a7c

Christian Kuhn authored Jan 04, 2022

The busybox variant as packaged with the test images based on
alpine of mktemp needs six 'X' as template in cglFixMyCommit.sh.
It otherwise emits a warning executing the command:

 > Build/Scripts/runTests.sh -s cglGit

Resolves: #96432
Releases: main, 11.5, 10.4
Change-Id: I1c1853aabe79186694161c21f5fe0341e1bd2e75
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72873

Tested-by: core-ci <typo3@b13.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>

c7c55a7c

[BUGFIX] Set mute=1 if autoplay=1 for rendering youtube videos · 0beca1c6

Georg Ringer authored Dec 10, 2021 and

Christian Kuhn committed Jan 04, 2022

The option "autoplay" only works if "mute" is enabled. See
https://developer.chrome.com/blog/autoplay/ for reference.

Resolves: #96320
Releases: main, 11.5, 10.4
Change-Id: Ic4e2de0576fe3d1619af8e35274adeb013c72b31
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72845

Tested-by: core-ci <typo3@b13.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>

0beca1c6

[BUGFIX] Check correctly for TCA search options · dc00f26c

Nikita Hovratov authored Jan 04, 2022 and

Christian Kuhn committed Jan 04, 2022

The documentation states "case" and "pidonly" are
of type boolean. But in the code in_array was used
to decide, whether to utilize these options.

This is now fixed by checking for the array keys.

Some lines above in the first if-branch, this has
been already fixed.

Resolves: #96454
Releases: main, 11.5
Change-Id: I04c3638620f7a91612bdc0598ff25893325bb801
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72844

Tested-by: core-ci <typo3@b13.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>

dc00f26c

[BUGFIX] Fix undefined array key error in DatabaseRecordList · 8ddf6b84

Nikita Hovratov authored Jan 04, 2022 and

Christian Kuhn committed Jan 04, 2022

TCA eval config is not required, so it must be
checked for existence.

Resolves: #96453
Releases: main, 11.5
Change-Id: I95425e3febac70ac2e03478b7385edbaf0c9a601
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72843

Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>

8ddf6b84

03 Jan, 2022 7 commits

[TASK] Update symfony dependencies to 5.4 (LTS) · 445f6066

Benni Mack authored Dec 01, 2021 and

Christian Kuhn committed Jan 03, 2022

This change enables raises Symfony's minimum
version to 5.4.0 as this is a LTS version.

Resolves: #96171
Releases: main, 11.5
Change-Id: Ia2acbe0bca60e0dbdb96cb2fe2e82a63f9575554
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72836

Tested-by: core-ci <typo3@b13.com>
Tested-by: Stefan Bürk <stefan@buerk.tech>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>

445f6066

[BUGFIX] Avoid undefined array key in inlineLocalizeSynchronize function of DataHandler · 444438b6

Johannes Seipelt authored Jan 02, 2022 and

Christian Kuhn committed Jan 03, 2022

Resolves: #96415
Releases: main, 11.5
Change-Id: I4f96cd250b1f1ef27c7232b8fff3214cb555ab32
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72841

Tested-by: core-ci <typo3@b13.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Johannes Seipelt <johannes.seipelt@3m5.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>

444438b6

[TASK] Add allowed composer plugins for composer >= 2.2.0 · 2a9dcee9

Torben Hansen authored Dec 23, 2021 and

Christian Kuhn committed Jan 03, 2022

Added the following Composer plugins as allowed/trusted

* composer/package-versions-deprecated
* typo3/class-alias-loader
* typo3/cms-composer-installers

Resolves: #96428
Releases: main, 11.5, 10.4
Change-Id: Iabb8f00411279f502bca1d1ba79714cc58d82d3f
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72781

Tested-by: core-ci <typo3@b13.com>
Tested-by: Stefan Bürk <stefan@buerk.tech>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>

2a9dcee9

[BUGFIX] Use realpath() for vcsIgnore in CGL fixer · 14451baa

Christian Kuhn authored Jan 03, 2022

It seems that symfony >= 5.4.0 has a bug in symfony
finder that .gitignore files are no longer always
found when the ->in() directive is a non-absolute
path with '/../'.
This triggers issues with our cgl fixer script in
nightly mode.
We work around that by using an absolute path
instead in the configuration and will report the
issue to symfony.

Resolves: #96450
Related: #96171
Releases: master, 11.5
Change-Id: Ice865b92c118e26d519fbca7ae49e41fbe4d5110
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72842

Tested-by: core-ci <typo3@b13.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>

14451baa

[BUGFIX] Allow rendering of subpages for spacers · 07638213

Benni Mack authored Dec 28, 2021 and

Oliver Bartsch committed Jan 03, 2022

If rendering of spacer pages in an HMENU is explicitly
given via SPC = 1, then subpages of pages are now rendered
as well.

This way, there is no difference between spacers and other
page types for submenu rendering anymore.

Resolves: #64428
Releases: main, 11.5
Change-Id: Ic4bc2661399498de61af486712ade85815ffa529
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72840

Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>

07638213

[BUGFIX] Avoid array offset on null warning when generating preview URL params · 0ce25043

Chris Müller authored Dec 30, 2021 and

Benni Mack committed Jan 03, 2022

Resolves: #96443
Releases: main, 11.5
Change-Id: I9f1c951628cf8872473ff20bbd59ffb769ffe279
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72839

Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Benni Mack <benni@typo3.org>

0ce25043

[BUGFIX] Avoid type errors in TimeTracker · 52d4e537

Susanne Moog authored Jan 02, 2022 and

Benni Mack committed Jan 03, 2022

Make sure to pass strings to html formatting methods.
Initialize hierarchy array correctly.

Resolves: #96448
Releases: main, 11.5
Change-Id: I2b9c28303c1c96d0a2ea1bc3ca971da3b4b3fe7d
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72838

Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>

52d4e537

30 Dec, 2021 4 commits

[BUGFIX] Avoid undefined array key in LegacyLinkNotationConverter · cd6df0df

Chris Müller authored Dec 29, 2021 and

Andreas Fernandez committed Dec 30, 2021

This error occurs when running linkvalidator in scheduler:
Undefined array key 1.

Resolves: #96439
Releases: main, 11.5
Change-Id: Idbe4b5bf52722a800026fc7af566daba925eaad2
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72837

Tested-by: core-ci <typo3@b13.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>

cd6df0df

[BUGFIX] Avoid duplicate pages in pagetree when rootPid is mounted · 62ada6fa

Benjamin Franzke authored Dec 28, 2021 and

Andreas Fernandez committed Dec 30, 2021

With the changes in #95854, implicit rootPid dbmounts caused
duplicated pages in pagetree, because explicit page mounts have
been considered multiple times for the pid=0 tree:

 * First time because of their relationship to pid = 0
 * Second time because of their explicit mount
   (which was sorted into the pid = 0 tree)

This happened because #95854 optimized to only use one call
to the PageTree repository, which then had the side effect
of merging "multiple" pages into one tree, instead
of showing "two" separate trees.

The patch ensures that multiple page trees are used when
the rootPid (0) is included as a webmount.

Releases: main, 11.5, 10.4
Resolves: #96367
Related: #95854
Change-Id: I7f421995f2d4aa88bb266fec684565102a4dc080
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72835

Tested-by: core-ci <typo3@b13.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>

62ada6fa

[BUGFIX] Fix TCA of sys_workspace custom_stages · 75c21c6b

Nikita Hovratov authored Dec 28, 2021 and

Benni Mack committed Dec 30, 2021

The TCA option "appearance" is an array, with
pre-defined configuration keys. The column
"custom_stages" of the table "sys_workspace" set a
csv value for this option. This does not work.

The configuration is now transformed into the
correct array format.

Resolves: #96437
Releases: main, 11.5, 10.4
Change-Id: I25112d7ea1ce605376d70fa2dabceddd3c121faa
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72833

Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>

75c21c6b

[BUGFIX] Avoid undefined array key in garbage collection task · a6561904

Chris Müller authored Dec 29, 2021 and

Benni Mack committed Dec 30, 2021

Resolves: #96438
Releases: main, 11.5
Change-Id: Idcb8ca5f889aef8d77c1e3950f5794fe54ed76e3
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72832

Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>

a6561904

29 Dec, 2021 1 commit

[TASK] Fix typo in InputDateTimeElement · f931a62a

Nikita Hovratov authored Dec 29, 2021 and

Benni Mack committed Dec 29, 2021

Resolves: #96441
Releases: main, 11.5
Change-Id: Id3ae6ee43d1db5ef2ee46fedb336561bc8049a72
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72791

Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>

f931a62a

28 Dec, 2021 1 commit

[BUGFIX] Remove useless felogin view configuration · 36454147

Markus Klein authored Dec 17, 2021 and

Benni Mack committed Dec 28, 2021

The setup should not contain the same settings twice.
Moreover, the default paths are always available,
no need to configure them.
Additionally, remove default paths from constants,
we don't need that either.

Resolves: #96384
Releases: main, 11.5
Change-Id: I204cc38a952dd7acd097d188d1637ad1b25324fc
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72719

Tested-by: core-ci <typo3@b13.com>
Tested-by: Simon Schaufelberger <simonschaufi+typo3@gmail.com>
Tested-by: Daniel Haupt <mail@danielhaupt.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Simon Schaufelberger <simonschaufi+typo3@gmail.com>
Reviewed-by: Daniel Haupt <mail@danielhaupt.de>
Reviewed-by: Benni Mack <benni@typo3.org>

36454147

23 Dec, 2021 8 commits

[TASK] Add tests for list menu with folder as root storage · 4d980f4e

Benni Mack authored Dec 22, 2021 and

Oliver Bartsch committed Dec 23, 2021

This change adds test to document the behavior that excludeDoktypes
needs to be set to render folders in a menus as well.

Resolves: #93924
Releases: main, 11.5
Change-Id: I870e2ef5cd07d5365d93ad04752b74a4edaebd64
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72790

Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>

4d980f4e

[BUGFIX] Do not link to untranslated records · dc749a15

Mathias Brodala authored Dec 21, 2018 and

Benni Mack committed Dec 23, 2021

This only fixes the issue for dedicated record links. Page links with
added query arguments can still lead to broken links.

Resolves: #87260
Releases: main, 11.5
Change-Id: Ib13aa1925de6463688e2b50612ce7b2820733ce7
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72788

Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>

dc749a15

[BUGFIX] Be consistent in HMENU.special = language · 1d5d5743

Benni Mack authored Dec 23, 2021

Previously, HMENU.addQueryString, which is only
available for special=language, was applied
not within the typolink() functionality but before.

By sorting out the properties, HMENU with
special=language now properly uses typolinks
addQueryString.

Using the magic property _ADD_GETVARS to activate
this option addQueryString but also using
the "_PAGES_OVERLAY_REQUESTEDLANGUAGE" allows
to fix special=language issues.

Resolves: #94713
Releases: main, 11.5
Change-Id: Ic26e702fb97bb878308de5e1710d2a3c4f28552d
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72789

Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>

1d5d5743

[BUGFIX] Avoid PHP 8 warnings in LocalCropScaleMaskHelper · c634d404

Benni Mack authored Dec 22, 2021

Resolves: #96344
Releases: main, 11.5
Change-Id: I986945e16e0a2adef827fc0532a431be7ab25e03
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72787

Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>

c634d404

[BUGFIX] Fix PHP 8 notices in workspaces preview · f99cd918

Benni Mack authored Dec 23, 2021

Resolves: #96430
Releases: main, 11.5
Change-Id: I8569537d90ee5dc74157db4f3e583366b82a2e27
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72786

Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>

f99cd918

[BUGFIX] Resolve shortcuts in HMENU to access restricted pages · 18b65882

Benni Mack authored Dec 22, 2021

There is a difference between

> typolink.linkAccessRestrictedPages = 1 (only a toggle)
and
> HMENU.showAccessRestrictedPages = [pageId]|NONE

HMENU.showAccessRestrictedPages behaves like
the global option "config.typolinkLinkAccessRestrictedPages"

Basically, if a page is access restricted, link
to a different {pageId}.

This change explains the behavior:
-- https://review.typo3.org/c/Packages/TYPO3.CMS/+/35908/

"typolink.linkAccessRestrictedPages" in contrast
still links to the actual disallowed page, which
is also nice in case you have a 403 error page in place.

This change fixes the behaviour of HMENU to behave
EXACTLY like the global config.typolinkLinkAccessRestrictedPages,
previously HMENU did some magic PLUS it set
"typolink.linkAccessRestrictedPages"

With this change, shortcuts to access restricted pages
now get properly transformed and linked for menus.

Resolves: #60258
Resolves: #65118
Related: #63804
Releases: main, 11.5
Change-Id: Ifd975243fe4b024b3fcbd4e356430d809cc0f429
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72785

Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>

18b65882

[BUGFIX] Avoid undefined array key in ContentObjectRenderer->getTypoLink() · 90817ca9

Chris Müller authored Dec 22, 2021 and

Benni Mack committed Dec 23, 2021

Resolves: #96418
Releases: main, 11.5
Change-Id: I00b77f478c667f59b751c6f13c975d03799086d7
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72783

Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>

90817ca9

[BUGFIX] Avoid undefined array key in TextMenuContentObject->writeMenu() · f6d94968

Chris Müller authored Dec 22, 2021 and

Benni Mack committed Dec 23, 2021

Resolves: #96377
Releases: main, 11.5
Change-Id: I98dfe39cf04468d54ee979afa34e7dd3bd40acf6
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72784

Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>

f6d94968