- 13 Dec, 2021 1 commit
-
-
Helmut Hummel authored
With the introduction of site settings being exposed to TypoScript with https://review.typo3.org/64128 it has become important to allow more characters as TypoScript keys. Allowing a slash in addition should cover cases where paths are exposed as keys. Additionally the above change reveals, that the ArrayUtility::flatten method does not properly handle array keys that has dots in between, as those must be escaped to produce a correct result. This change introduces a new flatten method after several failed attempts to guess what fixes might not be breaking. The new method is used in places where no TypoScript is used, as in those the weird edge case behaviour of the flatten method isn't expected anyway. The new method is marked internal until it is decided how to proceed with the flatten method. Resolves: #94646 Releases: main, 10.4 Change-Id: I4ebad8a0beece975702d8601a343aa1fdaaa285c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72120 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Helmut Hummel <typo3@helhum.io> Reviewed-by:
Helmut Hummel <typo3@helhum.io>
-
- 11 Dec, 2021 1 commit
-
-
This avoids an error-prone AJAX call in the backend module. This issue does not happen in TYPO3 v11+ anymore, as the method is not called via AJAX directly anymore. Resolves: #90073 Resolves: #91679 Releases: 10.4 Change-Id: I0dd9caba77352ee60e0e56138bffa3bbc02a98d0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72609 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
- 10 Dec, 2021 3 commits
-
-
* Adjusts all configuration files using the main branch instead of master * Makes all "Edit on Github" links in the Changelog and System Extension manuals work again after master - main switch. * Fixes all link to Github or Docs using the path containing main instead of master Resolves: #96138 Releases: main, 11.5, 10.4 Change-Id: Ifde73dd2bb8efdbf54eb2ba7625d6f201de9bd11 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72573 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Lina Wolf <112@linawolf.de> Reviewed-by:
Lina Wolf <112@linawolf.de>
-
If TSFE->set_no_cache is called, either a warning or a notice is triggered, depending if a BE user is connected or not. With this change, the preview mode will trigger a notice instead of a warning. This restores the same behaviour than before #86002. Resolves: #96306 Releases: main, 11.5, 10.4 Change-Id: I40b9b1d90d42f14de2977aca61c24a9fd698ced0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72578 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Make HTML parser more tolerant for single tags with ending slash but without white spaces. So `<hr/>` already was allowed and internally converted to `<hr />` while parsing the HTML. This patch extends this replace rule to all tags so that also `<br/>` can be used in RTE fields. Resolves: #96307 Releases: main, 11.5, 10.4 Change-Id: I7ba6c88e35804c6b5f991fb6b730fbc3d7a2514e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72580 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 06 Dec, 2021 3 commits
-
-
Christian Kuhn authored
Populate a series of minor deprecations and updates. composer req --dev typo3/testing-framework:^6.15.1 composer req --dev typo3/testing-framework:^6.15.1 -d typo3/sysext/core/ --no-update Resolves: #96265 Releases: 10.4 Change-Id: If8c9e5e9b424e907607edf4d718f92a926c3a15d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72533 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Christian Kuhn authored
Additional backport of #96166 to v10 since it is useful for nightly execution, too. Change-Id: I8e461592eecd0a66b0fcf6ee5ab14509ebec8277 Resolves: #96166 Releases: master, 11.5, 10.4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72532 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Christian Kuhn authored
The patch changes runTests.sh and the container definition to avoid mounting users home, /etc/passwd and /etc/group. yarn based setups need some special treatment but in the end bow to shell power, too. Change-Id: I4e5665d31c5bef4e046e992eddd534ae597cce31 Resolves: #96253 Releases: main, 11.5, 10.4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72517 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
- 04 Dec, 2021 1 commit
-
-
Christian Kuhn authored
APCu cache backend is a shared memory per user and typically bound to the executing posix user-id. Calculating different cache identifiers per user is useless since those won't share the same shm. Resolves: #96232 Releases: master, 11.5, 10.4 Change-Id: If6b6a744828d06d55f2c9b5656aef48193da7384 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72511 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
- 03 Dec, 2021 1 commit
-
-
Oliver Bartsch authored
A false check in the TER API allowed to use arbitrary version strings, as soon as they start with the known `XXX.XXX.XXX` schema. This will be fixed in TER API. However, core as receiver should also validate the incoming data, before storing them in the database. Therefore, the same version number check, which is used in the TER API, is now also applied in the ExtensionXmlParser. Resolves: #96209 Releases: main, 11.5, 10.4 Change-Id: I487eed34c6b25a5e3841d5263b52b9a73aaf681a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72484 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
- 01 Dec, 2021 1 commit
-
-
Georg Ringer authored
The translations need to use the language of the current backend user and not the one of the current language of the site in the frontend. Resolves: #96004 Releases: master, 11.5, 10.4 Change-Id: Id409e759de4f0324835cc932f87719147b6e1b0f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72362 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com>
-
- 29 Nov, 2021 1 commit
-
-
Resolves: #96133 Releases: main, 11.5, 10.4 Change-Id: Ic1924bbf34b746bf1891419da6cb54e547a509a8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72365 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
- 28 Nov, 2021 1 commit
-
-
Creating auto redirects, if page slug is changed, has been extended to add the target with LinkHandler 't3://' uri schema with #89327, adding language argument '_language' to enforce the language for the redirect, missing that that did not worked, which was solved through adding '_language' argument handling in #96043. As language arguments '_language' and 'L' are ignored, if the provided page uid is already the uid of the localized page, the parameter was meaning less. Further this breaks language fallback handling, if the localized page record is deleted. This patch uses now the default language page uid for creating target of auto-redirects to mitigate the issue that redirect will break if localized page is deleted but language fallback is configured. Resolves: #96103 Related: #96043 Related: #89327 Releases: master, 11.5, 10.4 Change-Id: I2ece06bf053bda4edb542910c3f51b1e6c8e052c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72359 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 25 Nov, 2021 1 commit
-
-
This patch fixes a bug where a t3 page URI with _language != 0 was resolved to a page in the default language. This caused automatically generated redirects to translated pages to redirect to the page in the default language. We now use the same override handling for the '_language' parameter (as already existed for 'L') when t3 page URIs are resolved. Also, we ensure that both parameters are always removed when the final URL is generated. Furthermore, this patch adds tests to cover these cases. Using the historical 'L' parameter still works and has been added to be handled as language override. Background information: The '_language parameter' is the preferred parameter to be used to specify the language in a t3 URI, not 'L'. The behaviour of creating auto redirects on slug changes was changed previously: The target was added as LinkHandler URI (instead of the path). Along with this change, the '_language' parameter was used to ensure the target URL is generated in the needed language (#89327). This introduced a problem where a redirect always redirected to the page in default language if a t3: page URI was used with '_language'. Resolves: #96043 Related: #89327 Releases: master, 11.5, 10.4 Change-Id: I95bdeff4827eed3be30528c02331b9c9ff2836b1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72271 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 22 Nov, 2021 1 commit
-
-
TCA slug field generator option 'prefixParentPageSlug' has been added to be used for page records only. Slug generation for non-page records with pid=0 has been fixed with #94655 which introduced a endless loop if 'prefixParentPageSlug' is used as slug field generator option for record tables. This patch only process 'prefixParentPageSlug' for page records, thus ignoring it for non-page records and avoiding the endlees loop and as such prevent segmentation faults or memory_limit fatal errors. Resolves: #95485 Related: #94655 Releases: master, 11.5, 10.4 Change-Id: I20e1ac68bad6ad9447b03debbedb646495045ac3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72257 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
- 19 Nov, 2021 3 commits
-
-
Releases: master, 11.5, 10.4 Resolves: #96040 Change-Id: Idc83eedacc1ab00f761e179e394e173a071b6b0d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72130 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Benjamin Franzke authored
This applies to rendering of database mounts (from groups or from workspaces): They are now shown as children of the virtual root page (uid=0) as it used to be in TYPO3 v8. This is to allow workspace users to get an overview of all changes of all mounts by navigating to the virtual page uid=0. Releases: master, 11.5, 10.4 Resolves: #95854 Related: #95972 Related: #91145 Change-Id: I7f6370f327711396193cf56b63f15876350c2559 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72078 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Benjamin Franzke <bfr@qbus.de>
-
The example for the CommaSeparatedValueProcessor was missing a value for the fieldEnclosure property. This might lead to the assumption that this property can be "unset", which is not the case as it always defaults to a quotation mark ("). This is now fixed by adding an example value. Resolves: #93190 Releases: master Change-Id: If4ee5f358f71d83d0117cf0e9c2e07c619966b9f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72122 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 17 Nov, 2021 3 commits
-
-
docker on mac and windows WSL2 encapsulate a VM into the system. The current xdebug remote config does not work in those cases since the host IP can not be determined with the current solution. Switching to host.docker.internal works for macOS and WSL2, and works for linux too in combination with an extra_hosts setting. This requires linux to use at least docker 20.10, which shouldn't be a huge issue with casual developer machines. Resolves: #95999 Resolves: #94932 Releases: master, 10.4 Change-Id: I02acfeefc08f338841b4fecdb952c7da37ff65e1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72218 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Christian Kuhn authored
Switching to 20.10 gives us a feature we need in runTests.sh. Resolves: #96013 Related: #94932 Related: #95999 Releases: master, 10.4 Change-Id: I7eef83c130b76cab84dff7d595b7807d34b22ce7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72213 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
The identifier from the linkHandler page TSconfig was formerly used as the reference table name "ref_table". This identifier is free to choose and shouldn't be interpreted as a name of a table. In order to resolve the correct table name, which is stated in the configuration, the page id of the reference record is now used. This allows the TypolinkSoftReferenceParser to read the according page TSconfig and to set the correct table name. Resolves: #95380 Releases: master, 10.4 Change-Id: I28817a7267a107df27828d99f7e0cf2eeaaf2de1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72202 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Henrik Ziegenhain <henrik@ziegenhain.me> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Henrik Ziegenhain <henrik@ziegenhain.me> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 15 Nov, 2021 4 commits
-
-
The ConditionMatcher tries to resolve the current page id from global variables. One of this possibilities uses the cmdMap that is sent to the DataHandler. This patch ensures that the correct target uid is used to resolve the page id. Resolves: #95967 Releases: master, 10.4 Change-Id: I0fb7968c3118f2ab78c1cbb1dda3643e9f2f450e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72119 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Benjamin Franzke authored
empty() returns true if a record contains 0 as value. Therefore isset() needs to be used instead. The corresponding fix that was introduced with #91145 to workaround this flaw is removed again. Change-Id: I7286cf2337e3d7c942844881f95041bc54f8e811 Resolves: #95972 Related: #91145 Releases: master, 10.4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72117 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Benjamin Franzke <bfr@qbus.de>
-
This patch applies the current recommendations for BASH scripts see https://github.com/koalaman/shellcheck#readme. Resolves: #95964 Releases: master, 10.4 Change-Id: I21ba18cb151acc0ff8f33a2135ef289669d15bab Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72179 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Christian Kuhn authored
Brings a series of core v11 relevant PHP 8.1 E_ALL preparations and a couple of minor details. composer req --dev typo3/testing-framework:^6.13.0 mikey179/vfsstream:^1.6.10 composer req --dev typo3/testing-framework:^6.13.0 mikey179/vfsstream:^1.6.10 -d typo3/sysext/core/ --no-update Change-Id: I140866e8fb7014efbc33b7c1f25b2f840bd19ce2 Resolves: #95979 Releases: master, 10.4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72177 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
- 11 Nov, 2021 3 commits
-
-
Currently, the value of `USdateFormat` is disregarded because the corresponding property, `FormEngineValidation.USmode`, is set to zero regardless in `FormEngineValidation.initialize()`. This change will ensure that `USmode` will remain 1 without conflicting with core functionality that relies on `USmode` being set *before* `initialize()` is called. Resolves: #86679 Releases: master, 10.4 Related-to: #91105 Change-Id: I5584ca7fe92742e28147f9883fedf53e0556f1b1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72116 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Benni Mack authored
This reverts commit 7bfe6f76 as this has some side-effects with absolute paths. Reverts: #95379 Resolves: #95959 Releases: master, 10.4 Change-Id: I0065bb2db480f29fea12890cdfb3d34b57c94eef Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72115 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Native time fields (dbtype) in the record list are now displayed independent from the server timezone. Resolves: #92962 Releases: master, 10.4 Change-Id: Ie9075378e67d0c302b126db78751992789fae29c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72113 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 10 Nov, 2021 6 commits
-
-
Redirects to target with LinkHandler uri 't3://' need a bootstrapped 'TypoScriptFrontendController' and parsed and executed TypoScript, which is done later in the middleware stack for normal requests. Thus RedirectService bootstraps 'TypoScriptFrontedController' to generate uri for LinkHandler uri. At this point global '$GLOBAL['TYPO3_REQUEST']' has not been in set, and the fallback to create it from GLOBALS would not have correct site and siteLanguage attributes set, which would fail to evaluate TypoScript conditions correctly like 'fallbackLanguageIds' array check for siteLanguage attribute, as null is returned instead of an array. For v11 this was already fixed through moving to passing the PSR-7 request and initalizing TSFE with passed request in #92666 and the coresponding patch. This patch sets a '$GLOBAL['TYPO3_REQUEST'] to the current '$request' to avoid 'InvalidTypoScriptConditionException' if page is in FE debug context (ex. DebugPreset). If no redirect is found to be handled, that temporarly global request object is removed, to handle it through the normal middleware stack. Resolves: #95882 Related: #92666 Releases: 10.4 Change-Id: I6d7bff643fa2440e3986e4362c1882d53db1bb67 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72074 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Sybille Peters <sypets@gmx.de> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Text cropping on texts with way more than 1000 characters triggers regular expression compilation errors. The sweet spot was determined to a value of max 962 characters, thus leading to internal 'preg_match' error state and throwing 'Compilation failed: regular expression is too large' warning. The patch crops text in multiple chunks and reassembles the chunks until crop position was reached to avoid this internal error exceeding the max regular expression pattern length. Further tests are added to cover this scenario. Resolves: #77642 Releases: master, 10.4 Change-Id: I15b778370df0d0a3d3087a0b199c3e16f7a46add Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72149 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Using references instead of absolute URLs has the following advantages: - If a target section is moved, the URL in a :ref: linking to it is updated automatically - It is possible to maintain the links to the other docs repository in a central place (Settings.cfg). This way, it is possible to link to the same version of a manual in a lower branch (e.g. 10.4) by changing the link in one place The above results in a better user experience (stay in information for same version when linking across docs repos) and less broken links (in the future). Resolves: #95948 Releases: master, 10.4 Change-Id: I84d801a75424bd94b4fa15aecb17a6085af07c36 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72148 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
FlexForm Section can be added before content element is saved. This is done by ensuring that processedTca have a value for list_type. Earlier the pi_flexform was ignored as the default values on create before save was empty. Resolves: #81684 Releases: master, 10.4 Change-Id: I62e03cbbd93e8785f58c24dad1e573e8b5e0202b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72147 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
The method signature of Query::locicalOr() is very misleading because it only states there is one method argument $constraint1. Actually, the method does accept any number of arguments, evaluated via func_get_args(). It also accepts any number of arguments if $constraint1 is an array of constraints. This leads to multiple issues when working with phpstan and also when simply using an IDE which does not understand the internal magic. The goal is to state, that logicalOr() needs at least two constraints but also accepts any number of further constraints. Since that requires a breaking change, the method signature can only be fixed partly for now. $constraint1 remains as is, a 2nd argument $constraint2 is introduced, null by default to make it optional and a variadic argument ...$furtherConstraints is also introduced. This approach keeps the bc promise but also lays the foundation for further changes in the next version. Releases: master, 10.4 Resolves: #95938 Change-Id: I2a605cb4f42ec5324d973b63cf838278287de516 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72144 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
- Remove information about bug which no longer exists - Link to redirects documentation - Remove example for redirect module because such a redirect may not be the best example to handle with EXT:redirects because permanent redirects with regex might be better maintained in webserver configuration, examples are best kept in redirects documentation and example for this specific redirect and the regex for it can be easily found elsewhere. Resolves: #95944 Releases: master, 10.4 Change-Id: Ia8f01f37228efc88c2675e342a96738b5e20ae6c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72146 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
- 09 Nov, 2021 6 commits
-
-
The first array entry for "$data" is the replacement for "%s" in vsprintf. The order has been swapped, so the wrong e-mail is the replacement instead of the localized error message. This has been recently fixed in master with #95459. Releases: 10.4 Resolves: #95444 Related: #95459 Change-Id: I046f604460bbe95788b076ff87cfc9319f7b0ab6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72105 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
The method signature of Query::locicalAnd() is very misleading because it only states there is one method argument $constraint1. Actually, the method does accept any number of arguments, evaluated via func_get_args(). It also accepts any number of arguments if $constraint1 is an array of constraints. This leads to multiple issues when working with phpstan and also when simply using an IDE which does not understand the internal magic. The goal is to state, that logicalAnd() needs at least two constraints but also accepts any number of further constraints. Since that requires a breaking change, the method signature can only be fixed partly for now. $constraint1 remains as is, a 2nd argument $constraint2 is introduced, null by default to make it optional and a variadic argument ...$furtherConstraints is also introduced. This approach keeps the bc promise but also lays the foundation for further changes in the next version. Releases: master, 10.4 Resolves: #95889 Change-Id: Ife1be32d99371b82a84b6f6d800a58d242c8ff0d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72099 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
To ease the work with phpstan and IDE's, some types in persistence related classes of extbase are now either fixed or more specified. Releases: master, 10.4 Resolves: #95885 Change-Id: I2a784bd3ffaae651dd67dd939ef13e5efcb2ead6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72112 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Oliver Bartsch authored
It's possible to query for deleted records in DB Check "Full search". Such records can then be restored only or additionally restored and directly edited. The icon for the latter action was broken, since a non existing icon identifier was used. This is now fixed, using the correct icon identifier. Resolves: #95923 Releases: master, 10.4 Change-Id: I7da25198efe731a9ccba9e673c8c55e42760b233 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72100 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Oliver Bartsch authored
In prior versions, creating a new page via the context menu inserted the new page "inside". This however changed to "after" in v8, leading to misbehavior, especially for non-admins, as they are usually not allowed to create pages on pid=0. This is now fixed by restoring the previous behavior of inserting pages "inside" instead of "after". Resolves: #81405 Releases: master, 10.4 Change-Id: I6a941c3e015189a471d0c136c81f1e5698426dbb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72097 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
The pagination feature in DB Check "Full search" did not work, since the defined offset was not added to the query. This is now fixed by checking for a comma separated string, which would therefore contain both an offset and the limit. In case both values are given, they are now properly added to the query. Resolves: #95922 Releases: master, 10.4 Change-Id: Id461b98a9818c3b55b34f93041a9c0950e68f634 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72096 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-