- 11 Jan, 2022 3 commits
-
-
The change for issue #94357 introduced handling for `event/` URLs, and accidentally modified handling for `video/` URLs as well. As a result, the `video/` IDs were incorrectly resolved containing a leading slash. Resolves: #96509 Releases: main, 11.5, 10.4 Change-Id: I5623ff59dac44a699877e4e5a2e91707f72a407e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72967 Reviewed-by:
Mathias Brodala <mbrodala@pagemachine.de> Reviewed-by:
Jigal van Hemert <jigal.van.hemert@typo3.org> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
Jigal van Hemert <jigal.van.hemert@typo3.org> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Oliver Hader <oliver.hader@typo3.org>
-
Scheduler backend module -> Add button -> add some valid information that makes the form save correctly -> "Save and new" from docheader save drop down -> boom. Resolves: #96506 Releases: main, 11.5 Change-Id: I8eacf1f5f958605f3505761a64902a71bcc0c7dd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72963 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Benni Mack authored
Since modern browsers already decode this "security" measure, the option config.spamProtectEmailAddresses = ascii is removed from TYPO3 Core. Existing installations having the option set to "ascii" will now behave as this option would be set to "0" (= disabled). Resolves: #90044 Releases: main Change-Id: I7fb4266e998ce7f2555f46e6c3ea216745ca54b6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72908 Tested-by:
Stefan Froemken <froemken@gmail.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Stefan Froemken <froemken@gmail.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 10 Jan, 2022 12 commits
-
-
When using a composer-based installation, public frontend assets such as JavaScript of stylesheet files are exposed in a dedicated `_assets/` folder. In those scenarios TypoScript settings for `config.absRefPrefix` need to be applied as well. Resolves: #96452 Releases: main, 11.5 Change-Id: I0695850be18c9c152c647883c122a0680e8e734f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72952 Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Helmut Hummel <typo3@helhum.io> Reviewed-by:
Simon Gilli <typo3@gilbertsoft.org> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Simon Gilli <typo3@gilbertsoft.org> Tested-by:
Oliver Hader <oliver.hader@typo3.org>
-
Andreas Fernandez authored
The maintainer of the `colors` package decided to rampage and released a bonkers version, see [1] and [2], causing an implosion of the npm eco system. Albeit TYPO3 uses this as a transitive dependency only, we're going to be safe and enforce this package to version 1.4.0, the current known to-be-stable version. [1] https://github.com/Marak/colors.js/issues/285 [2] https://www.bleepingcomputer.com/news/security/dev-corrupts-npm-libs-colors-and-faker-breaking-thousands-of-apps/ Resolves: #96499 Releases: main, 11.5, 10.4 Change-Id: Ic8ad9105c9a9bc45bb2519547bb044be672db27c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72949 Tested-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de>
-
Update to CKEditor v4.17.1 which addressed browser compatibility issues and known security vulnerabilities: https://ckeditor.com/cke4/release-notes Commands: rm -r typo3/sysext/rte_ckeditor/Resources/Public/JavaScript/Contrib cd Build yarn add 'ckeditor4@^4.17.1' yarn build Resolves: #96494 Releases: main, 11.5, 10.4 Change-Id: I87039f5a5d1fe7488f6d4c5d0c36e90421d4c93e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72938 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de>
-
Benni Mack authored
Some code in HMENU stems back from TYPO3 v3.x days, and this code aims to streamline the functionality given current functionality. HMENU now has its own sys_page object, which should be used. In addition, HMENU should fetch TSFE->id consistently across all its code base. Resolves: #96492 Releases: main, 11.5 Change-Id: I971a5958417077d51ea5c5070fc4b9ef513cd738 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72936 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Benjamin Franzke authored
This change is preparatory refactoring in order to support native JavaScript modules (ESM) where a module can't be used both as classic script-src and as ES6 module providing exports at the same time (this was/is possible for AMD as implemented in #95953): `export` is an invalid keyword in non-module scripts and cannot be specified conditionally, that is very different to AMD modules where `define()` can be called conditionally. JavaScriptHandler currently has three execution modes: * If used as script-scr: Call processItems from text content for: * RequireJS configuration * Generic JavaScriptItems processing * If used as AMD module: * Generic JavaScriptItems processing JavaScriptHandler is now separated into the following three concerns: JavaScriptItemProcessor ----------------------- The previous processor "mode" is now available as streamlined JavaScriptItemProcessor module, in order to drop type invariance (it requires parsed objects instead of allowing raw json data or objects) JavaScriptItemHandler --------------------- The previous JavaScriptHandler module that processes text content and calls arbitrary hooks has been simplified to the one usecase that was actually being used: Handling JavaScriptItems by parsing the text content. The extracted JavaScriptItemProcessor is used as backend for the actual work. RequireJSConfigHandler ---------------------- The RequireJS configurator is now available as separate module, as this logic is only needed once and not by other modules. There is no need to keep that functionality in JavaScriptItemProcessor, especially as it has been hidden from AMD modules, which complicated the JavaScriptHandler. This extraction also actually allows to make use of modules in JavaScriptHandler and therefore enables the possibility to share code using JavaScriptItemProcessor. Also the code has been migrated to TypeScript. JavaScriptItemHandler and RequireJSConfigHandler do not export or import code, therefore they are usable as plain targets for script-tags. In addition the JavaScriptItemHandler is now executed asynchronously, which allows the browser to parse DOM in parallel. (synchronous mode is required for RequireJS config, but not for loading of requirejs-modules/instructions, they are asynchronous anyway). FileClipboardCest is adapted to wait more than 1 second, since the rerendering of the clipboard (a new iframe request is made) takes longer than 1 second in some test runs (not locally, but on CI) (note: the default 1 second wait timeout is configured in typo3/sysext/core/Tests/Acceptance/Application.suite.yml, but that's too less in this case). Releases: main Resolves: #96476 Related: #95953 Related: #96323 Change-Id: I48a5751cea03537344e925beba365841e0855dde Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72892 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benjamin Franzke <bfr@qbus.de>
-
This restores the sort link for columns with "special" label, such as "tstamp" or "crdate". Resolves: #96489 Releases: main, 11.5 Change-Id: Iae7c9d2056256df5156f6fe8773d6b18e7ba8898 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72947 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com>
-
Resolves: #96490 Releases: main Change-Id: I43218e8f99f062fc43f14e1b26d7b68d8ca5414d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72937 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Update to @claviska/jquery-minicolors v2.3.6 which addressed known security vulnerabilities: https://security.snyk.io/vuln/SNYK-JS-CLAVISKAJQUERYMINICOLORS-1930824 https://github.com/claviska/jquery-minicolors/releases/tag/2.3.6 Commands: cd Build yarn add '@claviska/jquery-minicolors@^2.3.6' yarn build Resolves: #96495 Releases: main, 11.5, 10.4 Change-Id: Iaafdd29dd50a18321746fb36702702302078fceb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72940 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benjamin Franzke <bfr@qbus.de>
-
Oliver Bartsch authored
The linkvalidator module shows the path to the page, a broken link is on. Since editors might only have access to a subtree (mount point), the corresponding parent pages should not be displayed. This is now fixed by providing the necessary permission clause to `getRecordPath` in LinkValidatorController. Resolves: #92539 Releases: main, 11.5 Change-Id: Ibdb54560561dba5d7ad932d89ff5b73fc558f5f2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72905 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Oliver Bartsch authored
Resolves: #96481 Releases: main, 11.5 Change-Id: I41eeb4ecf0b90e998875701131b2c8a35bfa3225 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72906 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Benni Mack authored
This change uses typolink in EmailViewHelper, allowing to also use typolink hooks or custom Email Link Builder to be used consistently across TYPO3 Core (e.g. using the same hooks for all email link generation in the Frontend). Resolves: #96483 Releases: main, 11.5 Change-Id: Ia573dc5a7ebb9ca7f0f0b6b35126bd789f86a627 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72897 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Benni Mack authored
During the main work of TYPO3 v9 when Site Handling was introduced, the Page Link Builder turned into a single monster-method. Now, that most bugs are solved and we have a very good test coverage for this, this change splits several functionality into smaller methods, allowing for better readability, extensibility and further refactoring. Extending PageLinkBuilder now is much easier to replace a certain part of the existing functionality (also via XCLASS). Resolves: #96484 Releases: main, 11.5 Change-Id: I231cf3c13ec15dd1ad99f710ca27ce340c0deee2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72898 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 08 Jan, 2022 2 commits
-
-
Releases: main, 11.5 Resolves: #96488 Change-Id: I0ced03e4d551048414022214b832b3ceeb51400d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72933 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
The type can already be inferred from the source code. The cleanup was run automatically with a PHPStorm plugin. Resolves: #96482 Releases: main Change-Id: I669145adc66dc898f3016de1958cf0105c988243 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72907 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
- 07 Jan, 2022 6 commits
-
-
The scenario provided by tables tx_irretutorial_mnasym_* gets its own test extension and gets loaded where needed. Resolves: #96458 Releases: main, 11.5 Change-Id: I905bc6b7e33c54e343828f9569624fdd60042c2d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72899 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
In order to be able to influence the query of the LiveSearch, a new PSR-14 event ModifyQueryForLiveSearchEvent is added. This event can be used to e.g. adjust the query limit or to change the result order. Resolves: #93494 Releases: main Change-Id: I5990855d14e9de72adcba1449fb3f5336c004750 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68528 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Benjamin Franzke authored
User supplied strings must not be concatenated into the format parameter of sprintf() as sequences like %s, or (more likely) %20S (which is ' S' url escaped) may be contained and cause warnings because sprintf() expects additional arguments in that case. Streamline to always use the static '%s: "%s"' format instead. Releases: main, 11.5, 10.4 Resolves: #96478 Change-Id: Ic3b09c6e1e7c617e78ea405289680bd78d0aab64 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72900 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benjamin Franzke <bfr@qbus.de>
-
Oliver Bartsch authored
Resolves: #96479 Releases: main, 11.5 Change-Id: I8f054a9dd38e8b25ac606c002f95cb673e4e280c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72902 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
This patch adds a check to detect self referencing redirects, thus avoiding them and instead log an error in the corresponding frontend redirect middleware. Furthermore, add a bunch of tests along the way to cover this change and the different constellations, for example not avoiding redirect with the same path but external host. Resolves: #96427 Releases: main, 11.5, 10.4 Change-Id: I554ba51b53065dd754068e379f69c2a5dffc3054 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72856 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Sorting query results by text columns may require a filesort on harddisk which is slow. To boost up the search results of LiveSearch we have added an ORDER BY uid DESC to always show the newest created records first. Column "uid" exists in all TCA tables and as it is PRIMARY INDEX sorting will happen in memory. Resolves: #96365 Releases: main, 11.5 Change-Id: Icbf6e8c7717a495aaee995ff09cf2cd882173e65 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72669 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
- 06 Jan, 2022 10 commits
-
-
Benni Mack authored
In #87992 an early return was added to have <a> tags with just an "id" or "name" attribute. This is all nice, but when used further typolink settings (such as userFunc or custom "title"), these options were never run. This change now uses typolink() natively again and removes the introduced "resolveAnchorLinK" workaround. Added tests show that additional attributes are executed and links without href are actually created (was previously untested). Resolves: #96464 Related: #87992 Releases: main, 11.5 Change-Id: I67d4090228684fc89f72bc3d6367109437040ccf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72894 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Benni Mack <benni@typo3.org>
-
This change mainly adds tests for showing that the global TypoScript option config.ATagParams = tabindex="20" can be used and any given attributes are actually overridden if using typolink.ATagParams = tabindex="13". Resolves: #71703 Releases: main, 11.5 Change-Id: I984d66ecf7c303381e64e447a0cac731f055a567 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72896 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Benni Mack authored
When having a page of type "External URL", set to an email address, and config.spamProtectEmailAddresses = ascii set in TypoScript, the encoding now works properly. Resolves: #87787 Releases: main, 11.5 Change-Id: I15563f08a8a0007dc292f5d7e1a311e38a55db26 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72893 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Broken links are marked in RTE by using the attribute data-rte-error in the <a> tag, which results in a special style and lets the link be visible as broken. Previously this was not done for links to hidden pages and links to content elements. These links were however detected as broken by linkvalidator and displayed in the list of broken links. Marking them in RTE as well makes the behaviour consistent. This patch ensures the consistency between the list and the visual highlighting in RTE elements for links to hidden pages and hidden content elements. Highlighting links to hidden pages/content elements on hidden pages may be visually relaxed to a notice instead of an error in a dedicated patch as feature. One PHP8.0 array key warning is fixed along the way. Resolves: #93005 Releases: main, 11.5 Change-Id: Ib1ef4b81ab862657950a38e5ee6847dd82abb13f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67039 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Benni Mack authored
TYPO3's "makelinks" functionality parses for in-text external URLs and mailto links. This change uses Typolink under the hood now to consistently check for invalid content, and have the chance to use all hooks in typolink for such links as well. This way, typolink is used, but makelinks is executed AFTER possible resolved <a> tags avoiding double-calling parseFunc when <a> tag processing is configured. Resolves: #93012 Releases: main, 11.5 Change-Id: I574915e715793f6eccad1bdfc216e82e329179dd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72871 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Benni Mack authored
This change now always checks for the actual page ID in the default language, not of the translated page to see if the page should be excluded. Resolves: #94427 Releases: main, 11.5 Change-Id: I89c67b7955ccb69af28accbcf573576156919481 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72802 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Benni Mack <benni@typo3.org>
-
The HtmlViewHelper is extended for a couple of new arguments, used to influence the initialization of the content object. Following arguments are added: - "data" (array or object) - "current" - "currentValueKey" - "table" This allows to properly work with dynamic data in a custom parseFunc. With the provided data record ("data" argument), the individual entries can now be accessed using TS:field. With the "current" argument, TS:current can be filled individually and with the "currentValueKey" argument, a specific value from the data record can be set as new TS:current. The "table" argument is added for completeness, so that the ContentObjectRenderer can be initialized correctly. Resolves: #92749 Releases: main Change-Id: Ibecdb7530a33462dd5464524ac7aff31abb7432b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72803 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Christian Kuhn authored
This changes StandaloneView and RenderingContext to accept instances of ServerRequestInterface or no Request at all - in contrast to extbase Request only. This is possible with extbase Request implementing ServerRequestInterface since v11. The patch changes a couple of ViewHelpers like the often used TranslateViewHelper: It can run without triggering extbase magic, which especially avoids the performance wise awful ConfigurationManager. Further patches will refactor backend views to leverage this. Internal method RenderingContext->getUriBuilder() is obsoleted and removed along the way. This is a powerful change since it drops the last hard dependency to extbase in fluid and allows views without extbase being involved at all. Change-Id: I3b447b6f70e9ae6f94b981478cd8c4f43a86e9d4 Resolves: #96473 Related: #94428 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72758 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
The scenario provided by tables tx_irretutorial_mnattr_* gets its own test extension and gets loaded where needed. Resolves: #96459 Releases: main, 11.5 Change-Id: I48b08772f8c4d64f8a3ea930fc307a8d5d3f2189 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72870 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Merging #22190 shortly after #96470 has introduced a invalid test case expectation, which fails now core ci execution. This patch adds a missing 'target' expectation for the test added through #22190 to match introduced expectation with #96470. Resolves: #96472 Related: #22190 Related: #96470 Releases: main, 11.5 Change-Id: Ia92c71302a8d875b2b8f5c23aac97bfa7e3bfadc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72869 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
- 05 Jan, 2022 7 commits
-
-
This change adds tests to a very old issue to ensure that a page with only hidden subpages is not marked as IFSUB etc. MenuProcessor is extended to set a "hasSubpages" flag when IFSUB, CURIFSUB or ACTIFSUB is set. Resolves: #22190 Releases: main, 11.5 Change-Id: Ia9b73e8ae1028eafa94ba4fa5ca0dacf2562c074 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72868 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Benni Mack authored
The database field "pages.target" allows to define a custom target attribute for links in menus of external URLs. Before this was (wrongly) built in HMENU but applied after Typolink worked. This option belongs to the actual link building when building links to external URLs where $conf[extTarget] is evaluated. In addition, HMENU tests now also evaluate "target" for regular pages as well. Resolves: #96470 Releases: main, 11.5 Change-Id: I3919b6b13666565687e8ff56dcfc867c871837e2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72866 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Benni Mack authored
The linkvalidator backend module was previously built into the Web->Info module. Now, Linkvalidator receives its own module in the "Web" area. This allows to define access permissions for editors via the module access logic, and shapes the functionality in a cleaner way. The Linkvalidator module not only reports but also allows to validate. Through this change, the module is now accessible via a dedicated speaking backend URL. This change makes the feature much more prominent and allows for further refinements such as pagination. Resolves: #96465 Releases: main Change-Id: I83a4ed3f31cfbe59d61778b0d527f5f4704a404a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72701 Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Benni Mack <benni@typo3.org>
-
Oliver Bartsch authored
With the introduction of the multi record selection, the workspace actions, shown above and below the records, got prepended with labels. While the mass action targets the entire workspace, the label just read "all", which is misleading because one could think the action only targets all records of the current view and then accidentally publish or even worse, discard the entire workspace. This is fixed by changing the label. Resolves: #96468 Releases: main, 11.5 Change-Id: Id2205e843656af7576f7038dddc81ae53308a185 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72863 Tested-by:
Claus-Peter Eberwein <claus-peter.eberwein@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Claus-Peter Eberwein <claus-peter.eberwein@b13.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
With #96393 forward-compatible prepared statement suport has been added, which lacks support for the broadly known doctrine/dbal 'PARAM_STR_ARRAY' and 'PARAM_INT_ARRAY' types. Internal methods as alternatives were introduced as core internal methods with #92493 in the internal 'QueryHelper' class. This patch now moves these internal implementations to the 'QueryBuilder' to provide an forward-compatible public alternative, which is needed to prepare statements with 'in()' or 'notIn()' expression with array values, which can only be used as non-placeholder, which is not supported by PHP PDO implementation. Further usage of internal implementation which was introduced with #92493 are replaced with new public methods and internal methods in QueryHelper removed. Resolves: #96434 Related: #96393 Related: #92493 Releases: main, 11.5 Change-Id: I1f7f532eb82a248a28d8d7ec707d678d59a73ec0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72804 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
We removed the SQL query on pages (column: pid) for TYPO3 administrators, because this group of people has access to all pages anyway. Especially in large TYPO3 instances the collection of all pages UIDs took a lot of time. Resolves: #96356 Releases: main, 11.5 Change-Id: I436e15e79ce590c4228b9a9034f83497fa1db92e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72661 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Once a user simulated a time with the admin panel, it has not been easy to see the status of the field or to understand how to disable it. To make it easier for the user to handle a separate checkbox has been added that allows enabling or disabling the simulate time feature. Resolves: #94596 Releases: main, 11.5 Change-Id: I309475f19f64dd8324f2466082d979d0afdbd501 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72826 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Sybille Peters <sypets@gmx.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-