- 20 Jul, 2019 2 commits
-
-
Context is stateful as Aspects dependent on the (currently dispatched) request type (frontend/backend/installtool/CLI). Reqest-dependent arguments can not be injected during service creation; therefore the Context class is now created without default aspects and enhanced by the application classes (on demand). Note: The UserAspect constructor is adapted to use an explicit stdClass allocation instead of an immutable array casted to an object for the (fallback) pseudo user. This is to avoid php segmentation faults in functional tests (and also random unit test runs). The segmentation faults would be triggered due to the constructor change in the Context class, which now uses ondemand instead of preemptive Aspect creation. Background: immutable arrays are stored on stack. The cast to an object probably didn't relocate this memory to the heap which then causes segmentations faults when the static memory area (on stack) is exceeded. Releases: master Resolves: #88793 Change-Id: Ib165f85b66b34e8025e28ef483260463f1e2c826 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61274 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Susanne Moog <look@susi.dev> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
https://review.typo3.org/c/Packages/TYPO3.CMS/+/60834 changed the method getSwitchableControllerActions to be called getControllerConfiguration. It was forgotten to update one mock in AbstractConfigurationManagerTest which caused the test to be skipped with a warning. Resolves: #88808 Related: #88496 Releases: master Change-Id: I7624a274db13e16fc2002468b1eee0459713de93 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61330 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
- 19 Jul, 2019 7 commits
-
-
TYPO3's Logging Framework (especially LogLevel and LogManager) are not PSR-3 compatible, as it uses integers as constants and not strings, as defined in PSR-3's interfaces. This makes TYPO3 incompatible to use custom loggers, or to interop with other logging systems. The patch changes the logging API to depend on PSR-3 interfaces but strives for maximum compatibility. Resolves: #88799 Releases: master Change-Id: Ib41840cc87035c2323087877bac07e62c439482e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61156 Tested-by:
Frank Naegler <frank.naegler@typo3.org> Tested-by:
-
A TypoScriptAspect has been introduced to handle Context depending TypoScript settings. As a first step, the property `forceTemplateParsing` has been moved to this aspect and deprecated in both TSFE and TemplateService. Additionally, this is another step to resolve the interdependance between AdminPanel and TSFE. Resolves: #88792 Releases: master Change-Id: I77e7548a51534e96ad0656810163267e6c373d3c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61312 Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
This patch enables the labels for the export buttons which are hard to distinguish in case both appear side by side. Resolves: #88804 Releases: master, 9.5 Change-Id: Ie9a72823fcc1788ca10ae93f267c408a8da90212 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61326 Tested-by:
Benjamin Kott <benjamin.kott@outlook.com> Tested-by: Daniel Windloff Tested-by:
-
This patch adds a type cast to fix broken export of tables. Resolves: #88803 Releated: #88662 Releases: master Change-Id: I9fe725ddadf2a9d63d3c8af8005a453a68dc46cc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61325 Tested-by: Daniel Windloff Tested-by:
-
The php-cs-fixer rules have been adjusted by the following settings: - no_empty_phpdoc: Remove empty phpdoc blocks without any information - no_null_property_initialization: Remove initial null value from class properties - modernize_types_casting: Replace old-school `*val()` function calls with proper type casts Resolves: #88802 Releases: master Change-Id: Id2cfa849553d918e0461bafd09b3960bdf5ff700 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61324 Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
-
Some properties and methods are not used any more. They can be removed. Resolves: #88779 Releases: master Change-Id: I2f3d41803360eee692e9e6ce4b8b1a0cd76f559d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61306 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Riny van Tiggelen <info@online-gamer.nl> Reviewed-by:
-
The public internal property of TSFE "fePreview" has been deprecated in favor of a dedicated aspect handling the frontend preview flag. As a first step, the frontend preview aspect only contains a boolean flag holding the current preview state - but it might be extended with additional information on the preview mode at a later point. This is also a first step to remove the TSFE dependencies from the AdminPanel initialisation process. Resolves: #88791 Releases: master Change-Id: I2994d69d824b1b107a3a878b87c9dd2f7daf3ed2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61311 Tested-by:
-
- 18 Jul, 2019 2 commits
-
-
Benni Mack authored
Due to e50b1c1a the TypoScriptFrontendController requires four objects as constructor arguments while keeping maximum compatibility by fetching fallback information from the current PSR-7 object or setting data from the legacy arguments. The constructor is cleaned up with special initialize methods for readability. Resolves: #88747 Related: #88717 Releases: master Change-Id: I734d1184780b8bfdf0e9638aca75c6a4fc0f7e2c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61289 Tested-by:
-
A new IpLocker class replaces the lock functionality in AbstractUserAuthentication. The new class is capable of locking to IPv4 and IPv6 addresses. Resolves: #21638 Releases: master Change-Id: I0075a9e49690e31c938abf7242c1f088c73bb37d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/52947 Reviewed-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
- 17 Jul, 2019 7 commits
-
-
Also, some improvements are made to sentence structure, tenses and syntax highlightning. Resolves: #88748 Releases: master, 9.5 Change-Id: I932dabbfc404de7c3dc4f3cef1ccb50c2fd94f72 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61291 Tested-by:
Koen Wouters <koen.wouters@maxserv.com> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
-
When Page-based slug handling + routing was introduced, the initial PageRouter class turned big very quickly. Especially managing the possible pages that could match was initially based on the candidates principle that could be moved / exchanged later-on. For this to happen the initial step is to move this to a separate PHP class called "PageSlugCandidateProvider". As seen in the patch, all calls to the database related to retrieving pages (DB + PageRepository) are moved into PageSlugCandidateProvider. Resolves: #88575 Releases: master Change-Id: I14b3ebccf439613cc9aa7943d1a44d0892cf04e5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61050 Tested-by:
-
codeblock -> code-block Resolves: #88790 Releases: master, 9.5 Change-Id: I51f30b30ef7344e1b66bd5ed354d3bfe60074a57 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61309 Tested-by:
-
During the creation of Extbase itself, the configuration of controllers and their available/callable actions has been called switchable controller actions. This terminology has later also been used to configure an alternative controller configuration defined via typoscript or flexforms. As of today the term "switchable controller actions" is only used for the latter. The core, however, still uses this terminology for both the default controller configuration and the overrides. To clarify the terminology, the default configuration has been renamed to just "controller configuration". Releases: master Resolves: #88496 Change-Id: I718e2fe03d3560a57b17fc584479aff559d105e8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60834 Tested-by:
-
- Use strict type mode - Use type hints whereever possible Releases: master Resolves: #87629 Change-Id: I40d79cb6178886a6fc46edaf6c75fa900bf4ffc9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59625 Tested-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
-
TYPO3 prevents files from being deleted by the user when there are references to it in the sys_file_reference table. However if the file is referenced without using this table, the file is still deleted without any warnings. An example is a link to the file in a bodytext of a text content element. Thus it is possible to accidentally delete a file, which is referenced on the site in multiple places and create broken links. This change makes sure that such direct references (without using sys_file_reference) also prevent the file from being deleted. Resolves: #88462 Resolves: #77866 Releases: master, 9.5, 8.7 Change-Id: Ib8c45863d75ae430c801173658cf058f850ca982 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60846 Tested-by:
Steffen Frese <steffenf14@gmail.com> Reviewed-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
Julian Geils <j_geils@web.de> Reviewed-by:
-
Since Context API was introduced in TYPO3 v9, PageRepository is highly decoupled from $TSFE->sys_page, and fully works standalone. It is also used in various places where TSFE is not needed, or required, but also in places of EXT:core. Especially parts like RootlineUtility, which depends on PageRepository very much, cannot live without it. I propose to move this highly important PHP class into EXT:core, in order to allow to decouple EXT:frontend even further from EXT:core. The FQCN is moved from - \TYPO3\CMS\Frontend\Page\PageRepository to - TYPO3\CMS\Core\Domain\Repository\PageRepository It can be assumed to use PageRepository for any use-case and actually reduce usages towards BackendUtility::get... by using this API more and more. Further adaptions could be to reduce the logic within PageRepository and move this into QueryBuilder and assimilate especially the "versionOL" behavior. Resolves: #88746 Releases: master Change-Id: Id8225100ac60bd77fc7e1303efb4c46b741d3415 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61166 Tested-by:
-
- 16 Jul, 2019 5 commits
-
-
To prevent the truncation of new values via TCEForm, the field length is increased to 255. Resolves: #88722 Releases: master, 9.5 Change-Id: I982c20302be216c1819da9efc468f8a7b2be0add Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61283 Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Reviewed-by:
Björn Jacob <bjoern.jacob@tritum.de> Reviewed-by:
-
HTML5 defines that <script tags do not need "type=text/javascript" as additional attribute. TYPO3 Backend is fully HTML5, so all parts can be removed there. For Frontend, when having config.doctype = html5 (or empty), then the attributes do not get added anymore as well. If necessary, for Frontend rendering the attribute can be added in HTML5 by specifying includeJS.myfile.type = text/javascript in TypoScript. As this modifies Frontend output, it is considered breaking. Also see W3C specification: https://www.w3.org/TR/html52/semantics-scripting.html#element-attrdef-script-type Resolves: #88772 Releases: master Change-Id: I26ca4361e84cae680eedbf6855e209a6311c33da Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61300 Reviewed-by:
-
The new PSR-14 standard for dispatching Events (that is: to extend a Framework without having to modify a frameworks' code) adds a EventDispatcher object that can dispatch Event objects to EventListeners. In PSR-14 every dispatched event is an object. It uses PHP class names as identifiers for events. Class hierarchies may be used to group events. A ListenerProvider object collects available listeners from an extension and allows to listen and/or modify data provided by the Event object. The current implementation relies on a custom TYPO3-specific ListenerProvider that is configured using Symfony's Dependency Injection tags. As an example the Mailer-postProcInitialization signal/slot is replaced by an Event. This first patch introduces the feature, and does not deprecate anything yet. The most important part is that new Events can use this API instead of Hooks in TYPO3 v10. Short-Term goal is to deprecate SignalSlot dispatcher in TYPO3 v10, and migrate all signals to the EventDispatcher. Resolves: #88770 Releases: master Change-Id: I3649ddb9b9340640199279e6af3c040bffc397fe Signed-off-by:
-
Collapse single tables in multi table view of the DatabaseRecordList is invoked via javascript and its state is saved via AJAX. Remove the leftover code, which allows to set the collapse state via _GP('collapse'). Resolves: #88753 Releases: master Change-Id: Ibd02364c54563b76caf6e4f36ae9c8853b1d99c6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61294 Tested-by: -
ResourceCompressor allows to only concatenate files given in a given "baseDirectory" as separate option, which was used to only include files that are registered via TBE_STYLES for backend purposes. The functionality is removed to always concatenate all CSS files in TYPO3 Backend. A heavy dependency to DocumentTemplate of ALL backend functionality using PageRenderer is therefore removed. Resolves: #88758 Releases: master Change-Id: I07e2f15a3dd2298371db87ce2723ded0f6a56f31 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61296 Tested-by:
-
- 15 Jul, 2019 4 commits
-
-
Fix the translation key typo as suggested to show the correct error message if the password does not match the confirmation Resolves: #88691 Releases: master, 9.5 Change-Id: I8524bf7faee507782d79633d3b5afd9a0077ad6c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61292 Tested-by:
-
Resolves: #88765 Releases: master Change-Id: I26ca496a954b44f8cb08d770ecd544d35583ee6c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61299 Tested-by:
Alexander Schnitzler <review.typo3.org@alexanderschnitzler.de> Tested-by:
-
The following database fields from "tt_content" have been removed: * tt_content.spaceBefore (now used via space_before_class) * tt_content.spaceAfter (now used via space_after_class) Resolves: #88744 Releases: master Change-Id: I2da1645b94b68fadb2945c2f1708809e2e9cbab4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61286 Tested-by:
-
The backend users module (ext:beuser) persists previously defined filter combinations in be_users.uc fields of the according user. When a "user group" is defined in the filter, Extbase architecture internals get serialized and persisted as well which has performance impacts and most probably will exceed storage (16M) of be_users.uc field. It is enough to store the uid of the according be_groups entity. Resolves: #86361 Releases: master, 9.5, 8.7 Change-Id: I61ba4993d9594b1074546255e7d5c2d5506819fb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61117 Tested-by:
-
- 14 Jul, 2019 3 commits
-
-
Andreas Fernandez authored
With #87324 some code of FormEngine was moved into separated modules. In the very same patch, most of the code was rewritten to use native JavaScript as much as possible. However, with this change, `TBE_EDITOR.fieldChanged()` was partially broken as it uses jQuery's `triggerHandler` method to trigger a specific event. Events that are registered via jQuery's `on()` method work fine, but the approach is incompatible with JavaScript's native `addEventListener()` introduced in the mentioned change. As a quick fix, `TBE_EDITOR.fieldChanged()` now triggers the same event for native JavaScript code via `dispatchEvent()`. Resolves: #88738 Related: #87324 Releases: master Change-Id: I38fbb97f86f6765a45ad763c27e7afdac5754b1c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61278 Tested-by:
-
The property "vanillaParentPageTca " inside FormEngine is never used - also documented that it was never used before. The property is therefore removed. Resolves: #88669 Releases: master Change-Id: I71166ea44764d8bdc4b0c309a43f45f46309780f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61207 Tested-by:
-
If a table is defined as readonly, the controls should not be visible in the record list. The DataHandler respects already the setting but the UI did miss it. Resolves: #88708 Releases: master,9.5 Change-Id: I22db9f613b9c63e3b0e3fcffba9989089c0e7bc2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61243 Tested-by:
Guido Schmechel <guido.schmechel@brandung.de> Reviewed-by:
-
- 13 Jul, 2019 9 commits
-
-
In DocumentTemplate there is always one header call to define that everything is HTML and UTF-8. Since we do PSR-7 in Backend Context, this should be handled by the Response object, which we already do. This should normally be a bugfix for existing stable versions, although I'm very unsure on how this could affect any side-effects where extensions rely on this behavior for years (!) already, so this is master-only. OTOH this change should not affect anything in regular BE modules as they work with PSR-7 since TYPO3 v7 already. Resolves: #88743 Releases: master Change-Id: I20fb4844ca661c47eb1d56b6d20a8f2c58b17796 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61285 Tested-by:
-
Correction of the example regarding the user ID. Resolves: #88723 Releases: master, 9.5 Change-Id: I1823377c72997ec20bc36b3689e46fe16ded9127 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61282 Tested-by:
-
Adjusted tenses, unified sentence structure, adjusted code highlightning. Resolves: #88745 Releases: master, 9.5 Change-Id: I8accf6340be6c683220be950efb60c602344e05a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61287 Tested-by:
-
Transform InfoModuleController and it's dependency ModuleTemplate into a symfony manageed services to retrieve dependencies from symfony instead of GeneralUtility::makeInstance. ModuleTemplate is a prototype and is therefore marked shared: false. It is marked public: true so legacy calls to GeneralUtility::makeInstance(ModuleTemplate::class) resort to the container and properly inject dependencies. Also add a backend.controller symfony tag, to be universally applied for backend controllers. This tag automatically configures the controller to be publicly available from $container->get() which allows the route dispatcher to lazily instantiate the controller. Releases: master Resolves: #88721 Change-Id: I076c306736243e693542f2774dbe1108e28fe731 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61246 Tested-by:
-
The ImportExportController is responsible for exporting and importing data, which is a bit too much. In order to streamline the import/export functionality, the controller has been split into two controllers. Due to this, the route to the ImportExportController has no effect anymore, but is kept for bc reasons. Resolves: #88662 Releases: master Change-Id: If2beb9da8d65b6a054b616832712017df2a9c6b2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61202 Tested-by:
-
The usage has been deprecated in TYPO3 v9. Related: #87354 Resolves: #88733 Releases: master Change-Id: I4594adb2ba0885c4a2094c0a6108902165e26138 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61275 Tested-by:
-
In TYPO3\CMS\Frontend\Hooks\FrontendHooks->displayPreviewInfoMessage() is now checked, that the config.disablePreviewNotification is set. Resolves: #88653 Releases: master, 9.5 Change-Id: I0fc81b3aa40f46189cbb90854a401c806e5b25a2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61171 Tested-by:
-
This patch re-arranges the TYPO3 Core internally used middlewares for lifting off the weight of $GLOBALS['TSFE'] as Site Handling already introduced a lot of functionality which can now be utilized further. For this reason, the Frontend Rendering chain has been adapted. * If there is a "Site" + "Language" resolved, this information can be used directly, as there are no dependencies currently. * Frontend + Backend User Authentication works regardless of TSFE, Frontend User is added to the Request object as attribute to be added to TSFE later-on. * Resolving the Page ("slug") and mapping them to Page Arguments (URL parts + GET parameters) as well as validation against cHash is fully decoupled from TSFE. After that, TSFE is instantiated, which now gets all resolved objects injected. TSFE now only resolves the rootline against the proper permissions (auth) and validates the final page. Once done, TypoScript is compiled / cached. TSFE still contains the rootline, TypoScript, and the information about which non-cacheables are there. RequestHandler creates or fetches cached content, but currently piped through TSFE. This should be simplified further later-on. Resolves: #88717 Releases: master Change-Id: I12807455fd8b01493b2da45cf73a5c532b108cbe Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61155 Tested-by: -
cHash is now added automatically when a URL is generated. The relevant query parameters when indexing are stored in "static_page_arguments", which allows to remove the database field "cHashParams". Therefor it is not necessary anymore to configure if cHash should be taken into account when creating a configuration for indexed search. Instead, when linking to a page on a search result, the page arguments are added. In addition, when pages are indexed, only the static page arguments are evaluated. Debug Information when indexing is also adding data more sensibly via json_encode/decode. Effectively, this means that specific handling for cHash resolving is fully removed from EXT:indexed_search. Related: #87193 Resolves: #88741 Releases: master Change-Id: I84738612d42615a3ac24d271c5509b52467d81af Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61284 Tested-by:
-
- 12 Jul, 2019 1 commit
-
-
The method "localizationRedirect" in PageLayoutView, DatabaseRecordList and EditDocumentController were almost equal. The usage has been streamlined and the methods in PageLayoutView and DatabaseRecordList has been removed. Resolves: #88724 Releases: master Change-Id: I9c458e16d10c61c54e81bee61fc64aad675ac130 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61249 Tested-by:
-
