Commit fd5712c9 authored by Torben Hansen's avatar Torben Hansen Committed by Benni Mack
Browse files

[TASK] Define function argument types in ext:felogin

Argument types for 2 functions can safely be set
to `string`, since current implementations already
ensure, that only a string is passed as argument.

Resolves: #97799
Releases: main
Change-Id: Ia1f81b63f53c3087b4d03979a8fc17e0f7c8f6dd
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74968

Tested-by: core-ci's avatarcore-ci <typo3@b13.com>
Tested-by: Simon Schaufelberger's avatarSimon Schaufelberger <simonschaufi+typo3@gmail.com>
Tested-by: Benni Mack's avatarBenni Mack <benni@typo3.org>
Reviewed-by: Simon Schaufelberger's avatarSimon Schaufelberger <simonschaufi+typo3@gmail.com>
Reviewed-by: Benni Mack's avatarBenni Mack <benni@typo3.org>
parent 5d4e86cd
......@@ -272,14 +272,10 @@ class PasswordRecoveryController extends AbstractLoginFormController
/**
* Validates that $hash is in the expected format (timestamp|forgot_hash)
*
* @param string $hash
*
* @return bool
*/
protected function hasValidHash($hash): bool
protected function hasValidHash(string $hash): bool
{
return !empty($hash) && is_string($hash) && strpos($hash, '|') === 10;
return !empty($hash) && strpos($hash, '|') === 10;
}
/**
......
......@@ -136,7 +136,7 @@ class RedirectHandler
* @param string $redirectFirstMethod
* @return string
*/
protected function fetchReturnUrlFromList(array $redirectUrlList, $redirectFirstMethod): string
protected function fetchReturnUrlFromList(array $redirectUrlList, string $redirectFirstMethod): string
{
if (count($redirectUrlList) === 0) {
return '';
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment