[TASK] Define function argument types in ext:felogin

Argument types for 2 functions can safely be set
to `string`, since current implementations already
ensure, that only a string is passed as argument.

Resolves: #97799
Releases: main
Change-Id: Ia1f81b63f53c3087b4d03979a8fc17e0f7c8f6dd
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74968

Tested-by: core-ci <typo3@b13.com>
Tested-by: Simon Schaufelberger <simonschaufi+typo3@gmail.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Simon Schaufelberger <simonschaufi+typo3@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>

typo3/sysext/felogin/Classes/Controller/PasswordRecoveryController.php

@@ -272,14 +272,10 @@ class PasswordRecoveryController extends AbstractLoginFormController
 
     /**
      * Validates that $hash is in the expected format (timestamp|forgot_hash)
-     *
-     * @param string $hash
-     *
-     * @return bool
      */
-    protected function hasValidHash($hash): bool
+    protected function hasValidHash(string $hash): bool
     {
-        return !empty($hash) && is_string($hash) && strpos($hash, '|') === 10;
+        return !empty($hash) && strpos($hash, '|') === 10;
     }
 
     /**

typo3/sysext/felogin/Classes/Redirect/RedirectHandler.php

@@ -136,7 +136,7 @@ class RedirectHandler
      * @param string $redirectFirstMethod
      * @return string
      */
-    protected function fetchReturnUrlFromList(array $redirectUrlList, $redirectFirstMethod): string
+    protected function fetchReturnUrlFromList(array $redirectUrlList, string $redirectFirstMethod): string
     {
         if (count($redirectUrlList) === 0) {
             return '';