Commit d6ed6058 authored by Christian Kuhn's avatar Christian Kuhn
Browse files

[TASK] gitlab-ci: Activate check permissions script

Since moving to gitlab, script checkFilePermissions.sh
was inactive due to a gitlab detail that leads to
funny permissions of cloned files.

This can be suppressed with a gitlab feature toggle.

The patch activates that toggle, activates the test
script and fixes a couple of files that slipped in
with broken permissions meanwhile.

Change-Id: I2b0fdca282dbc39fe230b33910a690118a21b74e
Resolves: #95194
Releases: master, 10.4, 9.5
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71035


Tested-by: core-ci's avatarcore-ci <typo3@b13.com>
Tested-by: Christian Kuhn's avatarChristian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Christian Kuhn's avatarChristian Kuhn <lolli@schwarzbu.ch>
parent d0557514
......@@ -4,6 +4,12 @@ default:
# Any job taking longer than this is considered 'failed'
timeout: 30m
variables:
# Remove the usage of umask 0000 call for jobs executed with docker executor.
# gitlab repo clones otherwise lead to funny file permissions,
# which especially confuses runTests.sh -s checkPermissions
FF_DISABLE_UMASK_FOR_DOCKER_EXECUTOR: 1
cache:
# Default caching of .cache directory if a job does not override it.
# General rule: Keep them as small as possibles since that is less unpack work.
......
......@@ -40,10 +40,7 @@ integration various php 7.2:
- Build/Scripts/runTests.sh -s composerInstall -p 7.2
- Build/Scripts/runTests.sh -s checkExceptionCodes -p 7.2
- Build/Scripts/runTests.sh -s checkGitSubmodule -p 7.2
# broken on gitlab for now
# @todo: try to set up gitlab with FF_DISABLE_UMASK_FOR_DOCKER_EXECUTOR and have a non-root user setup for containers
# @todo: or relax the test script a bit
# - Build/Scripts/runTests.sh -s checkPermissions -p 7.2
- Build/Scripts/runTests.sh -s checkPermissions -p 7.2
- Build/Scripts/runTests.sh -s checkXlf -p 7.2
- Build/Scripts/runTests.sh -s checkRst -p 7.2
- Build/Scripts/runTests.sh -s checkFilePathLength -p 7.2
......
......@@ -31,10 +31,7 @@ integration various php 7.2 pre-merge:
- Build/Scripts/runTests.sh -s composerInstall -p 7.2
- Build/Scripts/runTests.sh -s checkExceptionCodes -p 7.2
- Build/Scripts/runTests.sh -s checkGitSubmodule -p 7.2
# broken on gitlab for now
# @todo: try to set up gitlab with FF_DISABLE_UMASK_FOR_DOCKER_EXECUTOR and have a non-root user setup for containers
# @todo: or relax the test script a bit
# - Build/Scripts/runTests.sh -s checkPermissions -p 7.2
- Build/Scripts/runTests.sh -s checkPermissions -p 7.2
- Build/Scripts/runTests.sh -s checkXlf -p 7.2
- Build/Scripts/runTests.sh -s checkRst -p 7.2
- Build/Scripts/runTests.sh -s checkFilePathLength -p 7.2
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment