Commit be239c20 authored by Andreas Fernandez's avatar Andreas Fernandez Committed by Benni Mack
Browse files

[BUGFIX] Remove unused `fieldChangeFunc` in GroupElement

The class GroupElement defines a `fieldChangeFunc` which is unused in
this context. Since this never caused an issue, it's assumed to be save
to remove the change handler.

This allows further cleanup in the FormEngine JavaScript land, e.g.
deprecating `setFormValueManipulate()`.

Resolves: #86948
Releases: master
Change-Id: I51f8c0c6bf3cd383ba2e12e29f329ceb979a9799
Reviewed-on: https://review.typo3.org/58910

Tested-by: default avatarTYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters's avatarWouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer's avatarGeorg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer's avatarGeorg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benni Mack's avatarBenni Mack <benni@typo3.org>
Tested-by: Benni Mack's avatarBenni Mack <benni@typo3.org>
parent a295c186
......@@ -265,13 +265,6 @@ class GroupElement extends AbstractFormElement
$showDeleteControl = false;
}
if ($maxItems === 1) {
// If maxItems==1 then automatically replace the current item in list
$parameterArray['fieldChangeFunc']['TBE_EDITOR_fieldChanged'] =
'setFormValueManipulate(' . GeneralUtility::quoteJSvalue($elementName) . ', \'Remove\');'
. $parameterArray['fieldChangeFunc']['TBE_EDITOR_fieldChanged'];
}
// Check against inline uniqueness - Create some onclick js for delete control and element browser
// to override record selection in some FAL scenarios - See 'appearance' docs of group element
$inlineStackProcessor = GeneralUtility::makeInstance(InlineStackProcessor::class);
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment