Commit bb1877d4 authored by Andreas Fernandez's avatar Andreas Fernandez
Browse files

[TASK] Update Bootstrap to 5.2.0

Bootstrap is updated to 5.2.0. Due to a behavior change (perhaps a
regression), carousels need adoption if they shouldn't slide
automatically as the old approach results in indefinitely sliding:

```
- <div class="carousel slide" data-bs-interval="0" data-bs-ride="carousel">
+ <div class="carousel slide" data-bs-ride="false">
```

However, this is also documented at [1].

Executed commands:

    cd Build
    nvm use
    yarn add bootstrap@^5.2.0
    yarn add --dev @types/bootstrap@^5.2.0
    grunt build

[1] https://getbootstrap.com/docs/5.2/components/carousel/#options

Resolves: #98051
Releases: main, 11.5
Change-Id: Ic9c284d9edb3881b4cc8663fad3747c19f078613
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75329


Tested-by: Benni Mack's avatarBenni Mack <benni@typo3.org>
Tested-by: core-ci's avatarcore-ci <typo3@b13.com>
Tested-by: Stefan Bürk's avatarStefan Bürk <stefan@buerk.tech>
Tested-by: Andreas Fernandez's avatarAndreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Benni Mack's avatarBenni Mack <benni@typo3.org>
Reviewed-by: Markus Klein's avatarMarkus Klein <markus.klein@typo3.org>
Reviewed-by: Stefan Bürk's avatarStefan Bürk <stefan@buerk.tech>
Reviewed-by: Andreas Fernandez's avatarAndreas Fernandez <a.fernandez@scripting-base.de>
parent 7512af39
......@@ -44,7 +44,7 @@ class ElementsBasicPasswordCest extends AbstractElementsBasicCest
// Open record and wait until form is ready
$I->waitForText('elements basic', 20);
$editRecordLinkCssPath = '#recordlist-tx_styleguide_elements_basic a[data-bs-original-title="Edit record"]';
$editRecordLinkCssPath = '#recordlist-tx_styleguide_elements_basic a[aria-label="Edit record"]';
$I->click($editRecordLinkCssPath);
$I->waitForElementNotVisible('#t3js-ui-block');
$I->waitForText('Edit Form', 3, 'h1');
......
......@@ -43,7 +43,7 @@ class ElementsGroupCest
$I->executeJS('window.name="TYPO3Main";');
$I->waitForText('elements group', 20);
$editRecordLinkCssPath = '#recordlist-tx_styleguide_elements_group a[data-bs-original-title="Edit record"]';
$editRecordLinkCssPath = '#recordlist-tx_styleguide_elements_group a[aria-label="Edit record"]';
$I->click($editRecordLinkCssPath);
$I->waitForText('Edit Form', 3, 'h1');
}
......
......@@ -44,7 +44,7 @@ class Inline1nCest
$I->switchToContentFrame();
$I->waitForText('inline 1n', 20);
$editRecordLinkCssPath = '#recordlist-tx_styleguide_inline_1n a[data-bs-original-title="Edit record"]';
$editRecordLinkCssPath = '#recordlist-tx_styleguide_inline_1n a[aria-label="Edit record"]';
$I->click($editRecordLinkCssPath);
$I->waitForText('Edit Form', 3, 'h1');
}
......
......@@ -42,7 +42,7 @@ class InlineFalCest
$I->switchToContentFrame();
$I->waitForText('inline fal', 20);
$editRecordLinkCssPath = '#recordlist-tx_styleguide_inline_fal a[data-bs-original-title="Edit record"]';
$editRecordLinkCssPath = '#recordlist-tx_styleguide_inline_fal a[aria-label="Edit record"]';
$I->click($editRecordLinkCssPath);
$I->waitForText('Edit Form', 3, 'h1');
}
......
......@@ -43,7 +43,7 @@ class NullPlaceholderCest
{
$I->amGoingTo('Check if deactivating null checkboxes marks as "changed"');
$editRecordLinkCssPath = '#recordlist-tx_styleguide_inline_fal a[data-bs-original-title="Edit record"]';
$editRecordLinkCssPath = '#recordlist-tx_styleguide_inline_fal a[aria-label="Edit record"]';
$I->click($editRecordLinkCssPath);
$I->waitForElementNotVisible('#t3js-ui-block');
......
......@@ -72,7 +72,7 @@ class TasksCest
*/
public function canEditTask(ApplicationTester $I): void
{
$I->click('//a[contains(@data-bs-original-title, "Edit")]');
$I->click('//a[contains(@aria-label, "Edit")]');
$I->waitForText('Edit scheduled task "System Status Update (reports)"');
$I->seeInField('#task_SystemStatusUpdateNotificationEmail', 'test@local.typo3.org');
$I->fillField('#task_SystemStatusUpdateNotificationEmail', 'foo@local.typo3.org');
......@@ -88,15 +88,15 @@ class TasksCest
public function canEnableAndDisableTask(ApplicationTester $I): void
{
$I->wantTo('See a enable button for a task');
$I->click('//button[contains(@data-bs-original-title, "Enable")]', '#tx_scheduler_form');
$I->click('//button[contains(@aria-label, "Enable")]', '#tx_scheduler_form');
$I->dontSeeElement('.tx_scheduler_mod1 .disabled');
$I->dontSee('disabled');
$I->wantTo('See a disable button for a task');
// Give tooltips some time to fully init
$I->wait(1);
$I->moveMouseOver('//button[contains(@data-bs-original-title, "Disable")]');
$I->moveMouseOver('//button[contains(@aria-label, "Disable")]');
$I->wait(1);
$I->click('//button[contains(@data-bs-original-title, "Disable")]');
$I->click('//button[contains(@aria-label, "Disable")]');
$I->waitForElementVisible('div.tx_scheduler_mod1');
$I->seeElement('.tx_scheduler_mod1 .disabled');
$I->see('disabled');
......@@ -108,8 +108,8 @@ class TasksCest
public function canDeleteTask(ApplicationTester $I, ModalDialog $modalDialog): void
{
$I->wantTo('See a delete button for a task');
$I->seeElement('//a[contains(@data-bs-original-title, "Delete")]');
$I->click('//a[contains(@data-bs-original-title, "Delete")]');
$I->seeElement('//a[contains(@aria-label, "Delete")]');
$I->click('//a[contains(@aria-label, "Delete")]');
$I->wantTo('Cancel the delete dialog');
// don't use $modalDialog->clickButtonInDialog due to too low timeout
......@@ -119,7 +119,7 @@ class TasksCest
$I->switchToContentFrame();
$I->wantTo('Still see and can click the Delete button as the deletion has been canceled');
$I->click('//a[contains(@data-bs-original-title, "Delete")]');
$I->click('//a[contains(@aria-label, "Delete")]');
$modalDialog->clickButtonInDialog('OK');
$I->switchToContentFrame();
$I->see('The task was successfully deleted.');
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment