Commit 9f0faa43 authored by Georg Ringer's avatar Georg Ringer
Browse files

[!!!][TASK] Remove field resizeTextareas_MaxHeight from user settings

The field `resizeTextareas_MaxHeight` with the label
"Maximum height of text areas in pixels* is removed because of low impact
and to simplify the settings module.

Resolves: #97605
Releases: main
Change-Id: I2a73a4ea99bc5e8fc91d5ccfaf7d1b5975c7ad16
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74601

Reviewed-by: Oliver Klee's avatarOliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Andreas Fernandez's avatarAndreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Benni Mack's avatarBenni Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn's avatarChristian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Georg Ringer's avatarGeorg Ringer <georg.ringer@gmail.com>
Tested-by: core-ci's avatarcore-ci <typo3@b13.com>
Tested-by: Andreas Fernandez's avatarAndreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Benni Mack's avatarBenni Mack <benni@typo3.org>
Tested-by: Christian Kuhn's avatarChristian Kuhn <lolli@schwarzbu.ch>
Tested-by: Georg Ringer's avatarGeorg Ringer <georg.ringer@gmail.com>
parent f109daad
...@@ -17,7 +17,6 @@ declare(strict_types=1); ...@@ -17,7 +17,6 @@ declare(strict_types=1);
namespace TYPO3\CMS\Backend\Form\Element; namespace TYPO3\CMS\Backend\Form\Element;
use TYPO3\CMS\Core\Authentication\BackendUserAuthentication;
use TYPO3\CMS\Core\Page\JavaScriptModuleInstruction; use TYPO3\CMS\Core\Page\JavaScriptModuleInstruction;
use TYPO3\CMS\Core\Utility\GeneralUtility; use TYPO3\CMS\Core\Utility\GeneralUtility;
use TYPO3\CMS\Core\Utility\MathUtility; use TYPO3\CMS\Core\Utility\MathUtility;
...@@ -181,11 +180,7 @@ class TextElement extends AbstractFormElement ...@@ -181,11 +180,7 @@ class TextElement extends AbstractFormElement
$classes[] = 't3js-enable-tab'; $classes[] = 't3js-enable-tab';
} }
$attributes['class'] = implode(' ', $classes); $attributes['class'] = implode(' ', $classes);
$maximumHeight = (int)$this->getBackendUserAuthentication()->uc['resizeTextareas_MaxHeight'];
if ($maximumHeight > 0) {
// add the max-height from the users' preference to it
$attributes['style'] = 'max-height: ' . $maximumHeight . 'px';
}
if (isset($config['max']) && (int)$config['max'] > 0) { if (isset($config['max']) && (int)$config['max'] > 0) {
$attributes['maxlength'] = (string)(int)$config['max']; $attributes['maxlength'] = (string)(int)$config['max'];
} }
...@@ -325,9 +320,4 @@ class TextElement extends AbstractFormElement ...@@ -325,9 +320,4 @@ class TextElement extends AbstractFormElement
return $resultArray; return $resultArray;
} }
protected function getBackendUserAuthentication(): BackendUserAuthentication
{
return $GLOBALS['BE_USER'];
}
} }
...@@ -17,7 +17,6 @@ declare(strict_types=1); ...@@ -17,7 +17,6 @@ declare(strict_types=1);
namespace TYPO3\CMS\Backend\Form\Element; namespace TYPO3\CMS\Backend\Form\Element;
use TYPO3\CMS\Core\Authentication\BackendUserAuthentication;
use TYPO3\CMS\Core\Page\JavaScriptModuleInstruction; use TYPO3\CMS\Core\Page\JavaScriptModuleInstruction;
use TYPO3\CMS\Core\Utility\GeneralUtility; use TYPO3\CMS\Core\Utility\GeneralUtility;
use TYPO3\CMS\Core\Utility\MathUtility; use TYPO3\CMS\Core\Utility\MathUtility;
...@@ -83,8 +82,6 @@ class TextTableElement extends AbstractFormElement ...@@ -83,8 +82,6 @@ class TextTableElement extends AbstractFormElement
*/ */
public function render() public function render()
{ {
$backendUser = $this->getBackendUserAuthentication();
$parameterArray = $this->data['parameterArray']; $parameterArray = $this->data['parameterArray'];
$resultArray = $this->initializeResultArray(); $resultArray = $this->initializeResultArray();
...@@ -175,11 +172,7 @@ class TextTableElement extends AbstractFormElement ...@@ -175,11 +172,7 @@ class TextTableElement extends AbstractFormElement
$classes[] = 't3js-enable-tab'; $classes[] = 't3js-enable-tab';
} }
$attributes['class'] = implode(' ', $classes); $attributes['class'] = implode(' ', $classes);
$maximumHeight = (int)$backendUser->uc['resizeTextareas_MaxHeight'];
if ($maximumHeight > 0) {
// add the max-height from the users' preference to it
$attributes['style'] = 'max-height: ' . $maximumHeight . 'px';
}
if (isset($config['max']) && (int)$config['max'] > 0) { if (isset($config['max']) && (int)$config['max'] > 0) {
$attributes['maxlength'] = (string)(int)$config['max']; $attributes['maxlength'] = (string)(int)$config['max'];
} }
...@@ -231,11 +224,6 @@ class TextTableElement extends AbstractFormElement ...@@ -231,11 +224,6 @@ class TextTableElement extends AbstractFormElement
return $resultArray; return $resultArray;
} }
protected function getBackendUserAuthentication(): BackendUserAuthentication
{
return $GLOBALS['BE_USER'];
}
/** /**
* Creates the HTML for the Table Wizard: * Creates the HTML for the Table Wizard:
* *
......
...@@ -239,7 +239,6 @@ class BackendUserAuthentication extends AbstractUserAuthentication ...@@ -239,7 +239,6 @@ class BackendUserAuthentication extends AbstractUserAuthentication
'titleLen' => 50, 'titleLen' => 50,
'edit_RTE' => '1', 'edit_RTE' => '1',
'edit_docModuleUpload' => '1', 'edit_docModuleUpload' => '1',
'resizeTextareas_MaxHeight' => 500,
]; ];
/** /**
......
.. include:: /Includes.rst.txt
.. _breaking-97605-1652214290
============================================================================
Breaking: #97605 - Remove field resizeTextareas_MaxHeight from user settings
============================================================================
See :issue:`97605`
Description
===========
The field `resizeTextareas_MaxHeight` with the label *Maximum height of text areas in pixels* has been removed.
The impact of the field is low and its removal simplifies the user settings module.
Impact
======
The height of textareas is the same for every user.
Affected installations
======================
Every TYPO3 installation.
Migration
=========
There is no migration available. If this feature is needed, the rendering of a field can be modified by a custom :php:`FormElement`.
.. index:: Backend, NotScanned, ext:backend
...@@ -261,9 +261,6 @@ ...@@ -261,9 +261,6 @@
<trans-unit id="showHiddenFilesAndFolders" resname="showHiddenFilesAndFolders"> <trans-unit id="showHiddenFilesAndFolders" resname="showHiddenFilesAndFolders">
<source>Show hidden files and folders in the filelist</source> <source>Show hidden files and folders in the filelist</source>
</trans-unit> </trans-unit>
<trans-unit id="flexibleTextareas_MaxHeight" resname="flexibleTextareas_MaxHeight">
<source>Maximum height of text areas in pixels</source>
</trans-unit>
<trans-unit id="editFunctionsTab" resname="editFunctionsTab"> <trans-unit id="editFunctionsTab" resname="editFunctionsTab">
<source>Edit and Advanced functions</source> <source>Edit and Advanced functions</source>
</trans-unit> </trans-unit>
......
...@@ -87,11 +87,6 @@ $GLOBALS['TYPO3_USER_SETTINGS'] = [ ...@@ -87,11 +87,6 @@ $GLOBALS['TYPO3_USER_SETTINGS'] = [
'eventName' => 'setup:confirmation:response', 'eventName' => 'setup:confirmation:response',
], ],
], ],
'resizeTextareas_MaxHeight' => [
'type' => 'number',
'class' => 'form-control-adapt',
'label' => 'LLL:EXT:setup/Resources/Private/Language/locallang.xlf:flexibleTextareas_MaxHeight',
],
'mfaProviders' => [ 'mfaProviders' => [
'type' => 'mfa', 'type' => 'mfa',
'label' => 'LLL:EXT:setup/Resources/Private/Language/locallang.xlf:mfaProviders', 'label' => 'LLL:EXT:setup/Resources/Private/Language/locallang.xlf:mfaProviders',
...@@ -108,5 +103,5 @@ $GLOBALS['TYPO3_USER_SETTINGS'] = [ ...@@ -108,5 +103,5 @@ $GLOBALS['TYPO3_USER_SETTINGS'] = [
'showitem' => '--div--;LLL:EXT:setup/Resources/Private/Language/locallang.xlf:personal_data,realName,email,emailMeAtLogin,avatar,lang, 'showitem' => '--div--;LLL:EXT:setup/Resources/Private/Language/locallang.xlf:personal_data,realName,email,emailMeAtLogin,avatar,lang,
--div--;LLL:EXT:setup/Resources/Private/Language/locallang.xlf:accountSecurity,passwordCurrent,password,password2,mfaProviders, --div--;LLL:EXT:setup/Resources/Private/Language/locallang.xlf:accountSecurity,passwordCurrent,password,password2,mfaProviders,
--div--;LLL:EXT:setup/Resources/Private/Language/locallang.xlf:opening,startModule, --div--;LLL:EXT:setup/Resources/Private/Language/locallang.xlf:opening,startModule,
--div--;LLL:EXT:setup/Resources/Private/Language/locallang.xlf:editFunctionsTab,edit_RTE,resizeTextareas_MaxHeight,titleLen,backendTitleFormat,edit_docModuleUpload,showHiddenFilesAndFolders,copyLevels,resetConfiguration', --div--;LLL:EXT:setup/Resources/Private/Language/locallang.xlf:editFunctionsTab,edit_RTE,titleLen,backendTitleFormat,edit_docModuleUpload,showHiddenFilesAndFolders,copyLevels,resetConfiguration',
]; ];
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment