Commit 987a9eaf authored by Stefan Neufeind's avatar Stefan Neufeind Committed by Christian Kuhn
Browse files

[BUGFIX] Re-apply colorspace to resulting image

When using filters the colorspace is not always applied.
A quickfix is to add the colorspace-setting again before
writing the output-image.
Multiple colorspace-settings on the commandline will be
executed in order. For example the grayscale-filter uses
"-colorspace GRAY". The final output-image can then be
converted to "-colorspace sRGB" again so the brightness
appears correct (not too dark) again.

Resolves: #78816
Releases: master, 8.7
Change-Id: I3fcabf8fdbb8d43f15662532b881501ebb43b1dd
Reviewed-on: https://review.typo3.org/50791

Reviewed-by: default avatarMathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: default avatarMathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: default avatarTYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn's avatarChristian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn's avatarChristian Kuhn <lolli@schwarzbu.ch>
parent cecacc9a
......@@ -2121,6 +2121,8 @@ class GraphicalFunctions
$params .= ' -crop ' . $data['origW'] . 'x' . $data['origH'] . '+' . $offsetX . '+' . $offsetY . '! ';
}
$command = $this->scalecmd . ' ' . $info[0] . 'x' . $info[1] . '! ' . $params . ' ';
// re-apply colorspace-setting for the resulting image so colors don't appear to dark (sRGB instead of RGB)
$command .= ' -colorspace ' . $this->colorspace;
$cropscale = $data['crs'] ? 'crs-V' . $data['cropV'] . 'H' . $data['cropH'] : '';
if ($this->alternativeOutputKey) {
$theOutputName = GeneralUtility::shortMD5($command . $cropscale . basename($imagefile) . $this->alternativeOutputKey . '[' . $frame . ']');
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment