Commit 9821608a authored by Andreas Fernandez's avatar Andreas Fernandez Committed by Benjamin Franzke
Browse files

[BUGFIX] Remove wrong data-formengine-input-name attribute

With #93135, selectMultipleSideBySide fields broke and didn't accept new
values as both select fields share the same `data-formengine-input-name`
which confuses the changed CSS selector.

This patch removes the attribute from the "value provider" fields as
it's not required there at all and also adapt FormEngine to not
use the styling related form-select class.

Resolves: #93213
Resolves: #93214
Related: #93135
Releases: master
Change-Id: I2cf4ad6ff4d78072bf5474d7393ad4eb7f771070
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67335

Tested-by: Mathias Brodala's avatarMathias Brodala <mbrodala@pagemachine.de>
Tested-by: default avatarTYPO3com <noreply@typo3.com>
Tested-by: Benjamin Franzke's avatarBenjamin Franzke <bfr@qbus.de>
Reviewed-by: Mathias Brodala's avatarMathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Benjamin Franzke's avatarBenjamin Franzke <bfr@qbus.de>
parent fdcb412a
......@@ -324,7 +324,6 @@ class SelectMultipleSideBySideElement extends AbstractFormElement
$html[] = ' data-relatedfieldname="' . htmlspecialchars($elementName) . '"';
$html[] = ' data-exclusivevalues="' . htmlspecialchars($config['exclusiveKeys']) . '"';
$html[] = ' id="' . $availableOptionsFieldId . '"';
$html[] = ' data-formengine-input-name="' . htmlspecialchars($elementName) . '"';
$html[] = ' class="form-select t3js-formengine-select-itemstoselect"';
$html[] = ' size="' . $size . '"';
$html[] = ' onchange="' . htmlspecialchars(implode('', $parameterArray['fieldChangeFunc'])) . '"';
......
......@@ -289,7 +289,7 @@ define(['jquery',
var $fieldEl;
switch (appendix) {
case '_list':
$fieldEl = $(':input.form-select[data-formengine-input-name="' + fieldName + '"]', $formEl);
$fieldEl = $(':input[data-formengine-input-name="' + fieldName + '"]:not([type=hidden])', $formEl);
break;
case '_avail':
$fieldEl = $(':input[data-relatedfieldname="' + fieldName + '"]', $formEl);
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment