Commit 7d1bc443 authored by Simon Schaufelberger's avatar Simon Schaufelberger Committed by Stefan Bürk
Browse files

[TASK] Remove type annotations where possible

Searched for "/** @var " and went through all results manually.
Skipped results where GeneralUtility::makeInstance is called with
a variable.

This reduces the PHPStan baseline further.

Imported some namespaces on the go.

Run commands:

> Build/Scripts/runTests.sh -s phpstanGenerateBaseline
> Build/Scripts/runTests.sh -s cglGit

Resolves: #97705
Releases: main,11.5
Change-Id: I700ba596234af8cd3d32507fb03d77cfe30c678a
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74785


Tested-by: core-ci's avatarcore-ci <typo3@b13.com>
Tested-by: Oliver Klee's avatarOliver Klee <typo3-coding@oliverklee.de>
Tested-by: Stefan Bürk's avatarStefan Bürk <stefan@buerk.tech>
Reviewed-by: Oliver Klee's avatarOliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Stefan Bürk's avatarStefan Bürk <stefan@buerk.tech>
parent e995c4f0
......@@ -1825,31 +1825,11 @@ parameters:
count: 1
path: ../../typo3/sysext/core/Tests/Unit/LinkHandling/EmailLinkHandlerTest.php
-
message: "#^Variable \\$storageMock in PHPDoc tag @var does not match assigned variable \\$factory\\.$#"
count: 1
path: ../../typo3/sysext/core/Tests/Unit/LinkHandling/FileLinkHandlerTest.php
-
message: "#^Variable \\$storageMock in PHPDoc tag @var does not match assigned variable \\$storage\\.$#"
count: 1
path: ../../typo3/sysext/core/Tests/Unit/LinkHandling/FileLinkHandlerTest.php
-
message: "#^Method PHPUnit\\\\Framework\\\\MockObject\\\\MockBuilder\\<TYPO3\\\\CMS\\\\Core\\\\Resource\\\\ResourceStorage\\>\\:\\:getMock\\(\\) invoked with 1 parameter, 0 required\\.$#"
count: 1
path: ../../typo3/sysext/core/Tests/Unit/LinkHandling/FolderLinkHandlerTest.php
-
message: "#^Variable \\$storageMock in PHPDoc tag @var does not match assigned variable \\$storage\\.$#"
count: 1
path: ../../typo3/sysext/core/Tests/Unit/LinkHandling/FolderLinkHandlerTest.php
-
message: "#^Variable \\$storageMock in PHPDoc tag @var does not match assigned variable \\$storage\\.$#"
count: 1
path: ../../typo3/sysext/core/Tests/Unit/LinkHandling/LegacyLinkNotationConverterTest.php
-
message: "#^Parameter \\#1 \\$data of method TYPO3\\\\CMS\\\\Core\\\\LinkHandling\\\\UrlLinkHandler\\:\\:resolveHandlerData\\(\\) expects array, string given\\.$#"
count: 1
......@@ -1905,11 +1885,6 @@ parameters:
count: 1
path: ../../typo3/sysext/core/Tests/Unit/Page/AssetRendererTest.php
-
message: "#^Call to an undefined method TYPO3\\\\CMS\\\\Core\\\\Page\\\\PageRenderer\\|TYPO3\\\\TestingFramework\\\\Core\\\\AccessibleObjectInterface\\:\\:expects\\(\\)\\.$#"
count: 1
path: ../../typo3/sysext/core/Tests/Unit/Page/PageRendererTest.php
-
message: "#^Cannot call method withCurrentPageNumber\\(\\) on array\\.$#"
count: 1
......@@ -1960,21 +1935,11 @@ parameters:
count: 1
path: ../../typo3/sysext/core/Tests/Unit/Resource/Driver/LocalDriverTest.php
-
message: "#^Variable \\$driver in PHPDoc tag @var does not exist\\.$#"
count: 1
path: ../../typo3/sysext/core/Tests/Unit/Resource/Driver/LocalDriverTest.php
-
message: "#^PHPDoc tag @param references unknown parameter\\: \\$expectedMergedProperties$#"
count: 1
path: ../../typo3/sysext/core/Tests/Unit/Resource/FileReferenceTest.php
-
message: "#^Variable \\$driverMock in PHPDoc tag @var does not exist\\.$#"
count: 1
path: ../../typo3/sysext/core/Tests/Unit/Resource/Filter/FileNameFilterTest.php
-
message: "#^Parameter \\#1 \\$expected of static method PHPUnit\\\\Framework\\\\Assert\\:\\:assertInstanceOf\\(\\) expects class\\-string\\<ad9195e2487eea33c8a2abd5cf33cba4\\>, string given\\.$#"
count: 1
......@@ -1990,11 +1955,6 @@ parameters:
count: 1
path: ../../typo3/sysext/core/Tests/Unit/Resource/Index/ExtractorRegistryTest.php
-
message: "#^PHPDoc tag @var for variable \\$fileResourceMock contains unknown class PHPUnit_Framework_MockObject_MockObject\\.$#"
count: 1
path: ../../typo3/sysext/core/Tests/Unit/Resource/Rendering/VimeoRendererTest.php
-
message: "#^Parameter \\#1 \\$uid of method TYPO3\\\\CMS\\\\Core\\\\Resource\\\\AbstractRepository\\:\\:findByUid\\(\\) expects int, string given\\.$#"
count: 2
......@@ -2012,7 +1972,7 @@ parameters:
-
message: "#^Call to an undefined method TYPO3\\\\CMS\\\\Core\\\\Site\\\\SiteFinder\\:\\:method\\(\\)\\.$#"
count: 2
count: 1
path: ../../typo3/sysext/core/Tests/Unit/Routing/SiteMatcherTest.php
-
......@@ -2451,7 +2411,7 @@ parameters:
path: ../../typo3/sysext/extbase/Tests/Functional/Property/TypeConverter/ObjectConverterTest.php
-
message: "#^Property class@anonymous/extbase/Tests/Functional/Property/TypeConverter/ObjectConverterTest\\.php\\:340\\:\\:\\$name is unused\\.$#"
message: "#^Property class@anonymous/extbase/Tests/Functional/Property/TypeConverter/ObjectConverterTest\\.php\\:341\\:\\:\\$name is unused\\.$#"
count: 1
path: ../../typo3/sysext/extbase/Tests/Functional/Property/TypeConverter/ObjectConverterTest.php
......@@ -2522,7 +2482,7 @@ parameters:
-
message: "#^Call to static method PHPUnit\\\\Framework\\\\Assert\\:\\:assertNull\\(\\) with DateTime&PHPUnit\\\\Framework\\\\MockObject\\\\MockObject&TYPO3\\\\TestingFramework\\\\Core\\\\AccessibleObjectInterface will always evaluate to false\\.$#"
count: 2
count: 1
path: ../../typo3/sysext/extbase/Tests/Unit/Persistence/Generic/Mapper/DataMapperTest.php
-
......@@ -2810,11 +2770,6 @@ parameters:
count: 1
path: ../../typo3/sysext/extensionmanager/Classes/ViewHelpers/ToggleExtensionInstallationStateViewHelper.php
-
message: "#^Variable \\$downloadUtilityMock in PHPDoc tag @var does not match assigned variable \\$extensionManagementServiceMock\\.$#"
count: 1
path: ../../typo3/sysext/extensionmanager/Tests/Unit/Controller/DownloadControllerTest.php
-
message: "#^Method PHPUnit\\\\Framework\\\\TestCase\\:\\:count\\(\\) invoked with 1 parameter, 0 required\\.$#"
count: 1
......@@ -3810,11 +3765,6 @@ parameters:
count: 3
path: ../../typo3/sysext/frontend/Tests/Functional/SiteHandling/SiteRequestTest.php
-
message: "#^Call to an undefined method TYPO3\\\\CMS\\\\Frontend\\\\Authentication\\\\FrontendUserAuthentication\\|TYPO3\\\\TestingFramework\\\\Core\\\\AccessibleObjectInterface\\:\\:method\\(\\)\\.$#"
count: 2
path: ../../typo3/sysext/frontend/Tests/Unit/Authentication/FrontendUserAuthenticationTest.php
-
message: "#^Call to static method PHPUnit\\\\Framework\\\\Assert\\:\\:assertFalse\\(\\) with string will always evaluate to false\\.$#"
count: 1
......@@ -3945,11 +3895,6 @@ parameters:
count: 1
path: ../../typo3/sysext/impexp/Tests/Functional/ImportExportTest.php
-
message: "#^Variable \\$subject in PHPDoc tag @var does not match assigned variable \\$importMock\\.$#"
count: 1
path: ../../typo3/sysext/impexp/Tests/Functional/ImportTest.php
-
message: "#^Call to an undefined method TYPO3\\\\CMS\\\\Extbase\\\\Mvc\\\\RequestInterface\\:\\:setArguments\\(\\)\\.$#"
count: 1
......@@ -4280,11 +4225,6 @@ parameters:
count: 1
path: ../../typo3/sysext/recycler/Tests/Unit/Task/CleanerFieldProviderTest.php
-
message: "#^Call to an undefined method TYPO3\\\\CMS\\\\Redirects\\\\Service\\\\RedirectService\\:\\:method\\(\\)\\.$#"
count: 1
path: ../../typo3/sysext/redirects/Tests/Unit/Service/RedirectServiceTest.php
-
message: "#^Parameter \\#1 \\$href of method TYPO3\\\\CMS\\\\Backend\\\\Template\\\\Components\\\\Menu\\\\MenuItem\\:\\:setHref\\(\\) expects string, TYPO3\\\\CMS\\\\Core\\\\Http\\\\Uri given\\.$#"
count: 2
......
......@@ -77,7 +77,6 @@ class InMemoryLogWriter extends AbstractWriter
protected function lockWriter(): void
{
self::$memoryLock = true;
/** @var LogRecord $record */
$record = GeneralUtility::makeInstance(
LogRecord::class,
'TYPO3.CMS.AdminPanel.Log.InMemoryLogWriter',
......
......@@ -74,7 +74,6 @@ class SystemInformationToolbarItem implements ToolbarItemInterface, RequestAware
public function addSystemMessage($text, $status = InformationStatus::STATUS_OK, $count = 0, $module = '', $params = ''): void
{
$this->systemMessageTotalCount += (int)$count;
/** @var InformationStatus $messageSeverity */
$messageSeverity = InformationStatus::cast($status);
// define the severity for the badge
if ($messageSeverity->isGreaterThan($this->highestSeverity)) {
......
......@@ -124,7 +124,6 @@ abstract class AbstractFormEngineAjaxController
*/
protected function getLabelsFromLocalizationFile($file)
{
/** @var LocalizationFactory $languageFactory */
$languageFactory = GeneralUtility::makeInstance(LocalizationFactory::class);
$language = $this->getLanguageService()->lang;
$localizationArray = $languageFactory->getParsedData($file, $language);
......
......@@ -22,6 +22,7 @@ use Psr\Http\Message\ServerRequestInterface;
use TYPO3\CMS\Core\Authentication\BackendUserAuthentication;
use TYPO3\CMS\Core\Authentication\LoginType;
use TYPO3\CMS\Core\Core\Environment;
use TYPO3\CMS\Core\FormProtection\BackendFormProtection;
use TYPO3\CMS\Core\FormProtection\FormProtectionFactory;
use TYPO3\CMS\Core\Http\JsonResponse;
use TYPO3\CMS\Core\Session\UserSessionManager;
......@@ -47,7 +48,7 @@ class AjaxLoginController
if ($this->isAuthorizedBackendSession()) {
$result = ['success' => true];
if ($this->hasLoginBeenProcessed($request)) {
/** @var \TYPO3\CMS\Core\FormProtection\BackendFormProtection $formProtection */
/** @var BackendFormProtection $formProtection */
$formProtection = FormProtectionFactory::get();
$formProtection->setSessionTokenFromRegistry();
$formProtection->persistSessionToken();
......
......@@ -389,7 +389,6 @@ class ElementInformationController
if ($rowValue) {
$creatorRecord = BackendUtility::getRecord('be_users', (int)$rowValue);
if ($creatorRecord) {
/** @var Avatar $avatar */
$avatar = GeneralUtility::makeInstance(Avatar::class);
$creatorRecord['icon'] = $avatar->render($creatorRecord);
$rowValue = $creatorRecord;
......
......@@ -64,7 +64,6 @@ class ContextMenuController
*/
public function clipboardAction(ServerRequestInterface $request): ResponseInterface
{
/** @var Clipboard $clipboard */
$clipboard = GeneralUtility::makeInstance(Clipboard::class);
$clipboard->initializeClipboard($request);
$clipboard->lockToNormal();
......
......@@ -664,7 +664,6 @@ class EditDocumentController
$relatedPageId = -$nRec['t3ver_oid'];
}
/** @var DataHandler $duplicateTce */
$duplicateTce = GeneralUtility::makeInstance(DataHandler::class);
$duplicateCmd = [
......
......@@ -65,7 +65,6 @@ class FormInlineAjaxController extends AbstractFormEngineAjaxController
}
// Parse the DOM identifier, add the levels to the structure stack
/** @var InlineStackProcessor $inlineStackProcessor */
$inlineStackProcessor = GeneralUtility::makeInstance(InlineStackProcessor::class);
$inlineStackProcessor->initializeByParsingDomObjectIdString($domObjectId);
$inlineStackProcessor->injectAjaxConfiguration($parentConfig);
......@@ -86,9 +85,7 @@ class FormInlineAjaxController extends AbstractFormEngineAjaxController
$childTableName = $parentConfig['foreign_table'];
/** @var TcaDatabaseRecord $formDataGroup */
$formDataGroup = GeneralUtility::makeInstance(TcaDatabaseRecord::class);
/** @var FormDataCompiler $formDataCompiler */
$formDataCompiler = GeneralUtility::makeInstance(FormDataCompiler::class, $formDataGroup);
$formDataCompilerInput = [
'command' => 'new',
......@@ -122,9 +119,7 @@ class FormInlineAjaxController extends AbstractFormEngineAjaxController
];
$childData['combinationChild'] = $this->compileChildChild($childData, $parentConfig, $inlineStackProcessor->getStructure());
} else {
/** @var TcaDatabaseRecord $formDataGroup */
$formDataGroup = GeneralUtility::makeInstance(TcaDatabaseRecord::class);
/** @var FormDataCompiler $formDataCompiler */
$formDataCompiler = GeneralUtility::makeInstance(FormDataCompiler::class, $formDataGroup);
$formDataCompilerInput = [
'command' => 'new',
......@@ -176,7 +171,6 @@ class FormInlineAjaxController extends AbstractFormEngineAjaxController
$parentConfig = $this->extractSignedParentConfigFromRequest((string)$ajaxArguments['context']);
// Parse the DOM identifier, add the levels to the structure stack
/** @var InlineStackProcessor $inlineStackProcessor */
$inlineStackProcessor = GeneralUtility::makeInstance(InlineStackProcessor::class);
$inlineStackProcessor->initializeByParsingDomObjectIdString($domObjectId);
$inlineStackProcessor->injectAjaxConfiguration($parentConfig);
......@@ -243,7 +237,6 @@ class FormInlineAjaxController extends AbstractFormEngineAjaxController
$type = $ajaxArguments[1] ?? null;
$parentConfig = $this->extractSignedParentConfigFromRequest((string)$ajaxArguments['context']);
/** @var InlineStackProcessor $inlineStackProcessor */
$inlineStackProcessor = GeneralUtility::makeInstance(InlineStackProcessor::class);
// Parse the DOM identifier (string), add the levels to the structure stack (array), load the TCA config:
$inlineStackProcessor->initializeByParsingDomObjectIdString($domObjectId);
......@@ -281,9 +274,7 @@ class FormInlineAjaxController extends AbstractFormEngineAjaxController
'inlineCompileExistingChildren' => false,
];
// Full TcaDatabaseRecord is required here to have the list of connected uids $oldItemList
/** @var TcaDatabaseRecord $formDataGroup */
$formDataGroup = GeneralUtility::makeInstance(TcaDatabaseRecord::class);
/** @var FormDataCompiler $formDataCompiler */
$formDataCompiler = GeneralUtility::makeInstance(FormDataCompiler::class, $formDataGroup);
$parentData = $formDataCompiler->compile($formDataCompilerInputForParent);
$parentConfig = $parentData['processedTca']['columns'][$parentFieldName]['config'];
......@@ -313,7 +304,6 @@ class FormInlineAjaxController extends AbstractFormEngineAjaxController
];
}
/** @var DataHandler $tce */
$tce = GeneralUtility::makeInstance(DataHandler::class);
$tce->start([], $cmd);
$tce->process_cmdmap();
......@@ -401,7 +391,6 @@ class FormInlineAjaxController extends AbstractFormEngineAjaxController
$ajaxArguments = $request->getParsedBody()['ajax'] ?? $request->getQueryParams()['ajax'];
[$domObjectId, $expand, $collapse] = $ajaxArguments;
/** @var InlineStackProcessor $inlineStackProcessor */
$inlineStackProcessor = GeneralUtility::makeInstance(InlineStackProcessor::class);
// Parse the DOM identifier (string), add the levels to the structure stack (array), don't load TCA config
$inlineStackProcessor->initializeByParsingDomObjectIdString($domObjectId);
......@@ -453,7 +442,6 @@ class FormInlineAjaxController extends AbstractFormEngineAjaxController
{
$parentConfig = $parentData['processedTca']['columns'][$parentFieldName]['config'];
/** @var InlineStackProcessor $inlineStackProcessor */
$inlineStackProcessor = GeneralUtility::makeInstance(InlineStackProcessor::class);
$inlineStackProcessor->initializeByGivenStructure($inlineStructure);
$inlineTopMostParent = $inlineStackProcessor->getStructureLevel(0);
......@@ -462,9 +450,7 @@ class FormInlineAjaxController extends AbstractFormEngineAjaxController
$child = $inlineStackProcessor->getUnstableStructure();
$childTableName = $child['table'];
/** @var TcaDatabaseRecord $formDataGroup */
$formDataGroup = GeneralUtility::makeInstance(TcaDatabaseRecord::class);
/** @var FormDataCompiler $formDataCompiler */
$formDataCompiler = GeneralUtility::makeInstance(FormDataCompiler::class, $formDataGroup);
$formDataCompilerInput = [
'command' => 'edit',
......@@ -514,9 +500,7 @@ class FormInlineAjaxController extends AbstractFormEngineAjaxController
$childChildUid = $child['databaseRow'][$parentConfig['foreign_selector']][0];
// child-child table name is set in child tca "the selector field" foreign_table
$childChildTableName = $child['processedTca']['columns'][$parentConfig['foreign_selector']]['config']['foreign_table'];
/** @var TcaDatabaseRecord $formDataGroup */
$formDataGroup = GeneralUtility::makeInstance(TcaDatabaseRecord::class);
/** @var FormDataCompiler $formDataCompiler */
$formDataCompiler = GeneralUtility::makeInstance(FormDataCompiler::class, $formDataGroup);
$formDataCompilerInput = [
'command' => 'edit',
......
......@@ -21,6 +21,7 @@ use Psr\Http\Message\ResponseInterface;
use Psr\Http\Message\ServerRequestInterface;
use TYPO3\CMS\Backend\Routing\UriBuilder;
use TYPO3\CMS\Core\Authentication\BackendUserAuthentication;
use TYPO3\CMS\Core\FormProtection\BackendFormProtection;
use TYPO3\CMS\Core\FormProtection\FormProtectionFactory;
use TYPO3\CMS\Core\Http\RedirectResponse;
use TYPO3\CMS\Core\SysLog\Action\Login as SystemLogLoginAction;
......@@ -66,7 +67,7 @@ class LogoutController
}
// Logout written to log
$this->getBackendUser()->writelog(SystemLogType::LOGIN, SystemLogLoginAction::LOGOUT, SystemLogErrorClassification::MESSAGE, 1, 'User %s logged out from TYPO3 Backend', [$this->getBackendUser()->user['username']]);
/** @var \TYPO3\CMS\Core\FormProtection\BackendFormProtection $backendFormProtection */
/** @var BackendFormProtection $backendFormProtection */
$backendFormProtection = FormProtectionFactory::get();
$backendFormProtection->removeSessionTokenFromRegistry();
$this->getBackendUser()->logoff();
......
......@@ -142,7 +142,6 @@ class OnlineMediaController
*/
protected function addFlashMessage(FlashMessage $flashMessage)
{
/** @var FlashMessageService $flashMessageService */
$flashMessageService = GeneralUtility::makeInstance(FlashMessageService::class);
$defaultFlashMessageQueue = $flashMessageService->getMessageQueueByIdentifier();
......
......@@ -91,7 +91,6 @@ class LocalizationController
$pageId = (int)$params['pageId'];
$languageId = (int)$params['languageId'];
/** @var TranslationConfigurationProvider $translationProvider */
$translationProvider = GeneralUtility::makeInstance(TranslationConfigurationProvider::class);
$systemLanguages = $translationProvider->getSystemLanguages($pageId);
......
......@@ -134,7 +134,6 @@ class SimpleDataHandlerController
$this->initializeClipboard($request);
$this->processRequest();
/** @var \TYPO3\CMS\Core\Messaging\FlashMessageService $flashMessageService */
$flashMessageService = GeneralUtility::makeInstance(FlashMessageService::class);
$content = [
......
......@@ -99,9 +99,7 @@ class AddController extends AbstractWizardController
if ($this->processDataFlag) {
// Because OnTheFly can't handle MM relations with intermediate tables we use TcaDatabaseRecord here
// Otherwise already stored relations are overwritten with the new entry
/** @var TcaDatabaseRecord $formDataGroup */
$formDataGroup = GeneralUtility::makeInstance(TcaDatabaseRecord::class);
/** @var FormDataCompiler $formDataCompiler */
$formDataCompiler = GeneralUtility::makeInstance(FormDataCompiler::class, $formDataGroup);
$input = [
'tableName' => $this->P['table'],
......@@ -114,7 +112,6 @@ class AddController extends AbstractWizardController
// If that record was found (should absolutely be...), then init DataHandler and set, prepend or append
// the record
if (is_array($currentParentRow)) {
/** @var DataHandler $dataHandler */
$dataHandler = GeneralUtility::makeInstance(DataHandler::class);
$data = [];
$recordId = $this->table . '_' . $this->id;
......@@ -197,9 +194,7 @@ class AddController extends AbstractWizardController
// Redirecting to FormEngine with instructions to create a new record
// AND when closing to return back with information about that records ID etc.
/** @var \TYPO3\CMS\Core\Http\NormalizedParams */
$normalizedParams = $request->getAttribute('normalizedParams');
/** @var \TYPO3\CMS\Backend\Routing\UriBuilder $uriBuilder */
$uriBuilder = GeneralUtility::makeInstance(UriBuilder::class);
$redirectUrl = (string)$uriBuilder->buildUriFromRoute('record_edit', [
'returnEditConf' => 1,
......
......@@ -107,7 +107,6 @@ class InlineControlContainer extends AbstractContainer
$this->inlineData = $this->data['inlineData'];
/** @var InlineStackProcessor $inlineStackProcessor */
$inlineStackProcessor = GeneralUtility::makeInstance(InlineStackProcessor::class);
$this->inlineStackProcessor = $inlineStackProcessor;
$inlineStackProcessor->initializeByGivenStructure($this->data['inlineStructure']);
......
......@@ -159,7 +159,6 @@ class SingleFieldContainer extends AbstractContainer
*/
protected function isInlineChildAndLabelField($table, $field)
{
/** @var InlineStackProcessor $inlineStackProcessor */
$inlineStackProcessor = GeneralUtility::makeInstance(InlineStackProcessor::class);
$inlineStackProcessor->initializeByGivenStructure($this->data['inlineStructure']);
$level = $inlineStackProcessor->getStructureLevel(-1);
......@@ -189,7 +188,6 @@ class SingleFieldContainer extends AbstractContainer
'foreign_field' => '',
];
/** @var InlineStackProcessor $inlineStackProcessor */
$inlineStackProcessor = GeneralUtility::makeInstance(InlineStackProcessor::class);
$inlineStackProcessor->initializeByGivenStructure($this->data['inlineStructure']);
$structureDepth = $inlineStackProcessor->getStructureDepth();
......
......@@ -84,7 +84,6 @@ class SelectSingleElement extends AbstractFormElement
$classList = ['form-select', 'form-control-adapt'];
// Check against inline uniqueness
/** @var InlineStackProcessor $inlineStackProcessor */
$inlineStackProcessor = GeneralUtility::makeInstance(InlineStackProcessor::class);
$inlineStackProcessor->initializeByGivenStructure($this->data['inlineStructure']);
$uniqueIds = [];
......
......@@ -89,7 +89,6 @@ class AddRecord extends AbstractNode
$id = StringUtility::getUniqueId('t3js-formengine-fieldcontrol-');
/** @var \TYPO3\CMS\Backend\Routing\UriBuilder $uriBuilder */
$uriBuilder = GeneralUtility::makeInstance(UriBuilder::class);
return [
'iconIdentifier' => 'actions-add',
......
......@@ -78,7 +78,6 @@ class LinkPopup extends AbstractNode
],
$this->forwardOnFieldChangeQueryParams($parameterArray['fieldChangeFunc'] ?? [])
);
/** @var \TYPO3\CMS\Backend\Routing\UriBuilder $uriBuilder */
$uriBuilder = GeneralUtility::makeInstance(UriBuilder::class);
$url = (string)$uriBuilder->buildUriFromRoute('wizard_link', ['P' => $urlParameters]);
$id = StringUtility::getUniqueId('t3js-formengine-fieldcontrol-');
......
......@@ -91,7 +91,6 @@ class ListModule extends AbstractNode
$id = StringUtility::getUniqueId('t3js-formengine-fieldcontrol-');
/** @var \TYPO3\CMS\Backend\Routing\UriBuilder $uriBuilder */
$uriBuilder = GeneralUtility::makeInstance(UriBuilder::class);
return [
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment