Skip to content

GitLab

Commit 3c55a8ce authored by Simon Schaufelberger's avatar Simon Schaufelberger Committed by Stefan Bürk
Browse files

[TASK] Add unit tests for mailto_makelinks 

Increase code coverage with some more tests.

Resolves: #97444
Related: #97303
Releases: main, 11.5
Change-Id: Icaa20aea45bc34b5618bfc55710014d928444510
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74371

Tested-by: core-ci's avatarcore-ci <typo3@b13.com>
Tested-by: Oliver Klee's avatarOliver Klee <typo3-coding@oliverklee.de>
Tested-by: Stefan Bürk's avatarStefan Bürk <stefan@buerk.tech>
Reviewed-by: Oliver Klee's avatarOliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Stefan Bürk's avatarStefan Bürk <stefan@buerk.tech>
parent 3e7fc67c
Hide whitespace changes
Inline Side-by-side
typo3/sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php
View file @ 3c55a8ce
......@@ -2403,13 +2403,12 @@ class ContentObjectRendererTest extends UnitTestCase
* @test
* @dataProvider httpMakelinksDataProvider
*/
public function httpMakelinksReturnsLink(string $data, array $configuration, string $expectedResult, LinkResult|false $linkResult): void
public function httpMakelinksReturnsLink(string $data, array $configuration, string $expectedResult, LinkResult $linkResult): void
{
if ($linkResult !== false) {
$linkFactory = $this->prophesize(LinkFactory::class);
$linkFactory->create(Argument::cetera())->willReturn($linkResult);
GeneralUtility::addInstance(LinkFactory::class, $linkFactory->reveal());
}
$linkFactory = $this->prophesize(LinkFactory::class);
$linkFactory->create(Argument::cetera())->willReturn($linkResult);
GeneralUtility::addInstance(LinkFactory::class, $linkFactory->reveal());
self::assertSame($expectedResult, $this->subject->http_makelinks($data, $configuration));
}
......@@ -2446,6 +2445,93 @@ class ContentObjectRendererTest extends UnitTestCase
self::assertSame($expectedResult, $this->subject->http_makelinks($data, $configuration));
}
public function mailtoMakelinksDataProvider(): array
{
return [
'mailto link' => [
'Some text with an email address mailto:john@example.com',
[
],
'Some text with an email address <a href="mailto:john@example.com">john@example.com</a>',
(new LinkResult(LinkService::TYPE_EMAIL, 'mailto:john@example.com'))->withLinkText('john@example.com'),
],
'mailto link with subject parameter' => [
'Some text with an email address mailto:john@example.com?subject=hi',
[
],
'Some text with an email address <a href="mailto:john@example.com?subject=hi">john@example.com</a>',
(new LinkResult(LinkService::TYPE_EMAIL, 'mailto:john@example.com?subject=hi'))->withLinkText('john@example.com'),
],
'mailto link with multiple parameters' => [
'Some text with an email address mailto:john@example.com?subject=Greetings&body=Hi+John',
[
],
'Some text with an email address <a href="mailto:john@example.com?subject=Greetings&amp;body=Hi+John">john@example.com</a>',
(new LinkResult(LinkService::TYPE_EMAIL, 'mailto:john@example.com?subject=Greetings&body=Hi+John'))->withLinkText('john@example.com'),
],
'mailto link with question mark' => [
'Some text with an email address mailto:john@example.com?',
[
],
'Some text with an email address <a href="mailto:john@example.com">john@example.com</a>?',
(new LinkResult(LinkService::TYPE_EMAIL, 'mailto:john@example.com'))->withLinkText('john@example.com'),
],
'mailto link with period' => [
'Some text with an email address mailto:john@example.com.',
[
],
'Some text with an email address <a href="mailto:john@example.com">john@example.com</a>.',
(new LinkResult(LinkService::TYPE_EMAIL, 'mailto:john@example.com'))->withLinkText('john@example.com'),
],
'mailto link with wrap' => [
'Some text with an email address mailto:john@example.com.',
[
'wrap' => '<span>|</span>',
],
'Some text with an email address <span><a href="mailto:john@example.com">john@example.com</a></span>.',
(new LinkResult(LinkService::TYPE_EMAIL, 'mailto:john@example.com'))->withLinkText('john@example.com'),
],
'mailto link with ATagBeforeWrap' => [
'Some text with an email address mailto:john@example.com.',
[
'wrap' => '<span>|</span>',
'ATagBeforeWrap' => 1,
],
'Some text with an email address <a href="mailto:john@example.com"><span>john@example.com</span></a>.',
(new LinkResult(LinkService::TYPE_EMAIL, 'mailto:john@example.com'))->withLinkText('john@example.com'),
],
'mailto link with ATagParams' => [
'Some text with an email address mailto:john@example.com.',
[
'ATagParams' => 'class="email"',
],
'Some text with an email address <a href="mailto:john@example.com" class="email">john@example.com</a>.',
(new LinkResult(LinkService::TYPE_EMAIL, 'mailto:john@example.com'))->withAttribute('class', 'email')->withLinkText('john@example.com'),
],
];
}
/**
* @test
* @dataProvider mailtoMakelinksDataProvider
*/
public function mailtoMakelinksReturnsMailToLink(string $data, array $configuration, string $expectedResult, LinkResult $linkResult): void
{
$linkFactory = $this->prophesize(LinkFactory::class);
$linkFactory->create(Argument::cetera())->willReturn($linkResult);
GeneralUtility::addInstance(LinkFactory::class, $linkFactory->reveal());
self::assertSame($expectedResult, $this->subject->mailto_makelinks($data, $configuration));
}
/**
* @test
*/
public function mailtoMakelinksReturnsNoMailToLink(): void
{
self::assertSame('mailto:', $this->subject->mailto_makelinks('mailto:', []));
}
/**
* @return array
*/
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment