Commit 304877c6 authored by Oliver Hader's avatar Oliver Hader
Browse files

Fixed bug #12739: XSS in shortcuts (thanks to Francois Suter and Georg Ringer)

git-svn-id: https://svn.typo3.org/TYPO3v4/Core/branches/TYPO3_4-1@8376 709f56b5-9817-0410-a4d7-c38de5d9e867
parent f6d2e33c
......@@ -11,6 +11,7 @@
* Fixed bug #12458: Session fixation possibility in new sesion machanism of the install tool (thanks to Benjamin Mack, Helmut Hummel and Ernesto Baschny)
* Fixed bug #12736: XSS in setup module (thanks to Georg Ringer)
* Fixed bug #13989: Mitigate PHP's RNG vulnerability (thanks to Marcus Krause and Helmut Hummel)
* Fixed bug #12739: XSS in shortcuts (thanks to Francois Suter and Georg Ringer)
2010-05-17 Oliver Hader <oliver@typo3.org>
......
......@@ -153,6 +153,7 @@ class SC_alt_shortcut {
global $BE_USER;
$description = ''; // Default description
$url = urldecode($this->URL);
$queryParts = parse_url($url);
// Lookup the title of this page and use it as default description
$page_id = $this->getLinkedPageId($url);
......@@ -176,8 +177,9 @@ class SC_alt_shortcut {
}
// Adding a shortcut being set from another frame
if ($this->modName && $this->URL) {
// Adding a shortcut being set from another frame,
// but only if it's a relative URL (i.e. scheme part is not defined)
if ($this->modName && $this->URL && empty($queryParts['scheme'])) {
$fields_values = array(
'userid' => $BE_USER->user['uid'],
'module_name' => $this->modName.'|'.$this->M_modName,
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment