Commit 2e92b1d0 authored by Christian Kuhn's avatar Christian Kuhn Committed by Andreas Fernandez
Browse files

[TASK] Remove SqlSrv related test code

We're not actively testing Microsoft SQL Server
anymore. The functional test related group annotation
not-mssql can be removed, along with the docker
container setup.

Resolves: #96591
Releases: main
Change-Id: Ida5ce97fbab3c19e7e7a0b2548b03fa758f48bb0
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73069


Tested-by: core-ci's avatarcore-ci <typo3@b13.com>
Tested-by: Stefan Bürk's avatarStefan Bürk <stefan@buerk.tech>
Tested-by: Andreas Fernandez's avatarAndreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Stefan Bürk's avatarStefan Bürk <stefan@buerk.tech>
Reviewed-by: Andreas Fernandez's avatarAndreas Fernandez <a.fernandez@scripting-base.de>
parent 4a5e6a1b
......@@ -19,13 +19,6 @@ services:
tmpfs:
- /var/lib/mysql/:rw,noexec,nosuid
mssql2019latest:
image: typo3/core-testing-mssql2019:latest
environment:
ACCEPT_EULA: "Y"
SA_PASSWORD: "Test1234!"
MSSQL_PID: Developer
postgres:
image: postgres:${POSTGRES_VERSION}-alpine
environment:
......@@ -980,98 +973,6 @@ services:
fi
"
prepare_functional_mssql2019latest:
image: alpine:3.8
links:
- mssql2019latest
- redis4
- memcached1-5
command: >
/bin/sh -c "
if [ ${SCRIPT_VERBOSE} -eq 1 ]; then
set -x
fi
echo Waiting for database start...;
while ! nc -z mssql2019latest 1433; do
sleep 1;
done;
echo Database is up;
"
functional_mssql2019latest:
image: typo3/core-testing-${DOCKER_PHP_IMAGE}:latest
user: "${HOST_UID}"
volumes:
- ${CORE_ROOT}:${CORE_ROOT}
environment:
typo3DatabaseDriver: "${DATABASE_DRIVER}"
typo3DatabaseName: func
typo3DatabasePassword: "Test1234!"
typo3DatabaseUsername: SA
typo3DatabasePort: 1433
typo3DatabaseCharset: utf-8
typo3DatabaseHost: mssql2019latest
typo3TestingRedisHost: redis4
typo3TestingMemcachedHost: memcached1-5
working_dir: ${CORE_ROOT}
extra_hosts:
- "host.docker.internal:host-gateway"
command: >
/bin/sh -c "
if [ ${SCRIPT_VERBOSE} -eq 1 ]; then
set -x
fi
php -v | grep '^PHP'
if [ ${CHUNKS} -gt 0 ]; then
echo \"Running chunk ${THISCHUNK}\"
COMMAND=\"vendor/phpunit/phpunit/phpunit -c Build/phpunit/FunctionalTests-Job-${THISCHUNK}.xml ${EXTRA_TEST_OPTIONS} --exclude-group not-mssql ${TEST_FILE}\"
else
COMMAND=\"vendor/phpunit/phpunit/phpunit -c Build/phpunit/FunctionalTests.xml ${EXTRA_TEST_OPTIONS} --exclude-group not-mssql ${TEST_FILE}\"
fi
if [ ${PHP_XDEBUG_ON} -eq 0 ]; then
XDEBUG_MODE=\"off\" $${COMMAND};
else
XDEBUG_MODE=\"debug,develop\" \
XDEBUG_TRIGGER=\"foo\" \
XDEBUG_CONFIG=\"client_port=${PHP_XDEBUG_PORT} client_host=host.docker.internal\" \
$${COMMAND};
fi
"
functional_deprecated_mssql2019latest:
image: typo3/core-testing-${DOCKER_PHP_IMAGE}:latest
user: "${HOST_UID}"
volumes:
- ${CORE_ROOT}:${CORE_ROOT}
environment:
typo3DatabaseDriver: "${DATABASE_DRIVER}"
typo3DatabaseName: func
typo3DatabasePassword: "Test1234!"
typo3DatabaseUsername: SA
typo3DatabasePort: 1433
typo3DatabaseCharset: utf-8
typo3DatabaseHost: mssql2019latest
typo3TestingRedisHost: redis4
typo3TestingMemcachedHost: memcached1-5
working_dir: ${CORE_ROOT}
extra_hosts:
- "host.docker.internal:host-gateway"
command: >
/bin/sh -c "
if [ ${SCRIPT_VERBOSE} -eq 1 ]; then
set -x
fi
php -v | grep '^PHP'
COMMAND=\"vendor/phpunit/phpunit/phpunit -c Build/phpunit/FunctionalTestsDeprecated.xml ${EXTRA_TEST_OPTIONS} --exclude-group not-mssql ${TEST_FILE}\"
if [ ${PHP_XDEBUG_ON} -eq 0 ]; then
XDEBUG_MODE=\"off\" $${COMMAND};
else
XDEBUG_MODE=\"debug,develop\" \
XDEBUG_TRIGGER=\"foo\" \
XDEBUG_CONFIG=\"client_port=${PHP_XDEBUG_PORT} client_host=host.docker.internal\" \
$${COMMAND};
fi
"
prepare_functional_postgres:
image: alpine:3.8
links:
......
......@@ -423,7 +423,6 @@ class Typo3DatabaseBackendTest extends FunctionalTestCase
* @test
*
* @group not-postgres
* @group not-mssql
* @group not-sqlite
*/
public function flushByTagWorksWithEmptyCacheTablesWithMysql(): void
......@@ -436,7 +435,6 @@ class Typo3DatabaseBackendTest extends FunctionalTestCase
* @test
*
* @group not-postgres
* @group not-mssql
* @group not-sqlite
*/
public function flushByTagsWorksWithEmptyCacheTablesWithMysql(): void
......@@ -449,7 +447,6 @@ class Typo3DatabaseBackendTest extends FunctionalTestCase
* @test
*
* @group not-postgres
* @group not-mssql
* @group not-sqlite
*/
public function flushByTagRemovesCorrectRowsFromDatabaseWithMysql(): void
......@@ -471,7 +468,6 @@ class Typo3DatabaseBackendTest extends FunctionalTestCase
* @test
*
* @group not-postgres
* @group not-mssql
* @group not-sqlite
*/
public function flushByTagsRemovesCorrectRowsFromDatabaseWithMysql(): void
......@@ -547,7 +543,6 @@ class Typo3DatabaseBackendTest extends FunctionalTestCase
* @test
*
* @group not-postgres
* @group not-mssql
* @group not-sqlite
*/
public function collectGarbageWorksWithEmptyTableWithMysql(): void
......@@ -560,7 +555,6 @@ class Typo3DatabaseBackendTest extends FunctionalTestCase
* @test
*
* @group not-postgres
* @group not-mssql
* @group not-sqlite
*/
public function collectGarbageRemovesCacheEntryWithExpiredLifetimeWithMysql(): void
......@@ -593,7 +587,6 @@ class Typo3DatabaseBackendTest extends FunctionalTestCase
* @test
*
* @group not-postgres
* @group not-mssql
* @group not-sqlite
*/
public function collectGarbageRemovesTagEntriesForCacheEntriesWithExpiredLifetimeWithMysql(): void
......@@ -626,7 +619,6 @@ class Typo3DatabaseBackendTest extends FunctionalTestCase
* @test
*
* @group not-postgres
* @group not-mssql
* @group not-sqlite
*/
public function collectGarbageRemovesOrphanedTagEntriesFromTagsTableWithMysql(): void
......
......@@ -203,7 +203,6 @@ class SchemaMigratorTest extends FunctionalTestCase
/**
* @test
* @group not-mssql
*/
public function renameUnusedField(): void
{
......@@ -362,7 +361,6 @@ class SchemaMigratorTest extends FunctionalTestCase
/**
* @test
* @group not-postgres
* @group not-mssql
* @group not-sqlite
*/
public function installCanPerformChangeOperations(): void
......@@ -380,7 +378,6 @@ class SchemaMigratorTest extends FunctionalTestCase
/**
* @test
* @group not-postgres
* @group not-mssql
* @group not-sqlite
*/
public function importStaticDataInsertsRecords(): void
......@@ -408,7 +405,6 @@ class SchemaMigratorTest extends FunctionalTestCase
/**
* @test
* @group not-postgres
* @group not-mssql
* @group not-sqlite
*/
public function changeTableEngine(): void
......
......@@ -89,7 +89,6 @@ class QueryParserTest extends FunctionalTestCase
* Test ColumnMap::RELATION_HAS_MANY
*
* @test
* @group not-mssql
*/
public function queryWithRelationHasManyWithoutParentKeyFieldNameReturnsExpectedResult(): void
{
......
......@@ -51,7 +51,7 @@ class ExportPageTreeViewTest extends AbstractImportExportTestCase
{
// @todo: This test needs an overhaul.
// It fails with mariadb / mysql with "DOMDocument::loadXML(): Namespace prefix xlink for href on use is not defined in Entity, line: 6"
// it fails with sqlite / mssql with data set 0 due to missing '</li></ul>' at the end. ExportPagetTree class issue?
// it fails with sqlite with data set 0 due to missing '</li></ul>' at the end. ExportPagetTree class issue?
self::markTestSkipped();
$this->importDataSet(__DIR__ . '/../Fixtures/DatabaseImports/irre_tutorial.xml');
......
......@@ -171,7 +171,6 @@ class PagesAndTtContentWithImagesInEmptyDatabaseTest extends AbstractImportExpor
/**
* @test
* @group not-mssql
*/
public function importPagesAndRelatedTtContentWithImageWithForcedUids(): void
{
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment