Commit 255bbd79 authored by Christian Kuhn's avatar Christian Kuhn
Browse files

[TASK] CI: Always retry failed jobs once

We restricted the default retry of single jobs a while
ago to do that only for acceptance test related jobs.
This does not work out well: There are simply to many
things that occassionally false-negative due to network,
timing or other issues.
The patch adds general retry:1 for all jobs for mental
sanity.

Resolves: #97597
Related: #96999
Releases: main, 11.5
Change-Id: I408b7ef1b6c6145dc1b5b12bc4550c00dfdaa930
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74584

Tested-by: Stefan Bürk's avatarStefan Bürk <stefan@buerk.tech>
Tested-by: core-ci's avatarcore-ci <typo3@b13.com>
Tested-by: Georg Ringer's avatarGeorg Ringer <georg.ringer@gmail.com>
Tested-by: Christian Kuhn's avatarChristian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Stefan Bürk's avatarStefan Bürk <stefan@buerk.tech>
Reviewed-by: Georg Ringer's avatarGeorg Ringer <georg.ringer@gmail.com>
Reviewed-by: Christian Kuhn's avatarChristian Kuhn <lolli@schwarzbu.ch>
parent a80d02fa
default:
# Always retry a failed job, so it has a chance to recover from a faulty machine, network or timing issue
retry: 1
# Any job taking longer than this is considered 'failed'
timeout: 30m
......
......@@ -15,8 +15,6 @@ acceptance application mariadb php 8.1 locked:
script:
- Build/Scripts/runTests.sh -s composerInstall -p 8.1
- Build/Scripts/runTests.sh -s acceptance -d mariadb -i 10.3 -p 8.1 -c $CI_NODE_INDEX/$CI_NODE_TOTAL
# Always retry a failed job, so it has a chance to recover from a faulty machine or timing issue
retry: 1
acceptance application mariadb php 8.1 max:
stage: acceptance
needs: []
......@@ -38,8 +36,6 @@ acceptance application mariadb php 8.1 max:
script:
- Build/Scripts/runTests.sh -s composerInstallMax -p 8.1
- Build/Scripts/runTests.sh -s acceptance -d mariadb -i 10.3 -p 8.1 -c $CI_NODE_INDEX/$CI_NODE_TOTAL
# Always retry a failed job, so it has a chance to recover from a faulty machine or timing issue
retry: 1
acceptance application mariadb php 8.1 min:
stage: acceptance
needs: []
......@@ -61,8 +57,6 @@ acceptance application mariadb php 8.1 min:
script:
- Build/Scripts/runTests.sh -s composerInstallMin -p 8.1
- Build/Scripts/runTests.sh -s acceptance -d mariadb -i 10.3 -p 8.1 -c $CI_NODE_INDEX/$CI_NODE_TOTAL
# Always retry a failed job, so it has a chance to recover from a faulty machine or timing issue
retry: 1
acceptance application mysql php 8.1 locked:
stage: acceptance
......@@ -81,8 +75,6 @@ acceptance application mysql php 8.1 locked:
script:
- Build/Scripts/runTests.sh -s composerInstall -p 8.1
- Build/Scripts/runTests.sh -s acceptance -d mysql -j 8.0 -p 8.1 -c $CI_NODE_INDEX/$CI_NODE_TOTAL
# Always retry a failed job, so it has a chance to recover from a faulty machine or timing issue
retry: 1
acceptance application mysql php 8.1 max:
stage: acceptance
needs: []
......@@ -104,8 +96,6 @@ acceptance application mysql php 8.1 max:
script:
- Build/Scripts/runTests.sh -s composerInstallMax -p 8.1
- Build/Scripts/runTests.sh -s acceptance -d mysql -j 8.0 -p 8.1 -c $CI_NODE_INDEX/$CI_NODE_TOTAL
# Always retry a failed job, so it has a chance to recover from a faulty machine or timing issue
retry: 1
acceptance application mysql php 8.1 min:
stage: acceptance
needs: []
......@@ -127,8 +117,6 @@ acceptance application mysql php 8.1 min:
script:
- Build/Scripts/runTests.sh -s composerInstallMin -p 8.1
- Build/Scripts/runTests.sh -s acceptance -d mysql -j 8.0 -p 8.1 -c $CI_NODE_INDEX/$CI_NODE_TOTAL
# Always retry a failed job, so it has a chance to recover from a faulty machine or timing issue
retry: 1
acceptance application sqlite php 8.1 locked:
stage: acceptance
......@@ -147,8 +135,6 @@ acceptance application sqlite php 8.1 locked:
script:
- Build/Scripts/runTests.sh -s composerInstall -p 8.1
- Build/Scripts/runTests.sh -s acceptance -d sqlite -p 8.1 -c $CI_NODE_INDEX/$CI_NODE_TOTAL
# Always retry a failed job, so it has a chance to recover from a faulty machine or timing issue
retry: 1
acceptance application sqlite php 8.1 max:
stage: acceptance
needs: []
......@@ -170,8 +156,6 @@ acceptance application sqlite php 8.1 max:
script:
- Build/Scripts/runTests.sh -s composerInstallMax -p 8.1
- Build/Scripts/runTests.sh -s acceptance -d sqlite -p 8.1 -c $CI_NODE_INDEX/$CI_NODE_TOTAL
# Always retry a failed job, so it has a chance to recover from a faulty machine or timing issue
retry: 1
acceptance application sqlite php 8.1 min:
stage: acceptance
needs: []
......@@ -193,8 +177,6 @@ acceptance application sqlite php 8.1 min:
script:
- Build/Scripts/runTests.sh -s composerInstallMin -p 8.1
- Build/Scripts/runTests.sh -s acceptance -d sqlite -p 8.1 -c $CI_NODE_INDEX/$CI_NODE_TOTAL
# Always retry a failed job, so it has a chance to recover from a faulty machine or timing issue
retry: 1
# @todo New acceptance tests with postgres has some issues, so we leave them
# disabled for now before adding more unstable acceptance tests.
......@@ -212,8 +194,6 @@ acceptance application sqlite php 8.1 min:
# script:
# - Build/Scripts/runTests.sh -s composerInstall -p 8.1
# - Build/Scripts/runTests.sh -s acceptance -d postgres -k 10 -p 8.1 -c $CI_NODE_INDEX/$CI_NODE_TOTAL
# # Always retry a failed job, so it has a chance to recover from a faulty machine or timing issue
# retry: 1
#acceptance application postgres php 8.1 max:
# stage: acceptance
# needs: []
......@@ -232,8 +212,6 @@ acceptance application sqlite php 8.1 min:
# script:
# - Build/Scripts/runTests.sh -s composerInstallMax -p 8.1
# - Build/Scripts/runTests.sh -s acceptance -d postgres -k 10 -p 8.1 -c $CI_NODE_INDEX/$CI_NODE_TOTAL
# # Always retry a failed job, so it has a chance to recover from a faulty machine or timing issue
# retry: 1
#acceptance application postgres php 8.1 min:
# stage: acceptance
# needs: []
......@@ -252,5 +230,3 @@ acceptance application sqlite php 8.1 min:
# script:
# - Build/Scripts/runTests.sh -s composerInstallMin -p 8.1
# - Build/Scripts/runTests.sh -s acceptance -d postgres -k 10 -p 8.1 -c $CI_NODE_INDEX/$CI_NODE_TOTAL
# # Always retry a failed job, so it has a chance to recover from a faulty machine or timing issue
# retry: 1
......@@ -13,8 +13,6 @@ acceptance install mariadb php 8.1 locked:
script:
- Build/Scripts/runTests.sh -s composerInstall -p 8.1
- Build/Scripts/runTests.sh -s acceptanceInstall -d mariadb -i 10.3 -p 8.1
# Always retry a failed job, so it has a chance to recover from a faulty machine or timing issue
retry: 1
acceptance install mariadb php 8.1 max:
stage: acceptance
needs: []
......@@ -31,8 +29,6 @@ acceptance install mariadb php 8.1 max:
script:
- Build/Scripts/runTests.sh -s composerInstallMax -p 8.1
- Build/Scripts/runTests.sh -s acceptanceInstall -d mariadb -i 10.3 -p 8.1
# Always retry a failed job, so it has a chance to recover from a faulty machine or timing issue
retry: 1
acceptance install mariadb php 8.1 min:
stage: acceptance
needs: []
......@@ -52,8 +48,6 @@ acceptance install mariadb php 8.1 min:
script:
- Build/Scripts/runTests.sh -s composerInstallMin -p 8.1
- Build/Scripts/runTests.sh -s acceptanceInstall -d mariadb -i 10.3 -p 8.1
# Always retry a failed job, so it has a chance to recover from a faulty machine or timing issue
retry: 1
acceptance install mysql php 8.1 locked:
stage: acceptance
......@@ -70,8 +64,6 @@ acceptance install mysql php 8.1 locked:
script:
- Build/Scripts/runTests.sh -s composerInstall -p 8.1
- Build/Scripts/runTests.sh -s acceptanceInstall -d mysql -j 8.0 -p 8.1
# Always retry a failed job, so it has a chance to recover from a faulty machine or timing issue
retry: 1
acceptance install mysql php 8.1 max:
stage: acceptance
needs: []
......@@ -91,8 +83,6 @@ acceptance install mysql php 8.1 max:
script:
- Build/Scripts/runTests.sh -s composerInstallMax -p 8.1
- Build/Scripts/runTests.sh -s acceptanceInstall -d mysql -j 8.0 -p 8.1
# Always retry a failed job, so it has a chance to recover from a faulty machine or timing issue
retry: 1
acceptance install mysql php 8.1 min:
stage: acceptance
needs: []
......@@ -112,8 +102,6 @@ acceptance install mysql php 8.1 min:
script:
- Build/Scripts/runTests.sh -s composerInstallMin -p 8.1
- Build/Scripts/runTests.sh -s acceptanceInstall -d mysql -j 8.0 -p 8.1
# Always retry a failed job, so it has a chance to recover from a faulty machine or timing issue
retry: 1
acceptance install postgres php 8.1 locked:
stage: acceptance
......@@ -130,8 +118,6 @@ acceptance install postgres php 8.1 locked:
script:
- Build/Scripts/runTests.sh -s composerInstall -p 8.1
- Build/Scripts/runTests.sh -s acceptanceInstall -d postgres -k 10 -p 8.1
# Always retry a failed job, so it has a chance to recover from a faulty machine or timing issue
retry: 1
acceptance install postgres php 8.1 max:
stage: acceptance
needs: []
......@@ -151,8 +137,6 @@ acceptance install postgres php 8.1 max:
script:
- Build/Scripts/runTests.sh -s composerInstallMax -p 8.1
- Build/Scripts/runTests.sh -s acceptanceInstall -d postgres -k 10 -p 8.1
# Always retry a failed job, so it has a chance to recover from a faulty machine or timing issue
retry: 1
acceptance install postgres php 8.1 min:
stage: acceptance
needs: []
......@@ -172,8 +156,6 @@ acceptance install postgres php 8.1 min:
script:
- Build/Scripts/runTests.sh -s composerInstallMin -p 8.1
- Build/Scripts/runTests.sh -s acceptanceInstall -d postgres -k 10 -p 8.1
# Always retry a failed job, so it has a chance to recover from a faulty machine or timing issue
retry: 1
acceptance install sqlite php 8.1 locked:
stage: acceptance
......@@ -190,8 +172,6 @@ acceptance install sqlite php 8.1 locked:
script:
- Build/Scripts/runTests.sh -s composerInstall -p 8.1
- Build/Scripts/runTests.sh -s acceptanceInstall -d sqlite -p 8.1
# Always retry a failed job, so it has a chance to recover from a faulty machine or timing issue
retry: 1
acceptance install sqlite php 8.1 max:
stage: acceptance
needs: []
......@@ -211,8 +191,6 @@ acceptance install sqlite php 8.1 max:
script:
- Build/Scripts/runTests.sh -s composerInstallMax -p 8.1
- Build/Scripts/runTests.sh -s acceptanceInstall -d sqlite -p 8.1
# Always retry a failed job, so it has a chance to recover from a faulty machine or timing issue
retry: 1
acceptance install sqlite php 8.1 min:
stage: acceptance
needs: []
......@@ -232,5 +210,3 @@ acceptance install sqlite php 8.1 min:
script:
- Build/Scripts/runTests.sh -s composerInstallMin -p 8.1
- Build/Scripts/runTests.sh -s acceptanceInstall -d sqlite -p 8.1
# Always retry a failed job, so it has a chance to recover from a faulty machine or timing issue
retry: 1
......@@ -16,5 +16,3 @@ acceptance application mariadb php 8.1 pre-merge:
script:
- Build/Scripts/runTests.sh -s composerInstall -p 8.1
- Build/Scripts/runTests.sh -s acceptance -p 8.1 -d mariadb -i 10.3 -c $CI_NODE_INDEX/$CI_NODE_TOTAL
# Always retry a failed job, so it has a chance to recover from a faulty machine or timing issue
retry: 1
......@@ -14,8 +14,6 @@ acceptance install mariadb php 8.1 pre-merge:
script:
- Build/Scripts/runTests.sh -s composerInstall -p 8.1
- Build/Scripts/runTests.sh -s acceptanceInstall -d mariadb -i 10.3 -p 8.1
# Always retry a failed job, so it has a chance to recover from a faulty machine or timing issue
retry: 1
acceptance install mysql php 8.1 pre-merge:
stage: main
......@@ -33,8 +31,6 @@ acceptance install mysql php 8.1 pre-merge:
script:
- Build/Scripts/runTests.sh -s composerInstall -p 8.1
- Build/Scripts/runTests.sh -s acceptanceInstall -d mysql -j 8.0 -p 8.1
# Always retry a failed job, so it has a chance to recover from a faulty machine or timing issue
retry: 1
acceptance install postgres php 8.1 pre-merge:
stage: main
......@@ -52,8 +48,6 @@ acceptance install postgres php 8.1 pre-merge:
script:
- Build/Scripts/runTests.sh -s composerInstall -p 8.1
- Build/Scripts/runTests.sh -s acceptanceInstall -d postgres -k 10 -p 8.1
# Always retry a failed job, so it has a chance to recover from a faulty machine or timing issue
retry: 1
acceptance install sqlite php 8.1 pre-merge:
stage: main
......@@ -71,5 +65,3 @@ acceptance install sqlite php 8.1 pre-merge:
script:
- Build/Scripts/runTests.sh -s composerInstall -p 8.1
- Build/Scripts/runTests.sh -s acceptanceInstall -d sqlite -p 8.1
# Always retry a failed job, so it has a chance to recover from a faulty machine or timing issue
retry: 1
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment