-
Helmut Hummel authored
The code for the web installer and the cli installer is only partly aligned and shared, thus may easily diverge, leading to different installation results. The code to create system settings is now put into SetupService and is used for both installation methods, so that the cli install now also uses FactoryConfiguration.php. Additionally, the following cleanups are performed to prepare further cleanup of the installation process: * The cli setup does not set insecure trustedHostPattern any more. * Silent config and template file changes are removed from setup, as conceptually these do nothing on newly created config and template files. * New exceptions are created for config file generation instead of misusing a FAL-related exception. * Absolute paths are made relative to project path before being passed to exception. Resolves: #102403 Releases: main, 12.4 Change-Id: I069e9e9f4136bba56d630eaf09f676b6c5ea7904 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81793 Tested-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
Helmut Hummel <typo3@helhum.io> Reviewed-by:
Helmut Hummel <typo3@helhum.io> Tested-by:
core-ci <typo3@b13.com>
b89aad13Helmut Hummel authoredThe code for the web installer and the cli installer is only partly aligned and shared, thus may easily diverge, leading to different installation results. The code to create system settings is now put into SetupService and is used for both installation methods, so that the cli install now also uses FactoryConfiguration.php. Additionally, the following cleanups are performed to prepare further cleanup of the installation process: * The cli setup does not set insecure trustedHostPattern any more. * Silent config and template file changes are removed from setup, as conceptually these do nothing on newly created config and template files. * New exceptions are created for config file generation instead of misusing a FAL-related exception. * Absolute paths are made relative to project path before being passed to exception. Resolves: #102403 Releases: main, 12.4 Change-Id: I069e9e9f4136bba56d630eaf09f676b6c5ea7904 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81793 Tested-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
Helmut Hummel <typo3@helhum.io> Reviewed-by:
Helmut Hummel <typo3@helhum.io> Tested-by:
core-ci <typo3@b13.com>
Loading