Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • typo3 typo3
  • Project information
    • Project information
    • Activity
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • CI/CD
    • Insights
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • typo3typo3
  • typo3typo3
  • Repository
Switch branch/tag
  • typo3
  • typo3
  • sysext
  • backend
  • Classes
  • Controller
  • PageLayoutController.php
Find file BlameHistoryPermalink
  • Oliver Bartsch's avatar
    [BUGFIX] Calculate action menu generation earlier in PageLayoutController · d85d3626
    Oliver Bartsch authored Jan 11, 2022
    With #95387 the menu generation of the page module
    was moved to the end of the request handling method.
    
    However, the `makeActionMenu()` method does currently
    not only create the menu but does also make some sanity
    check, whether the currently selected `function` is actually
    available.
    
    If not, the `function` is reset to the default ("columns mode").
    This e.g. happens when in languages mode and then switching
    to another domain / another site, which is single language only.
    This then led to the user being unable to work in "columns mode",
    since no action menu is generated for such sites.
    
    This is now fixed by executing the mentioned method before the
    content gets generated.
    
    Resolves: #96084
    Related: #95387
    Releases: main, 11.5
    Change-Id: Iadb67ece1724b6d34a4724d7782bdd295cece642
    Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72971
    
    
    Tested-by: core-ci's avatarcore-ci <typo3@b13.com>
    Tested-by: Benni Mack's avatarBenni Mack <benni@typo3.org>
    Tested-by: Jochen's avatarJochen <rothjochen@gmail.com>
    Tested-by: Oliver Bartsch's avatarOliver Bartsch <bo@cedev.de>
    Reviewed-by: Benni Mack's avatarBenni Mack <benni@typo3.org>
    Reviewed-by: Jochen's avatarJochen <rothjochen@gmail.com>
    Reviewed-by: Oliver Bartsch's avatarOliver Bartsch <bo@cedev.de>
    d85d3626