Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • typo3 typo3
  • Project information
    • Project information
    • Activity
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • CI/CD
    • Insights
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • typo3typo3
  • typo3typo3
  • Repository
Switch branch/tag
  • typo3
  • ..
  • Repository
  • PageRepository.php
Find file BlameHistoryPermalink
  • Benni Mack's avatar
    [!!!][TASK] Return moved PID when overlaying versioned records · c8495412
    Benni Mack authored Oct 18, 2020 and Christian Kuhn's avatar Christian Kuhn committed Oct 19, 2020
    In the past, the API methods:
    * PageRepository->versionOL()
    * BackendUtility::workspaceOL()
    
    returned the PID of the moved record in a workspace in the field
    _ORIG_PID and the live record value in "pid".
    
    The methods "fixVersioningPid()" were used to return the
    moved PID (of the versioned records) and set the "_ORIG_PID"
    to the value of the live record.
    
    This inconsistency can be overcome by simply using workspaceOL
    returning the newly moved location as "pid" and keep the "_ORIG_pid"
    of the live record for later purposes.
    
    This way, fixVersioningPid is not needed anymore, if workspaceOL/versionOL
    is applied. TYPO3 Core is not using the fixVersioningPid methods
    anymore now and they are marked as deprecated.
    
    As this is a breaking change ("behavior of overlay and value of _ORIG_pid")
    an RST explains the new behavior.
    
    Resolves: #92598
    Releases: master
    Change-Id: I618d282d490b386e1a75caae3ab657f1605e3cb3
    Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66169
    
    
    Tested-by: Anja Leichsenring's avatarAnja Leichsenring <aleichsenring@ab-softlab.de>
    Tested-by: default avatarTYPO3com <noreply@typo3.com>
    Tested-by: Christian Kuhn's avatarChristian Kuhn <lolli@schwarzbu.ch>
    Reviewed-by: Anja Leichsenring's avatarAnja Leichsenring <aleichsenring@ab-softlab.de>
    Reviewed-by: Christian Kuhn's avatarChristian Kuhn <lolli@schwarzbu.ch>
    c8495412