Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • typo3 typo3
  • Project information
    • Project information
    • Activity
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • CI/CD
    • Insights
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • typo3typo3
  • typo3typo3
  • Repository
Switch branch/tag
  • typo3
  • ..
  • Repository
  • PageRepository.php
Find file BlameHistoryPermalink
  • Christian Kuhn's avatar
    [BUGFIX] Avoid improper method call in PageRepositoryTest · b5c631ed
    Christian Kuhn authored Oct 13, 2021
    Some PageRepositoryTest tests call getMenu() with a
    restricted set of select fields as second argument.
    
    Running this test without error suppression reveals
    the code accesses db fields like 'doktype' which are
    not fetched with a restricted field list.
    
    The patch changes the test method calls to not restrict
    the field list to fix the test, and adds a @todo in
    PageRepository to review the $fields argument with a
    future patch so the code does not rely on a possibly
    incomplete list of fields anymore.
    
    Resolves: #95634
    Releases: master
    Change-Id: Ib4c6f2f22a4222b1383fcdbf554d4fe78c919626
    Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71632
    
    
    Tested-by: core-ci's avatarcore-ci <typo3@b13.com>
    Tested-by: Stefan Bürk's avatarStefan Bürk <stefan@buerk.tech>
    Tested-by: Jochen's avatarJochen <rothjochen@gmail.com>
    Tested-by: Christian Kuhn's avatarChristian Kuhn <lolli@schwarzbu.ch>
    Reviewed-by: Stefan Bürk's avatarStefan Bürk <stefan@buerk.tech>
    Reviewed-by: Jochen's avatarJochen <rothjochen@gmail.com>
    Reviewed-by: Christian Kuhn's avatarChristian Kuhn <lolli@schwarzbu.ch>
    b5c631ed