Skip to content
  • Christian Kuhn's avatar
    [TASK] Deprecate ConfigurationForm · 906684cb
    Christian Kuhn authored
    The call tree of the extension manager "configuration form"
    ext_conf_template.txt parser is a mess:
    The ext:extensionmanager ConfigurationUtility calls ext:core
    ConfigurationForm which is a class that extends ExtendedTemplateService
    which extends TemplateService. The "TypoScript" a-like parsing then uses
    class TypoScriptParser. This compiles to a huge list of dependencies.
    
    The patch compiles this mess down to a series of methods within
    ConfigurationUtility directly, effectively adding needed parts
    of TypoScriptParser and ConfigurationForm as protected methods.
    The class ends up with way less direct and indirect dependencies.
    
    The various detail parsing methods are still messy and hard to follow,
    but rewriting the parser heart does not really make sense since the
    ext_conf_template.txt format will bite the dust sooner or later anyway
    and having all in one place is already much better than before.
    So putting some days of energy into rewriting these specific parts
    of the TypoScript parsing did not seem to be worth it, even if it in
    the end could probably solved with 1/4 of code.
    
    Class ConfigurationForm is deprecated but could also be removed
    as breaking patch later if anyone wants to refactor the remaining
    ExtendedTemplateService and TemplateService classes in v9.
    
    Note this patch is an intermediate step before the ConfigurationUtility
    class form ext:em is moved into the install tool.
    
    Change-Id: I62d9fafb6444d954e17c980358e6367a83b033b8
    Resolves: #82725
    Releases: master
    Reviewed-on: https://review.typo3.org/54362
    
    
    Reviewed-by: default avatarSusanne Moog <susanne.moog@typo3.org>
    Tested-by: default avatarSusanne Moog <susanne.moog@typo3.org>
    Tested-by: default avatarTYPO3com <no-reply@typo3.com>
    Reviewed-by: default avatarWouter Wolters <typo3@wouterwolters.nl>
    Reviewed-by: default avatarMona Muzaffar <mona.muzaffar@gmx.de>
    Tested-by: default avatarMona Muzaffar <mona.muzaffar@gmx.de>
    Reviewed-by: default avatarChristian Kuhn <lolli@schwarzbu.ch>
    Tested-by: default avatarChristian Kuhn <lolli@schwarzbu.ch>
    906684cb