Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • typo3 typo3
  • Project information
    • Project information
    • Activity
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • CI/CD
    • Insights
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • typo3typo3
  • typo3typo3
  • Repository
  • typo3
  • ..
  • Utility
  • GeneralUtilityTest.php
Find file BlameHistoryPermalink
  • Oliver Klee's avatar
    [TASK] Ignore PHPStan errors in GeneralUtilityTest for contract violations · 8c28103c
    Oliver Klee authored May 07, 2022 and Christian Kuhn's avatar Christian Kuhn committed May 08, 2022
    In tests for `GeneralUtility` that explicitly violate the contract
    (and test the correct error handling in those cases), PHPStan errors about
    the contract violation are not helpful and rather clutter the
    PHPStan baseline.
    
    So these errors are now silenced with an annotation in the corresponding
    tests, allowing us to focus on PHPStan errors about actual issues.
    
    Note: We only use this annotation in tests, not in production code,
    to avoid silencing errors about actual problems.
    
    Resolves: #97574
    Releases: main, 11.5
    Change-Id: I2586dd77a4e3f9d801e24af68ab29984ad8d02c5
    Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74547
    
    
    Tested-by: Nikita Hovratov's avatarNikita Hovratov <nikita.h@live.de>
    Tested-by: core-ci's avatarcore-ci <typo3@b13.com>
    Tested-by: Christian Kuhn's avatarChristian Kuhn <lolli@schwarzbu.ch>
    Reviewed-by: Nikita Hovratov's avatarNikita Hovratov <nikita.h@live.de>
    Reviewed-by: Christian Kuhn's avatarChristian Kuhn <lolli@schwarzbu.ch>
    8c28103c