• Christian Kuhn's avatar
    [TASK] Streamline TSconfig API · 45c582a8
    Christian Kuhn authored
    Final patch to de-mess the user / page TSconfig related API.
    
    Page TSconfig can be overriden in user TSconfig by prefixing the
    path with 'page.' in user TSconfig. However, method
    BackendUtility::getModTSconfig() violated this principle and
    had a special merge strategy that allowed ommitting the 'page.'
    prefix. This has been marked as deprecated in the TSconfig docs for
    various years and has been lately removed in the docs altogether,
    but the code still existed.
    The patch moves this merge into BackendUtility::getPagesTSconfig()
    and properly deprecates this case. Usages of getModTSconfig() are
    changed to use getPagesTSconfig() directly, dropping the artificial
    'properties' and 'value' sub arrays and omitting some rather expensive
    string operations at the same time.
    This obsoletes getModTSconfig() and a couple of related methods.
    
    Additionally, BackendUserAuthentication->getTSConfig() has been
    abused frequently to operate on different arrays than it's own userTS.
    Those usages are dropped with the patch. Handing over arguments to
    getTSConfig() is now deprecated, effectively reducing the method a getter.
    
    This reduces the API down to BackendUtility::getPagesTSconfig($pid)
    and BackendUserAuhtentiction->getTSConfig() both just returning the
    entire array. This simplified API can now be documented in the docs.
    
    Change-Id: I4bbb066c1d4e2edbc0182f7967897a1558cc3c0d
    Resolves: #85016
    Related: #84982
    Releases: master
    Reviewed-on: https://review.typo3.org/56968
    
    
    Tested-by: default avatarTYPO3com <no-reply@typo3.com>
    Reviewed-by: Jan Helke's avatarJan Helke <typo3@helke.de>
    Tested-by: Jan Helke's avatarJan Helke <typo3@helke.de>
    Reviewed-by: Anja Leichsenring's avatarAnja Leichsenring <aleichsenring@ab-softlab.de>
    Tested-by: Anja Leichsenring's avatarAnja Leichsenring <aleichsenring@ab-softlab.de>
    Reviewed-by: Christian Kuhn's avatarChristian Kuhn <lolli@schwarzbu.ch>
    Tested-by: Christian Kuhn's avatarChristian Kuhn <lolli@schwarzbu.ch>
    45c582a8