Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • typo3 typo3
  • Project information
    • Project information
    • Activity
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Insights
    • Issue
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • typo3
  • typo3typo3
  • Repository
Switch branch/tag
  • typo3
  • typo3
  • sysext
  • core
  • Classes
  • DataHandling
  • DataHandler.php
Find file BlameHistoryPermalink
  • Benni Mack's avatar
    [BUGFIX] Remove DataHandler->newlog() functionality · 4586d38c
    Benni Mack authored Jul 31, 2021 and Andreas Fernandez's avatar Andreas Fernandez committed Aug 03, 2021
    This change removes the internal "newlog()" method
    from DataHandler. All occurrences are replaced
    by DataHandler->log() methods, which newlog() acted as
    a wrapper for it.
    
    The main downside of newlog() is that the connection
    to the actual record (when writing to sys_log) is lost,
    and no contextual information is kept.
    
    This change solves that problem by properly setting
    the table and record uid to the log method.
    
    The main usages for DataHandler->newlog() are
    put into localization and workspaces/versionable
    handling. where the "action" is currently set
    to SystemLogGenericAction::UNDEFINED, because
    there is no specific type for them. Specific action
    types have been added for localize, versionize and
    publishing.
    
    The next step in this line of patches are:
    * Clean up the labels by always using %s or {} for replacements.
    
    Resolves: #94685
    Releases: master
    Change-Id: If943dbaba39e1a9c16028b8c64e18b4b42aba902
    Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70171
    
    Tested-by: core-ci's avatarcore-ci <typo3@b13.com>
    Tested-by: Anja Leichsenring's avatarAnja Leichsenring <aleichsenring@ab-softlab.de>
    Tested-by: Andreas Fernandez's avatarAndreas Fernandez <a.fernandez@scripting-base.de>
    Reviewed-by: Anja Leichsenring's avatarAnja Leichsenring <aleichsenring@ab-softlab.de>
    Reviewed-by: Andreas Fernandez's avatarAndreas Fernandez <a.fernandez@scripting-base.de>
    4586d38c