Christian Kuhn authored Aug 05, 2020 and Benni Mack committed Aug 06, 2020

Another 'broken since ever' fix: Sorting a record in
workspaces by moving it 'after itself', the record vanishes
from the interface. While this action is kinda useless,
it can for instance accidently happen by an editor.

As with other move operations in workspaces, a move
placeholder and the versioned data record is created.
In case of inserting after itself, the move placeholder
state is not correctly updated - both pid and sorting
values end up with 0. The records then no longer belong
to the correct pid and are not 'seen' by workspaces.

The patch fixes this case by making sure the pid and sorting
determination of the move placeholder does not accidently
operate on itself as reference record. A series of functional
DataHandler tests nail the correct state for pages and
tt_content in non-workspace and workspace scenarios.

Resolves: #53619
Releases: master, 10.4
Change-Id: I39b5e9f72bd05645dcd429bed3833d2a792efaec
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65171


Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>