Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • typo3 typo3
  • Project information
    • Project information
    • Activity
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • CI/CD
    • Insights
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • typo3typo3
  • typo3typo3
  • Repository
Switch branch/tag
  • typo3
  • typo3
  • sysext
  • frontend
  • Classes
  • Http
  • RequestHandler.php
Find file BlameHistoryPermalink
  • Helmut Hummel's avatar
    [BUGFIX] Only allow scalar values in AssetCollector · 2a0218b6
    Helmut Hummel authored Feb 28, 2020 and Daniel Goerz's avatar Daniel Goerz committed Feb 29, 2020
    Since AssetCollector needs to be serialized,
    or to be more precise its state need to be cached as string,
    we must avoid that state is stored that isn't serializable.
    
    Therefore we adapt the API to reflect this and change
    the API calls to not add non serializable objects.
    
    With this change we also revert the previous USER_INT fix
    that bound the AssetCollector unnecessarily to PageRenderer
    and store it serialized in cache (the deserialization was
    already part of the code of the commit that introduced
    the AssetCollector).
    
    Reverts: #90537
    Resolves: #90565
    Releases: master
    Change-Id: I59f10b608e5f270aaacde63bcd347116910aac7a
    Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63488
    
    
    Tested-by: default avatarTYPO3com <noreply@typo3.com>
    Tested-by: Susanne Moog's avatarSusanne Moog <look@susi.dev>
    Tested-by: Daniel Goerz's avatarDaniel Goerz <daniel.goerz@posteo.de>
    Reviewed-by: Susanne Moog's avatarSusanne Moog <look@susi.dev>
    Reviewed-by: Daniel Goerz's avatarDaniel Goerz <daniel.goerz@posteo.de>
    2a0218b6