Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • typo3 typo3
  • Project information
    • Project information
    • Activity
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • CI/CD
    • Insights
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • typo3typo3
  • typo3typo3
  • Repository
Switch branch/tag
  • typo3
  • typo3
  • sysext
  • backend
  • Classes
  • Controller
  • PageLayoutController.php
Find file BlameHistoryPermalink
  • Benni Mack's avatar
    [TASK] Reduce inline JavaScript in Page Module Paste logic · 290d9d2c
    Benni Mack authored Aug 12, 2021
    When having a content element on the clipboard (normal mode)
    the page module dynamically shows paste icons
    everywhere.
    
    This change centralizes the generation of the Paste icons
    into JavaScript, so the inline javascript usage of "top.*"
    functionality to park code somewhere has been removed,
    and the actual items are generated in JavaScript.
    
    In addition, as this code is only affecting the page module
    when a tt_content element is on the clipboard, the Paste.js
    JS module is only loaded when appropriate, thus reducing
    the actual loading time for "regular" visits on the Page Module.
    
    The icon in the paste button is now loaded via a native web component,
    and only necessary logic is used in the Paste JS module.
    
    The outer rendering for the Page Module has been simplified,
    moving this functionality all into PageLayoutController,
    reducing cross-dependencies between the PageLayout* classes.
    
    Resolves: #94840
    Releases: master
    Change-Id: I380df9a56bfff74684616732166f25c68bbc6dec
    Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70488
    
    
    Tested-by: core-ci's avatarcore-ci <typo3@b13.com>
    Tested-by: Jochen's avatarJochen <rothjochen@gmail.com>
    Tested-by: Oliver Bartsch's avatarOliver Bartsch <bo@cedev.de>
    Tested-by: Benni Mack's avatarBenni Mack <benni@typo3.org>
    Reviewed-by: Wouter Wolters's avatarWouter Wolters <typo3@wouterwolters.nl>
    Reviewed-by: Jochen's avatarJochen <rothjochen@gmail.com>
    Reviewed-by: Oliver Bartsch's avatarOliver Bartsch <bo@cedev.de>
    Reviewed-by: Benni Mack's avatarBenni Mack <benni@typo3.org>
    290d9d2c