Commits · main.74814.6 · typo3 / CI / CMS

07 Jun, 2022 3 commits

[TASK] Add functional tests for indexed_search · ba720712

Florian Schöppe authored Jun 03, 2022 and

Stefan Bürk committed Jun 07, 2022

Added tests for:
- indexing contents and words
- a basic search
- metaphone search

Resolves: #97732
Releases: main, 11.5, 10.4
Change-Id: Id56e09f129de4bd13092f584e97eedc9fd326b5c

ba720712

[DOCS] Make example more general to not confuse · 3d1b0a08

Lina Wolf authored Jun 06, 2022 and

Oliver Bartsch committed Jun 07, 2022

Releases: main
Resolves: #97735
Change-Id: I703595777f4bb7727cc72b7ab92cb2446f3cf30e
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74820

Tested-by: core-ci <typo3@b13.com>
Tested-by: Simon Schaufelberger <simonschaufi+typo3@gmail.com>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Simon Schaufelberger <simonschaufi+typo3@gmail.com>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>

3d1b0a08

[BUGFIX] Avoid invalid type exception in FinisherVariableProvider · 70ed0ede

Josua Vogel authored May 27, 2022 and

Oliver Bartsch committed Jun 07, 2022

Guard invalid argument type exception by using null coalescing operator
in `\TYPO3\CMS\Form\Domain\Finishers\FinisherVariableProvider`.

Resolves: #97699
Releases: main, 11.5
Change-Id: I6312fb35d52857004e0467a20e215fc4095e0037
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74775

Tested-by: Stefan Bürk <stefan@buerk.tech>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: crell <larry@garfieldtech.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>

70ed0ede

06 Jun, 2022 5 commits

[TASK] Solve several phpstan issues in GifBuilder · f9c1ed54

Simon Schaufelberger authored May 25, 2022 and

Stefan Bürk committed Jun 06, 2022

Also add some (indirect) basic tests for
GifBuilder::calculateValue.

Used command:

> Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Resolves: #97690
Releases: main, 11.5
Change-Id: I836db8570f64ecb2729c1707fcfe9fc1af672151
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74743

Tested-by: Oliver Klee <typo3-coding@oliverklee.de>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>

f9c1ed54

[BUGFIX] Fix randomly failing PageTreeFilterCest · 520ecd36

Simon Schaufelberger authored May 31, 2022 and

Stefan Bürk committed Jun 06, 2022

Sometimes it happens that the page tree is not updated
within a certain amount of time resulting in failing tests.
This patch will add a timeout and makes sure that the page
tree is updated.

Resolves: #97714
Releases: main, 11.5
Change-Id: Id28d955ccda6838701aea63e6aa97b5ee9c602b5
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74793

Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Klee <typo3-coding@oliverklee.de>
Tested-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>

520ecd36

[BUGFIX] Avoid type error when importing content · f32e7128

Chris Müller authored Jun 05, 2022 and

Stefan Bürk committed Jun 06, 2022

Resolves: #97658
Releases: main, 11.5
Change-Id: Ic4e18d64849e64404dca0eef240060d882476526
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74817

Tested-by: core-ci <typo3@b13.com>
Tested-by: Simon Schaufelberger <simonschaufi+typo3@gmail.com>
Tested-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Simon Schaufelberger <simonschaufi+typo3@gmail.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>

f32e7128

[BUGFIX] Make file paths absolute in GIFBUILDER · 7a3202cb

Simon Schaufelberger authored Mar 15, 2022 and

Stefan Bürk committed Jun 06, 2022

In CLI context the full path to the temporary generated file by the
GIFBUILDER can't be resolved. Because of this inconsistency, absolute
file paths are used from now on.

Resolves: #95379
Releases: main
Change-Id: If3a8613ed8e8d11a1b8a474fa564f947ef8a5c0c
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73932

Tested-by: core-ci <typo3@b13.com>
Tested-by: Nikita Hovratov <nikita.h@live.de>
Tested-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Nikita Hovratov <nikita.h@live.de>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>

7a3202cb

[TASK] Drop PhpStorm meta configuration for getAccessibleMock & friends · 1088be60

Oliver Klee authored Jun 06, 2022 and

Stefan Bürk committed Jun 06, 2022

This is now covered by the annotations using generics in the testing
framework base class, and hence not needed anymore.

(Removing it also helps get consistent behavior from PhpStorm's
static type analysis.)

Resolves: #97736
Releases: main, 11.5, 10.4
Change-Id: Ia7d7e790bb92eaf1c9b7ffa4f9d97b2b0a50dee3
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74822

Tested-by: core-ci <typo3@b13.com>
Tested-by: Simon Schaufelberger <simonschaufi+typo3@gmail.com>
Tested-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Simon Schaufelberger <simonschaufi+typo3@gmail.com>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>

1088be60

04 Jun, 2022 3 commits

[BUGFIX] Align translation prefix handling in DataMapProcessor · 410d2899

Oliver Bartsch authored Jun 03, 2022 and

Nikita Hovratov committed Jun 05, 2022

For translating / synchronizing (inline) records, the DataHandler
dispatches the data map to the DataMapProcessor. This components'
implementation of the translation prefix however differed from the
one in DataHandler, leading to inconsistency, as some fields still
got the "Translate to:" prefix added, while others did not.

This is now fixed by aligning the functionality with the one
used in the DataHandler.

Resolves: #97721
Releases: main, 11.5
Change-Id: I425ca172f2c66cf43613fb62be0e35fa1dff76fe
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74815

Tested-by: core-ci <typo3@b13.com>
Tested-by: Stefan Bürk <stefan@buerk.tech>
Tested-by: Nikita Hovratov <nikita.h@live.de>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Nikita Hovratov <nikita.h@live.de>

410d2899

[BUGFIX] Respect ordering in pagination of redirect module · 2dd3daa5

Georg Ringer authored May 17, 2022 and

Nikita Hovratov committed Jun 04, 2022

The pagination links of the redirects module must respect a given
ordering.

Resolves: #97645
Releases: main, 11.5
Change-Id: Iaa65b8e365e9014796c463118504182f66b49ccb
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74673

Tested-by: core-ci <typo3@b13.com>
Tested-by: Stefan Bürk <stefan@buerk.tech>
Tested-by: Nikita Hovratov <nikita.h@live.de>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Nikita Hovratov <nikita.h@live.de>

2dd3daa5

[BUGFIX] Fix crashes for current and getInfo on empty storages · e08c44bf

Oliver Klee authored Apr 18, 2022 and

Stefan Bürk committed Jun 04, 2022

For empty storages, we need to avoid accessing inexistent array elements.

Resolves: #97417
Relates: #97554
Releases: main, 11.5
Change-Id: Ieee36b4c0ede9726ce936030f631a3322e3813a9
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74342

Tested-by: core-ci <typo3@b13.com>
Tested-by: Simon Schaufelberger <simonschaufi+typo3@gmail.com>
Tested-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: crell <larry@garfieldtech.com>
Reviewed-by: Simon Schaufelberger <simonschaufi+typo3@gmail.com>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>

e08c44bf

03 Jun, 2022 8 commits

[BUGFIX] Use configuration context for placeholders in YAML import · 3dc65515

Sascha Egerer authored Nov 30, 2020 and

Oliver Bartsch committed Jun 03, 2022

The placeholder replacement in the yaml import method must receive
the current configuration context to be able to replace placeholders
with values that are already configured instead of the subvalues of
the import statement.

Resolves: #92956
Releases: main, 11.5
Change-Id: I4766bf1e6d268bb4c1bdd24e638c9b5056e600b8
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66946

Tested-by: Daniel Goerz <daniel.goerz@b13.com>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Daniel Goerz <daniel.goerz@b13.com>
Reviewed-by: Oliver Bartsch <bo@cedev.de>

3dc65515

[TASK] Add functional tests to test the caching behavior of ext:form · 73ed5173

waldhacker authored Feb 25, 2022 and

Stefan Bürk committed Jun 03, 2022

In preparation for patchset
https://review.typo3.org/c/Packages/TYPO3.CMS/+/70460/,
functional tests are introduced to test the caching behavior
of EXT:form.

Resolves: #97049
Related: #93887
Releases: main
Change-Id: Ief1c8d90371d6003512f88a064c2d82e51502590
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73722

Tested-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Klee <typo3-coding@oliverklee.de>
Tested-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>

73ed5173

[BUGFIX] Ensure proper value when accessing array · 6fdb5153

Marc Willmann authored Jun 01, 2022 and

Stefan Bürk committed Jun 03, 2022

Even if the property 'crop' is not explicit set in the
TypoScript code provide expected values to the stdWrap
method (which expects a string and not NULL).

Resolves: #97720
Releases: main, 11.5
Change-Id: Id8039ea5e379aa9a3ed81499f90160a5af8546f3
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74799

Tested-by: core-ci <typo3@b13.com>
Tested-by: Jan Helke <jh@f7.de>
Tested-by: Simon Schaufelberger <simonschaufi+typo3@gmail.com>
Tested-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Jan Helke <jh@f7.de>
Reviewed-by: Simon Schaufelberger <simonschaufi+typo3@gmail.com>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>

6fdb5153

[BUGFIX] Use correct check for disabled field in DataHandler · 47fa45cf

Georg Ringer authored Jun 02, 2022 and

Stefan Bürk committed Jun 03, 2022

Instead of checking for the array key `enablecolumns` the check must be
done on the field `disabled` itself.

Resolves: #97728
Releases: main, 11.5
Change-Id: I411b37d4d63eb1ad52592cd887a95c2552ab7bfa
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74810

Tested-by: core-ci <typo3@b13.com>
Tested-by: Simon Schaufelberger <simonschaufi+typo3@gmail.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Simon Schaufelberger <simonschaufi+typo3@gmail.com>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>

47fa45cf

[TASK] Properly deprecate the check for the SiteLanguageAwareTrait · 24c5372a

Oliver Klee authored Apr 20, 2022 and

Stefan Bürk committed Jun 03, 2022

In #87380, it was recommended to use the `SiteLanguageAwareInterface`
instead of the `SiteLanguageAwareTrait` for marking classes as site
language aware. The usage of the trait for this was never properly
deprecated - it was only marked as "at any time after TYPO3 v11",
which is not specific enough.

The proper deprecation is now done so the check for the trait can
be removed for TYPO3 v13.

Resolves: #97435
Related: #87380
Releases: main
Change-Id: I6e8d130b295d4dc3f69639b4fa0e13d6b73f1040
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74361

Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Simon Schaufelberger <simonschaufi+typo3@gmail.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>

24c5372a

[BUGFIX] Use correct todo annotation in drag-upoader.ts · f8016368

Andreas Fernandez authored Jun 03, 2022

Resolves: #97730
Releases: main
Change-Id: I78aa8d10dfdd045405316c25d8ce39d353b9e9d6
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74812

Tested-by: core-ci <typo3@b13.com>
Tested-by: Stefan Bürk <stefan@buerk.tech>
Tested-by: Oliver Klee <typo3-coding@oliverklee.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>

f8016368

[TASK] Raise to recent moment & moment-timezone versions · 117a0f6f

Oliver Hader authored Jun 01, 2022 and

Andreas Fernandez committed Jun 03, 2022

+ npm package moment up to v2.29.2 contained a vulnerability
  (https://github.com/advisories/GHSA-8hfj-j24r-96c4) which only
  affected npm server users - in order to avoid confusion concerning
  security aspects, the package version is raised
+ npm package moment-timezone was upgraded to recent timezone data
  "IANA TZDB 2021"

Executed commands:

cd Build; \
  nvm use; \
  yarn upgrade moment moment-timezone; \
  yarn exec grunt clear-build; \
  yarn exec grunt build

Resolves: #97723
Releases: main, 11.5, 10.4
Change-Id: I84ea9ca6b696d74aab70cfa45e6d41a95ae0159d
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74802

Tested-by: core-ci <typo3@b13.com>
Tested-by: Simon Schaufelberger <simonschaufi+typo3@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Simon Schaufelberger <simonschaufi+typo3@gmail.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>

117a0f6f

[BUGFIX] Late bind drag uploader · 234569f4

Andreas Fernandez authored May 26, 2022 and

Georg Ringer committed Jun 03, 2022

If TCA with a file upload is used within IRRE (e.g. as done by
EXT:news), creating a new record or opening an existing record now sets
up the drag uploader.

As the DragUploader module is loaded independently from the FormEngine
main module, loading order may vary, rendering an event-based solution
unstable. To solve this issue without any major refactorings, a
MutationObserver is installed by the DragUploader module.

Resolves: #97676
Releases: main, 11.5
Change-Id: I36a3922999842f4d0bddfc7e4b148ec39880d9df
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74748

Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Nikita Hovratov <nikita.h@live.de>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Nikita Hovratov <nikita.h@live.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>

234569f4

02 Jun, 2022 3 commits

[TASK] Add URL to PHP documentation for datetime.format · 78d81a90

medarob authored Jun 02, 2022 and

Oliver Hader committed Jun 02, 2022

Resolves: #97726
Releases: main
Change-Id: I7139dc9431aa5bf117d2aa3d4cf4586e5bf74b8b
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74807

Tested-by: Oliver Klee <typo3-coding@oliverklee.de>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>

78d81a90

[TASK] Improve a type annotation in the setup extension · 5c8af34c

Oliver Klee authored Apr 18, 2022 and

Stefan Bürk committed Jun 02, 2022

Also add a missing type cast.

Used command:
> ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Resolves: #97426
Releases: main, 11.5
Change-Id: I5a48c0737833792f99652cc54a90db9bcbe798b8
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74351

Tested-by: core-ci <typo3@b13.com>
Tested-by: Simon Schaufelberger <simonschaufi+typo3@gmail.com>
Tested-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Simon Schaufelberger <simonschaufi+typo3@gmail.com>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>

5c8af34c

[TASK] Raise to recent composer/composer 2.2 version · 5e89b5dc

Oliver Hader authored Jun 01, 2022 and

Oliver Hader committed Jun 02, 2022

composer req --dev composer/composer:^2.2.12

Resolves: #97722
Releases: main, 11.5
Change-Id: I526de4c62b5f9bc03230a8794cd42082e9f00560
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74800

Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Klee <typo3-coding@oliverklee.de>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>

5e89b5dc

31 May, 2022 2 commits

[BUGFIX] Make schedulable commands field identifiers unique · ff0fa37f

Oliver Bartsch authored May 25, 2022

The scheduler module contains a special task,
which allows to select schedulable symfony
commands.

The corresponding field provider therefore
adds the commands' configured arguments
and options. Due to insufficient prefixing, it
was not possible to display arguments and
options with the same name. Additionally,
using "action" as name always overwrote
the "select schedulable commands" field.

This is now resolved by adding proper prefixes.

Resolves: #97691
Releases: main, 11.5
Change-Id: I0e2c958fc699065cad6c53c0876e2c9ef14fc1f6
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74745

Tested-by: core-ci <typo3@b13.com>
Tested-by: Stefan Bürk <stefan@buerk.tech>
Tested-by: Torben Hansen <derhansen@gmail.com>
Tested-by: Jochen <rothjochen@gmail.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Torben Hansen <derhansen@gmail.com>
Reviewed-by: Jochen <rothjochen@gmail.com>
Reviewed-by: Oliver Bartsch <bo@cedev.de>

ff0fa37f

[TASK] Note nullable parameters and returns as such · f0ef135d

crell authored May 17, 2022 and

Stefan Bürk committed May 31, 2022

Based on the code, these parameters are nullable. The doc
comments should reflect that. Doing so eliminates several
PHPStan warnings.

Whether these parameters ought to be nullable is a question
for another time.

Resolves: #97648
Releases: main, 11.5
Change-Id: Id0cc51d159ebb0321e94f7fb77a5d560950cfb05
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74676

Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Klee <typo3-coding@oliverklee.de>
Tested-by: Simon Schaufelberger <simonschaufi+typo3@gmail.com>
Tested-by: Nikita Hovratov <nikita.h@live.de>
Tested-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Simon Schaufelberger <simonschaufi+typo3@gmail.com>
Reviewed-by: Nikita Hovratov <nikita.h@live.de>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>

f0ef135d

30 May, 2022 3 commits

[TASK] Fix wrong indentation in Context class · 538046cd

Torben Hansen authored May 30, 2022 and

Nikita Hovratov committed May 30, 2022

The switch structures in `Context` class are indented
wrong. This patch corrects the indentation.

Resolves: #97708
Releases: main, 11.5
Change-Id: I70b9f94b196b8bb94078df41956f67619cd4bc15
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74790

Tested-by: core-ci <typo3@b13.com>
Tested-by: Simon Schaufelberger <simonschaufi+typo3@gmail.com>
Tested-by: Oliver Klee <typo3-coding@oliverklee.de>
Tested-by: Nikita Hovratov <nikita.h@live.de>
Reviewed-by: Simon Schaufelberger <simonschaufi+typo3@gmail.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Nikita Hovratov <nikita.h@live.de>

538046cd

[TASK] Update PHPStan to version 1.7.3 · 921a6786

Oliver Klee authored May 24, 2022 and

Stefan Bürk committed May 30, 2022

Used commands:

> composer req --dev phpstan/phpstan:^1.7.3
> ./Build/Scripts/runTests.sh -s clean
> ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Resolves: #97706
Releases: main, 11.5
Change-Id: Ida82935064ad4ff5c2858d9a5a6696befd52e512
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74786

Tested-by: core-ci <typo3@b13.com>
Tested-by: Simon Schaufelberger <simonschaufi+typo3@gmail.com>
Tested-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Simon Schaufelberger <simonschaufi+typo3@gmail.com>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>

921a6786

[TASK] Make the return type of GeneralUtility::tempnam more specific · f11dbece

Oliver Klee authored May 28, 2022 and

Stefan Bürk committed May 30, 2022

Also adapt the callers accordingly. This resolves a few PHPStan warnings
and allows simplifying some code.

Used command:

> ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Resolves: #97703
Releases: main, 11.5
Change-Id: I29b7278960a519dd7c5e0d3e2966b75933941a38
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74779

Tested-by: core-ci <typo3@b13.com>
Tested-by: Simon Schaufelberger <simonschaufi+typo3@gmail.com>
Tested-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Simon Schaufelberger <simonschaufi+typo3@gmail.com>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>

f11dbece

29 May, 2022 1 commit

[TASK] Improve and clean up some type annotations in tests · e24d05f4

Oliver Klee authored May 28, 2022 and

Stefan Bürk committed May 29, 2022

This gets rids of some PHPStan warnings triggered by the latest
testing framework raise.

Used command:
> ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Resolves: #97702
Releases: main
Change-Id: I95059f39465df0ad868645c0c66dac19327f8882
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74778

Tested-by: core-ci <typo3@b13.com>
Tested-by: Simon Schaufelberger <simonschaufi+typo3@gmail.com>
Tested-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Simon Schaufelberger <simonschaufi+typo3@gmail.com>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>

e24d05f4

28 May, 2022 4 commits

[BUGFIX] Resolve a stray strpos call · 01a24ae0

crell authored May 16, 2022 and

Stefan Bürk committed May 29, 2022

This conversion got past the big conversion patch
before, probably due to the negation.

Resolves: #97640
Releases: main, 11.5
Change-Id: I67dd19c286ce25ad8cda71c1451fa84ed25dc971
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74651

Tested-by: Simon Schaufelberger <simonschaufi+typo3@gmail.com>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Simon Schaufelberger <simonschaufi+typo3@gmail.com>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>

01a24ae0

[BUGFIX] Mark nullable properties in EXT:core as such · 0193bc7c

Oliver Klee authored May 14, 2022 and

Stefan Bürk committed May 28, 2022

Resolves: #97630
Releases: main, 11.5
Change-Id: Id31d1b28929eb85dd2adaa8a263e5d84a2a842b5
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74644

Tested-by: core-ci <typo3@b13.com>
Tested-by: Simon Schaufelberger <simonschaufi+typo3@gmail.com>
Tested-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: crell <larry@garfieldtech.com>
Reviewed-by: Simon Schaufelberger <simonschaufi+typo3@gmail.com>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>

0193bc7c

[TASK] Remove dead code paths identified by PHPStan · 074cb535

crell authored May 12, 2022 and

Stefan Bürk committed May 28, 2022

According to PHPStan, these checks are all unnecessary.
Most of them appear to be type checks that have been
rendered unnecessary due later type additions. They
are therefore removed without replacement.

Used command:

> Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Resolves: #97622
Releases: main, 11.5
Change-Id: I9aac41e98b22fcce55afb97f8aeaebe3209a8bfb
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74637

Tested-by: Nikita Hovratov <nikita.h@live.de>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Nikita Hovratov <nikita.h@live.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>

074cb535

[TASK] Update copyright year in README.md and INSTALL.md · 6f3d45da

Torben Hansen authored May 28, 2022 and

Stefan Bürk committed May 28, 2022

Update copyright year to 2022

Resolves: #97704
Releases: main, 11.5, 10.4
Change-Id: I15e6c0674ac293eecad88f95379ec33679dda8d4
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74780

Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Klee <typo3-coding@oliverklee.de>
Tested-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>

6f3d45da

27 May, 2022 3 commits

[DOCS] Streamline felogin documentation · eaaa9984

Chris Müller authored May 26, 2022 and

Nikita Hovratov committed May 27, 2022

The patch provides the following changes:
- Use consistent header levels
- Format code examples with the correct language
- Use example.org as domain for example link
- Apply takeaways from https://forge.typo3.org/issues/85035#note-8
  (chapter "login process")

Resolves: #97692
Related: #85035
Releases: main, 11.5
Change-Id: If6c7851c25210cf4e03fb07efeaf14973e667cb9
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74746

Tested-by: core-ci <typo3@b13.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Nikita Hovratov <nikita.h@live.de>
Reviewed-by: Simon Schaufelberger <simonschaufi+typo3@gmail.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Nikita Hovratov <nikita.h@live.de>

eaaa9984

[TASK] Add `function_to_constant` to php-cs-fixer · 08ca9785

Andreas Fernandez authored May 27, 2022

php-cs-fixer has the fixer `function_to_constant` which replaces PHP
functions to their equivalent constants, which is added with this
commit.

Resolves: #97697
Releases: main
Change-Id: Ibdbfab404d2a7d35698d4afd6bb265294f7c3faf
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74773

Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Oliver Klee <typo3-coding@oliverklee.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>

08ca9785

[BUGFIX] Update guzzlehttp/guzzle to 7.4.3 · 1e90ac9d

Andreas Fernandez authored May 26, 2022

The package guzzlehttp/guzzle has been updated to 7.4.3 and 6.5.6
respectively, both fixing a security vulnerability related to
cross-domain cookie leakage [1]. Since TYPO3 is not affected by
this issue by default, this is handled as a public bugfix.

However, 3rd party code (e.g. thru extensions) may be affected by this
issue, as long `'cookies' => true` is used in requests done by Guzzle.

Executed commands:

    composer require \
        guzzlehttp/guzzle:^7.4.3 \
        -W
    composer require \
        -d typo3/sysext/core \
        guzzlehttp/guzzle:^7.4.3 \
        --no-update

[1] https://github.com/guzzle/guzzle/security/advisories/GHSA-cwmx-hcrq-mhc3

Resolves: #97694
Releases: main, 11.5, 10.4
Change-Id: I39071c917c7ed26392f66b0ea2f774ecbceead9f
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74747

Tested-by: Simon Schaufelberger <simonschaufi+typo3@gmail.com>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Klee <typo3-coding@oliverklee.de>
Tested-by: Stefan Bürk <stefan@buerk.tech>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Simon Schaufelberger <simonschaufi+typo3@gmail.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>

1e90ac9d

25 May, 2022 5 commits

[BUGFIX] Disable toggle all action in multi record selection · a1325680

Oliver Bartsch authored May 24, 2022

If a table in recordlist only contains records
which do not provide a checkbox, the "toggle
all" action should be disabled as well, since
using this action would have no effect.

Resolves: #97685
Releases: main, 11.5
Change-Id: Id87bb5dd9df10c33acd03d0c5dbca179bb7f1cdd
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74736

Tested-by: core-ci <typo3@b13.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Jochen <rothjochen@gmail.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Jochen <rothjochen@gmail.com>
Reviewed-by: Oliver Bartsch <bo@cedev.de>

a1325680

[BUGFIX] Prevent undefined array key warnings in RecordHistory · 48975aef

Oliver Bartsch authored May 24, 2022

Occurred on accessing the record history
for records on pid=0.

Resolves: #97682
Releases: main, 11.5
Change-Id: I041fd9c2dfa8f8cfda4f89c47d320e5bfa6e7f3a
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74733

Tested-by: core-ci <typo3@b13.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Stefan Bürk <stefan@buerk.tech>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Oliver Bartsch <bo@cedev.de>

48975aef

[BUGFIX] Prevent TypeError in ActionController · 1c0cf77e

Oliver Bartsch authored May 24, 2022

Ensure to properly typecast optional
parameters of throwStatus() before
passing them to type hinted methods.

Resolves: #97666
Releases: main, 11.5
Change-Id: Ifb6d43cffc97899cdd4ab72d48703bc3db23f0e1
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74735

Tested-by: core-ci <typo3@b13.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Stefan Bürk <stefan@buerk.tech>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Oliver Bartsch <bo@cedev.de>

1c0cf77e

[TASK] Align the test field annotations with the testing framework · 45719077

Oliver Klee authored May 24, 2022 and

Christian Kuhn committed May 25, 2022

Also drop type annotations that already are present in the
corresponding field in the superclass, and drop some type annotations
that are redundant with the existing native type declarations.

This helps resolves a bunch of new PHPStan warnings after the recent
changes in the testing framework. It also helps static code analysis,
and makes the code more succinct.

Resolves: #97687
Releases: main, 11.5
Change-Id: I6f1b67f410f7e195b036bc5b5b528cb271a990b9
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74738

Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>

45719077

[BUGFIX] Properly handle shortcuts for creating new records · 79809796

Oliver Bartsch authored May 20, 2022

When creating bookmarks to the "new" view in FormEngine,
those bookmark previously did not show up in the toolbar list,
because the parent page access check failed.

This is now fixed by also resolving the parent page for
new record bookmarks properly.

Additionally the shortcut title for those use cases does
now match the title, displayed in FormEngine.

Resolves: #97655
Releases: main, 11.5
Change-Id: If62391bffe4126c746b6c5650d1aa9d0821f2960
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74691

Tested-by: core-ci <typo3@b13.com>
Tested-by: Jochen <rothjochen@gmail.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Jochen <rothjochen@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Oliver Bartsch <bo@cedev.de>

79809796