- 06 Jun, 2022 1 commit
-
-
Resolves: #97658 Releases: main, 11.5 Change-Id: Ic4e18d64849e64404dca0eef240060d882476526 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74817 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech>
-
- 18 Apr, 2022 1 commit
-
-
'BackendUtility::getProcessedValue()' currently implicitly returns mixed, whereas makeDiffDisplay() requires a string. Using force-casting in '\TYPO3\CMS\Impexp\ImportExport' for the value before passing it is the most straightforward fix for now. Resolves: #97373 Related: #97210 Related: #97372 Releases: main Change-Id: I89cd60ed227cf285040c118b741951734e0fa8a7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74287 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 05 Feb, 2022 1 commit
-
-
Many classes in TYPO3 have a function called getBackendUser() or getBackendUserAuthentication(). The function definition is not always equal and some functions have a return type or doc comment and others do not. This patch streamlines the functions as following: * They must always use a return type declaration * They must not contain a doc comment header Also, some superfluous override of getBackendUser() have been removed. Additionally the parameter type declaration for $backendUserAuthentication in * BeforeHistoryRollbackStartEvent * AfterHistoryRollbackFinishedEvent * RecordHistoryRollback have been adapted to be nullable. Resolves: #96752 Releases: main Change-Id: Id7eec1bc5d0d602ccab95de75149053f7223a86c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73304 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
- 02 Feb, 2022 1 commit
-
-
Many classes in TYPO3 have a function called getLanguageService(). The function definition is not always equal and some functions have a return type or doc comment and others do not. This patch streamlines the function as following: * It must always use a return type declaration * It must not contain a doc comment header Also, the superfluous override of getLanguageService() in some subclasses extending AbstractFormElement has been removed. Resolves: #96732 Releases: main Change-Id: Ie4e7fc19b2e84dee78496b4eec674a215a81c00c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73261 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 17 Jan, 2022 1 commit
-
-
A bigger but careful refactoring of the ImportController and ExportController together with a view adaption. The module is still as ugly as before, but the underlying codebase should be much better understandable now. Change-Id: I34e90f0cef48ffd4c9fbe348a3d69901a717b74f Resolves: #96558 Related: #96513 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73033 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 07 Dec, 2021 1 commit
-
-
Oliver Bartsch authored
The database table sys_language has become obsolete with the introduction of site handling and site languages. Therefore, the sys_language database table and the corresponding TCA is now removed. Fixtures and tests are adjusted to no longer rely on this table. Additionally, also a couple of code comments through the Core are adjusted. Executed commands: composer u typo3/cms-styleguide Resolves: #96277 Related: #94165 Releases: main Change-Id: I4ab0f3c7bb6de110cc1ce9826b2718f60d8a18a0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72534 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
- 26 Nov, 2021 1 commit
-
-
Instead of using `GeneralUtility::mkdir` the method `GeneralUtility::mkdir_deep` should be used to avoid errors if the parent directory does not yet exist. Resolves: #96029 Releases: master, 11.5 Change-Id: Ic5005df117ddedd8fcae5b9c41c092f8328c8a57 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72236 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de>
-
- 17 Nov, 2021 1 commit
-
-
EXT:impexp EXT:indexed_search EXT:info EXT:install Resolves: #94264 Releases: master Change-Id: I0799fce1f3f316a4b6e0925f6813738a2c53f8a9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69394 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 12 Oct, 2021 1 commit
-
-
The (ugly) statement strpos($haystack, 'needle') !== false can be safely replaced with str_contains($haystack, 'needle'). This is possible, as a symfony polyfill for php 8.0 functions is in place. Resolves: #95466 Releases: master Change-Id: I313f47832a254c23c6815b6b44557a01019e59e7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71429 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 07 Oct, 2021 1 commit
-
-
Log messages generally use double-quotes. This patch fixes the few stragglers that do not. This also fixes an issue in PHP 8.1, where the defaults for htmlspecialchars() have changed resulting in some test failures. Standardizing the quotes makes the tests pass in all cases. Resolves: #95507 Releases: master Change-Id: I7ee189b8df997700f62f8379916624c27f02742a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71476 Reviewed-by:
crell <larry@garfieldtech.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Oliver Bartsch <bo@cedev.de>
-
- 13 Sep, 2021 1 commit
-
-
Some EXT:impexp functional tests threw warnings of the type "Undefined array key" which did not abort the test but were written unnoticed to the TYPO3 logs. These warnings are fixed in this patch. Resolves: #94972 Releases: master Change-Id: I0e4f3558cd12ef49ae6dc071edd67cd2621dbc2f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70741 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
- 23 Aug, 2021 1 commit
-
-
Running the functional EXT:impexp tests causes the EXT:impexp/Tests/Functional/Fixtures/Folders/fileadmin/user_upload folder to grow larger. This is due to export files being created that have not been cleaned up after the tests have run. In addition, completely delete the default import/export folder in ImportExport::removeDefaultImportExportFolder(). This method is currently only used in tests. Resolves: #94937 Releases: master Change-Id: I55d821ec18689172a73e0f290f1e155fae64d3cb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70683 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
- 12 Aug, 2021 1 commit
-
-
This patch serves as a basis for further improving the UX and new features for import / export. * Better separation between controllers and worker services * Refactor code & streamline wording * More strict typing and some PHP 8 related fixes * Streamline exception handling * Support full import configuration in CLI command impexp:import * Functional tests with increased coverage and less mocking * A set of acceptance tests for the backend interface * Minor bug fixes Note: The output of the extension has not been changed in any way, e.g. the format of the export file remains the same. Only the internal processes have been optimized. Resolves: #94772 Releases: master Change-Id: I4df66a6f615e07d6d9767723a12a769aedeb341b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70332 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 15 Jul, 2021 1 commit
-
-
Added fallback for undefined array keys in backend, core, recycler, impexp, scheduler and linkvalidator Resolves: #94542 Releases: master Change-Id: Ieeda20879f1906c9e9a743e0377767cfce8dec09 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69813 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 12 Jul, 2021 1 commit
-
-
Added fallback value for array undefined keys for filelist as well as for impexp because it is part of the current clipboard fuctionality. Introduced new tests for clipboard and file upload. Resolves: #94509 Releases: master Change-Id: Ibed7c53f49665c4502aaa05dbe78f468d354f3a1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69771 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 10 Dec, 2020 1 commit
-
-
Inline JavaScript produced by BackendUtility:viewOnClick is substituted with markup based instructions and static JavaScript event handlers. // basically delivers window.open(generatedUri) BackendUtility::viewOnClick($pageId, $backPath, $rootLine, $section, $viewUri, $getVars, $switchFocus); can be substituted with e.g. \TYPO3\CMS\Backend\Routing\PreviewUriBuilder::create($pageId, $viewUri) ->withRootLine($rootLine) ->withSection($section) ->withAdditionalQueryParameters($getVars) ->serializeDispatcherAttributes([ PreviewUriBuilder::OPTION_SWITCH_FOCUS => $switchFocus, ]); which results in the following HTML data attributes (data can be retrieved as array of complete element as well) data-dispatch-action="TYPO3.WindowManager.localOpen" data-dispatch-args="["https://...",null,"previewWin"]" Resolves: #91123 Releases: master Change-Id: Iedd9bfe60827977677ee68e2c948c63e359abf84 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64243 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 28 Sep, 2020 1 commit
-
-
This patch fixes incompatible type usage in function arguments and is preparatory work for introducing native type hints and strict mode in all core files. Resolves: #92168 Releases: master, 10.4 Change-Id: I79c4576e570e175b770e8ee2929b835a4a0fa55a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65910 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 15 Apr, 2020 1 commit
-
-
With this patch, the header comment of php files is automatically added by the php-cs-fixer, which guarantees that its format and place of occurrence remain the same in all files. Files that are copied over from other projects are excluded. Furthermore, files that are kind of inspired by other projects also get the same header comment but may have a second, additional comment explaining its origin. Used command: bin/php-cs-fixer fix --config=Build/php-cs-fixer/header-comment.php Releases: master Resolves: #91024 Change-Id: I5a040517e0fbde6e5a27d589bf2f222078326dc8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64159 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 14 Apr, 2020 1 commit
-
-
This change adds two changes 'blank_line_after_opening_tag' => true, 'single_trait_insert_per_statement' => true, to our PHP-CS Fixer configuration, adopting more rules related to PSR-12. Resolves: #91020 Releases: master Change-Id: I180b2cbceb077911bddeb42d9f131e5b32244ed2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64158 Tested-by:
Josef Glatz <josefglatz@gmail.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
TYPO3com <noreply@typo3.com> Reviewed-by:
Josef Glatz <josefglatz@gmail.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de>
-
- 02 Apr, 2020 1 commit
-
-
Several issues have been ignored because of checks on runtime constants which vary from context to context. Since we can only simulate one context, phpstan is unable to properly detect several paths. Releases: master Resolves: #90909 Change-Id: Ie3213112a299559687f27317821453137cd5322a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64030 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Georg Ringer <georg.ringer@gmail.com>
-
- 23 Mar, 2020 1 commit
-
-
This change targets a couple of things: - The global constant "FILE_DENY_PATTERN_DEFAULT" is moved to a class constant - The global constant "PHP_EXTENSIONS_DEFAULT" which is not in use anymore, is removed. - The security aspect of checking against the fileDenyPattern is extracted into its own Class where - The fileDenyPattern can never be empty, but only be set via DefaultConfiguration. This makes it easier to test this functionality, a single object is taking over the responsibility, and the logic is now in one place. Also, the non-usage of the global constant makes life easier. Resolves: #90147 Releases: master Change-Id: I9db0d6fc3b10f75a3735017cb9ac0d9bfd4ff02b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62843 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com>
-
- 29 Feb, 2020 1 commit
-
-
Resolves: #90587 Releases: master Change-Id: Ia85673a693d0de19745379c79dba157e33aa6804 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63493 Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Susanne Moog <look@susi.dev> Reviewed-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
Susanne Moog <look@susi.dev>
-
- 30 Jan, 2020 1 commit
-
-
The so-called "singleton factory instance" is a wrapper around makeInstance which can be used directly anyways. With Dependency Injection this is not even necessary anymore, and should be avoided under all circumstances. The constructor does not cache anything, so this can be replaced completely. SingletonInterface + DI should be sufficient already. Resolves: #90260 Releases: master Change-Id: I964ddb90425b273c6e7588781c4b7e3fe39ddd18 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63076 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org>
-
- 30 Dec, 2019 1 commit
-
-
php bin/rector process A couple of rectors have been disabled due to different reasons: - Rector\Php71\Rector\FuncCall\CountOnNullRector This rector has been disabled as it creates rather long and complex structures to avoid calling count on null. This rector will be enabled as soon as TYPO3 uses at least PHP 7.3 which introduces a "is_countable" method. - Rector\Php71\Rector\Assign\AssignArrayToStringRector This rector has been disabled as it does not work properly. The default types of parameters have been changed although their types could properly be inferred by a doc block or by value assignments. - Rector\Php71\Rector\BinaryOp\BinaryOpBetweenNumberAndStringRector This rector has been disabled as it does not work properly. A bug report is filed and to be found here: https://github.com/rectorphp/rector/issues/2454 - Rector\Php71\Rector\FuncCall\RemoveExtraParametersRector This rector has been disabled as it does not work properly. It removed arguments in tests, especially when using prophecies. Releases: master Resolves: #90002 Change-Id: I6ed14d38cc697a23104286db57535d6a3c0dbf62 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62751 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de>
-
- 20 Dec, 2019 1 commit
-
-
In TYPO3 v10, BasicFileUtility is not used by DataHandler anymore, and never initialized with other file permissions than "allow any file ending", which is why the simple check on the fileDenyPattern can be used directly in Import functionality. The next patch would then allow to clean up BasicFileUtility where the methods which belong to "internal_type=file" are not in use anymore. Resolves: #89941 Releases: master Change-Id: I58a28a1cd1f6d284d241479a324c877a2824e7bb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62627 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Susanne Moog <look@susi.dev> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Susanne Moog <look@susi.dev>
-
- 19 Dec, 2019 1 commit
-
-
php bin/rector process The Rector\Php70\Rector\List_\ListSwapArrayOrderRector rector has been disabled as this needs proper testing and a separate patch. Releases: master Resolves: #89907 Change-Id: I56b296221622afdc72feb5a48145431efd993ea1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62592 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de>
-
- 27 Nov, 2019 1 commit
-
-
composer require --dev rector/rector:"^0.5.0" This commit introduces the requirement to rector/rector to automatically process code changes by given set of rules. To make this commit more meaningful, a first set "php53" has been processed. Releases: master Resolves: #89785 Change-Id: I6e2ff9654266458ae9fb6800547ff4712b0b66d8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62437 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de>
-
- 23 Aug, 2019 1 commit
-
-
This patch replaces all usages of `strstr()` and its friends where the existence of a certain substring is checked, but the result isn't used at all with `strpos()`, which uses less memory. Resolves: #88922 Releases: master Change-Id: Ie45589ac9410e22e1b48e82dd8086eadb6d74107 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61445 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Frank Naegler <frank.naegler@typo3.org> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Frank Naegler <frank.naegler@typo3.org>
-
- 03 Jul, 2019 1 commit
-
-
The functionality, which was only allowed for admins, does not consider FAL restrictions. In order to be consistent with FAL, this is removed. Resolves: #88681 Releases: master Change-Id: I7a42539b5391af7d730deabffbe638a2ceed1a05 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61221 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org>
-
- 12 Jun, 2019 1 commit
-
-
Benni Mack authored
With the introduction of CKEditor in TYPO3 v8, the support for images in RTEs is dropped, however functionality was kept for compatibility with RTEHtmlArea, which was still available in TYPO3 v8 as separate extension. The functionality to handle images in CKEditor is possible to be applied again, however, as this cannot be managed properly via FAL in its current state, the previous functionality is remvoed from Core. Separate CKEditor extensions as already published, are able to manage the image handling in CKEditor directly already. Dropped * setting TYPO3_CONF_VARS[BE][RTE_imageStorageDir] * transformation setting "ts_images". * softref "images" logic * ImportExport->getRTEoriginalFilename() * RteHtmlParser->TS_images_rte() * CLI Command: cleanup:rteimages and Class RteImagesCommand Resolves: #88500 Releases: master Change-Id: Ie564b19a7d0f9b7d46398094c8d7ecd845e31a65 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60886 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Daniel Gorges <daniel.gorges@b13.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Daniel Gorges <daniel.gorges@b13.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 01 Oct, 2018 1 commit
-
-
All specific controllers for specific Backend actions, Backend-module related modules, all hook implementations (where the core uses hooks by itself), and module-specific ViewHelpers are now marked as @internal to ensure developers what is part of the public TYPO3 Core API. within - EXT:felogin - EXT:feedit - EXT:filelist - EXT:frontend - EXT:fluid_styled_content - EXT:impexp All leftover @api methods have been removed. Resolves: #86508 Releases: master Change-Id: I97a6964a5f77dc9ee3d90365e9fda3d7d7be6266 Reviewed-on: https://review.typo3.org/58527 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
Susanne Moog <susanne.moog@typo3.org>
-
- 29 Sep, 2018 1 commit
-
-
The phpDoc comment "@internal" is used in most places during the development of TYPO3 v7, TYPO3 v8 and TYPO3 v9 and denotes that this specific method, class or property is not part of the Public API, and does not even need any notice if it is removed. However, we still have/had various places in TYPO3 core where "@access private" was used. This is now migrated to "@internal". "@access public" is not needed and is removed. Resolves: #86446 Releases: master Change-Id: Iaef206b04aee13c280d62b107dd7eac04a38c700 Reviewed-on: https://review.typo3.org/58462 Reviewed-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
Susanne Moog <susanne.moog@typo3.org> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com>
-
- 22 Jun, 2018 1 commit
-
-
Class properties explicitly initialized with NULL and redundant assignments in constructors are removed. Resolves: #85287 Releases: master Change-Id: I44c565a0b54e7e98ffa6d2d1de5335a6212a5742 Reviewed-on: https://review.typo3.org/57243 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Alexander Schnitzler <typo3@alexanderschnitzler.de> Reviewed-by:
Jigal van Hemert <jigal.van.hemert@typo3.org> Reviewed-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de> Tested-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de>
-
- 15 Jun, 2018 1 commit
-
-
Resolves: #85277 Releases: master Change-Id: I6510ae323051a01e3b0e3bbdf7b347adeb46880c Reviewed-on: https://review.typo3.org/57234 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Jan Helke <typo3@helke.de> Tested-by:
Jan Helke <typo3@helke.de>
-
- 29 Mar, 2018 1 commit
-
-
All TYPO3 Core areas where typo3temp/var/ was directly used, the new Environment::getVarPath() API is now used. When running via composer or setting the environment variable "TYPO3_PATH_APP", the folder is $projectRootPath . /var otherwise "typo3temp/var/" as before. Additional changes to the default naming scheme - Cache folders are now named lower-case (Cache/Code becomes cache/code). - Install tool session files are stored within "var/session" instead of "var/InstallToolSessions". - Extension Manager files are now within "var/extensionmanager" in a lower-cased variant - log files are now placed into "var/log" instead of "var/logs" - lock files are now placed into "var/lock" instead of "var/locks" Resolves: #84545 Releases: master Change-Id: Ifa57413cd212243387532ffb3435cfca361a582b Reviewed-on: https://review.typo3.org/56413 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
Susanne Moog <susanne.moog@typo3.org>
-
- 02 Mar, 2018 1 commit
-
-
These parentheses are redundant and may be safely removed. Resolves: #84092 Releases: master Change-Id: I59f2b7454316ecd05f57d28e344f03a65d13e5c5 Reviewed-on: https://review.typo3.org/55952 Reviewed-by:
Mathias Schreiber <mathias.schreiber@typo3.com> Tested-by:
Mathias Schreiber <mathias.schreiber@typo3.com> Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Frank Naegler <frank.naegler@typo3.org> Tested-by:
Frank Naegler <frank.naegler@typo3.org>
-
- 18 Jan, 2018 1 commit
-
-
Christian Kuhn authored
ext:impexp has a "size" display and adds size information to export formats for records file sizes. This is entirely removed with the patch - both from interface and .xml/.t3d exports: * The size handling on db records always made little sense, the default maximum size of 1MB was "never" hit, there wasn't even an input box to raise that limit, ever. This information is now just removed from the export formats. * The size handling on files is rather irrelevant with FAL, since FAL file integrity is checked with sha1 already. The size display during export in the interface for FAL files never worked since FAL migration in core v6.0 - It always displayed 0. Nobody ever cared, there is not even a forge issue about that. * Removing the 'size' column in the export interface - which only carried rather irrelevant information on record "size" only - simplifies the interface a bit. * The record size information in exports depends on used dbms due to different internal database types. Removing that makes exports more dbms agnostic. This can be seen with all the functional test fixture file changes coming with the patch - removing that reduces a maintenance nightmare in this area and improves the chance to align exports in between the functional testes on different dbms again. Note that exporting .xml/.t3d in v9 and importing it in a v8 instance does not work anyway due to more significant DB field related changes in v9 already. The effects of this patch could be easily mitigated on v8, but we were unable to create anything in v9 that is able to be imported in v8 again - and ext:impexp is not created to be an upgrade / download helper in the first place. Thus, ignoring size checks in v8 to mitigate effects of the file format change does not seem to be necessary and is not done. Change-Id: I0cae7b371b6ac027e27c9192ffa273dabc9795c7 Resolves: #83606 Releases: master Reviewed-on: https://review.typo3.org/55391 Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Reiner Teubner <rteubner@me.com> Tested-by:
Reiner Teubner <rteubner@me.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
- 27 Dec, 2017 1 commit
-
-
Using null coalescing operator in PHP 7 simplifies code structure. Resolves: #83129 Releases: master Change-Id: I449415c99ccb0ea158d3943800bc824514f7629c Reviewed-on: https://review.typo3.org/54810 Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Benni Mack <benni@typo3.org>
-
- 19 Dec, 2017 1 commit
-
-
Instead of integers, the permission constants should be used throughout the TYPO3 Core. Resolves: #83383 Releases: master Change-Id: I00c10f97fc800d9533866c98284bbd22cd1bb575 Reviewed-on: https://review.typo3.org/55156 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com>
-
- 27 Nov, 2017 1 commit
-
-
Several hundred function calls and vast numbers of indentations can be saved by using the null coalesce operator instead of checking empty/array. Change-Id: I38f2ce2de83a454aaa0d16c771014b6de84b3f7a Releases: master Resolves: #80812 Reviewed-on: https://review.typo3.org/52416 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
Susanne Moog <susanne.moog@typo3.org> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl>
-