- 13 Oct, 2021 2 commits
-
-
Since #95466 str_contains() is used with `null` instead of strings in a lot of cases throughout the core. This causes TypeErrors with symfony/polyfill-php80 < 1.23.1 (nighty composer-min stage). symfony/polyfill-php80 accounted for this case with v1.23.1, therefore the minimum requirement is raised. Also the missing requirement in EXT:core is added. composer require symfony/polyfill-php80:^1.23.1 composer require --no-update -d typo3/sysext/core \ symfony/polyfill-php80:^1.23.1 composer require --no-update -d typo3/sysext/form \ symfony/polyfill-php80:^1.23.1 Releases: master Resolves: #95619 Related: #95466 Change-Id: Iebabf2a9db2a3a3938b65ee2e27a5c65776007b8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71613 Reviewed-by:Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
$GLOBALS['TYPO3_CONF_VARS']['EXTENSIONS'] stores extensions specific settings - settings created from definitions in ext_conf_template.typoscript files. This array is not defined in DefaultConfiguration.php, it was probably used to test for when the transition from the serialized string to the flat array was done around core v8 or so. We can now safely add it as default-empty array to DefaultConfiguration.php, so core can rely on existance of this array key. Resolves: #95608 Releases: master Change-Id: I850cd4af6e99e2e29d7a08fb3f99f41aa6e2ab05 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71598 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Stefan Bürk <stefan@buerk.tech> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
Josef Glatz <josefglatz@gmail.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
- 12 Oct, 2021 20 commits
-
-
Some assertions in extbase functional tests access not existing array keys, which raises PHP 8.0 warnings. Sanitize these. Resolves: #95609 Releases: master Change-Id: I828270bb42146cfe836f045d09bf865e37591a14 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71599 Tested-by:
core-ci <typo3@b13.com>
Tested-by: 
Oliver Bartsch <bo@cedev.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de> -
Supported versions by the community has been changed after v11 LTS has been released, Furthermore v9 has shifted into ELTS and is no longer supported by the community. This patch updates the version matrix in SECURITY.md to reflect these changes, as this is for ex. displayed on github as security policy. Resolves: #95604 Releases: master Change-Id: Ie12b1d1dd52fbca7b443bb17b0033379175866ac Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71595 Tested-by:
Simon Gilli <typo3@gilbertsoft.org>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Simon Gilli <typo3@gilbertsoft.org>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
Reviewed-by: -
Resolves: #95599 Related: #94328 Releases: master Change-Id: If4fc48d4b279298d4bde9cd338322e5e4598a237 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71593 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Torben Hansen <derhansen@gmail.com> Tested-by:
Oliver Bartsch <bo@cedev.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de> -
Resolves: #95602 Releases: master Change-Id: Ic91531aa6d5a95006b99bbf2d8b29db9a41516fa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71594 Tested-by:
Jochen <rothjochen@gmail.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Jochen <rothjochen@gmail.com>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: -
Resolves: #95586 Related: #94402 Releases: master Change-Id: I2b6094032523e8bcbbc67edb32b2a2c8f3abcb9f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71563 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Jochen <rothjochen@gmail.com>
Tested-by: Jochen <rothjochen@gmail.com>
Reviewed-by: -
The Format/HtmlViewHelper is designed to run in backend without TSFE. The HtmlViewHelperTest with disabled error suppression reveals ContentObjectRenderer does not always properly check for instances of TypoScriptFrontentController. Resolves: #95584 Releases: master Change-Id: Ia0ac6870d7ffc6405b12c5cbb483617808db856e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71558 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Jochen <rothjochen@gmail.com>
Tested-by: Jochen <rothjochen@gmail.com>
Reviewed-by: -
Christian Kuhn authored
As found by ext:fluid TypolinkViewHelperTest with disabled error suppression, ContentObjectRenderer does not properly check an array key access in a helper method of typolink(). Change-Id: I8c4410473f89473a623461123d99bada8ba8ee14 Resolves: #95583 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71557 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Nikita Hovratov <nikita.h@live.de> Tested-by:
Jochen <rothjochen@gmail.com>
Tested-by: Jochen <rothjochen@gmail.com>
Reviewed-by: -
The persistence tests use ext:blog_example repositories and miss to properly setup ConfigurationManager for this extension, which is usually done by extbase bootstrap. Running the functional tests without error suppression reveal this incomplete setup. Resolves: #95587 Releases: master Change-Id: If99104526c7d66589af739a9c9b1ad139d5d4d81 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71567 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
Extbase functional tests with disabled error suppression reveal there are still some tests with fixture classes that don't return ResponseInterface in extbase action controllers. Resolves: #95585 Releases: master Change-Id: I6a030c3458dae5e5f40bf6b5e5df5ed7fd862420 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71559 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Benjamin Franzke <bfr@qbus.de> Reviewed-by:
-
Benni Mack authored
Change-Id: I601a246dc057e469876326c7f1d163bbfdf19cad Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71562 Tested-by:
-
Benni Mack authored
Change-Id: I9a38139470a45db0f2f0062165b69180a1b58bc1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71561 Tested-by:
-
Resolves: #95450 Releases: master Change-Id: Ifc008b06c3db26a835d50fa7f07caa23600c9795 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71555 Tested-by:
Oliver Bartsch <bo@cedev.de>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Jochen <rothjochen@gmail.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Jochen <rothjochen@gmail.com>
Reviewed-by: -
Adapt description and remove hints on exceptions which are not thrown here. Resolves: #95149 Releases: master, 10.4 Change-Id: I5c9cf4f1d5eac3966edfab26eea763192a3c712a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70970 Reviewed-by:
core-ci <typo3@b13.com>
Tested-by: -
These warnings have been fixed by adding a proper fallback where needed. Resolves: #95563 Releases: master Change-Id: I13b42cdc7c910f75de0adc093549438da44d734b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71534 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
Georg Ringer authored
To make it easier for developers and integrators, the table name is now shown in the backend when debugging is active. Resolves: #92427 Related: #83461 Releases: master Change-Id: I2c7413b5deac43490b6a7392060da76992a69bd9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65892 Tested-by:
Oliver Bartsch <bo@cedev.de>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: -
The (ugly) statement strpos($haystack, 'needle') !== false can be safely replaced with str_contains($haystack, 'needle'). This is possible, as a symfony polyfill for php 8.0 functions is in place. Resolves: #95466 Releases: master Change-Id: I313f47832a254c23c6815b6b44557a01019e59e7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71429 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
-
Releases: master Resolves: #95574 Change-Id: I2587d67c09b317a6a14681fdf2c77a702d0be734 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71552 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
-
The WorkspaceMenu JavaScript module is used to update the topbar elements, related to workspaces. The required state handling is now simplified and does no longer rely or manipulate "global" configuration (top.TYPO3.configuration or top.TYPO3.Backend). This therefore also allows to remove the "inWorkspace" value, set in the BackendController. Additionally, the "check icon", in front of the current selected workspace menu item, is now properly updated again. Resolves: #95503 Releases: master Change-Id: Ic2bce429c07e62b86d71f32f143280fb20a73cc2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71478 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Jochen <rothjochen@gmail.com>
Tested-by: Jochen <rothjochen@gmail.com>
Reviewed-by: -
Allow a list of HTML tags in the help content just as for the configuration details. Resolves: #95152 Releases: master Change-Id: Icc2e0b60a1ed86f67604e276322ec24162234a95 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70980 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
composer req --dev composer/package-versions-deprecated:^1.11.99.4 composer req --dev friendsofphp/php-cs-fixer:^3.2 composer u mikey179/vfsstream Resolves: #95570 Releases: master Change-Id: Ic2321dde785113e16d200b649cd7da9a91de9d71 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71537 Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
core-ci <typo3@b13.com>
Tested-by:
-
- 11 Oct, 2021 18 commits
-
-
Resolves: #95573 Releases: master, 10.4 Change-Id: I13742f80588d8d1d566d08e7b51c165a5139fe50 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71538 Reviewed-by:
core-ci <typo3@b13.com>
Tested-by: -
The install tool has a special standing due to the FailSafeContainer. The default functional test set up however creates a 'full' container. This triggers a slightly different code path in ViewHelperResolver, which we need to work around a bit. Resolves: #95568 Releases: master Change-Id: I0eb8ad905baedf50d7cee74b30625573d1b854ae Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71535 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com> Reviewed-by:
-
Fixes some undefined array key errors which happen in some specific scenarios related to workspaces usage. Resolves: #95564 Releases: master Change-Id: I22fde56a506ae327ed0121bc68882996da7728df Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71532 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Jochen <rothjochen@gmail.com>
Tested-by: Jochen <rothjochen@gmail.com>
Reviewed-by: -
enableRuntimeCache() has been deprecated with #93038, with all calls being removed. #94772 re-introduced one case, probably during rebasing. Resolves: #95569 Related: #93038 Related: #94772 Releases: master Change-Id: I5f072f85d5714496870a5fdbb4694fd3426a56a5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71536 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
This resolves a todo in Tooltip.ts, where we've waited for an updated types definition for bootstrap. Now some new methods, like Tooltip.getOrCreateInstance, are known to TypeScript and can be used, without setting an ignore comment. Command used: > yarn upgrade @types/bootstrap --latest Resolves: #95553 Releases: master Change-Id: I4f9c33c735580ebb02d29b3910403f03c01a5913 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71522 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
Christian Kuhn authored
Yet another series of PHP 8 stabilizations for ext:lowlevel QueryGenerator. This time found by functional tests when error handling in functionals is turned off. * Various null coalescence within class itself * A test setup change which string_replace()'ed within a serialized string, which invalidates length specifications. Fixed by serializing after replace operations, instead of before. Resolves: #95562 Releases: master Change-Id: Id0b06f1059bfb39296ccdb9cc37ff610652ba3f5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71531 Tested-by:
Oliver Bartsch <bo@cedev.de>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: -
When accessing the Workspaces module in the LIVE workspaces, the underlying code tries to access the list of stages although the LIVE has none. To avoid downstream undefined key errors, return empty list up front. Resolves: #95566 Releases: master Change-Id: If8178e7968d7a6b094c66f1b54a6f47b0a5762a7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71533 Tested-by:
Oliver Bartsch <bo@cedev.de>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Xavier Perseguers <xavier@typo3.org> Tested-by:
Jochen <rothjochen@gmail.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Jochen <rothjochen@gmail.com>
Reviewed-by: -
If no allowed languages are defined for a BE user / group ([allowed_languages] is not set), only broken links in records of the default language were shown for editors. This was incorrect and this patch fixes the problem. Broken links in translated records will now always be shown for editors (if they have write access to the records). Background information: Linkvalidator checks if the current editor has write access to the elements / fields in which the broken links are contained. This ensures that only broken links will be displayed, if the editor can fix them. Resolves: #95467 Releases: master, 10.4 Change-Id: I53f507889a9a275e7aa42994549976a9d38489b7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71430 Tested-by:
Oliver Bartsch <bo@cedev.de>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Jochen <rothjochen@gmail.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Jochen <rothjochen@gmail.com>
Reviewed-by: -
There are few cases where the resulting path from FilePathSanitizer is needed and used as absolute path to a private file. For these usages the file now is returned early. Additionally the logic to make a relative path out of an absolute path is now relaxed a bit, so that legacy usages of this API won't fail any more. An exception is still thrown, when a path from Composer package is requested, that can not be resolved to a public path. Resolves: #95481 Resolves: #95495 Releases: master Change-Id: I8df7d74e6e71154be0508a96cdc19821beeb5ecb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71457 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Oliver Bartsch <bo@cedev.de> -
Christian Kuhn authored
One of the functional test related extensions still sets 'exclude' TCA property for a transOrigPointerField, which is deprecated and migrated away since fixing #89550. Resolves: #95561 Related: #89550 Releases: master Change-Id: I1f5bce2ef3ef6daee0ce57fb0e34bb4a48022fdb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71530 Tested-by:
Oliver Bartsch <bo@cedev.de>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Jochen <rothjochen@gmail.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Jochen <rothjochen@gmail.com>
Reviewed-by: -
Oliver Bartsch authored
This fixes a couple of undefined array key accesses in BackendUserAuthentication->modAccess(). Besides, the code is a bit simplified and some comments are added / fixed. Resolves: #95560 Releases: master Change-Id: I0fb20e1b9783fb770ff344bc0b4dc339f4a2ad50 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71529 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Jochen <rothjochen@gmail.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Jochen <rothjochen@gmail.com>
Reviewed-by: Oliver Bartsch <bo@cedev.de> -
Releases: master Resolves: #95490 Change-Id: I8c7f055182e9a4da8ea5a7a4bd946cc69ce26e0f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71455 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Jochen <rothjochen@gmail.com>
Tested-by: Jochen <rothjochen@gmail.com>
Reviewed-by: -
In PageSlugCandidateProvider the pageCandidate MPVar has been build conditional based on of original MPVar was set. The check did not checked for not existing index which throws an 'undefined index'. This patch uses the correct check to prevent that warning. Resolves: #95546 Releases: master Change-Id: Ib2478b45b769a50ab14eddd220ebbf02a19d3adb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71516 Reviewed-by:
Jochen <rothjochen@gmail.com>
Reviewed-by: core-ci <typo3@b13.com>
Tested-by: Jochen <rothjochen@gmail.com>
Tested-by: -
RedirectsServiceTests simulate frontend requests without executing them really, which prevents from running through the FE Bootstrap stack, thus not all needed stuff are setup correctly, thus throwing a warning that $GLOBALS['BE_USER'] is not defined. This patch initialize a backenduser for the RedirectServiceTest to setup a correct BackendUser object, thus mitigating this warning. Resolves: #95548 Releases: master Change-Id: I8318738e22761f172383db3b981779e331043f3f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71518 Reviewed-by:
Guido Schmechel <guido.schmechel@brandung.de> Reviewed-by:
Jochen <rothjochen@gmail.com>
Reviewed-by: core-ci <typo3@b13.com>
Tested-by: Jochen <rothjochen@gmail.com>
Tested-by: -
Tests in SlugServiceTest from ext:redirects depend on an initialized LanguageService, which has not been done as there are no real frontend request executed, thus the normal FE Bootstrap was not run. This leads to undefined index errors because $GLOBALS['LANG'] is not initalized. The patch initalizes the LanguageService using the Bootstrap::initalizeLanguageObject() in the setup(). Resolves: #95547 Releases: master Change-Id: I53fb8877dd2692968c342e8df266f6268384ed1f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71517 Reviewed-by:
Jochen <rothjochen@gmail.com>
Reviewed-by: core-ci <typo3@b13.com>
Tested-by: Jochen <rothjochen@gmail.com>
Tested-by: -
Initializing LanguageService in $GLOBALS['LANG'] with Bootstrap::initalizeLanguageObject() needs a proper setup $GLOBALS['BE_USER']. The patch moves Bootstrap::initialzeLanguageObject() from abstract testcase to the corresponding setUp() methods user and admin recycler tests after the corresponding backend user is set up. Furthermore some assertions are fine tuned to prevent array access warnings in tests. Resolves: #95549 Releases: master Change-Id: I3a9fed0a6f83e9481b169fb4a476ba2e2235e483 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71519 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Jochen <rothjochen@gmail.com>
Tested-by: Jochen <rothjochen@gmail.com>
Reviewed-by: -
BrokenLinkRepositoryTest of ext:linkvalidator initalizes beuser dynamicly for tests and testdatasets. LanguageService has been initializied once as setup, before a valid beuser was initialized. Thus undefined index BE_USER warnings has been created. This patch (re)initializes the LanguageService using the corresponsign Bootstrap::initializeLanguageObject() method after each backend user initializing, and remove the single to early call from setUp(). Resolves: #95552 Releases: master Change-Id: I89f8e0e6092c1578ef57c20e52b950b9a73996a3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71523 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: -
Install tool has been trying to connect to the database before checking if a bare minimum of configuration is given to. This has been done to decide if the database connect step needs to be shown. Starting with php8.1 this fails hard and the step is not shown, thus an installation cannot be finished. This patch change the checking order and checks for the bare minimum of configuration first, before try to connect to the database. Build/Scripts/runTests.sh -s acceptanceInstall -p 8.1 -d sqlite Build/Scripts/runTests.sh -s acceptanceInstall -p 8.1 -d mariadb Build/Scripts/runTests.sh -s acceptanceInstall -p 8.1 -d mysql Resolves: #95545 Releases: master, 10.4 Change-Id: I9923198b26f86e44fd6c1f6655195faa0c79895e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71514 Tested-by:
core-ci <typo3@b13.com>
Tested-by:
-
