1. 16 Aug, 2021 1 commit
  2. 10 Aug, 2021 1 commit
  3. 20 Jul, 2021 1 commit
  4. 16 Jul, 2021 1 commit
  5. 30 Jun, 2021 2 commits
  6. 22 Jun, 2021 1 commit
  7. 27 May, 2021 1 commit
  8. 05 May, 2021 1 commit
  9. 04 May, 2021 1 commit
  10. 29 Apr, 2021 1 commit
  11. 24 Mar, 2021 1 commit
  12. 18 Mar, 2021 1 commit
  13. 16 Mar, 2021 2 commits
  14. 12 Mar, 2021 1 commit
  15. 23 Feb, 2021 1 commit
  16. 22 Dec, 2020 1 commit
  17. 14 Dec, 2020 1 commit
    • Alexander Schnitzler's avatar
      [TASK] Deprecate @Extbase\Inject · 64c8a784
      Alexander Schnitzler authored and Benjamin Franzke's avatar Benjamin Franzke committed
      Since core dependency injection is in place and is about to
      replace the extbase dependency injection, marking properties
      with the @Extbase\Inject annotation to invoke property injection is
      deprecated and must be replaced by one of the following di
      methods:
      
      - constructor injection: works both with core and extbase di
        and is well suited to make extensions compatible for multiple
        TYPO3 versions.
      
      - setter injection: Basically the same like constructor injection.
        Both the core and extbase di can handle setter injection and
        both are supported in different TYPO3 versions.
      
      - (core) property injection: This kind of injection can be used
        but it requires the configuration of services via a Services.yaml
        in the Configuration folder of an extension.
      
      The recommended way is constructor injection. Not only is it the
      most compatible version of di, it also brings the advantage of
      clearly showing dependencies of a class. Also, it quickly shows
      if dependencies stack up which indicates that the service should
      be refactored.
      
      Releases: master
      Resolves: #92386
      Change-Id: I61afbb6bb15b136c200849c6c8f2cd6211d4c306
      Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65835
      
      
      Tested-by: default avatarTYPO3com <noreply@typo3.com>
      Tested-by: Georg Ringer's avatarGeorg Ringer <georg.ringer@gmail.com>
      Tested-by: Benjamin Franzke's avatarBenjamin Franzke <bfr@qbus.de>
      Reviewed-by: Georg Ringer's avatarGeorg Ringer <georg.ringer@gmail.com>
      Reviewed-by: Benjamin Franzke's avatarBenjamin Franzke <bfr@qbus.de>
      64c8a784
  18. 05 Dec, 2020 1 commit
  19. 29 Nov, 2020 1 commit
  20. 20 Nov, 2020 1 commit
  21. 19 Nov, 2020 2 commits
  22. 17 Nov, 2020 1 commit
  23. 12 Nov, 2020 1 commit
    • Benni Mack's avatar
      [!!!][TASK] Do not create new version placeholders in workspaces anymore · 74899ecf
      Benni Mack authored
      Creating a new record in a workspace adds two database rows.
      
      One that is the "placeholder", which - since v10.4 - contains
      the same metadata as the other record:
      
      * t3ver_wsid = workspaceID
      * t3ver_oid = 0 (simulating behavior of an "online pendant record")
      * t3ver_state = 1
      
      And the "versionized" record, identified by:
      
      * t3ver_wsid = workspaceID
      * t3ver_oid = uid of the new placeholder record
      * t3ver_state = -1
      
      As of TYPO3 v10, the first record is not needed anymore,
      the versioned record can be queried directly, however, since
      the relations (except MM) point to the placeholder record,
      this one is kept.
      
      As result, only one record is created from now on:
      
      * t3ver_wsid = workspaceID
      * t3ver_oid = 0 (no online counterpart)
      * t3ver_state = 1
      
      On reading, the record is queried directly (no overlay needed anymore!)
      with the existing Database Doctrine Restrictions. On publishing, the
      record just gets the state/stage/wsid set and is "live".
      
      This brings fundamental benefits:
      
      * No overlays needed when querying
      * Fewer database records (placeholders are not helpful)
      * Conceptual problems with placeholder and shadowed fields are removed
      
      Resolves: #92791
      Releases: master
      Change-Id: I0288cc63fe72d8442d586f309bd4054ac44e829b
      Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65587
      
      
      Tested-by: default avatarTYPO3com <noreply@typo3.com>
      Tested-by: Christian Kuhn's avatarChristian Kuhn <lolli@schwarzbu.ch>
      Tested-by: Oliver Bartsch's avatarOliver Bartsch <bo@cedev.de>
      Tested-by: Benni Mack's avatarBenni Mack <benni@typo3.org>
      Reviewed-by: Christian Kuhn's avatarChristian Kuhn <lolli@schwarzbu.ch>
      Reviewed-by: Oliver Bartsch's avatarOliver Bartsch <bo@cedev.de>
      Reviewed-by: Benni Mack's avatarBenni Mack <benni@typo3.org>
      74899ecf
  24. 06 Nov, 2020 1 commit
    • Alexander Schnitzler's avatar
      [!!!][TASK] Make Extbase handle PSR-7 responses only · 23b09b8f
      Alexander Schnitzler authored and Daniel Goerz's avatar Daniel Goerz committed
      With this patch, Extbase does no longer handle/return
      extbase responses whose api was defined by the extbase
      ResponseInterfacer. Instead, Extbase does create a PSR-7
      compatible response object and passes it back through
      the request handling stack.
      
      Since PSR-7 requires response objects to be immutable,
      the response object is no longer accessible as property
      of class ActionController. It is also no longer accessible
      through the ControllerContext class. In fact, the response
      is completely hidden from the user and can no longer be
      changed.
      
      To address this issue, an upcoming patch will enable users
      to return user controlled responses from within controller
      actions instead of just returning content strings. User will
      then be forced to return response objects with the content
      and all necessary headers, such as the content-type, set.
      
      Since the Response class has been deleted, it is no longer
      usable in user land code. It should be replaced with PSR-7
      compatible response objects to stay compatible with response
      handlers of both the core and extbase.
      
      Releases: master
      Resolves: #92502
      Change-Id: I4d5dc1478be6dd25b43f6249139eeb4ce5cc3094
      Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66070
      
      
      Tested-by: default avatarTYPO3com <noreply@typo3.com>
      Tested-by: Benni Mack's avatarBenni Mack <benni@typo3.org>
      Tested-by: Daniel Goerz's avatarDaniel Goerz <daniel.goerz@posteo.de>
      Reviewed-by: Benni Mack's avatarBenni Mack <benni@typo3.org>
      Reviewed-by: Daniel Goerz's avatarDaniel Goerz <daniel.goerz@posteo.de>
      23b09b8f
  25. 23 Oct, 2020 1 commit
    • Alexander Schnitzler's avatar
      [!!!][TASK] Request processing chain must return a response object · 723cacda
      Alexander Schnitzler authored and Benni Mack's avatar Benni Mack committed
      This patch introduces a proper request/response handling chain. That
      means, that Extbase no longer creates a response object early, passes
      it through the request handler and dispatcher into the controller and
      expects it to be altered there.
      
      Instead, request handlers, the dispatcher and controllers only get
      passed a request object and controllers are then responsible for
      creating and returning a response.
      
      This change is preparatory work for the introduction of PSR-7 responses
      in Extbase. Those responses are immutable and can no longer passed by
      reference through the stack. Instead, the controller must return the
      desired response along with its state down the stack while remaining
      unaltered.
      
      This patch is considered breaking because it changes several method
      signatures of public classes and interfaces.
      
      Still, it is quite unlikely to be struck by this change when using
      the public api of Extbase and not overriding classes such as the
      ActionController.
      
      Releases: master
      Resolves: #92513
      Change-Id: I3ab7846268ea68727a2f57eea69328b85be4f5e6
      Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66079
      
      
      Tested-by: default avatarTYPO3com <noreply@typo3.com>
      Tested-by: Oliver Bartsch's avatarOliver Bartsch <bo@cedev.de>
      Tested-by: Benni Mack's avatarBenni Mack <benni@typo3.org>
      Reviewed-by: Oliver Bartsch's avatarOliver Bartsch <bo@cedev.de>
      Reviewed-by: Benni Mack's avatarBenni Mack <benni@typo3.org>
      723cacda
  26. 14 Oct, 2020 1 commit
  27. 12 Oct, 2020 1 commit
    • Benni Mack's avatar
      [!!!][TASK] Remove move placeholders · 27c7de8a
      Benni Mack authored and Christian Kuhn's avatar Christian Kuhn committed
      Workspaces ("Element-based versioning") previously had - due to
      the "pid=-1" logic until TYPO3 v10 - a so-called "MOVE PLACEHOLDER".
      
      This was indicated by t3ver_state = 3, all relevant fields:
      * t3ver_state = 3 (move placeholder)
      * t3ver_oid = 0 no connected live record, it allowed fetching these records
        with one query together with live records as db restrictions t3ver_oid > 0
      * t3ver_wsid = workspace UID
      * t3ver_move_id = UID of the live record
      * pid = new PID the version was moved to
      * sorting - when a record was moved within page with activated sorting
      
      Other record fields were not important. However, when moving a record, the
      value from TCA ctrl section "shadowColumnsForMovePlaceholders" was used to
      fill in gaps from the live record.
      
      The ACTUAL versioned record was indicated by t3ver_state = 4, the so-called
      "MOVE POINTER". In previous version until TYPO3 v10, it's PID field was set
      to -1, but since TYPO3 v10, it has the same PID as the "MOVE PLACEHOLDER".
      
      Characteristics of the move pointer as of TYPO3 v10:
      * t3ver_state = 4 (move pointer)
      * t3ver_oid = UID of the live record
      * t3ver_wsid = workspace UID
      * t3ver_move_id = 0
      * pid = PID the version was moved to
      * sorting - same value as the live record (not evaluated until now)
      * All other fields with optionally modified content
      
      Both move placeholder and move pointer did not know each other directly.
      Fetching the move pointer for a move placeheldor (or the other way around)
      involved the live record, leading to many queries.
      
      The patch obsoletes the move placeholder records, moving necessary
      information to the move pointer: It now contains the updated sorting
      and is considered in the Database Restrictions to be fetched.
      
      In general, when publishing, the moved record now
      behaves identical to the other versioned types.
      
      This makes the internal code much easier, creates less DB queries
      on read + write and leads to less DB records in the database.
      
      The change removes creation of move placeholders, and considers the
      move pointers when evaluating sorting and PID in DataHandler.
      
      Read functionality from BackendUtility and PageRepository don't need an
      additional step to fetch the live version of a move placeholder anymore.
      
      An upgrade wizard takes existing move placeholders (state=3), updates
      pid+sorting (PID generally not needed, just to be sure) of the move
      pointer (state=4) and then deletes the move placeholder.
      
      TCA definition $TCA[my-table][ctrl][shadowColumnsForMovePlaceholders]
      is not needed anymore and removed by an auto TCA migration.
      
      Finally, workspace enabled tables do not need the t3ver_move_id field
      anymore: The live record UID is already in t3ver_oid field for state=4
      records, just like with all other versioned records. The field will
      be fully removed with a separate patch in order to keep the actual CSV
      tests readable for this patch.
      
      Resolves: #92497
      Releases: master
      Change-Id: I206336aec8be8a324fefdfd69f648f5a298c6ad1
      Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65797
      
      
      Tested-by: default avatarTYPO3com <noreply@typo3.com>
      Tested-by: Oliver Bartsch's avatarOliver Bartsch <bo@cedev.de>
      Tested-by: Christian Kuhn's avatarChristian Kuhn <lolli@schwarzbu.ch>
      Reviewed-by: Oliver Bartsch's avatarOliver Bartsch <bo@cedev.de>
      Reviewed-by: Christian Kuhn's avatarChristian Kuhn <lolli@schwarzbu.ch>
      27c7de8a
  28. 04 Aug, 2020 1 commit
  29. 30 Jun, 2020 1 commit
  30. 05 Jun, 2020 1 commit
  31. 04 Jun, 2020 1 commit
  32. 03 Jun, 2020 1 commit
  33. 02 Jun, 2020 1 commit
  34. 26 May, 2020 1 commit
  35. 19 May, 2020 1 commit
  36. 12 May, 2020 1 commit
  37. 28 Apr, 2020 1 commit