- 17 Nov, 2021 1 commit
-
-
Resolves: #95729 Releases: master Change-Id: I5020a42d156dbd15202228e963fd8853e123b8bf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72209 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com>
Tested-by:
-
- 10 Nov, 2021 1 commit
-
-
Resolves: #95925 Releases: master Change-Id: I125fcb5e60561646ee8398b0536106a2d5c828ed Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72103 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Nikita Hovratov <nikita.h@live.de> Tested-by:
-
- 13 Oct, 2021 1 commit
-
-
Benjamin Franzke authored
With the deprecation of CacheManager usage during TCA/ext_tables loading in #94979, the console command cache:flush needs to be adapted to avoid CacheManager when loading TCA. BootService is therefore adapted to pass the 'core' cache instance to the respective TCA methods directly, avoiding CacheManager usage inside ExtensionManagementUtility. Resolves: #95638 Related: #94979 Releases: master Change-Id: Icd30835e94fbefdaf3a6b8ee40168e0853207ac9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71636 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Benjamin Franzke <bfr@qbus.de> Reviewed-by:
-
- 12 Oct, 2021 1 commit
-
-
The (ugly) statement strpos($haystack, 'needle') !== false can be safely replaced with str_contains($haystack, 'needle'). This is possible, as a symfony polyfill for php 8.0 functions is in place. Resolves: #95466 Releases: master Change-Id: I313f47832a254c23c6815b6b44557a01019e59e7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71429 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
-
- 03 Oct, 2021 1 commit
-
-
The PackageManager has all information on which packages are installed and how they are named, thus it should serve as only source of truth regarding package path resolving. Resolves: #95435 Releases: master Change-Id: Ib77fdd2a82f6669fc2420ec0e90935c5f1d7dc37 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71405 Tested-by:
core-ci <typo3@b13.com>
Tested-by: 
Simon Gilli <typo3@gilbertsoft.org>
Tested-by: Simon Gilli <typo3@gilbertsoft.org>
Reviewed-by:
-
- 02 Oct, 2021 1 commit
-
-
Core cache is used in many places throughout the core, mostly to cache resources gathered from installed extensions. In every single place the cache identifier for these caches is constructed in a similar, but not identical way. This change aims to unify the cache identifiers and introduce a (private) API to generate a cache identifier same way for all core caches. As a "side effect" all identifier suffixes are now identical and can be recognized to belong together. Releases: master Resolves: #95024 Change-Id: I0e090af636c58795473059191f1e571d5a6c1b73 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70810 Tested-by:
core-ci <typo3@b13.com>
Tested-by:
-
- 24 Sep, 2021 1 commit
-
-
Benni Mack authored
The rule trailing_comma_in_multiline is added to the PHP CS fixer configuration. This reduces possible merge conflicts in the future. The commands to apply the rules over the code base was ./bin/php-cs-fixer fix \ --path-mode intersection \ --config=Build/php-cs-fixer.php \ typo3/sysext And then: ./bin/php-cs-fixer fix --config=Build/php-cs-fixer.php Resolves: #94553 Releases: master Change-Id: I0ebbfa9edbbcde19aaeb44219a71f2f093ab705e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69825 Tested-by:core-ci <typo3@b13.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
-
- 20 Sep, 2021 1 commit
-
-
The navFrameScript / navigationFrameModule functionality, which adds an iFrame for the navigation frame for a specific module has now been deprecated in favor of native custom HTML tags / web components. Resolves: #94094 Releases: master Change-Id: Ieb89f9f87efe0f2f12dd6abe4a8111edda0cd24b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68923 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
- 03 Sep, 2021 1 commit
-
-
Also introduce internal PathUtility API to resolve the web path of extension resources and a helper public API method to check whether a path is an extension resource path. Start using the new API throughout the core. All checks of EXT prefix are replaced, further usages of getAbsoluteWebPath will be replaced in subsequent patches. Releases: master Resolves: #95022 Change-Id: I27994f309af8b35ad3822a5be59d81d164fa9cd0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70805 Tested-by:
core-ci <typo3@b13.com>
Tested-by: 
Oliver Bartsch <bo@cedev.de>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by:
-
- 30 Aug, 2021 1 commit
-
-
A cache:warmup CLI command is added that is safe to be executed during deployment or development mode. It is made extra sure that the command will be executable, even if all caches are stale or even broken. That means this command is able to repair broken di, localconf and tca caches. Technically this became due to preparations for lowlevel cli commands in #86248. Caches that will be warmed up by TYPO3 core: + DI + ext_localconf + TCA + ext_tables + middleware stack + PackageManager + sites-configuration + expressionLanguageProviders + BackendRoutes + l10n (parses all xlf files, and creates cache for all languages) + assets: BackendIcons + dashboard: DashboardPresets + dashboard: WidgetGroups Out of scope or impossible to be warmed: * Frontend warmup: Can be providedby extensions that listen for the CacheWarmupEvent * RequireJS (assets cache): Often applies with context-conditions therefore not reliably warmable. * Extbase – better of for a separate patch intesting cache entries would be: RequestHandlers, ClassSchemata and PersistenceClasses(?) * Warmup of Fluid templates: It is impossible to auto-detect whether all files in Resources/{Templates,Layouts,Partials} are Fluid files. Could by added later on with an explicit registry that allows to define which templates are suitable for warmup. Releases: master Resolves: #93436 Change-Id: I53dd8915a2e06b3d21d778af985c76132e0d4f67 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61645 Tested-by:Helmut Hummel <typo3@helhum.io> Tested-by:
core-ci <typo3@b13.com>
Tested-by:
-
- 25 Aug, 2021 1 commit
-
-
Benni Mack authored
This change is a precursor to https://review.typo3.org/c/Packages/TYPO3.CMS/+/69174 This change effectively: * Centralizes checks to PackageStates.php in Bootstrap * Centralizes some specific Install-Tool functionality in PackageManager * Adds a cache identifier for ext_localconf/TCA/ext_tables.php from the packagemanager The last adaption allows to have custom cache identifier when the active packages have been updated. Resolves: #94987 Releases: master Change-Id: Ibc34fe1084ee42ef0a86e2942c6aed3a345b7188 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70752 Tested-by:
core-ci <typo3@b13.com>
Tested-by:
-
- 24 Aug, 2021 1 commit
-
-
With using a global namespace the usage of use statements is not a problem anymore. Resolves: #94280 Releases: master Change-Id: I642b47b4257c22fa59a812763e5f92d5a0d2236a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70548 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: crell <larry@garfieldtech.com> Reviewed-by:
-
- 08 Aug, 2021 1 commit
-
-
Strip declare declaration from concatenated ext_localconf files. Resolves: #94739 Releases: master Change-Id: I006278888b950a3a4aa105dc6bb822390cd29aef Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70281 Tested-by:
core-ci <typo3@b13.com>
Tested-by:
-
- 04 Aug, 2021 1 commit
-
-
In #94622 the TCA type `category` was introduced as replacement for the CategoryRegistry. Therefore, the CategoryRegistry as well as the API method ExtensionManagementUtility::makeCategorizable() are now deprecated. Resolves: #85613 Related: #94622 Releases: master Change-Id: Ie12a643b97e2149981aec3fb1599bf8c8b4a8d64 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70202 Tested-by:
core-ci <typo3@b13.com>
Tested-by:
-
- 22 Jul, 2021 1 commit
-
-
Fix a PHP Warning on custom auth services that have no service subtype "processLoginDataBE". Resolves: #94599 Releases: master Change-Id: I5046236b659674cebc761861ccf668c9bb226dc5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70012 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
- 12 Jun, 2021 1 commit
-
-
The internal methods `generateItemList()` and `explodeItemList()` from `ExtensionManagementUtility` are unused since v7 and therefore now removed. Resolves: #94314 Releases: master Change-Id: I6db5cf6e198f7d69ecb58c5ca8dec1e24c9c55a4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69463 Tested-by:
core-ci <typo3@b13.com>
Tested-by:
-
- 20 Apr, 2021 1 commit
-
-
Various PHP classes, which were previously a specific implementation for various Link Picker / Element Browser renderings for trees are removed. In addition, the so-called "LegacyTree" is removed along with all entry points, also for the "navFrameScript" of the iframe inside the File main module. Modules who previously registered to the iFrame navigation component are now moved to the new file storage component. Since the related code was marked as internal, the files are removed without substitution. Resolves: #93944 Releases: master Change-Id: Ib42c5b32d44c8a697e250f178280f743b0d7e1da Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68799 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com>
Tested-by:
-
- 14 Mar, 2021 1 commit
-
-
Corrects some wrong language identifiers introduced in #91008 Resolves: #93731 Releases: master, 10.4 Change-Id: I2e33e922a248634f9a6ce10274ca53df1ca447d8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68377 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
-
- 06 Oct, 2020 1 commit
-
-
This patch fixes incompatible type usage in function arguments and is preparatory work for introducing native type hints and strict mode in all core files. Releases: master, 10.4 Resolves: #92279 Change-Id: I469892a56334a13ab19df17aeaa39a68226b7510 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65679 Tested-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
-
- 04 Oct, 2020 1 commit
-
-
Described optional 4th parameter for the $item array, which is used to add items to defined groups from addTcaSelectItemGroup(). Releases: master Resolves: #92479 Change-Id: I837c654c90d6e2305558125e697cde5c520bd271 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66009 Tested-by:
Daniel Haupt <mail@danielhaupt.de> Tested-by:
-
- 18 Sep, 2020 1 commit
-
-
In order to ensure PHP 8 compatibility, PHP methods should not have optional arguments BEFORE required arguments. Resolves: #92140 Releases: master Change-Id: Ia9ee2ba12af0301d7bf2a0defbe6ad64674c1a71 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65742 Tested-by:
-
- 22 Aug, 2020 1 commit
-
-
Helmut Hummel authored
Use IMAGECROPSCALEMASK to render IRRE thumbnails, so that the crop area is properly respected and the TCA configuration for the rendering is applied as well. Also fix the resolving of the crop area, which remained undiscovered, as the crop configuration is ignored with IMAGEPREVIEW processing. Releases: master, 10.4, 9.5 Resolves: #91978 Change-Id: Ia986bc4ec77ce06a9dacbced0b536462f19db1a3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65278 Tested-by:
Tim Schreiner <schreiner.tim@gmail.com> Tested-by:
Simon Praetorius <simon@praetorius.me> Reviewed-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
-
- 06 Aug, 2020 1 commit
-
-
Fixes an obvious PHP notice level error thrown in casual requests multiple times. Resolves: #91945 Releases: master, 10.4 Change-Id: I7d21c0e67ac680443cc0892bfa15ddd45c724b22 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65217 Reviewed-by:
Daniel Siepmann <coding@daniel-siepmann.de>
Reviewed-by:
-
- 09 Jul, 2020 1 commit
-
-
This change removes deprecated functionality: - ReferenceIndex->updateIndex() is now either ProgressListenerInterface or null - ExtensionManagementUtility->findService() expects an array as third argument - BasicFileUtility->setFileExtensionPermissions() removed - GeneralUtility->callUserFunction now expects object or null as third argument - DataMapper->__construct does not expect $query to be set anymore - ObjectAccess->setProperty - fourth argument removed Resolves: #91613 Related: #91473 Releases: master Change-Id: I39fa30f84201b0ed837f6ac0e6d27e1ddb15376d
-
- 05 Jun, 2020 1 commit
-
-
This leaves TYPO3 to only handle "XLF" files for language labels natively. Resolves: #91482 Related: #91473 Releases: master Change-Id: Ibf2d0f087e333ab4874c614880022186634e3dbc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64631 Tested-by:
-
- 31 May, 2020 1 commit
-
-
Various classes and methods are removed, that have been marked as deprecated before. Resolves: #91543 Related: #91473 Releases: master Change-Id: I1dd8b773326c8960b01173003a3251b6ee1d69f1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64616 Tested-by:
-
- 30 May, 2020 1 commit
-
-
Remove a stale comment wrt PackageManager->activePackageDuringRuntime() as that method has been removed in #91477. Drop the setSingletonInstance workaround which was only needed for the runtime activated packages feature to work. Also remove some left over runtimeActivatedPackages logic in various places. Resolves: #91500 Related: #91477 Related: #91473 Releases: master Change-Id: Ia2830c230e2a8b7443bb24a79c81dbf7f2f86226 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64588 Tested-by:
-
- 16 Apr, 2020 1 commit
-
-
This patch has been created with rector and php-cs-fixer bin/rector process --set=php53 typo3/sysext/core/Classes bin/rector process --set=php53 typo3/sysext/core/Tests Resolves: #91054 Releases: master Change-Id: Ie27503980812581103a5d12581a80a7e8fe474f1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64192 Tested-by:Susanne Moog <look@susi.dev> Reviewed-by:
-
- 15 Apr, 2020 2 commits
-
-
Benni Mack authored
Due to the deprecation of "switchable controller actions", list_type items can now be grouped in FormEngine - as well as all other "select" fields defined in TCA. A new TCA option in TCA type=select is added, called "itemGroups". In addition, all "items" now have four parts (fourth being optional) 0 => label 1 => value 2 => icon 3 => groupID where the group belongs to an item group (defined explicitly) or taken from a --div-- element, which then turns into an optgroup. In order then to avoid the "itemProcFunc" of tt_content.list_type which is used to sort items, a "sortOrders" option is added to sort items (within a group, if grouping is enabled) by label or value. When registering a new plugin, the groupId can be added as well as an additional parameter, which falls back to the "default" group. A new method ExtensionManagementUtility::addTcaSelectItemGroup() allows to add item groups via API. When registering extbase Plugins or pibase plugins, it is possible to add a registered "group ID" to make use of this feature. Resolves: #91008 Resolves: #82352 Releases: master Change-Id: I8ad215b5cbc16f332e7c129d762fc020ade5ceeb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63889 Tested-by:
-
With this patch, the header comment of php files is automatically added by the php-cs-fixer, which guarantees that its format and place of occurrence remain the same in all files. Files that are copied over from other projects are excluded. Furthermore, files that are kind of inspired by other projects also get the same header comment but may have a second, additional comment explaining its origin. Used command: bin/php-cs-fixer fix --config=Build/php-cs-fixer/header-comment.php Releases: master Resolves: #91024 Change-Id: I5a040517e0fbde6e5a27d589bf2f222078326dc8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64159 Tested-by:
-
- 14 Apr, 2020 1 commit
-
-
This change adds two changes 'blank_line_after_opening_tag' => true, 'single_trait_insert_per_statement' => true, to our PHP-CS Fixer configuration, adopting more rules related to PSR-12. Resolves: #91020 Releases: master Change-Id: I180b2cbceb077911bddeb42d9f131e5b32244ed2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64158 Tested-by:Josef Glatz <josefglatz@gmail.com> Tested-by:
Oliver Bartsch <bo@cedev.de>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by:
-
- 19 Mar, 2020 1 commit
-
-
When adding a new main module, the "position" is now taken into account, allowing TYPO3 Core also to use the addModule API everywhere. Resolves: #47663 Releases: master Change-Id: I733ee92eada88f09fd247fa818c018dc6bee62d6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63724 Tested-by:
-
- 08 Mar, 2020 2 commits
-
-
Releases: master Resolves: #90668 Change-Id: I92cc4942f9f06d587a7957a94f006d157143e55c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63569 Tested-by:
-
If ExtensionUtility::registerModule is called with a module configuration only containing an icon identifier the default icon of extbase is unset. Resolves: #80844 Releases: master, 9.5 Change-Id: I879b4fad2c6881fface0d64581c031b6ac7589eb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63612 Tested-by:
-
- 14 Feb, 2020 1 commit
-
-
Benni Mack authored
Use code cache properly instead of storing strings into it, because it is proper usage of our API, removes the need for stripping PHP code strings and improves performance when OPCache is in use (which is recommended on production systems). Additionally all calls to ->has are removed, except one place where boolean values are stored in a runtime cache and in tests, because the API guarantees returning "false" when using ->get or ->require Doing so reduces the amount of lookups on the backend storage (file_exists for file backend, SQL queries for DB backend) and makes up more straightforward code in most places (reduces cyclomatic complexity by removing obsolete "else" branching). Releases: master Resolves: #89895 Change-Id: I401512ad4ddffb622ce2f4a9d88274deb4b4e849 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62558 Tested-by:
Achim Fritz <af@achimfritz.de> Tested-by:
-
- 16 Jan, 2020 1 commit
-
-
Benni Mack authored
The description that the extension key should be used - instead of the plugin identifier is wrong, and is now adapted. Resolves: #90113 Releases: master, 9.5 Change-Id: I4928dba4255d46bf72e0a0b45e5ff3360ae718ac Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62921 Tested-by:
Jörg Bösche <typo3@joergboesche.de> Tested-by:
Steffen Frese <steffenf14@gmail.com> Tested-by:
Felix P. <f.pachowsky@neusta.de> Tested-by:
Tobi Kretschmann <tobi@tobishome.de> Reviewed-by:
-
- 09 Jan, 2020 1 commit
-
-
To optimize TYPO3 for Opcaching and speeding up performance, as well as simplyfing the bootstrap (also for the testing framework) the constants * TYPO3_version * TYPO3_branch are moved to a new PHP class "Typo3Version". This reduces the necessity to define the constants, and since TYPO3 Bootstrap continues to use the class, the constants are defined in the constructor for TYPO3 v10, and will be removed in TYPO3 v11. Resolves: #90007 Releases: master Change-Id: I18942023c0e234a328d45f724a6b3092c801982c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62740 Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Reviewed-by:
-
- 30 Dec, 2019 2 commits
-
-
Benni Mack authored
With TYPO3 v8.6, the new Content Types for menus were introduced where each menu type is not stored in the database field "menu_type" anymore, but moved to a separate "CType" property. This change was breaking, however some left-over code was there but never removed. The code does not do anything anymore but handle the special "menu_type" cases like in Page Module CType Previews or categorization handling. FYI: This is a pre-patch to streamline the category API. Resolves: #90035 Releases: master Change-Id: I180fc5b1e2d33f74cf05d2565ab11049cc361c49 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62785 Tested-by:
Benjamin Kott <benjamin.kott@outlook.com> Tested-by:
-
php bin/rector process A couple of rectors have been disabled due to different reasons: - Rector\Php71\Rector\FuncCall\CountOnNullRector This rector has been disabled as it creates rather long and complex structures to avoid calling count on null. This rector will be enabled as soon as TYPO3 uses at least PHP 7.3 which introduces a "is_countable" method. - Rector\Php71\Rector\Assign\AssignArrayToStringRector This rector has been disabled as it does not work properly. The default types of parameters have been changed although their types could properly be inferred by a doc block or by value assignments. - Rector\Php71\Rector\BinaryOp\BinaryOpBetweenNumberAndStringRector This rector has been disabled as it does not work properly. A bug report is filed and to be found here: https://github.com/rectorphp/rector/issues/2454 - Rector\Php71\Rector\FuncCall\RemoveExtraParametersRector This rector has been disabled as it does not work properly. It removed arguments in tests, especially when using prophecies. Releases: master Resolves: #90002 Change-Id: I6ed14d38cc697a23104286db57535d6a3c0dbf62 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62751 Tested-by:
-
- 18 Dec, 2019 1 commit
-
-
php bin/rector process Releases: master Resolves: #89807 Change-Id: I667199693dc519d0353d8e10b40d86faf1cf946a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62448 Tested-by:Jan Stockfisch <typo3@jan-stockfisch.de> Tested-by:
-
