[!!!][TASK] Remove last arguments of wrapClickMenuOnIcon()

Since unrelated functionality was moved to a
dedicated method, the corresponding arguments
are now removed. Therefore, the method does
now always return `string`.

Resolves: #96210
Related: #92583
Releases: main
Change-Id: I498738d37b0fcafda529c119ada7f5ea63c5d663

typo3/sysext/backend/Classes/Utility/BackendUtility.php

@@ -2161,34 +2161,12 @@ class BackendUtility
      * @param int|string $uid If icon is for database record this is the UID for the
      * record from $table or identifier for sys_file record
      * @param string $context Set tree if menu is called from tree view
-     * @param string $_addParams NOT IN USE Deprecated since TYPO3 11, will be removed in TYPO3 12.
-     * @param string $_enDisItems NOT IN USE Deprecated since TYPO3 11, will be removed in TYPO3 12.
-     * @param bool $returnTagParameters If set, will return only the onclick
-     * JavaScript, not the whole link. Deprecated since TYPO3 11, will be removed in TYPO3 12.
      *
-     * @return string|array The link wrapped input string.
+     * @return string The link wrapped input string.
      */
-    public static function wrapClickMenuOnIcon(
-        $content,
-        $table,
-        $uid = 0,
-        $context = '',
-        $_addParams = '',
-        $_enDisItems = '',
-        $returnTagParameters = false
-    ) {
+    public static function wrapClickMenuOnIcon($content, $table, $uid = 0, $context = ''): string
+    {
         $tagParameters = self::getClickMenuOnIconTagParameters((string)$table, $uid, (string)$context);
-
-        if ($_addParams !== '') {
-            trigger_error('Calling BackendUtility::wrapClickMenuOnIcon() with unused 5th parameter is deprecated and will be removed in v12.', E_USER_DEPRECATED);
-        }
-        if ($_enDisItems !== '') {
-            trigger_error('Calling BackendUtility::wrapClickMenuOnIcon() with unused 6th parameter is deprecated and will be removed in v12.', E_USER_DEPRECATED);
-        }
-        if ($returnTagParameters) {
-            trigger_error('Calling BackendUtility::wrapClickMenuOnIcon() with 7th parameter set to true is deprecated and will be removed in v12. Please use BackendUtility::getClickMenuOnIconTagParameters() instead.', E_USER_DEPRECATED);
-            return $tagParameters;
-        }
         return '<a href="#" ' . GeneralUtility::implodeAttributes($tagParameters, true) . '>' . $content . '</a>';
     }
 

typo3/sysext/core/Documentation/Changelog/12.0/Breaking-96107-DeprecatedFunctionalityRemoved.rst

@@ -133,6 +133,7 @@ The following PHP class methods changed signature according to previous deprecat
 
 The following PHP static class methods changed signature according to previous deprecations in v11 at the end of the argument list:
 
+- :php:`\TYPO3\CMS\Backend\Utility\BackendUtility::wrapClickMenuOnIcon()` (arguments 5, 6 and 7 are removed)
 - :php:`\TYPO3\CMS\Core\Utility\ArrayUtility::arrayDiffAssocRecursive()` (argument 3 is removed)
 
 The following PHP class methods changed signature according to previous deprecations in v11 and are now type hinted:

typo3/sysext/filelist/Classes/FileList.php

@@ -535,7 +535,7 @@ class FileList
                             $theData[$field] = htmlspecialchars($this->getLanguageService()->getLL('folder'));
                             break;
                         case 'icon':
-                            $theData[$field] = (string)BackendUtility::wrapClickMenuOnIcon($theIcon, 'sys_file', $folderObject->getCombinedIdentifier());
+                            $theData[$field] = BackendUtility::wrapClickMenuOnIcon($theIcon, 'sys_file', $folderObject->getCombinedIdentifier());
                             break;
                         case 'name':
                             $theData[$field] = $this->linkWrapDir($displayName, $folderObject);
@@ -678,7 +678,7 @@ class FileList
                         $theData[$field] = $this->makePath($fileObject);
                         break;
                     case 'icon':
-                        $theData[$field] = (string)BackendUtility::wrapClickMenuOnIcon($this->getFileOrFolderIcon($fileName, $fileObject), 'sys_file', $fileObject->getCombinedIdentifier());
+                        $theData[$field] = BackendUtility::wrapClickMenuOnIcon($this->getFileOrFolderIcon($fileName, $fileObject), 'sys_file', $fileObject->getCombinedIdentifier());
                         break;
                     case 'name':
                         // Edit metadata of file

typo3/sysext/info/Classes/Controller/PageInformationController.php

@@ -501,7 +501,7 @@ class PageInformationController
         $icon = '<span ' . $toolTip . '>' . $this->iconFactory->getIconForRecord('pages', $row, Icon::SIZE_SMALL)->render() . '</span>';
         // The icon with link
         if ($this->getBackendUser()->recordEditAccessInternals('pages', $row)) {
-            $icon = (string)BackendUtility::wrapClickMenuOnIcon($icon, 'pages', $row['uid']);
+            $icon = BackendUtility::wrapClickMenuOnIcon($icon, 'pages', $row['uid']);
         }
         return $icon;
     }

typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodArgumentDroppedMatcher.php

@@ -247,6 +247,7 @@ return [
         'maximumNumberOfArguments' => 4,
         'restFiles' => [
             'Deprecation-92583-DeprecateLastArgumentsOfWrapClickMenuOnIcon.rst',
+            'Breaking-96107-DeprecatedFunctionalityRemoved.rst',
         ],
     ],
     'TYPO3\CMS\Core\Page\PageRenderer->render' => [