Commit 0193bc7c authored by Oliver Klee's avatar Oliver Klee Committed by Stefan Bürk
Browse files

[BUGFIX] Mark nullable properties in EXT:core as such

Resolves: #97630
Releases: main, 11.5
Change-Id: Id31d1b28929eb85dd2adaa8a263e5d84a2a842b5
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74644


Tested-by: core-ci's avatarcore-ci <typo3@b13.com>
Tested-by: Simon Schaufelberger's avatarSimon Schaufelberger <simonschaufi+typo3@gmail.com>
Tested-by: Stefan Bürk's avatarStefan Bürk <stefan@buerk.tech>
Reviewed-by: crell's avatarcrell <larry@garfieldtech.com>
Reviewed-by: Simon Schaufelberger's avatarSimon Schaufelberger <simonschaufi+typo3@gmail.com>
Reviewed-by: Stefan Bürk's avatarStefan Bürk <stefan@buerk.tech>
parent 074cb535
......@@ -365,11 +365,6 @@ parameters:
count: 1
path: ../../typo3/sysext/core/Classes/Authentication/AbstractUserAuthentication.php
-
message: "#^Property TYPO3\\\\CMS\\\\Core\\\\Authentication\\\\BackendUserAuthentication\\:\\:\\$filePermissions \\(array\\) in isset\\(\\) is not nullable\\.$#"
count: 1
path: ../../typo3/sysext/core/Classes/Authentication/BackendUserAuthentication.php
-
message: "#^Parameter \\#1 \\$separator of function explode expects non\\-empty\\-string, string given\\.$#"
count: 1
......@@ -495,16 +490,6 @@ parameters:
count: 1
path: ../../typo3/sysext/core/Classes/DataHandling/DataHandler.php
-
message: "#^Property TYPO3\\\\CMS\\\\Core\\\\DataHandling\\\\DataHandler\\:\\:\\$checkModifyAccessListHookObjects \\(array\\) in isset\\(\\) is not nullable\\.$#"
count: 1
path: ../../typo3/sysext/core/Classes/DataHandling/DataHandler.php
-
message: "#^Property TYPO3\\\\CMS\\\\Core\\\\DataHandling\\\\DataHandler\\:\\:\\$outerMostInstance \\(TYPO3\\\\CMS\\\\Core\\\\DataHandling\\\\DataHandler\\) in isset\\(\\) is not nullable\\.$#"
count: 1
path: ../../typo3/sysext/core/Classes/DataHandling/DataHandler.php
-
message: "#^Result of && is always true\\.$#"
count: 1
......@@ -695,11 +680,6 @@ parameters:
count: 1
path: ../../typo3/sysext/core/Classes/Error/ErrorHandler.php
-
message: "#^Property TYPO3\\\\CMS\\\\Core\\\\FormProtection\\\\AbstractFormProtection\\:\\:\\$sessionToken \\(string\\) on left side of \\?\\? is not nullable\\.$#"
count: 1
path: ../../typo3/sysext/core/Classes/FormProtection/AbstractFormProtection.php
-
message: "#^Result of && is always true\\.$#"
count: 1
......@@ -990,11 +970,6 @@ parameters:
count: 1
path: ../../typo3/sysext/core/Classes/Package/Cache/PackageStatesPackageCache.php
-
message: "#^Property TYPO3\\\\CMS\\\\Core\\\\Package\\\\Package\\:\\:\\$serviceProvider \\(string\\) on left side of \\?\\? is not nullable\\.$#"
count: 1
path: ../../typo3/sysext/core/Classes/Package/Package.php
-
message: "#^Offset string does not exist on null\\.$#"
count: 1
......@@ -1190,11 +1165,6 @@ parameters:
count: 1
path: ../../typo3/sysext/core/Classes/Resource/OnlineMedia/Processing/PreviewProcessing.php
-
message: "#^Property TYPO3\\\\CMS\\\\Core\\\\Resource\\\\Processing\\\\AbstractGraphicalTask\\:\\:\\$targetFileExtension \\(string\\) in isset\\(\\) is not nullable\\.$#"
count: 1
path: ../../typo3/sysext/core/Classes/Resource/Processing/AbstractGraphicalTask.php
-
message: "#^Strict comparison using \\=\\=\\= between string and null will always evaluate to false\\.$#"
count: 1
......@@ -1265,11 +1235,6 @@ parameters:
count: 1
path: ../../typo3/sysext/core/Classes/Resource/ResourceStorage.php
-
message: "#^Property TYPO3\\\\CMS\\\\Core\\\\Resource\\\\ResourceStorage\\:\\:\\$processingFolder \\(TYPO3\\\\CMS\\\\Core\\\\Resource\\\\Folder\\) in isset\\(\\) is not nullable\\.$#"
count: 1
path: ../../typo3/sysext/core/Classes/Resource/ResourceStorage.php
-
message: "#^If condition is always true\\.$#"
count: 1
......@@ -1315,16 +1280,6 @@ parameters:
count: 1
path: ../../typo3/sysext/core/Classes/Routing/Aspect/PersistedPatternMapper.php
-
message: "#^Property TYPO3\\\\CMS\\\\Core\\\\Routing\\\\Enhancer\\\\AbstractEnhancer\\:\\:\\$variableProcessor \\(TYPO3\\\\CMS\\\\Core\\\\Routing\\\\Enhancer\\\\VariableProcessor\\) in isset\\(\\) is not nullable\\.$#"
count: 1
path: ../../typo3/sysext/core/Classes/Routing/Enhancer/AbstractEnhancer.php
-
message: "#^Unreachable statement \\- code above always terminates\\.$#"
count: 1
path: ../../typo3/sysext/core/Classes/Routing/Enhancer/AbstractEnhancer.php
-
message: "#^Property TYPO3\\\\CMS\\\\Core\\\\Routing\\\\Enhancer\\\\AbstractEnhancer\\:\\:\\$aspects \\(array\\<TYPO3\\\\CMS\\\\Core\\\\Routing\\\\Aspect\\\\AspectInterface\\>\\) on left side of \\?\\? is not nullable\\.$#"
count: 1
......@@ -1375,11 +1330,6 @@ parameters:
count: 1
path: ../../typo3/sysext/core/Classes/Routing/RouteSorter.php
-
message: "#^Property TYPO3\\\\CMS\\\\Core\\\\Routing\\\\UrlGenerator\\:\\:\\$mappableProcessor \\(TYPO3\\\\CMS\\\\Core\\\\Routing\\\\Aspect\\\\MappableProcessor\\) on left side of \\?\\? is not nullable\\.$#"
count: 1
path: ../../typo3/sysext/core/Classes/Routing/UrlGenerator.php
-
message: "#^Comparison operation \"\\>\" between int\\<2, max\\> and 0 is always true\\.$#"
count: 1
......
......@@ -140,7 +140,7 @@ class BackendUserAuthentication extends AbstractUserAuthentication
protected $fileStorages;
/**
* @var array
* @var array|null
*/
protected $filePermissions;
......
......@@ -550,7 +550,7 @@ class DataHandler implements LoggerAwareInterface
protected $disableDeleteClause = false;
/**
* @var array
* @var array|null
*/
protected $checkModifyAccessListHookObjects;
......@@ -558,7 +558,7 @@ class DataHandler implements LoggerAwareInterface
* The outer most instance of \TYPO3\CMS\Core\DataHandling\DataHandler:
* This object instantiates itself on versioning and localization ...
*
* @var \TYPO3\CMS\Core\DataHandling\DataHandler
* @var \TYPO3\CMS\Core\DataHandling\DataHandler|null
*/
protected $outerMostInstance;
......
......@@ -38,7 +38,7 @@ abstract class AbstractFormProtection
/**
* The session token which is used to be hashed during token generation.
*
* @var string
* @var string|null
*/
protected $sessionToken;
......
......@@ -46,7 +46,7 @@ class Package implements PackageInterface
* ServiceProvider class name. This property and the corresponding
* composer.json setting is internal and therefore no api (yet).
*
* @var string
* @var string|null
* @internal
*/
protected $serviceProvider;
......
......@@ -25,7 +25,7 @@ namespace TYPO3\CMS\Core\Resource\Processing;
abstract class AbstractGraphicalTask extends AbstractTask
{
/**
* @var string
* @var string|null
*/
protected $targetFileExtension;
......
......@@ -189,7 +189,7 @@ class ResourceStorage implements ResourceStorageInterface
protected $eventDispatcher;
/**
* @var Folder
* @var Folder|null
*/
protected $processingFolder;
......
......@@ -32,7 +32,7 @@ abstract class AbstractEnhancer implements EnhancerInterface
protected $aspects = [];
/**
* @var VariableProcessor
* @var VariableProcessor|null
*/
protected $variableProcessor;
......
......@@ -26,7 +26,7 @@ use TYPO3\CMS\Core\Routing\Aspect\MappableProcessor;
class UrlGenerator extends SymfonyUrlGenerator
{
/**
* @var MappableProcessor
* @var MappableProcessor|null
*/
protected $mappableProcessor;
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment