Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • C CMS
  • Project information
    • Project information
    • Activity
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Graph
    • Compare
    • Locked Files
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • typo3typo3
  • CI
  • CMS
  • Repository
Switch branch/tag
  • cms
  • typo3
  • sysext
  • impexp
  • Classes
  • ImportExport.php
Find file BlameHistoryPermalink
  • Benni Mack's avatar
    [TASK] Move VerifyDenyPattern functionality into separate logic · e3d0d14a
    Benni Mack authored Jan 10, 2020 and Georg Ringer's avatar Georg Ringer committed Mar 23, 2020
    This change targets a couple of things:
    - The global constant "FILE_DENY_PATTERN_DEFAULT" is moved to a class constant
    - The global constant "PHP_EXTENSIONS_DEFAULT" which is not in use anymore, is removed.
    - The security aspect of checking against the fileDenyPattern is extracted into its own
    Class where
    - The fileDenyPattern can never be empty, but only be set via DefaultConfiguration.
    
    This makes it easier to test this functionality, a single object is taking over the responsibility, and the logic is now in one place. Also, the non-usage of the global constant makes life easier.
    
    Resolves: #90147
    Releases: master
    Change-Id: I9db0d6fc3b10f75a3735017cb9ac0d9bfd4ff02b
    Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62843
    
    
    Tested-by: Oliver Hader's avatarOliver Hader <oliver.hader@typo3.org>
    Tested-by: default avatarTYPO3com <noreply@typo3.com>
    Tested-by: Georg Ringer's avatarGeorg Ringer <georg.ringer@gmail.com>
    Reviewed-by: Oliver Hader's avatarOliver Hader <oliver.hader@typo3.org>
    Reviewed-by: Georg Ringer's avatarGeorg Ringer <georg.ringer@gmail.com>
    e3d0d14a