Skip to content
  • Stefan Bürk's avatar
    [BUGFIX] Raise 3rd party composer packages to composer.lock version · bce2a155
    Stefan Bürk authored and Christian Kuhn's avatar Christian Kuhn committed
    During testing to activate E_ALL and PHP 8.1 testing with activated
    E_ALL, nightly 'composerMin' tests for PHP8.1 are failing with several
    E_DEPRECATED warnings, which was not discoverd in composerLock tests.
    
    Several composer packages, ex. 'symfony/finder' and 'symfony/routing',
    are required with different min versions than written in composer.lock
    file, thus downgrading these components which emits E_DEPRECATED PHP8.1
    warnings in nightly composerMin tests execeuted with PHP 8.1.
    
    'symfony/options-resolver' needs to be added directly, as this has been
    installed as dependency with different lower version constraints for
    'friendsofphp/php-cs-fixer' and 'symfony/rate-limiter', thus we need to
    add it directly with the locked version as min requirement as there are
    no newer versions of these packages with needed min version as required
    version.
    
    'bacon/bacon-qr-code' needs to be raised to avoid a float to int PHP8.1
    conversion warning.
    
    This patch acts as pre-patch to activate E_ALL and PHP 8.1 testing and
    thus raise version of these components to the currently locked version
    in 'composer.lock' file, to be conservative.
    
    Used composer commands:
    
    composer req bacon/bacon-qr-code:^2.0.4
    composer req bacon/bacon-qr-code:^2.0.4 \
      -d typo3/sysext/core --no-update
    
    composer req masterminds/html5:^2.7.5
    composer req masterminds/html5:^2.7.5 \
      -d typo3/sysext/core --no-update
    
    composer req symfony/config:^5.3.4
    composer req symfony/config:^5.3.4 \
      -d typo3/sysext/core --no-update
    
    composer req symfony/console:^5.3.7
    composer req symfony/console:^5.3.7 \
      -d typo3/sysext/core --no-update
    composer req symfony/console:^5.3.7 \
      -d typo3/sysext/redirects --no-update
    
    composer req symfony/dependency-injection:^5.3.7
    composer req symfony/dependency-injection:^5.3.7 \
      -d typo3/sysext/core --no-update
    composer req symfony/dependency-injection:^5.3.7 \
      -d typo3/sysext/extbase --no-update
    composer req symfony/dependency-injection:^5.3.7 \
      -d typo3/sysext/fluid --no-update
    
    composer req symfony/expression-language:^5.3.7
    composer req symfony/expression-language:^5.3.7 \
      -d typo3/sysext/core --no-update
    composer req symfony/expression-language:^5.3.7 \
      -d typo3/sysext/form --no-update
    
    composer req symfony/filesystem:^5.3.4
    composer req symfony/filesystem:^5.3.4 \
      -d typo3/sysext/core --no-update
    
    composer req symfony/finder:^5.3.7
    composer req symfony/finder:^5.3.7 \
      -d typo3/sysext/core --no-update
    composer req symfony/finder:^5.3.7 \
      -d typo3/sysext/install --no-update
    
    composer req symfony/http-foundation:^5.3.7
    composer req symfony/http-foundation:^5.3.7 \
      -d typo3/sysext/core --no-update
    composer req symfony/http-foundation:^5.3.7 \
      -d typo3/sysext/install --no-update
    
    composer req symfony/mailer:^5.3.4
    composer req symfony/mailer:^5.3.4 \
      -d typo3/sysext/core --no-update
    
    composer req symfony/mime:^5.3.7
    composer req symfony/mime:^5.3.7 \
      -d typo3/sysext/core --no-update
    
    composer req symfony/polyfill-intl-normalizer:^1.23.0
    composer req symfony/polyfill-intl-normalizer:^1.23.0 \
      -d typo3/sysext/core --no-update
    
    composer req symfony/polyfill-intl-icu:^1.23.0
    composer req symfony/polyfill-intl-icu:^1.23.0 \
      -d typo3/sysext/core --no-update
    
    composer req symfony/polyfill-intl-idn:^1.23.0
    composer req symfony/polyfill-intl-idn:^1.23.0 \
      -d typo3/sysext/core --no-update
    
    composer req symfony/polyfill-mbstring:^1.23.1
    composer req symfony/polyfill-mbstring:^1.23.1 \
      -d typo3/sysext/core --no-update
    composer req symfony/polyfill-mbstring:^1.23.1 \
      -d typo3/sysext/frontend --no-update
    
    composer req symfony/property-access:^5.3.7
    composer req symfony/property-access:^5.3.7 \
      -d typo3/sysext/extbase --no-update
    
    composer req symfony/property-info:^5.3.7
    composer req symfony/property-info:^5.3.7 \
      -d typo3/sysext/extbase --no-update
    
    composer req symfony/rate-limiter:^5.3.4
    composer req symfony/rate-limiter:^5.3.4 \
      -d typo3/sysext/core --no-update
    
    composer req symfony/routing:^5.3.7
    composer req symfony/routing:^5.3.7 \
      -d typo3/sysext/core --no-update
    
    composer req symfony/var-dumper:^5.3.7
    composer req symfony/var-dumper:^5.3.7 \
      -d typo3/sysext/adminpanel --no-update
    
    composer req symfony/yaml:^5.3.6
    composer req symfony/yaml:^5.3.6 \
     -d typo3/sysext/core --no-update
    
    Following are needed, but are new as direct requirements but locked:
    
    composer req symfony/options-resolver:^5.3.7
    composer req symfony/options-resolver:^5.3.7 \
      -d typo3/sysext/core --no-update
    
    Resolves: #95970
    Releases: master
    Change-Id: I43441ff6ba260721026447c035d0f2a56902119b
    Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72166
    
    
    Tested-by: default avatarcore-ci <typo3@b13.com>
    Tested-by: default avatarJochen <rothjochen@gmail.com>
    Tested-by: default avatarChristian Kuhn <lolli@schwarzbu.ch>
    Reviewed-by: default avatarOliver Klee <typo3-coding@oliverklee.de>
    Reviewed-by: default avatarJochen <rothjochen@gmail.com>
    Reviewed-by: default avatarChristian Kuhn <lolli@schwarzbu.ch>
    bce2a155
Analyzing file…