Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • C CMS
  • Project information
    • Project information
    • Activity
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Graph
    • Compare
    • Locked Files
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • typo3typo3
  • CI
  • CMS
  • Repository
Switch branch/tag
  • cms
  • ..
  • Controller
  • ActionController.php
Find file BlameHistoryPermalink
  • Christian Kuhn's avatar
    [TASK] Deprecate extbase StopActionException · 8ada892a
    Christian Kuhn authored Jun 15, 2021
    There are three possible cases an extbase controller
    action can come up with:
    a) Return a casual psr-7 response (html, json, ...)
    b) Return an extbase specific ForwardResponse to dispatch
       extbase-internally to another action.
    c) Have a redirect the client should receive to
       call some other Url.
    
    a) and b) are simple in v11 - the action returns a
    PSR-7 ResponseInterface. c) however throws StopActionException
    instead, which is caught by extbase Dispatcher and
    then returned. This is ugly.
    
    The patch changes this and deprecates the StopActionException.
    We can not drop the throw call since that would be breaking,
    but we prepare towards a clean v12 solution, which leads to
    the sitation that *all* extbase actions return a response.
    
    Resolves: #94351
    Releases: master
    Change-Id: Ie5a53109959a008ab1666f52d5a81e6e7ba3efdb
    Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69498
    
    
    Tested-by: core-ci's avatarcore-ci <typo3@b13.com>
    Tested-by: Daniel Goerz's avatarDaniel Goerz <daniel.goerz@posteo.de>
    Tested-by: Anja Leichsenring's avatarAnja Leichsenring <aleichsenring@ab-softlab.de>
    Tested-by: Christian Kuhn's avatarChristian Kuhn <lolli@schwarzbu.ch>
    Reviewed-by: Daniel Goerz's avatarDaniel Goerz <daniel.goerz@posteo.de>
    Reviewed-by: Anja Leichsenring's avatarAnja Leichsenring <aleichsenring@ab-softlab.de>
    Reviewed-by: Christian Kuhn's avatarChristian Kuhn <lolli@schwarzbu.ch>
    8ada892a