Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • C CMS
  • Project information
    • Project information
    • Activity
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Graph
    • Compare
    • Locked Files
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • typo3typo3
  • CI
  • CMS
  • Repository
Switch branch/tag
  • cms
  • ..
  • Fixtures
  • input_page_with_broken_link_external_...
Find file BlameHistoryPermalink
  • Christian Kuhn's avatar
    [BUGFIX] Speed up linkvalidator functional tests · 4bfdf830
    Christian Kuhn authored Nov 26, 2021
    The ext:linkvalidator functional tests work with a
    fictional domain name to test if the code finds broken
    external links.
    
    This can be unfortunate since it triggers DNS lookups
    that can be slow - such stuff should be avoided in
    functional tests anyway.
    
    Solution is to use localhost as test domain with an
    invalid path instead. This is more expressive, too.
    
    The result can be stunning: My DNS resolver for whatever
    reason takes ages to (not) resolve that domain using
    dockerized runTests.sh. I got a similar result from
    another coredev. The linkvalidator tests run nearly
    five minutes without the patch and are down to two
    seconds with patch.
    
    Resolves: #96087
    Releases: master, 11.5
    Change-Id: Idbb32ac57925c52d4cef9e8d412d56347f09a04e
    Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72312
    
    
    Tested-by: Stefan Bürk's avatarStefan Bürk <stefan@buerk.tech>
    Tested-by: core-ci's avatarcore-ci <typo3@b13.com>
    Tested-by: Benni Mack's avatarBenni Mack <benni@typo3.org>
    Tested-by: Christian Kuhn's avatarChristian Kuhn <lolli@schwarzbu.ch>
    Reviewed-by: Stefan Bürk's avatarStefan Bürk <stefan@buerk.tech>
    Reviewed-by: Benni Mack's avatarBenni Mack <benni@typo3.org>
    Reviewed-by: Christian Kuhn's avatarChristian Kuhn <lolli@schwarzbu.ch>
    4bfdf830