Skip to content
  • Alexander Schnitzler's avatar
    [TASK] Apply rector set php71 · 2db847fb
    Alexander Schnitzler authored and Anja Leichsenring's avatar Anja Leichsenring committed
    
    
        php bin/rector process
    
    A couple of rectors have been disabled due to different reasons:
    
    - Rector\Php71\Rector\FuncCall\CountOnNullRector
      This rector has been disabled as it creates rather long and
      complex structures to avoid calling count on null.
    
      This rector will be enabled as soon as TYPO3 uses at least
      PHP 7.3 which introduces a "is_countable" method.
    
    - Rector\Php71\Rector\Assign\AssignArrayToStringRector
      This rector has been disabled as it does not work properly.
      The default types of parameters have been changed although
      their types could properly be inferred by a doc block or
      by value assignments.
    
    - Rector\Php71\Rector\BinaryOp\BinaryOpBetweenNumberAndStringRector
      This rector has been disabled as it does not work properly.
      A bug report is filed and to be found here:
      https://github.com/rectorphp/rector/issues/2454
    
    - Rector\Php71\Rector\FuncCall\RemoveExtraParametersRector
      This rector has been disabled as it does not work properly.
      It removed arguments in tests, especially when using
      prophecies.
    
    Releases: master
    Resolves: #90002
    Change-Id: I6ed14d38cc697a23104286db57535d6a3c0dbf62
    Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62751
    Tested-by: default avatarTYPO3com <noreply@typo3.com>
    Tested-by: default avatarBenni Mack <benni@typo3.org>
    Tested-by: default avatarAnja Leichsenring <aleichsenring@ab-softlab.de>
    Reviewed-by: default avatarBenni Mack <benni@typo3.org>
    Reviewed-by: default avatarAnja Leichsenring <aleichsenring@ab-softlab.de>
    2db847fb