ViewHelper or Partial / Section for the Buttons on the detail page
Each button on the detail page has a lot of things in common.
- render if exists only
- rel=nofollow and target=_blank
- an icon
- a text
A ViewHelper, partial or section with following arguments would increase the readability in my opinion:
- label
- icon
- uri
Example
Before
<f:if condition="{extension.forgeLink}">
<f:link.external class="btn btn-secondary btn-block" rel="nofollow" uri="{extension.forgeLink}" target="_blank">
<i class="fa fa-hand-o-right"></i> Found an Issue?
</f:link.external>
</f:if>After
<t3ext:externalLink label="Found an Issue?" uri="{extension.forgeLink}" icon="fa-hand-o-right"/>Acceptance Criteria:
- proper partial
- current link buttons on the detail page are rendered using the new partial