Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • E extensions.typo3.org
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 80
    • Issues 80
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 4
    • Merge requests 4
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • servicesservices
  • t3o sites
  • extensions.typo3.org
  • extensions.typo3.org
  • Issues
  • #445
Closed
Open
Issue created Apr 09, 2020 by Alexander Nostadt@ano🇩🇪Contributor2 of 2 checklist items completed2/2 checklist items

ViewHelper or Partial / Section for the Buttons on the detail page

Each button on the detail page has a lot of things in common.

  • render if exists only
  • rel=nofollow and target=_blank
  • an icon
  • a text

A ViewHelper, partial or section with following arguments would increase the readability in my opinion:

  • label
  • icon
  • uri

Example

Before

<f:if condition="{extension.forgeLink}">
  <f:link.external class="btn btn-secondary btn-block" rel="nofollow" uri="{extension.forgeLink}" target="_blank">
    <i class="fa fa-hand-o-right"></i> Found an Issue?
  </f:link.external>
</f:if>

After

<t3ext:externalLink label="Found an Issue?" uri="{extension.forgeLink}" icon="fa-hand-o-right"/>

Acceptance Criteria:

  • proper partial
  • current link buttons on the detail page are rendered using the new partial
Edited Apr 17, 2020 by Alexander Nostadt
Assignee
Assign to
Time tracking