Michael Stucki authored May 25, 2016 and Philipp Gampe committed May 25, 2016

It looks like RealUrl on typo3.org has bugs related to cHash caching.
It happened several times that caching was disabled because the
stored cHash for a speaking URL was wrong.

The fix for this was to clear the tx_realurl_chashcache table.
However, this led to even more problems because now the wrong entries
are displayed on the details page of extensions.

It's assumed that this is all caused by an old (and patched) RealUrl
version on typo3.org. Until it is replaced, the workaround is to change
the list view for extensions to USER_INT.

Change-Id: I407545c319c6248b071b4844aef1d72bedca6d5a
Reviewed-on: https://review.typo3.org/48285


Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Tested-by: Philipp Gampe <philipp.gampe@typo3.org>

Due to problems with the main release version change from
2 to 1 digits, the check is corrected now.
It takes now only the 3000 newest records.

Change-Id: Ic0f7c90295cb101d8b42d117ed76e6a7d5d55723
Reviewed-on: https://review.typo3.org/48147


Reviewed-by: Thomas Löffler <loeffler@spooner-web.de>
Tested-by: Thomas Löffler <loeffler@spooner-web.de>

Change-Id: Iaedd98afe17f0c1269f20728009d567715778fc6
Reviewed-on: https://review.typo3.org/48146


Reviewed-by: Thomas Löffler <loeffler@spooner-web.de>
Tested-by: Thomas Löffler <loeffler@spooner-web.de>

Due to the change of main release from 2 to 1 digit
there were many false positives in the outdated task run.

Change-Id: I4e472fe5c77553ad972df430be6f5be23d441040
Reviewed-on: https://review.typo3.org/48135


Reviewed-by: Thomas Löffler <loeffler@spooner-web.de>
Tested-by: Thomas Löffler <loeffler@spooner-web.de>

Currently extensions which were uploaded by using a zip archive have an
empty dependency added when installing through extension manager. This
results in an exception during installation and prevents correct working
systems.

Change-Id: Ic64e536793dcaab37bf8fbbc0ce15f06bc472f78
Reviewed-on: https://review.typo3.org/47362


Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>

Change-Id: I95d78cf864bec794f483521c1617a05dfcdaca53
Reviewed-on: https://review.typo3.org/47146


Reviewed-by: Thomas Löffler <loeffler@spooner-web.de>
Tested-by: Thomas Löffler <loeffler@spooner-web.de>

For links to the same page we only need a relative
link.
Especially for solr index which saves the absolute
url and prevents the switch to https.

Change-Id: Ic272c33f69664a7d0a0442fb16223eb827d71571
Relates: #65880
Reviewed-on: https://review.typo3.org/46170


Tested-by: Thomas Löffler <loeffler@spooner-web.de>
Reviewed-by: Thomas Löffler <loeffler@spooner-web.de>

Change-Id: I706bd0dbc6f916c791c9df92f7c1a2afe7ffeb29
Reviewed-on: https://review.typo3.org/46518


Reviewed-by: Thomas Löffler <loeffler@spooner-web.de>
Tested-by: Thomas Löffler <loeffler@spooner-web.de>

Helmut Hummel authored Jan 30, 2016 and Thomas Löffler committed Mar 07, 2016

This method will be needed in ter extension

Change-Id: Ifd29721a9ae2fcadf7d30907106ba06606392e2c
Reviewed-on: https://review.typo3.org/46417


Reviewed-by: Thomas Löffler <loeffler@spooner-web.de>
Tested-by: Thomas Löffler <loeffler@spooner-web.de>

* Corrects ZIP file location in file system
* Changes check if file exists
* Corrects path to ZIP and T3X files

Change-Id: Ib6482d7acb87a0bbefb547696fff0e969df31018
Reviewed-on: https://review.typo3.org/42396


Tested-by: Thomas Löffler <loeffler@spooner-web.de>
Reviewed-by: Thomas Löffler <loeffler@spooner-web.de>

Thomas Löffler authored Dec 05, 2015 and Philipp Gampe committed Dec 05, 2015

Change-Id: I5546c35bc031cc02d701bba663f1edc7c8a6820e
Reviewed-on: https://review.typo3.org/45134


Tested-by: Thomas Löffler <loeffler@spooner-web.de>
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Tested-by: Philipp Gampe <philipp.gampe@typo3.org>

Thomas Löffler authored Oct 01, 2015 and Cedric Ziel committed Dec 01, 2015

Review state (-2) means outdated

Change-Id: I4eb153ea21933c1b715856c99e6e472af2d64c0c
Reviewed-on: https://review.typo3.org/43690


Reviewed-by: Cedric Ziel <cedric@cedric-ziel.com>
Tested-by: Cedric Ziel <cedric@cedric-ziel.com>

Stefan Busemann authored Jul 16, 2015 and Cedric Ziel committed Dec 01, 2015

Adds checkbox in upload form and error
if checkbox was not checked for upload

Change-Id: I6fadb1791ab4890dbb54650b9cf0df394e2108b2
Resolves: #25731
Reviewed-on: https://review.typo3.org/41504


Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Reviewed-by: Cedric Ziel <cedric@cedric-ziel.com>
Tested-by: Cedric Ziel <cedric@cedric-ziel.com>

Due to always providing a ZIP download
the table header section with big download
buttons has to show the ZIP file as well.

Change-Id: Id4e17d2063d7eb06826abb7e84f19a4d83dd1b14
Resolves: #68963
Reviewed-on: http://review.typo3.org/42530


Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Thomas Löffler <loeffler@spooner-web.de>
Reviewed-by: Stefan Busemann <stefan.busemann@in2code.de>
Reviewed-by: Thomas Löffler <loeffler@spooner-web.de>

Change-Id: Ied9469f5b389bb25f44264ece56b8be486bbef3c
Reviewed-on: http://review.typo3.org/42341


Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Tested-by: Xavier Perseguers <xavier@typo3.org>
Reviewed-by: Thomas Löffler <loeffler@spooner-web.de>
Tested-by: Thomas Löffler <loeffler@spooner-web.de>

This change adds a simple controller that outputs
all extensions, that should be loaded from the
repository clone url instead of the TER.

Example json:

{
  "meta":null,
  "data":{
    "templavoila":{
      "repository_clone_url": "https://github.com/alexanderschnitzler/templavoila.git"
    },
    "gridelements":{
      "repository_clone_url": "https://github.com/typo3-ter/gridelements.git"
    }
  }
}

Resolves: #68439
Change-Id: I1d52edac62e905c55dde99ecac316382a2998bdb
Reviewed-on: http://review.typo3.org/41906


Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Thomas Löffler <loeffler@spooner-web.de>
Tested-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Tested-by: Thomas Löffler <loeffler@spooner-web.de>

Alexander Schnitzler authored Jul 23, 2015 and Thomas Löffler committed Jul 30, 2015

Adds an input field in the extension edit form
that lets extension authors enter a publicly
available url for their repository - like github,
bitbucket or git.typo3.org - that then will be
used as package source on composer.typo3.org

Resolves: #68438
Change-Id: Id317b598ef227d2ed5aeb3c5cb62a903192625d3
Reviewed-on: http://review.typo3.org/41872


Reviewed-by: Tomas Norre Mikkelsen <tomasnorre@gmail.com>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Thomas Löffler <loeffler@spooner-web.de>
Tested-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Tested-by: Thomas Löffler <loeffler@spooner-web.de>

Thomas Löffler authored Nov 30, 2014 and Tomas Norre Mikkelsen committed Jul 27, 2015

Due to fetching the JSON file from a remote
server causes some time, the data will be
fetched now from an existing local file.

Needs: https://review.typo3.org/#/c/34804/

Change-Id: I9f16a6c80e7f66feb23256b9874c0ff0f0f6741c
Relates: #62510
Reviewed-on: http://review.typo3.org/34805


Tested-by: Thomas Löffler <loeffler@spooner-web.de>
Reviewed-by: Tomas Norre Mikkelsen <tomasnorre@gmail.com>

Thomas Löffler authored Apr 04, 2015 and Tomas Norre Mikkelsen committed Jul 27, 2015

Due to the not working condition the solr re-index
is not activating after setting a version as outdated.

Change-Id: I7ffaab057f55a6d306e6efc64682711162ac4f30
Relates: #54383
Reviewed-on: http://review.typo3.org/38477


Tested-by: Thomas Löffler <loeffler@spooner-web.de>
Reviewed-by: Tomas Norre Mikkelsen <tomasnorre@gmail.com>

Thomas Löffler authored Mar 29, 2015 and Tomas Norre Mikkelsen committed Jul 27, 2015

One must not know the whole path to the ZIP or T3X file

Change-Id: I06b11e843356eb8b3b609db7fbe7f49d529fb14f
Reviewed-on: http://review.typo3.org/38334


Tested-by: Thomas Löffler <loeffler@spooner-web.de>
Reviewed-by: Tomas Norre Mikkelsen <tomasnorre@gmail.com>

Generates ZIP file from existing T3X file on demand.
If ZIP file exists it will be downloaded directly

Change-Id: I3a30a398dc3683386b51e9bf9bf3faa16d91e494
Reviewed-on: http://review.typo3.org/38329


Reviewed-by: Cedric Ziel <cedric@cedric-ziel.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Thomas Löffler <loeffler@spooner-web.de>
Reviewed-by: Ingo Pfennigstorf <i.pfennigstorf@gmail.com>

Thomas Löffler authored Jul 01, 2015 and Ingo Pfennigstorf committed Jul 06, 2015

Change-Id: Ia28a2c266678fdc7b883538fe81ba45d9fc9366b
Resolves: #67833
Reviewed-on: http://review.typo3.org/40799


Reviewed-by: Cedric Ziel <cedric@cedric-ziel.com>
Tested-by: Cedric Ziel <cedric@cedric-ziel.com>

Thomas Löffler authored Apr 12, 2015 and Ingo Pfennigstorf committed Apr 25, 2015

Change-Id: Ibae0bd4958f287e95d42d3f72858c4c37f731713
Reviewed-on: http://review.typo3.org/38640


Tested-by: Thomas Löffler <loeffler@spooner-web.de>
Reviewed-by: Cedric Ziel <cedric@cedric-ziel.com>
Tested-by: Cedric Ziel <cedric@cedric-ziel.com>
Reviewed-by: Ingo Pfennigstorf <i.pfennigstorf@gmail.com>
Tested-by: Ingo Pfennigstorf <i.pfennigstorf@gmail.com>

Change-Id: I6a8825f3188b75ca686d333670dd3a0e2fe4c41f
Resolves: #64240
Reviewed-on: http://review.typo3.org/38451


Tested-by: Thomas Löffler <loeffler@spooner-web.de>
Reviewed-by: Soren Malling <soren.malling@gmail.com>
Reviewed-by: Cedric Ziel <cedric@cedric-ziel.com>
Tested-by: Cedric Ziel <cedric@cedric-ziel.com>

Due to timeout when fetching data from
metrics.typo3.org.

Change-Id: Ie971bfb6bde0a9760607011032ee4d3f822cf6e6
Resolves: #62510
Reviewed-on: http://review.typo3.org/34806


Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Reviewed-by: Thomas Löffler <loeffler@spooner-web.de>
Tested-by: Thomas Löffler <loeffler@spooner-web.de>
Reviewed-by: Cedric Ziel <cedric@cedric-ziel.com>
Tested-by: Cedric Ziel <cedric@cedric-ziel.com>
Reviewed-by: Ingo Pfennigstorf <i.pfennigstorf@gmail.com>

If the latest version of an extension is insecure
the download button has to disappear.

Change-Id: I91cb822060d7f716f60aba0526d16885bb3a98a8
Resolves: #61545
Reviewed-on: http://review.typo3.org/33989


Tested-by: Thomas Löffler <loeffler@spooner-web.de>
Reviewed-by: Tomas Norre Mikkelsen <tomasnorre@gmail.com>
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>

Due to the check for review_state < 0 all versions that
are outdated (-2) will be shown as insecure (-1)

Change-Id: I6efa22a55a8fd0dac0c5ce1c326858bb4f795185
Resolves: #62865
Reviewed-on: http://review.typo3.org/33988


Reviewed-by: Tomas Norre Mikkelsen <tomasnorre@gmail.com>
Tested-by: Thomas Löffler <loeffler@spooner-web.de>
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>

Xavier Perseguers authored Sep 26, 2014 and Thomas Löffler committed Nov 11, 2014

Whenever an external manual is defined and the extension does not
provide an embedded extension manual, link to the external manual
should replace the standard link.

Change-Id: I96ce5074467e07716ddab5c4b249a6b92b085063
Resolves: #61899
Reviewed-on: http://review.typo3.org/32981


Reviewed-by: Tomas Norre Mikkelsen <tomasnorre@gmail.com>
Reviewed-by: Thomas Löffler <loeffler@spooner-web.de>
Tested-by: Thomas Löffler <loeffler@spooner-web.de>

Thomas Löffler authored Aug 07, 2014 and Philipp Gampe committed Aug 29, 2014

Resolves: #60917
Change-Id: I0031bb09e980681cb8ccaae038d28806a92c3b76
Reviewed-on: http://review.typo3.org/32040


Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Tested-by: Philipp Gampe <philipp.gampe@typo3.org>

* Touches the extension's timestamp for indexer

Change-Id: I59edd6e2bb34d6044adb012b688a7aaa35b648ae
Resolves: #54383
Reviewed-on: http://review.typo3.org/31499


Reviewed-by: Christian Zenker <typo3@xopn.de>
Tested-by: Christian Zenker <typo3@xopn.de>

Change-Id: Ifb8fbd8206d330cc71adaea035e7d4f8678db248
Reviewed-on: http://review.typo3.org/32525


Reviewed-by: Christian Zenker <typo3@xopn.de>
Tested-by: Christian Zenker <typo3@xopn.de>

Thomas Löffler authored Aug 07, 2014 and Tomas Norre Mikkelsen committed Aug 29, 2014

Resolves: #60918
Change-Id: I03dfa545ad22681c211e0780991cd855b33ff3f3
Reviewed-on: http://review.typo3.org/32039


Reviewed-by: Tomas Norre Mikkelsen <tomasnorre@gmail.com>
Tested-by: Tomas Norre Mikkelsen <tomasnorre@gmail.com>

Remove outdated extensions in list
"Other extensions from that owner"

Resolves: #60732
Change-Id: Ic42769241e1d2994f8cd7bb95b4f34b4898f1fd4
Reviewed-on: http://review.typo3.org/31990


Reviewed-by: Thomas Löffler <loeffler@spooner-web.de>
Tested-by: Thomas Löffler <loeffler@spooner-web.de>

The TER frontend upload needs to extract various information
(description, state, dependecies, title, etc) from the extensions
em_conf.php file.
This file is user generated and could contain malicious code.

As collecting all information via the web interface is not feasible,
we parse the file with PHP-Parser and evalute save parts of the code.

PHP-Parser turns the file into an AST. Then we can traverse it and
remove any nodes that are not scalars or arrays.
Additionally we check that we only have one assignment and that we
only assign to $EM_CONF.

The save AST is then turned back into PHP code and eval'd such that
we get access to the data.

The TER SOAP API is not affected, because the ext_emconf.php file
contents are provided as array and not as file.

Change-Id: I41ac8aedc3a233b5d56caa9c11eed4075d380537
Reviewed-on: http://review.typo3.org/31940


Reviewed-by: Christian Zenker <typo3@xopn.de>
Tested-by: Christian Zenker <typo3@xopn.de>

Christian Zenker authored Jul 26, 2014 and Thomas Löffler committed Jul 27, 2014

Extbase keeps all constituted objects in a cache so it can return
the identical object again if it is needed in any other relation.
This leads to all Versions being in memory at some point blocking
lots of RAM.

Measuring on the vagrant box showed that the needed memory increases
linear by about 30kb per treated version. In the initial run about
30.000 versions need to be checked. A test run on deploy showed
that even setting the memory_limit to 1G is not enough.

As every Version and Relation is only needed once during the
scheduler run their memory might as well be freed after processing.

The patch refactors the code and introduces new code in the
cleanupMemory() method. It removes the constituted objects
the extbase caches so Garbage Collection can free the memory again.

Change-Id: If4f915b76b986e91c140d6386ea0a5c2e540dfcf
Reviewed-on: http://review.typo3.org/31856


Reviewed-by: Christian Zenker <typo3@xopn.de>
Tested-by: Christian Zenker <typo3@xopn.de>
Reviewed-by: Thomas Löffler <loeffler@spooner-web.de>
Tested-by: Thomas Löffler <loeffler@spooner-web.de>

Philipp Gampe authored Jul 25, 2014 and Tomas Norre Mikkelsen committed Jul 25, 2014

If the fe_users record does not exists, the owner entry in the
extension single view is skipped.

Resolves: #60557
Change-Id: I0c4ab23f712d160078289f027cafc69c95ee8406
Reviewed-on: http://review.typo3.org/31800


Reviewed-by: Tomas Norre Mikkelsen <tomasnorre@gmail.com>
Tested-by: Tomas Norre Mikkelsen <tomasnorre@gmail.com>

Thomas Löffler authored Jul 04, 2014 and Philipp Gampe committed Jul 25, 2014

The translation key "msg.version_not_found" is missing.
Add it to the translation file.

Change-Id: I2b7c5c8633465c97d1369d0e2326ff8f9b265b33
Resolves: #59236
Reviewed-on: http://review.typo3.org/31318


Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Tested-by: Philipp Gampe <philipp.gampe@typo3.org>

Thomas Löffler authored Jul 04, 2014 and Tomas Norre Mikkelsen committed Jul 25, 2014

Builds url with all needed data and creates the
flattr "thing" on the first click and donation.

Change-Id: Ie60155d44858de43cb86f3a590def19f70c064c9
Resolves: #51721
Reviewed-on: http://review.typo3.org/31325


Reviewed-by: Tomas Norre Mikkelsen <tomasnorre@gmail.com>
Tested-by: Tomas Norre Mikkelsen <tomasnorre@gmail.com>

Extension "news" with dependency "6.2.2-6.2.99"
was set as outdated because of wrong check

Adds a unit test for this case

Change-Id: I7c3fc476395a611077877436859648741c5150f2
Relates: #54383
Reviewed-on: http://review.typo3.org/31779


Reviewed-by: Christian Zenker <typo3@xopn.de>
Tested-by: Christian Zenker <typo3@xopn.de>

Change-Id: I921c3ddcb4aee074a64dd78abcbc621d01fbba54
Reviewed-on: http://review.typo3.org/31764


Reviewed-by: Christian Zenker <typo3@xopn.de>
Tested-by: Christian Zenker <typo3@xopn.de>
Reviewed-by: Thomas Löffler <loeffler@spooner-web.de>
Tested-by: Thomas Löffler <loeffler@spooner-web.de>