Skip to content
GitLab
Menu
Projects
Groups
Snippets
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Sign in
Toggle navigation
Menu
Open sidebar
services
t3o sites
extensions.typo3.org
extensions.typo3.org
Commits
3a26888e
Commit
3a26888e
authored
May 28, 2018
by
Helmut Hummel
Committed by
Thomas Löffler
Jun 06, 2018
Browse files
Ensure only valid composer names are exposed via API
parent
5d88752e
Changes
1
Show whitespace changes
Inline
Side-by-side
html/typo3conf/ext/ter_fe2/Classes/Controller/Eid/ExtensionController.php
View file @
3a26888e
...
...
@@ -14,6 +14,9 @@ namespace T3o\TerFe2\Controller\Eid;
* The TYPO3 project - inspiring people to share!
*/
use
TYPO3\CMS\Core\Database\ConnectionPool
;
use
TYPO3\CMS\Core\Utility\GeneralUtility
;
/**
* Class \T3o\TerFe2\Controller\Eid\ExtensionController
*/
...
...
@@ -59,13 +62,33 @@ class ExtensionController
*/
protected
function
findAllWithValidComposerName
()
{
$extensions
=
$this
->
databaseConnection
->
exec_SELECTgetRows
(
'*'
,
$queryBuilder
=
GeneralUtility
::
makeInstance
(
ConnectionPool
::
class
)
->
getQueryBuilderForTable
(
'tx_terfe2_domain_model_extension'
);
$expr
=
$queryBuilder
->
expr
();
$result
=
$queryBuilder
->
select
(
'tx_terfe2_domain_model_extension.composer_name'
,
'tx_terfe2_domain_model_version.composer_info'
)
->
from
(
'tx_terfe2_domain_model_extension'
)
->
join
(
'tx_terfe2_domain_model_extension'
,
'hidden = 0 and deleted = 0 and composer_name <> ""'
);
'tx_terfe2_domain_model_version'
,
'tx_terfe2_domain_model_version'
,
$expr
->
eq
(
'tx_terfe2_domain_model_extension.last_version'
,
'tx_terfe2_domain_model_version.uid'
)
)
->
where
(
$expr
->
neq
(
'tx_terfe2_domain_model_extension.composer_name'
,
$queryBuilder
->
createNamedParameter
(
''
)
)
)
->
execute
();
foreach
(
$extensions
as
$extension
)
{
while
(
$extension
=
$result
->
fetch
())
{
$latestVersionComposerInfo
=
@
json_decode
(
$extension
[
'composer_info'
],
true
);
if
(
empty
(
$latestVersionComposerInfo
[
'name'
])
||
$latestVersionComposerInfo
[
'name'
]
!==
$extension
[
'composer_name'
])
{
continue
;
}
$this
->
jsonArray
[
'data'
][
$extension
[
'ext_key'
]]
=
array
(
'composer_name'
=>
$extension
[
'composer_name'
],
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment