This project is mirrored from https://git.typo3.org/typo3/typo3.git.
Pull mirroring failed .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer or owner.
Last successful update .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer or owner.
Last successful update .
- 18 Feb, 2022 11 commits
-
-
Georg Ringer authored
Avoid exceptions when creating inline relations if the parent record is not yet persisted. Resolves: #96900 Releases: main, 11.5 Change-Id: I383fd37efa8bec09333ee61156be1add99fd6e56 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73519 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com>
-
BackendUserAuthentication isn't an injectable service, therefore the (unused) dependency injection is dropped and $GLOBALS['BE_USER'] usage is moved to be scoped by the isBackend() check. Also fix the same DI-anti-pattern in CategoryPermissionsAspect. No user facing error is currently known for this case, as the ModifyTreeDataEvent is only executed in backend context, so this is just to streamline both aspects. Releases: main, 11.5 Resolves: #96960 Change-Id: I7b9f49ef82eeffcf369f471b5d031311aa5007b4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73597 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org>
-
We have three files that define backend routes: * Configuration/Backend/Routes.php * Configuration/Backend/AjaxRoutes.php * Configuration/Backend/Modules.php Routes defined by these files now contain the composer package name ('name' attribute in composer.json) of the package that defined the route as option. Backend modules now have a getPackageName() method. This is useful as shown with #96962 and will likely find further usages in the future. Change-Id: Ifa20f11ee7caa470eb2a1eed9e4ddf3ede088a54 Resolves: #96961 Related: #96962 Related: #96733 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73191 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benjamin Franzke <bfr@qbus.de>
-
Oliver Bartsch authored
Some components in the Core allow to either define locallang references or static labels. To process them in a template, usually the f:translate ViewHelper is used. Since the value will be dynamically and a static label as "key" will lead to an exception in non extbase context, the dynamic value must also be defined as the default, which will be used by the ViewHelper, in case the "key" can not be resolved. There are two possibilities to define the default. Either by setting the "default" attribute or by adding the value as tag content. Latter failed since #96473 because the tag content was resolved too late. The previous behaviour is now restored by evaluating a possible default value before processing the "key". Resolves: #96964 Related: #96473 Releases: main Change-Id: If932d2de14b8b58005051a03ccf7be290b66ddd9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73599 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Benjamin Franzke authored
The importmap dependencies were not correctly resolved as the importmap has not been stored into $this->importMaps when loaded from the assets cache. Do properly store the value into $this->importMaps in getFromCache and actually always use getImportMaps() wrapper to avoid using the importMaps property that is null by default. This fixed for example the RTE external url link browser that missed the configuration for the EXT:backend importmap. Releases: main Resolves: #96933 Related: #96510 Change-Id: Ib9305b9275ebde039230646ac4199c81ee8fcf85 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73567 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benjamin Franzke <bfr@qbus.de>
-
Oliver Bartsch authored
The ModuleData API, introduced in #96895, is now used in the ConfigurationController. Additionally, to streamline the behaviour of backend modules, the configuration module now falls back to the first available configuration provider, if none or an invalid provider is requested. Resolves: #96950 Related: #96895 Releases: main Change-Id: Ib0ca62319ee2ce696f4f1391565ffeea26d06a7f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73584 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Oliver Bartsch authored
The ModuleData API, introduced in #96895, is now used in the ViewModuleController. Resolves: #96944 Related: #96895 Releases: main Change-Id: I7471ff4cefd0c2b5972e4533ed40d439a98f463a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73575 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
The ModuleData API, introduced in #96895, is now used in the LinkValidatorController. Additionally, collapsing tasks in the special "No task group" group is now possible again. Resolves: #96946 Related: #96895 Related: #96574 Releases: main Change-Id: Ifa7a475ab18a12495748d774ea2a80da852609b7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73579 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Oliver Bartsch authored
The ModuleData API, introduced in #96895, is now used in the ReviewController. Resolves: #96956 Related: #96895 Releases: main Change-Id: Ie2e4ac3dab37c246183efb53910bb2cd1a774189 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73591 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Some default properties in TypoScript have been modified back then with the TypoScript condition [compatVersion > 4.0] which has been removed years ago. This code replaces the leftover functionality and explicitly checks the occurrences with default values. In addition, the more performant "array_replace_recursive" function is used for the page.config merging. Resolves: #96885 Releases: main Change-Id: I3dbd4e0b8c105a31e8babd0c5da0ca4ecc9c42d7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73483 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Benjamin Franzke authored
* Avoid scrollIntoView which is no longer needed since #96947 * Do not catch exceptions on tab-click in ElementsBasicInputRangeCest which has been introduced in #93629, but actually didn't catch the documented case where the tab was already active (no exception in that case). It was actually only triggered when the tab was scrolled away. Again no longer needed due to #96947. Resolves: #96951 Related: #96947 Related: #93629 Releases: main, 11.5 Change-Id: I787960ea5dd8a6c946e090d90c4c9d2ecb950e68 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73583 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benjamin Franzke <bfr@qbus.de>
-
- 17 Feb, 2022 17 commits
-
-
Oliver Bartsch authored
The ModuleData API, introduced in #96895, is now used in the LinkValidatorController. Resolves: #96941 Related: #96895 Releases: main Change-Id: I15a6aafe006875b5288ea6be80e5710935a065c7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73573 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Oliver Bartsch authored
The ModuleData API, introduced in #96895, is now used in the BackendUserController. EXT:beuser previously used an own "ModuleData" model, which is now unused and therefore removed. Resolves: #96955 Related: #96895 Releases: main Change-Id: Ia8b48eb8e417c214beded4d12907ef88395e1a0a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73590 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Oliver Bartsch authored
The ModuleData API, introduced in #96895, is now used in the ListController of EXT:extensionmanager. Resolves: #96952 Related: #96895 Releases: main Change-Id: Iad5052aad5c6d7491429eb057693cc361a23aae6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73587 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Resolves: #96891 Releases: main Change-Id: Ib77917f5517499d278e42a4406f81aa0445deaed Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73491 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Oliver Bartsch authored
Some code examples for the ShortcutButton "routeIdentifier" property, introduced in #93093, used the non existing "web_view" identifier. Using this code example will therefore lead to a RouteNotFoundException exception. This is now fixed by using the correct identifier for the viewpage module. Resolves: #96945 Related: #93093 Releases: main, 11.5 Change-Id: Icf0a7cd476328661a630f24655ec53fe34b78745 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73576 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Oliver Bartsch authored
The option to disable the column selector in the filelist is located under the top-level key "options". Resolves: #96959 Related: #84184 Releases: main, 11.5 Change-Id: I97d09e17a19953ef20e9f3108c053d323f2a4507 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73596 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Resolves: #96958 Related: #96895 Releases: main Change-Id: Ide82630aa770cf85e6d53e3dd106bd327602e52f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73595 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Oliver Bartsch authored
While implementing the ModuleData API in #96895, the data to be fetched was accidentally be limited to be session-lasting. Since module settings should be kept for a user when logging out, the corresponding "ses" parameter is removed again. Resolves: #96957 Related: #96895 Releases: main Change-Id: I383f310578d90e5b1d544e9cb57cebc523b307fa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73592 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Oliver Bartsch authored
Linkvalidator linktypes are now automatically tagged and registered, based on the implemented `LinktypeInterface`, using the autoconfiguration feature from the DI container. The previous registration via `$GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['linkvalidator']['checkLinks']` has been removed. Additionally, to be able to use autoconfiguration, the identifier of a linktype has to be provided by the service directly using the now required :php:`getIdentifier()` method. Resolves: #96935 Releases: main Change-Id: Ie7e53b2b9fb73394fa39d5cb84597d5e48326e29 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73568 Tested-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Benjamin Franzke authored
With #90879 useOrOverridePlaceholder fields have been adapted to autofocus the related field when the related checkbox (e.g in sys_file_references) are triggered in FormEngine.toggleCheckboxField. This has the side effect that input fields whose checkbox is preselected are autofocused on initial page load, when FormEngine.toggleCheckboxField() is called from FormEngine.initializeNullWithPlaceholderCheckboxes. This caused the browser to scroll to these fields. The autofocus is now changed to not be triggered on initial pageload, only when FormEngine.toggleCheckboxField() is used due to user input. This also had the effect that acceptance tests failed randomly as automated tab-clicks didn't work (for example in #93629), when the formengine iframe was scrolled all the way to the last useOrOverridePlaceholder field, rendering the tab-selection invisible. Releases: main, 11.5 Resolves: #96947 Related: #90879 Related: #93629 Change-Id: Ie880595079e60421556994b14af0b94bba67b73c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73578 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
Benjamin Franzke <bfr@qbus.de>
-
Benni Mack authored
This is a nice one: One of the most underrated features (pages within Backend User Sections), is checked within TSFE, if a logged-in backend user has access to the current page. This change uses the current "TSFE->page" record to do the check and avoids 1 additional SQL query. Resolves: #96934 Releases: main Change-Id: I3e1c1000ab290e5c6cbcb38b512b7caf4eac5bc2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73569 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Since the "stop task" action in the scheduler module is still a link, the necessary parameters are added again. Resolves: #96948 Related: #96574 Releases: main Change-Id: I7962b07eee57e8987a643f0e1fd6bcbb5d125edc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73581 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benjamin Franzke <bfr@qbus.de>
-
'ext:redirect' now clusters the redirect cache into dedicated parts per domain, which reduces the data amount needed to load on redirect handling in the frontend to the absolute minimum. On the other hand, when rebuilding a cache this is narrowed down to the related domain, thus avoiding retrieving and caching all redirects, which may reduce the processing time in the backend on changing redirects or auto redirects creation on page updates. This works around some flaws for some instances and use cases, but do not harm on smaller instances with lower redirects count. * read and write redirect cache by domain based identifier * removed one array level from cached information and reduced one array key level in redirect matching code * cache identifier for domain entries are build using 'sha1()' * combined with early redirects introduced with #96480 this reduces the loaded data even more, as it is done in chunks * adjusted unit tests to reflect two redirect cache service calls, one for the domain and one for wildcard "*". * rebuilding cache through datahandler hook now rebuilds only for the related 'source_host', thus avoiding rebuild of all redirects for every change. This may still be further improved for multi record operations with the same domain. A 'rebuildAll()' fallback stayed as a last defense to cover cases where specific source_host cannot be determined. Resolves: #96617 Releases: main, 11.5 Change-Id: Id335017cf890dca7c57e892a2561c3555348a668 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73118 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Benjamin Franzke authored
With #96849 t3editor classes have been declared strictly typed. TemplateService converts keys interpretable as integer into real integers and therefore any usage with string based functions need to convert the values to string data type. Resolves: #96937 Related: #96849 Releases: main Change-Id: I3672b5d8b5f881e152d795c5ceaebd58226cf86f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73571 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benjamin Franzke <bfr@qbus.de>
-
Releases: main, 11.5 Resolves: #96943 Change-Id: I1934c621ab87ba46387860050124d8c55210a81c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73574 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Resolves: #96942 Related: #93023 Releases: main, 11.5 Change-Id: I7352a53e03162b24a7e931244e02de5067cc02eb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73572 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Mathias Brodala <mbrodala@pagemachine.de> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Mathias Brodala <mbrodala@pagemachine.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
FlexFormSectionContainer raises an exception when title is not defined. Releases: main, 11.5 Resolves: #96936 Change-Id: I0ad1a432f11bb2cc36f718ca25f430cf91d94417 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73570 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
- 16 Feb, 2022 12 commits
-
-
Current typo3/testing-framework is more strict. > composer u typo3/testing-framework Resolves: #96932 Releases: main Change-Id: Ic01af39317d7e515531f710afcd54d6600827779 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73528 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Oliver Bartsch authored
The StandardContentPreviewRenderer runs through a list of fields, whose value should be processed and displayed in the footer. Some of those field values might be a reference to a foreign table, e.g. in the "fe_group" field. Due to changes in getProcessedValue(), it's necessary to provide the records' uid, to be able to resolve values of fields with a "foreign_table" configuration. Resolves: #96920 Releases: main, 11.5 Change-Id: I0d8739710e478a7cb264be1d5b90b70af31de964 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73563 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Christian Kuhn authored
Class BackendTemplateView has been a temporary solution to simplify the implementation of the "TsConfig template override" feature into smaller patches. With ModuleTemplate and general view works being mostly done in the backend, BackendTemplateView should be removed again. The patch removes all usages switching nearly all views to BackendViewFactory, which removes the explicit dependency to Typo3Fluid ViewInterface since the EXT:core ViewInterface is not directly bound to Fluid anymore. Using BackendViewFactory has the additional advantage that templates which don't use ModuleTemplate because they're hook usages or some other "sub-view", can now be overridden with TsConfig, too. Using BackendViewFactory also makes the dependency to ServerRequestInterface explicit. The patch thus hands $request around at some more places where $request was only an indirect dependency before. One special @todo area is FormEngine, which is unable to have dependency injection (for BackendViewFactory) due to its manual constructor arguments. The patch falls back to Typo3Fluid TemplateView in those cases. The FormEngine API should be adapted with another patch. Change-Id: Ie8959dada4dc6fd30e04d87fea6004e74cbe5990 Resolves: #96904 Related: #96730 Related: #96513 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73518 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
With #96906 the ES6 module files changed to lowercase-dashed naming convention, but the modules in EXT:form have been missed. Releases: main Resolves: #96931 Related: #96906 Change-Id: If1b977645c314afa451e60bde6025f8d90abf9ee Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73566 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Make the web more secure by using https as fallback scheme if not set. Resolves: #96835 Releases: main Change-Id: I7eea535046b25a55c705a1e13c841318966527ff Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73489 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benjamin Franzke <bfr@qbus.de>
-
The @inheritdoc annotation is essentially useless since it adds no value to code readers especially in more and more strict environments. Static code analyzers use doc header annotations from parent classes or interfaces anyways. The patch removes all @inheritdoc annotations throughout the core and removes @inheritdoc from the 'allowed annotation' list in CI. Relsolves: #96930 Releases: main Change-Id: I33fcc837eb6b7c8c8c34a33d28aa2911070c6b6f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73565 Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com>
-
A few places still manually check for "LLL:" as prefix. This is now resolved, as all of this is already done in LanguageService directly. Resolves: #96926 Releases: main Change-Id: Icee5060a5d5b48177e9a5440fcab5d50e3dc9036 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73561 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Argument and return type hints are aligned to match implemented interface \ArrayAccess with proper type hints and removing the '#[\ReturnTypeWillChange]' attribute, which has been used as a workaround. Most methods and the constructor already had proper type hints with the exception of the interface methods, which is now aligned. Class properties have also been set to proper type hints along the way. Resolves: #96918 Related: #95746 Releases: main Change-Id: Iccbe482ab9b174cf6198c372dfcaf312fd1c682f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73555 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de>
-
With the introduction of the simplified ModuleTemplate API and the transition of all core backend modules towards it, the old API can and should be deprecated to faciliate the "Override templates with TsConfig" feature in extensions as well. Resolves: #96903 Related: #96730 Related: #96812 Releases: main Change-Id: I8b15e8f9d999cf61bf9856ceed67beb85921a4e4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73517 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de>
-
Benjamin Franzke authored
With the TypeScript source move in #96906 one file hasn't been moved into the correct place, causing operating systems with case insensitive file systems like MacOS to merge Input/index.d.ts and input/clearable.ts into one folder called "Input/". This causes the compilation to fail. Move the index.d.ts in to the new folder. Resolves: #96927 Related: #96906 Releases: main Change-Id: If1eb46a059c2f99eeb20613a52c30bab76b4f5df Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73562 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benjamin Franzke <bfr@qbus.de>
-
With the recent ES6 changes, the EXT:install JavaScript modules could no longer be loaded into the main backend frame, as the importmap configuration was not tagged to be included there. Add the backend.module tag to the EXT:install importmap in order for TYPO3/CMS/Install/chosen.jquery.min.js to be loadable for the system maintainer modal in backend context. Releases: main Resolves: #96924 Related: #96323 Change-Id: I6109ce00a331b93c1bef29f0e455fa6be126e387 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73560 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
With #96570 RequireJS is no longer loaded when CKEDITOR is used, therefore the typo3link plugin needs to use direct ES6 imports (using the importShim polyfill for Firefox compatibility) instead of the legacy RequireJS shim. Releases: main Resolves: #96923 Related: #96570 Change-Id: I5bcfbca003b98f264d67e51b9738eedb6f8865ac Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73559 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-