This project is mirrored from https://git.typo3.org/typo3/typo3.git.
Pull mirroring failed .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
Last successful update .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
Last successful update .
- 09 Nov, 2019 4 commits
-
-
In case of IRRE in site context not the full form engine variables are available - therefor a fallback has been implemented. Resolves: #89628 Releases: master, 9.5 Change-Id: I0c499d41354e4dc369f5a53f2109d8559b5e3bcb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62265 Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Oliver Bartsch <bo@cedev.de>
Tested-by: Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
Reviewed-by: -
The value of `data-table-unique-original-value` was accidentally of type array. This causes runtime errors since a string is expected. This patch now creates a proper value passed to FormEngine to handle the original unique value. Resolves: #89588 Related: #87711 Releases: master, 9.5 Change-Id: I9184aa025f01196d0c206b5b86c712dc1049487f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62195 Tested-by:
Oliver Bartsch <bo@cedev.de>
Tested-by: Susanne Moog <look@susi.dev> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
Reviewed-by: -
This commit adds an option to the slug input type which allows it to use the uid of a record when the update slug button is pressed in the FormEngine. Resolves: #89560 Releases: master, 9.5 Change-Id: Id645714f1b26e20e511022d1c74ea793964ffa19 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62170 Reviewed-by:
Daniel Sattler <sattler@b13.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
Reviewed-by: Wolfgang Klinger <wolfgang@wazum.com> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Oliver Bartsch <bo@cedev.de>
Tested-by: -
Dynamically fetching/applying additional data for the link explanation seems to be overdone, so we simply deactivate the toggle button and remove the icon after selection/modification of the link target. After persisting the record, the updated link explanation will be visible. Resolves: #88737 Releases: master, 9.5 Change-Id: I679abb2178aedfc8a29cccace99950a3a8acaab6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61422 Tested-by:
Oliver Bartsch <bo@cedev.de>
Tested-by: Alexander Stehlik <alexander.stehlik@gmail.com> Tested-by:
Oliver Bartsch <bo@cedev.de>
Reviewed-by:
-
- 07 Nov, 2019 1 commit
-
-
The InputDateTimeElement now takes an element identifier to initialize a field as a date time picker. The DateTimePicker module now uses an optional element identifier to render the date time picker. Resolves: #89586 Related: #87324 Releases: master Change-Id: I65727fe503fed65b28e38f64b1a44b619087b937 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62197 Tested-by:
-
- 05 Nov, 2019 2 commits
-
-
Since the default language can be different from site configuration to site configuration, "flags-multiple" icon is used instead of the fallback "default-not-found" icon when no default language is configured (e.g. when editing a translated sys_file_metadata record in filelist module). Resolves: #88909 Releases: master Change-Id: Ie755cc06b43e4b735000ab598f14853773d58ced Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61432 Tested-by:
Oliver Bartsch <bo@cedev.de>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: -
There were two double quotes within two exception messages. That could lead to irritation whether one was part of header name respectively the display condition string. Resolves: #89583 Releases: master, 9.5 Change-Id: Idbe6efc296e1d064b14806fc248c2a23c9dadf24 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62193 Tested-by:
Oliver Bartsch <bo@cedev.de>
Tested-by: 
Daniel Siepmann <coding@daniel-siepmann.de>
Tested-by: Georg Ringer <georg.ringer@gmail.com> Tested-by:
Oliver Bartsch <bo@cedev.de>
Reviewed-by: Daniel Siepmann <coding@daniel-siepmann.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
- 30 Oct, 2019 1 commit
-
-
When a custom FAL / sys_file_reference inline element is registered, and there are custom allowed file extensions, the property "elementBrowserAllowed" is not properly run through "GeneralUtility::trimExplode()", however, all other places do this properly. The changes moves the trimExplode to the correct place, so uploading of files directly in FormEngine works properly. Resolves: #89540 Releases: master, 9.5 Change-Id: I9a486f8c932078629761bd86cc1d9455120fc7a5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62155 Tested-by:
Daniel Gorges <daniel.gorges@b13.com> Tested-by:
-
- 10 Oct, 2019 1 commit
-
-
Use double quotes for exact phrases and space as delimiter for multiple words/phrases. Also allow to search for numbers. Resolves: #89170 Releases: master, 9.5 Change-Id: I5346e8fb54946c5dc4c415507b6c773f0854afbd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61703 Tested-by:
Steffen Frese <steffenf14@gmail.com> Tested-by:
Felix P. <f.pachowsky@neusta.de> Tested-by:
Julian Geils <j_geils@web.de> Tested-by:
-
- 09 Oct, 2019 1 commit
-
-
Use a checksum of the element's name as additional identifier to generate an unique id for checkboxes in flexform sections. Resolves: #89092 Releases: master, 9.5 Change-Id: I57075aba05c8de23cbdacfff3a05b63eb71499c9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61911 Tested-by:
Sascha Rademacher <sascha.rademacher+typo3@gmail.com> Tested-by:
Christian Eßl <indy.essl@gmail.com> Tested-by:
Jörg Bösche <typo3@joergboesche.de> Tested-by:
Armin Vieweg <armin@v.ieweg.de> Reviewed-by:
-
- 08 Oct, 2019 1 commit
-
-
Oliver Hader authored
This reverts commit c529deac. The patch only addressed a single use-case. In favour of a more generic approach mentioned change has been reverted. Reverts: #89220 Resolves: #89362 Releases: master, 9.5 Change-Id: I30900d1b80268b263a47ba1c261904f7caa63710 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61913 Tested-by:
Tobi Kretschmann <tobi@tobishome.de> Reviewed-by:
-
- 07 Oct, 2019 1 commit
-
-
Make spelling in TYPO3 great again. Resolves: #89290 Releases: master Change-Id: I520840dd0774aa5d658ce6a45811aa6282c9e461 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61845 Tested-by:
-
- 26 Sep, 2019 1 commit
-
-
This reverts commit e531ddce. Reason for revert: immature merge Change-Id: Ia31248587537a502ffdfc84761bacd7095999642 Resolves: #89276 Reverts: #89056 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61815 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
- 25 Sep, 2019 2 commits
-
-
When changing the doktype a confirmation modal appears. This patch reverts the value of the field to the original value after closing the modal without clicking *OK*. This works for all selects with 'onChange' => 'reload' and 'renderType' => 'selectSingle' Resolves: #89220 Releases: master,9.5 Change-Id: I6d479f9180d64e8e4c25e96f52e60dca36863fd9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61771 Tested-by:
Frank Nägler <frank.naegler@typo3.org> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
-
This patch moves some array functions used in loops (array_merge, array_replace) out of their calling loop for performance reasons, where applicable. This this achieved by calling the functions via array unpacking ("splat operator"). See for further reading: https://github.com/kalessil/phpinspectionsea/blob/master/docs/performance.md#slow-array-function-used-in-loop Resolves: #89056 Releases: master Change-Id: Ia21b1909f77879918b84c6fa702f07a41149e83f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59083 Tested-by:
-
- 19 Sep, 2019 1 commit
-
-
FormEngine does not show and handle IRRE records when they are deleted (connected records from the live workspace are shown). When removal and refactoring of code in this ares was done for v9, "too much" code got removed. Which is why workspace overlays are not handled properly anymore. In addition, the ElementInformationController now correctly resolves a workspace record when finding the pageInfo and access. Resolves: #88502 Related: #82634 Releases: master, 9.5 Change-Id: Ib2d70ffa92c78752626b43ec5012d9dba036e7b8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60890 Tested-by:
Achim Fritz <af@achimfritz.de> Tested-by:
-
- 12 Sep, 2019 1 commit
-
-
Labels of records provided by the suggest wizard should not contain any HTML content as they are directly applied as <option> element to the <select> element of the appropriate database field in backend forms. As the suggest wizard may generate such labels in case of stripped record titles, this commit strips away all HTML tags in order to apply the labels in a clean way to the appropriate element in the DOM. Resolves: #89161 Releases: master, 9.5 Change-Id: Ibe5bb81f79c663cf7cfc30bbe896fdf4492c4c3c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61698 Tested-by:
-
- 11 Sep, 2019 2 commits
-
-
This patch fixes some flaws in the IRRE uniqueness handling: - Validation is triggered once a record has been removed from DOM - Removed records are now added to their selector again if not opened before - Uniqueness handling now works for records with uid "0", which is relevant for a site's language handling - The unique update is now triggered only when the value of its selector in a record actually changes Resolves: #87711 Releases: master, 9.5 Change-Id: I9fe15d8e8790eff305024b706450cd2c37da9340 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61578 Reviewed-by:
-
TYPO3 Core handles the result of database queries in a lot of different ways to filter out workspace records. With "versioning support v1" (= without workspaces), the identifier was usually "pid = -1" to filter out records that should not be displayed in live results. With workspaces, there are other, better ways to identify versioned via the following fields: - t3ver_state (what kind of versioned record is there) - t3ver_oid (if the versioned record points to a live record) - t3ver_wsid (the workspace ID) The "pid" field was kept as misuse, but fine for most of the database queries. Since we now have Doctrine DBAL, and Restrictions, the Core API can now be unified to actually check for "t3ver_oid>0" instead of "pid<>-1" to identify a versioned record. All places in TYPO3 Core now does not check for "pid<>-1" anymore for tables that are workspace-aware. In the future, it is then possible to get rid of the "pid=-1" value when writing versioned records, streamlining the API effectively, to find one proper way to query and write records. This change does not modify any other places in TYPO3 Core where Workspace Records are written, but only cleans up the API to only consider "t3ver_oid" instead of "pid", avoiding the mis-use of "pid". Most queries can then be handled by simply checking: - t3ver_wsid=0 AND deleted=0 for only fetching live records - t3ver_wsid IN (0,12) AND t3ver_oid=0 to find all live records, and draft placeholders, to do overlays then Resolves: #89122 Releases: master Change-Id: I781d1ae440fe944e6c8c99d02884a6eb0c1be0a7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61641 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
- 08 Sep, 2019 1 commit
-
-
The API method BackendUtility::isTableWorkspaceEnabled($table) should be used when dealing with a backend context to determine if a table has versioning support enabled. This functionality wasn't used consistently throughout TYPO3 Backend / CLI code and should be used in order to determine. For PageRepository a separate protected method is introduced to avoid a dependency on BackendUtility. This patch is a precursor for streamlining the workspaces API further. Resolves: #89108 Releases: master Change-Id: Id63e04a5faa1520459d23fb5467ebfb523d9d958 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61639 Tested-by:
-
- 05 Sep, 2019 1 commit
-
-
If a TCA field is set to readOnly=true and is using the type "inline", all buttons are now hidden and the fields of the relation are set to readOnly as well. Resolves: #56060 Releases: master, 9.5 Change-Id: If2b1cb2be0591d765f40512aaf341a9c26a2f87f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61490 Tested-by:
Torben Hansen <derhansen@gmail.com> Tested-by:
Richard Haeser <richard@maxserv.com> Reviewed-by:
-
- 04 Sep, 2019 1 commit
-
-
The filter functionality of fields `type = select` with renderType = selectMultipleSideBySide is always enabled now. Resolves: #88907 Releases: master Change-Id: I7332f39abd6444fc164e8b60009690f6af637b73 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61428 Reviewed-by:
-
- 29 Aug, 2019 1 commit
-
-
A new appearance property "fileByUrlAllowed" is used to separately enable / disable the buttons "Add media by URL" and "Select & upload files". fileUploadAllowed = 0 now only hides the button "Select & upload files" fileByUrlAllowed = 0 now hides the button "Add media by URL" if "elementBrowserType" is set to "file" both values are true by default Resolves: #84250 Releases: master Change-Id: I3c3ae34f7514128cb164a5edc8ed028a86af1238 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60752 Tested-by:
Guido Schmechel <guido.schmechel@brandung.de> Tested-by:
-
- 28 Aug, 2019 1 commit
-
-
This patch updates friendsofphp/php-cs-fixer to version 2.15.2 and applies fixes to the code. Executed commands: composer require --dev "friendsofphp/php-cs-fixer:^2.15.2" ./bin/php-cs-fixer fix --config Build/.php_cs Resolves: #89031 Releases: master, 9.5 Change-Id: I3761ab56f66b6bd3b0fadc2bfa354cf4010b5e43 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61564 Tested-by:
-
- 23 Aug, 2019 1 commit
-
-
This patch replaces all usages of `strstr()` and its friends where the existence of a certain substring is checked, but the result isn't used at all with `strpos()`, which uses less memory. Resolves: #88922 Releases: master Change-Id: Ie45589ac9410e22e1b48e82dd8086eadb6d74107 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61445 Tested-by:
-
- 14 Aug, 2019 1 commit
-
-
Fixes following typos: - Replace 'ite_language' with 'site_language' in SiteTcaInline - Replace 'langauges' with 'languages' in rst file - Replace 'sytem' with 'system' in CreateAdmin template Resolves: #88948 Releases: master, 9.5 Change-Id: Iaca4ad7eb7647508e3de66004c288efe84be4b0b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61486 Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
-
- 02 Aug, 2019 1 commit
-
-
Make sure there is actually an 'items' array in the processedTCA before validating the items. Resolves: #88624 Releases: master, 9.5, 8.7 Change-Id: I1fb6d47ac017ce6950926387387ad19d8445af74 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61122 Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Tested-by:
-
- 14 Jul, 2019 1 commit
-
-
The property "vanillaParentPageTca " inside FormEngine is never used - also documented that it was never used before. The property is therefore removed. Resolves: #88669 Releases: master Change-Id: I71166ea44764d8bdc4b0c309a43f45f46309780f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61207 Tested-by:
-
- 12 Jul, 2019 1 commit
-
-
With #88665 some JavaScript code and superfluous event "registration" was removed. It turns out that the event stuff was not that superfluous and is still required with the Link Browser to properly update the field values. Resolves: #88729 Related: #88665 Releases: master Change-Id: I78a5e65f42a978245e31d478b83d82949c26ac17 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61272 Tested-by:
-
- 05 Jul, 2019 4 commits
-
-
Since Pseudo-Sites have been removed, sys_language is not the recommended way anymore to detect available languages. It is however possible to use all site configurations to select a language to limit the language to a backend user / group with proper labels now. Resolves: #88659 Releases: master Change-Id: Ifbbaba28897eb06e5d574742a1094c90b03ba8f3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61199 Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Tested-by:
-
With RequireJS in place, it is possible to minimize the amount of inline JavaScript in the backend. This patch removes FormEngine's `additionalJavaScriptSubmit` feature that registers additional submit handlers and allows to abort the form submission. This feature is rarely used at all, but can be achieved using a RequireJS module that registers a callback in `TYPO3/CMS/Backend/DocumentSaveActions`. Since the feature is gone, a lot of global code within TBE_EDITOR is removed as well. Resolves: #88667 Releases: master Change-Id: I92f26aa52cafab5df30a706ea95f1e1702a4a778 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60861 Tested-by:
-
The "Refresh required" is currently built in PHP and invoked when changing a field that is explictly configured as "onChange => reload" in TCA. Since we aren't limited to the technology of our time anymore, the main logic can get moved into FormEngine.js and only registration is kept in FormEngine for now. This commit also removed some superfluous usages of `TBE_EDITOR_fieldChanged`, as those are already handled by FormEngine. Resolves: #88665 Releases: master Change-Id: I255b70fba7af8253c6bc02611029a74a57a2a043 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61204 Tested-by:
-
The options `options.popupWindowSize` and `options.rte.popupWindowSize` used to configure popup sizes have been removed. Most of the popups are rendered as modals that don't allow configured sizes, the remaining popups have hardcoded sizes. Resolves: #88657 Releases: master Change-Id: Ide212d0669e8c4bc199263c5fe868529cbbc7930 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61195 Tested-by:
Johannes Seipelt <johannes.seipelt@3m5.de> Reviewed-by:
-
- 04 Jul, 2019 1 commit
-
-
Various places (Trees, Inline Data) can be optimized by using a more "space-saving" and faster approach. By using json_encode/decode instead of serializing the data, the stored information in "uc" of Backend Users will be vastly smaller when dealing with larger installations. Resolves: #88680 Releases: master Change-Id: I59e83c8c7615e9da63b04ebb4930c2b68b38ad7c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61220 Tested-by:
-
- 27 Jun, 2019 1 commit
-
-
Currently, the ElementBrowser is used in three different places in FormEngine, all of them trigger it differently. This patch introduces an event-driven approach and streamlines all usages. Resolves: #88436 Releases: master Change-Id: I13e696f29ade0aede6a2466cbca1e27cebc86c61 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60818 Tested-by:
-
- 25 Jun, 2019 1 commit
-
-
Serialized values in l18n_diffsource are vulnerable to insecure deserialization when being invoked in FormEngine or DataHandler. Resolves: #88323 Releases: master, 9.5, 8.7 Security-Commit: 215de3e52140dc69ccb0e5802ab4234922b1aa63 Security-Bulletin: TYPO3-CORE-SA-2019-020 Change-Id: I03704b35d94e2575e9231656977f3760e6f04e2b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61146 Tested-by:
-
- 19 Jun, 2019 1 commit
-
-
Benni Mack authored
Profiling shows that when linking to 100 pages, SiteFinder (which instantiates SiteConfiguration) is instantiated 100 times. Although SiteFinder information might change during one request, the SiteConfiguration does not (except when updating the Configuration via API). So, a first-level-cache can be used to avoid calls to "cache_core" multiple times during one request, and SiteConfiguration can become a Singleton instance. Resolves: #88577 Releases: master, 9.5 Change-Id: I3d9167da9442d684d32a73d6cf2003c91bdf4d68 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61078 Tested-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
-
- 17 Jun, 2019 1 commit
-
-
SiteMatcher is a container around SiteFinder now as PseudoSite handling was removed, so SiteFinder can be used directly. Resolves: #88568 Releases: master Change-Id: Ib0f5a42351ed5c11c25458b74074b80f5c574bbd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61043 Tested-by:
-
- 05 Jun, 2019 1 commit
-
-
The LinkBrowser used in FormEngine is now opened in a modal window instead of a popup. Resolves: #88471 Releases: master Change-Id: I59992b2fc8a9fbf6b01aa2213c024fd0c13de009 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60860 Tested-by:
-
- 31 May, 2019 1 commit
-
-
For IRRE relations with a "foreign_selector" relation set to a field of type "group" and internal_type "db", the backend wrongly rendered the message "Allowed file extensions". Instead "Allowed relations" is now shown for table relations. Resolves: #87747 Releases: master, 9.5, 8.7 Change-Id: I8a3b7686af14821ece0f727601c1a1bc0d5e1953 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60830 Tested-by:
-
