This project is mirrored from https://git.typo3.org/typo3/typo3.git.
Pull mirroring failed .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
Last successful update .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
Last successful update .
- 15 Mar, 2021 1 commit
-
-
Benni Mack authored
The SVG tree is now building the SVG elements and needed containers ("<g>") via lit-helper. In addition, the update() method is renamed to this.updateVisibleNodes() to easier integrate this as Lit element, as update() is a reserved protected method in lit. The initialize() method is much cleaner, as the event listener registration is now separated in a custom method. Resolves: #93724 Releases: master Change-Id: I945cd620f9900c6ea535dfe5f0d44ee5ced46f89 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68367 Tested-by:Richard Haeser <richard@richardhaeser.com> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com>
Tested-by: Daniel Gorges <daniel.gorges@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
- 11 Mar, 2021 1 commit
-
-
This change optimizes the SVG Tree implementations (again), this time focussing on using proper constructors for SVG tree and its derivatives (SelectTree, PageTree, FileStorageTree). In addition, the search + filter logic is now moved into the base class, in order to reduce duplicate code, and to re-add features (next steps) that were not implemented in TYPO3 v9 when re-writing the page tree, such as highlighting filtered results. In addition, unused properties and settings are removed. This change marks one of the final changes for reworking the SVG Tree implementation, afterwards allowing us to move towards: * native DOM events in favor of d3-dispatch * custom elements instead of wrapper methods * decouple "top." and "document." based settings into the Container classes Resolves: #93701 Releases: master Change-Id: I55733b8c2d0a84ca263ac6e77d7d0bac30877e25 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68332 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
- 10 Mar, 2021 2 commits
-
-
Benni Mack authored
As the temporary mount point functionality is not bound to the actual PageTree, but the navigation component, this code is now moved outside of the PageTree, and using lit-based rendering and proper event handling. The advantages of this change are that the SVG Tree / PageTree component - does not access HTML outside its own wrapper (parentNode) - the mount point information is now rendered via LIT (= automatically updated) - additional setting "temporaryMountPointPath" is not needed inside the PageTree anymore - We also now use <typo3-backend-icon> and the $lll lit helper Resolves: #93697 Releases: master Change-Id: Idaa56f12e6d1444a1abdf23d2a37b71948d47023 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68307 Tested-by:
Daniel Sattler <sattler@b13.de> Tested-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
core-ci <typo3@b13.com>
Reviewed-by: -
This patch provides the following changes in order to have better abstractions and encapsulate the dependencies of each implementation. 1. SelectTree (Category Tree) The TreeToolbar is now clearly coupled into the SelectTree and built as LitElement inside the SelectTreeElement. SelectTree now contains all relevant functionality regarding selecting multiple items, and shows settings (SelectTreeSettings) which were only used in SelectTree. This is especially relevant for the multiple item selection, and the exclusiveKey handling. 2. PageTree + FileStorageTree Obsolete public methods are removed, and visibility is changed. Filtering is now separated in favor of a non-public property. By using Types (in e.g. PageTreeDragDrop) the visibility is also adapted Obsolete wrapper methods are removed. Resolves: #93692 Releases: master Change-Id: Ifead098bb80e37d5c7ad5e1d0eabda14aa7087ce Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68303 Tested-by:
core-ci <typo3@b13.com>
Tested-by:
-
- 09 Mar, 2021 1 commit
-
-
Native HTMLElements are more versatile than a the current NavigationComponent interface. All custom actions can be dispatched via events, that means the NavigationComponent interface, as recently introduced in #93672, is removed again. Resolves: #93685 Releases: master Change-Id: I578810ce655d1da3f34bcb456967f62756793b24 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68233 Tested-by:
core-ci <typo3@b13.com>
Tested-by:
-
- 08 Mar, 2021 1 commit
-
-
In order to use the non-iframe navigation component properly, the current ties to "PageTree" (which was de-facto the only possible navigation component to be used until TYPO3 v11 due to heavy coupling) are removed. The TreeInterface, which served as a wrapper for the PageTree Navigation Component is removed, and replaced by the NavigationComponent interface in TypeScript. In addition, loading and initializing (and keeping state) of the used navigation component now solely relies in the NavigationContainer. This in turn, finally allows to e.g. properly re-load the FileStorageTree and PageTree separately (see BackendUtility change) while incorporating some ES6 nullable functionality. In addition, the NavigationContainer is now jQuery-free. Resolves: #93672 Releases: master Change-Id: Ia16a3e789459225b21fa12efd1db6f3b4500cfef Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68201 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com>
Reviewed-by:
-
- 01 Mar, 2021 1 commit
-
-
The component is provided as replacement for the current lit-helper `icon()` which cannot provide support for icon usage inside shadow dom elements. The component renders all icons as inline SVGs. FontawesomeIconProvider is therefore adapted to provide inline rendered SVGs for font-awesome icons. Not that these inline font-awesome SVGs will also be used in areas where 'inline' icons are requested (like information toolbar) but the fallback to 'default' was used before. The component supports all properties of the Icon API via HTML attributes. Colors and custom sizes can be applied to the component via CSS color/font-size property: typo3-backend-icon[identifier=status-dialog-information] { color:#6daae0; /* An explicit font-size will be used as icon width & height */ font-size: 1.2em; } Resolves: #93473 Releases: master Change-Id: I3044c325f122eb0085ecb3f45fb9502bfb314d5d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67675 Tested-by:core-ci <typo3@b13.com>
Tested-by:
-
- 10 Feb, 2021 1 commit
-
-
Now that jQuery has gone and TypeScript is in place for Tree components, the next step is to consolidate and sort out re-usability. This change prepares the way for allowing multiple trees in the navigation component area (for FileStorageTree). * ContextMenu allows int+number (which is correct) * ContextMenu has all information from the TreeNode (and not the SVG element) - less Markup! * KeyTypeEnums are used throughout SvgTree * Centralized place for error notifications, removing duplicate code * tree.settings.isDragAnDrop is removed in favor of tree.settings.allowDragMove (which already exists) * Unused properties in TreeNode are removed * Since we are now in "TS module land", PageTreeToolbar.ts is removed because the class is only used in the PageTreeElement, so it does not need to be exposed anymore. Resolves: #93481 Releases: master Change-Id: Ia9bff532132dba5aea85352d7e510f6a7f9459c6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67683 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
core-ci <typo3@b13.com>
Tested-by:
-
- 09 Feb, 2021 1 commit
-
-
This change migrates all left-over components of * SvgTree * SelectTree (a.k.a. CategoryTree) * and PageTree to TypeScript adding types in various places to make the code less error-prone. Resolves: #87678 Resolves: #85400 Releases: master Change-Id: Ibb4024d365857c44018a7a201c1cf75baa48179a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67662 Tested-by:
core-ci <typo3@b13.com>
Tested-by:
-
- 08 Feb, 2021 1 commit
-
-
The PageTree components for the navigation area consists of: * PageTreeElement (container for rendering the navigation area w. toolbar + dragdrop + tree) * PageTreeToolbar (uses DnD for creating new items) * PageTree (JS, subclass of SvgTree) * PageTreeDragDrop This patch aims to rework the "PageTreeDragDrop" javascript file by moving separate logic into separate classes (as much as possible) and into a more stable API, being a first part. PageTreeDragDrop is a mixed code class currently, and is now split up in various separate classes: * DragDropHandler (interface) * ToolbarDragHandler -> used as the Toolbar Draggable Handler for new pages * PageTreeNodeDragHandler => used for moving/copying and deleting existing pages/nodes * PageTreeDragDrop now acts as a simple wrapper for d3-drag but still has some shared state For Future Reference: It is still up to decide on how to further decouple the code. Idea 1: Putting the d3-drag initialization into the right place and avoiding cross-dependencies. In general "initializeDragForNode" would also be handled via events, and all options / settings would be moved into the PageTreeDragDrop class. Ideally the PageTreeDragDrop contains the status of the current drag+drop action (position, node etc), so the PageTree would not know of anything itself. Idea 2: Another possibility is to use the current "PageTreeDragDrop" as a generic "TreeDragDropManager" because it does not contain any Page-Tree specific code anymore, but could be carried on later-on. The current change is already a good step as it moves all code to TypeScript and minimizes injection via constructors (except for the Tree itself). Resolves: #93446 Releases: master Change-Id: Ibd7a067c1e6a821b138a8cc2971ec8133392b600 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67650 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
-
- 04 Feb, 2021 1 commit
-
-
This change aims to reduce the overhead by using jQuery in favor of Vanilla JS in various Tree-related JS files in preparation for a TypeScript migration. * SvgTree.js * SelectTree.js * PageTree.js * PageTreeToolbar.ts * PageTreeElement.ts * TreeToolbar.ts Resolves: #93427 Releases: master Change-Id: I57fc8e66415ea4ab6eaf690d925fbf7670d74284 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67583 Tested-by:
-
- 01 Feb, 2021 1 commit
-
-
Benni Mack authored
The PageTree component (added in TYPO3 v9) is based on SVG Tree, which was added in a previous version (TYPO3 v8). However, changes like https://review.typo3.org/c/Packages/TYPO3.CMS/+/55878/ unnecessarily coupled the SVG Tree to the PageTree. In addition, some minor details to NOT use pagetree IDs everywhere allows to use other SVG-tree based components in the navigation container in the future. id=typo3-pagetree-treeContainer is kept for typo3/testing-framework compatibility, for now. Resolves: #93389 Releases: master Change-Id: Ieb51e46937cfb2f11efeb976da09bc600af8b5cf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67575 Tested-by:
-
- 29 Jan, 2021 1 commit
-
-
+ removed NavigationComponentInterface - actually no class-like component did implement it + introduced TreeInterface, having some aspects of previous NavigationComponentInterface + aim to use native DOM operations (instead jQuery) where possible + switched templating in PageTreeElement and PageTreeToolbar to lit-html Resolves: #93380 Releases: master Change-Id: Ia2a05ff3d05193e52d440e409ecca4c1e1feb518 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67544 Tested-by:
-
