This project is mirrored from https://git.typo3.org/typo3/typo3.git. Pull mirroring failed .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
Last successful update .
  1. 11 May, 2015 1 commit
  2. 28 Apr, 2015 1 commit
    • Christian Kuhn's avatar
      [!!!][TASK] House of forms · 736cbfc9
      Christian Kuhn authored
      This patch introduces a structural code refactoring to the
      FormEngine class and its related friend classes.
      
      FormEngine used to call itself over and over again with itself
      and sub classes writing to public properties of FormEngine keeping
      a global state that is then magically merged to sometimes working
      output.
      
      The patch introduces a tree approach with lots of small containers
      doing an encapsulated part of the rendering process and calling
      sub containers for inner details.
      As main construct a "globalOptions" array is modified in containers
      and given down to sub containers (tree knots) or elements (leaves),
      while sub structures always return a defined array that is
      merged by the parent and accumulates the full result.
      Goal is to have a better encapsulated code structure with better
      visible impact on changes done to this system.
      
      The patch creates this main structure. There is still a lot of
      mess around and additional patches can further improve the overall
      situation with smaller changes.
      
      Change-Id: I56b898dc0eaae8de4d31016997cfefe8d14ec53e
      Releases: master
      Resolves: #63846
      Resolves: #63854
      Resolves: #63856
      Resolves: #63858
      Resolves: #63859
      Resolves: #63860
      Resolves: #63861
      Resolves: #63862
      Resolves: #63863
      Resolves: #63865
      Resolves: #63876
      Resolves: #63881
      Resolves: #63882
      Resolves: #63883
      Resolves: #63893
      Reviewed-on: http://review.typo3.org/38433
      
      
      Reviewed-by: Anja Leichsenring's avatarAnja Leichsenring <aleichsenring@ab-softlab.de>
      Tested-by: Anja Leichsenring's avatarAnja Leichsenring <aleichsenring@ab-softlab.de>
      Reviewed-by: default avatarMarkus Klein <klein.t3@reelworx.at>
      Tested-by: default avatarMarkus Klein <klein.t3@reelworx.at>
      Reviewed-by: Christian Kuhn's avatarChristian Kuhn <lolli@schwarzbu.ch>
      Tested-by: Christian Kuhn's avatarChristian Kuhn <lolli@schwarzbu.ch>
      736cbfc9
  3. 28 Feb, 2015 1 commit
    • Christian Kuhn's avatar
      [!!!][TASK] Improve FormEngine and sub classes separation · 212b9dbf
      Christian Kuhn authored and Anja Leichsenring's avatar Anja Leichsenring committed
      This patch improves the separation of FormEngine and its sub
      classes. Currently, all sub classes like single element and wizard
      classes get an instance of the parent object to call various methods
      and properties on them. This is very hard to refactor and the mesh
      of call trees must be simplified to ease further refactoring and
      improve maintainability of code.
      
      This patch follows a divide & conquer approach:
      * Methods only used by sub elements are moved to AbstractFormElement
      * Properties FormEngine "knows" that are needed by element classes
        are given down in a data array during element instatiation to have
        a clear definition of what element classes know.
      * Methods used by both FormEngine and sub classes that do not need
        an instance of FormEngine are moved to a static helper for now to
        reduce the amount of code in FormEngine and to mark certain areas
        as stateless.
      * Class instances are not created on a global level anymore but
        created only in the scope where they are used
      * Class instances injected by outer code are created internally
        for enabling the using code to be moved around.
      
      All in all, this patch is mostly a preparation of defining a
      fully separated structure with defined concerns for every sub class.
      
      Most methods are moved around "as is" without changing functionality.
      The only area that is refactored codewise is renderWizards().
      
      There is still a nasty circular dependency between FormEngine,
      FlexFormElement and InlineElement. This is not resolved by the patch,
      but the surrounding code is now separated enough that this structure
      could be refactored to a tree. This may follow with other patches.
      
      This patch evolved on catharsis in branch formengine with 53 single
      patches. Details can be looked up there, all single patches are
      prefixed with [FormEngine].
      https://github.com/lolli42/TYPO3.CMS-Catharsis/tree/formengine
      
      Change-Id: I332ad51f5e94c09555480099e3a8a0257bed378f
      Releases: master
      Resolves: #65357
      Resolves: #63848
      Resolves: #63849
      Resolves: #63851
      Resolves: #63853
      Resolves: #63855
      Resolves: #63857
      Resolves: #63867
      Resolves: #63868
      Resolves: #63869
      Resolves: #63870
      Resolves: #63871
      Resolves: #63872
      Resolves: #63873
      Resolves: #63874
      Resolves: #63875
      Resolves: #63877
      Resolves: #63879
      Resolves: #63880
      Resolves: #63884
      Resolves: #63885
      Resolves: #63886
      Resolves: #63887
      Resolves: #63888
      Resolves: #63890
      Resolves: #63892
      Reviewed-on: http://review.typo3.org/37265
      
      
      Reviewed-by: Anja Leichsenring's avatarAnja Leichsenring <aleichsenring@ab-softlab.de>
      Tested-by: Anja Leichsenring's avatarAnja Leichsenring <aleichsenring@ab-softlab.de>
      Reviewed-by: Wouter Wolters's avatarWouter Wolters <typo3@wouterwolters.nl>
      Reviewed-by: Benni Mack's avatarBenjamin Mack <benni@typo3.org>
      Tested-by: Benni Mack's avatarBenjamin Mack <benni@typo3.org>
      212b9dbf
  4. 01 Feb, 2015 1 commit
  5. 16 Dec, 2014 1 commit
  6. 13 Dec, 2014 1 commit
  7. 06 Dec, 2014 1 commit
  8. 22 Jun, 2014 1 commit
    • Michael Schams's avatar
      [TASK] Re-work/simplify copyright header in PHP files - Part 6 · 526c060f
      Michael Schams authored
      This patch replaces the copyright/license header in PHP files with a
      new, simplified one. The new header does not show the year figure, nor
      an author name, and refers to the LICENSE.txt file for the full
      copyright information. License is: GPL2 or any later version.
      
      This is a multi-part commit due to the huge number of changed files.
      See issue #59782 for further details.
      
      Resolves: #59782
      Releases: 6.3, 6.2
      Change-Id: Idcd11219eb132c8690cfde256950980e9423bafd
      Reviewed-on: https://review.typo3.org/31027
      Reviewed-by: Krzysztof Adamczyk
      Tested-by: Krzysztof Adamczyk
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      526c060f
  9. 09 Mar, 2014 1 commit
  10. 10 Feb, 2014 1 commit
    • Christian Kuhn's avatar
      [TASK] Reduce memory footprint of unit tests · 2d05837d
      Christian Kuhn authored
      Running the whole unit test suite on cli can eat up a significant
      amount of memory. Most of that can not be mitigated due to phpunit
      itself, but we can at least hint the PHP garbage collection by
      unsetting test class properties in tearDown().
      
      The patch introduces a generic tearDown() method that reflects the
      test class and unsets all temporary properties of the class. In
      effect, tests do not need to take care of unsetting properties.
      
      The patch removes all tearDown() methods that only unset() stuff
      and keeps others that do additional things but adds a call to
      parent::tearDown(). Private properties are changed to protected,
      so parent::tearDown can reach them. The additional computing
      effort of the reflection is insignificant, the suite is nearly as
      fast as before.
      
      Results:
      php 5.3: 1056MB -> 851MB
      php 5.4: 870MB -> 670MB
      php 5.5.: 876MB -> 674MB
      
      Resolves: #55850
      Related: #51436
      Releases: 6.2
      Change-Id: Ie665c53a3ab35e4808677e483d2099e0511c393f
      Reviewed-on: https://review.typo3.org/27528
      Reviewed-by: Helmut Hummel
      Reviewed-by: Anja Leichsenring
      Tested-by: Anja Leichsenring
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      2d05837d
  11. 01 Oct, 2013 1 commit
  12. 19 Mar, 2013 1 commit
    • Wouter Wolters's avatar
      [TASK] Update copyright year to 2013 · 4d463976
      Wouter Wolters authored and Christian Kuhn's avatar Christian Kuhn committed
      In this patch are also some fixes for files containing
      a interface. Due the namespace change all interfaces
      have the curly bracket not on the same line as the
      interface name.
      
      Change-Id: I64ba45de73693452d681ce7f018965968b11d2af
      Resolves: #46370
      Releases: 6.1
      Reviewed-on: https://review.typo3.org/18984
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      4d463976
  13. 10 Nov, 2012 1 commit
    • Kai Vogel's avatar
      [FEATURE] Enable IRRE fields in FlexForms · 6ab0f6aa
      Kai Vogel authored
      This patch enables IRRE fields in flexform. They can be used
      identically to the TCA.
      
      FlexForm segments are separated by a new divider "---" to
      easily have the possiblity to recognize and parse them when
      handline the IRRE object identifiers.
      
      Besides that a new remapping level for FlexForms has been
      introduced to the DataHandler to update accordant FlexForm
      references after all child records have been written.
      
      Unit tests have been extended to check the new additions to
      the accordant object identifiers and form names. This is
      important to any processing of IRRE in the form view.
      
      Change-Id: Icadb89c2e496a5f1ad7de298ebee06d144475a11
      Resolves: #18957
      Releases: 6.0
      Reviewed-on: http://review.typo3.org/13968
      Reviewed-by: Steffen Ritter
      Tested-by: Steffen Ritter
      Reviewed-by: Kai Vogel
      Tested-by: Kai Vogel
      Reviewed-by: Helmut Hummel
      Tested-by: Helmut Hummel
      6ab0f6aa
  14. 05 Nov, 2012 1 commit